Re: svn commit: r1865522 - /subversion/trunk/subversion/libsvn_subr/sqlite3wrapper.c

2019-08-20 Thread Daniel Shahaf
kot...@apache.org wrote on Tue, 20 Aug 2019 09:18 +00:00: > When compiling SQLite, set the SQLITE_DEFAULT_MEMSTATUS=0 compile-time option. > > This is the recommended option that is not enabled by default. Setting it to > zero avoids using a mutex (and thus suffering a performance penalty) during

Re: svn commit: r1865523 - /subversion/trunk/subversion/libsvn_subr/sqlite3wrapper.c

2019-08-20 Thread Daniel Shahaf
kot...@apache.org wrote on Tue, 20 Aug 2019 09:23 +00:00: > +++ subversion/trunk/subversion/libsvn_subr/sqlite3wrapper.c Tue Aug 20 > 09:23:55 2019 > @@ -26,6 +26,7 @@ > #ifdef SVN_SQLITE_INLINE > # define SQLITE_OMIT_DEPRECATED 1 > # define SQLITE_DEFAULT_MEMSTATUS 0 > +# define SQLITE_OMIT

svn commit: r1865523 - /subversion/trunk/subversion/libsvn_subr/sqlite3wrapper.c

2019-08-20 Thread kotkov
Author: kotkov Date: Tue Aug 20 09:23:55 2019 New Revision: 1865523 URL: http://svn.apache.org/viewvc?rev=1865523&view=rev Log: When compiling SQLite, enable the SQLITE_OMIT_WAL compile-time option. We don't use WAL (write-ahead logging) feature of SQLite, but just keeping it enabled has a visibl

svn commit: r1865522 - /subversion/trunk/subversion/libsvn_subr/sqlite3wrapper.c

2019-08-20 Thread kotkov
Author: kotkov Date: Tue Aug 20 09:18:21 2019 New Revision: 1865522 URL: http://svn.apache.org/viewvc?rev=1865522&view=rev Log: When compiling SQLite, set the SQLITE_DEFAULT_MEMSTATUS=0 compile-time option. This is the recommended option that is not enabled by default. Setting it to zero avoids u

svn commit: r1865520 - /subversion/trunk/subversion/libsvn_subr/io.c

2019-08-20 Thread kotkov
Author: kotkov Date: Tue Aug 20 09:09:54 2019 New Revision: 1865520 URL: http://svn.apache.org/viewvc?rev=1865520&view=rev Log: Win32: fix an incorrect error status being propagated to the caller in case where we fail to stat the destination path while being in the middle of a failed rename. So,

svn commit: r1865519 - /subversion/trunk/subversion/libsvn_subr/io.c

2019-08-20 Thread kotkov
Author: kotkov Date: Tue Aug 20 09:00:03 2019 New Revision: 1865519 URL: http://svn.apache.org/viewvc?rev=1865519&view=rev Log: * subversion/libsvn_subr/io.c (win32_file_rename): Rename `status` to `err`. This lays the groundwork for fixing the incorrect error status being propagated to the c

svn commit: r1865518 - /subversion/trunk/subversion/libsvn_subr/io.c

2019-08-20 Thread kotkov
Author: kotkov Date: Tue Aug 20 08:48:32 2019 New Revision: 1865518 URL: http://svn.apache.org/viewvc?rev=1865518&view=rev Log: Win32: prevent svn_io_file_rename2() from spinning in the retry loop in a racy case where the rename function clears the read-only attribute from the destination file, bu