Re: svn commit: r1147882 - /subversion/trunk/subversion/libsvn_repos/hooks.c

2011-07-18 Thread Daniel Shahaf
The questions I see are: * is there a bug in ra_dav's handling of some non-ASCI lock tokens? * is there a missing input validation? If so, what validation, and does it belong in _repos or _fs? Daniel Shahaf wrote on Mon, Jul 18, 2011 at 22:50:40 +0300: > Ivan notes on IRC that this fixes issu

Re: svn commit: r1147882 - /subversion/trunk/subversion/libsvn_repos/hooks.c

2011-07-18 Thread Daniel Shahaf
Ivan notes on IRC that this fixes issues with non-ASCII lock tokens. (At least, he reports errors in 'svn ls -v' over http://; but for me 'ls' and 'info' work fine over svn://.) Are lock tokens even permitted to be non-ASCII? (both backends generate ASCII-only lock tokens (in the same manner)) I

svn commit: r1147882 - /subversion/trunk/subversion/libsvn_repos/hooks.c

2011-07-18 Thread ivan
Author: ivan Date: Mon Jul 18 13:58:31 2011 New Revision: 1147882 URL: http://svn.apache.org/viewvc?rev=1147882&view=rev Log: Convert lock token returned from pre-lock hook from native encoding to UTF-8. * subversion/libsvn_repos/hooks.c (svn_repos__hooks_pre_lock): Convert hook output from nat