[
https://issues.apache.org/jira/browse/TAP5-816?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ulrich Stärk updated TAP5-816:
------------------------------
Labels: bulk-close-candidate (was: )
This issue has been last updated more than 1.5 years ago, has no assignee,
affects an old version of Tapestry that is not actively developed anymore, and
is therefore prone to be bulk-closed in the near future.
If the issue still persists with the most recent development preview of
Tapestry, please update it as soon as possible. In the case of a feature
request, please discuss it with the Tapestry developer community on the
d...@tapestry.apache.org mailing list first.
> Add logs on reply script evaluation error
> -----------------------------------------
>
> Key: TAP5-816
> URL: https://issues.apache.org/jira/browse/TAP5-816
> Project: Tapestry 5
> Issue Type: Improvement
> Components: tapestry-core
> Affects Versions: 5.1.0.0
> Reporter: Denis Delangle
> Priority: Minor
> Labels: bulk-close-candidate
>
> On ajax queries, if the evaluation of the script part of the reply fails, no
> message is shown to the user. It is then tricky to solve issues. I only ask
> for logging of such errors.
> Here is a diff for tapestry.js file adding a call to Tapestry.error. I don't
> know if exception should be thrown back afterwards.
> Index: tapestry.js
> ===================================================================
> --- tapestry.js (revision 805422)
> +++ tapestry.js (working copy)
> @@ -307,7 +307,15 @@
> // evaluating the reply.script
> // and other final steps.
>
> - if (reply.script) eval(reply.script);
> +
> + if (reply.script) {
> + try {
> + eval(reply.script);
> + } catch(e) {
> + //We catch any exception that can occur during
> script evaluation and we log it
> +
> Tapestry.error(Tapestry.Messages.clientException + e);
> + }
> + }
>
> Tapestry.onDomLoadedCallback();
>
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
