Author: joshcanfield Date: Mon Jun 27 13:57:43 2011 New Revision: 1140164 URL: http://svn.apache.org/viewvc?rev=1140164&view=rev Log: TAP5-1559 - Excessive warnings
Modified: tapestry/tapestry5/trunk/tapestry-core/src/main/java/org/apache/tapestry5/EventConstants.java tapestry/tapestry5/trunk/tapestry-core/src/main/java/org/apache/tapestry5/TrackableComponentEventCallback.java tapestry/tapestry5/trunk/tapestry-core/src/main/java/org/apache/tapestry5/ajax/MultiZoneUpdate.java tapestry/tapestry5/trunk/tapestry-core/src/main/java/org/apache/tapestry5/dom/Element.java tapestry/tapestry5/trunk/tapestry-core/src/main/java/org/apache/tapestry5/internal/TapestryInternalUtils.java tapestry/tapestry5/trunk/tapestry-core/src/main/java/org/apache/tapestry5/internal/services/javascript/CoreJavaScriptStack.java Modified: tapestry/tapestry5/trunk/tapestry-core/src/main/java/org/apache/tapestry5/EventConstants.java URL: http://svn.apache.org/viewvc/tapestry/tapestry5/trunk/tapestry-core/src/main/java/org/apache/tapestry5/EventConstants.java?rev=1140164&r1=1140163&r2=1140164&view=diff ============================================================================== --- tapestry/tapestry5/trunk/tapestry-core/src/main/java/org/apache/tapestry5/EventConstants.java (original) +++ tapestry/tapestry5/trunk/tapestry-core/src/main/java/org/apache/tapestry5/EventConstants.java Mon Jun 27 13:57:43 2011 @@ -138,7 +138,7 @@ public class EventConstants * Event triggered by {@link org.apache.tapestry5.corelib.components.AjaxFormLoop} to inform the * container that a new row has been requested. The return value from the event handler must be the newly created * object, which must - * also be visible in the {@link encoder parameter}. + * also be visible in the {@link org.apache.tapestry5.corelib.components.AjaxFormLoop#encoder} parameter. */ public static final String ADD_ROW = "addRow"; @@ -168,7 +168,7 @@ public class EventConstants * request completions of * the current input. The context is the partial string provided by the client. * - * @SINCE 5.1.0.4 + * @since 5.1.0.4 */ public static final String PROVIDE_COMPLETIONS = "provideCompletions"; Modified: tapestry/tapestry5/trunk/tapestry-core/src/main/java/org/apache/tapestry5/TrackableComponentEventCallback.java URL: http://svn.apache.org/viewvc/tapestry/tapestry5/trunk/tapestry-core/src/main/java/org/apache/tapestry5/TrackableComponentEventCallback.java?rev=1140164&r1=1140163&r2=1140164&view=diff ============================================================================== --- tapestry/tapestry5/trunk/tapestry-core/src/main/java/org/apache/tapestry5/TrackableComponentEventCallback.java (original) +++ tapestry/tapestry5/trunk/tapestry-core/src/main/java/org/apache/tapestry5/TrackableComponentEventCallback.java Mon Jun 27 13:57:43 2011 @@ -23,8 +23,9 @@ import org.apache.tapestry5.services.Tra /** * Extends {@link ComponentEventCallback} with a way to determine if the underlying event has been aborted * due to a some event returning an acceptable, non-null value. The standard implementation of this - * is a wrapper around either the {@linkplain Traditional traditional} or {@linkplain Ajax} versions - * of the {@link ComponentEventResultProcessor} service, i.e., they allow for a navigational result. + * is a wrapper around either the {@linkplain Traditional traditional} or + * {@linkplain org.apache.tapestry5.services.Ajax ajax} versions of the {@link ComponentEventResultProcessor} + * service, i.e., they allow for a navigational result. * <p> * Instances of this are made available via the {@link Environmental} annotation. * Modified: tapestry/tapestry5/trunk/tapestry-core/src/main/java/org/apache/tapestry5/ajax/MultiZoneUpdate.java URL: http://svn.apache.org/viewvc/tapestry/tapestry5/trunk/tapestry-core/src/main/java/org/apache/tapestry5/ajax/MultiZoneUpdate.java?rev=1140164&r1=1140163&r2=1140164&view=diff ============================================================================== --- tapestry/tapestry5/trunk/tapestry-core/src/main/java/org/apache/tapestry5/ajax/MultiZoneUpdate.java (original) +++ tapestry/tapestry5/trunk/tapestry-core/src/main/java/org/apache/tapestry5/ajax/MultiZoneUpdate.java Mon Jun 27 13:57:43 2011 @@ -45,7 +45,8 @@ public class MultiZoneUpdate this(zoneId, renderer, null); } - /** Alternate constructor that takes a ClientBodyElement (typically, a {@link Zone}). */ + /** Alternate constructor that takes a ClientBodyElement (typically, a + * {@link org.apache.tapestry5.corelib.components.Zone}). */ public MultiZoneUpdate(ClientBodyElement zone) { this(zone.getClientId(), zone.getBody()); Modified: tapestry/tapestry5/trunk/tapestry-core/src/main/java/org/apache/tapestry5/dom/Element.java URL: http://svn.apache.org/viewvc/tapestry/tapestry5/trunk/tapestry-core/src/main/java/org/apache/tapestry5/dom/Element.java?rev=1140164&r1=1140163&r2=1140164&view=diff ============================================================================== --- tapestry/tapestry5/trunk/tapestry-core/src/main/java/org/apache/tapestry5/dom/Element.java (original) +++ tapestry/tapestry5/trunk/tapestry-core/src/main/java/org/apache/tapestry5/dom/Element.java Mon Jun 27 13:57:43 2011 @@ -489,9 +489,6 @@ public final class Element extends Node /** * Searchs for a child element with a particular name below this element. The path parameter is a slash separated * series of element names. - * - * @param path - * @return */ public Element find(String path) { Modified: tapestry/tapestry5/trunk/tapestry-core/src/main/java/org/apache/tapestry5/internal/TapestryInternalUtils.java URL: http://svn.apache.org/viewvc/tapestry/tapestry5/trunk/tapestry-core/src/main/java/org/apache/tapestry5/internal/TapestryInternalUtils.java?rev=1140164&r1=1140163&r2=1140164&view=diff ============================================================================== --- tapestry/tapestry5/trunk/tapestry-core/src/main/java/org/apache/tapestry5/internal/TapestryInternalUtils.java (original) +++ tapestry/tapestry5/trunk/tapestry-core/src/main/java/org/apache/tapestry5/internal/TapestryInternalUtils.java Mon Jun 27 13:57:43 2011 @@ -122,9 +122,6 @@ public class TapestryInternalUtils /** * Converts a string to an {@link OptionModel}. The string is of the form "value=label". If the equals sign is * omitted, then the same value is used for both value and label. - * - * @param input - * @return */ public static OptionModel toOptionModel(String input) { @@ -161,9 +158,6 @@ public class TapestryInternalUtils /** * Wraps the result of {@link #toOptionModels(String)} as a {@link SelectModel} (with no option groups). - * - * @param input - * @return */ public static SelectModel toSelectModel(String input) { @@ -174,9 +168,6 @@ public class TapestryInternalUtils /** * Converts a map entry to an {@link OptionModel}. - * - * @param input - * @return */ public static OptionModel toOptionModel(Map.Entry input) { @@ -206,9 +197,6 @@ public class TapestryInternalUtils /** * Wraps the result of {@link #toOptionModels(Map)} as a {@link SelectModel} (with no option groups). - * - * @param input - * @return */ public static <K, V> SelectModel toSelectModel(Map<K, V> input) { @@ -219,9 +207,6 @@ public class TapestryInternalUtils /** * Converts an object to an {@link OptionModel}. - * - * @param input - * @return */ public static OptionModel toOptionModel(Object input) { @@ -250,9 +235,6 @@ public class TapestryInternalUtils /** * Wraps the result of {@link #toOptionModels(List)} as a {@link SelectModel} (with no option groups). - * - * @param input - * @return */ public static <E> SelectModel toSelectModel(List<E> input) { @@ -264,9 +246,6 @@ public class TapestryInternalUtils /** * Parses a key/value pair where the key and the value are seperated by an equals sign. The key and value are * trimmed of leading and trailing whitespace, and returned as a {@link KeyValue}. - * - * @param input - * @return */ public static KeyValue parseKeyValue(String input) { @@ -348,6 +327,7 @@ public class TapestryInternalUtils * @param messages * the messages to search for the label * @param prefix + * prepended to key * @param value * to get a label for * @return the label @@ -383,7 +363,6 @@ public class TapestryInternalUtils * Determines if the two values are equal. They are equal if they are the exact same value (including if they are * both null). Otherwise standard equals() comparison is used. * - * @param <T> * @param left * value to compare, possibly null * @param right @@ -396,7 +375,7 @@ public class TapestryInternalUtils return true; if (left == null) - return right == null; + return false; return left.equals(right); } @@ -550,11 +529,11 @@ public class TapestryInternalUtils public static Orderable<String> mixinTypeAndOrder(String mixinDef) { int idx = mixinDef.indexOf("::"); - if (idx == -1) { return new Orderable(mixinDef, mixinDef); } + if (idx == -1) { return new Orderable<String>(mixinDef, mixinDef); } String type = mixinDef.substring(0, idx); String[] constraints = splitMixinConstraints(mixinDef.substring(idx + 2)); - return new Orderable(type, type, constraints); + return new Orderable<String>(type, type, constraints); } public static String[] splitMixinConstraints(String s) @@ -563,7 +542,7 @@ public class TapestryInternalUtils } /** - * Common mapper, used primarily with {@link F#map(Mapper, java.util.Collection)} + * Common mapper, used primarily with {@link org.apache.tapestry5.func.Flow#map(org.apache.tapestry5.func.Mapper)} * * @since 5.2.0 */ @@ -572,7 +551,7 @@ public class TapestryInternalUtils public StylesheetLink map(Asset input) { return new StylesheetLink(input); - }; + } }; public static LinkCreationListener2 toLinkCreationListener2(final LinkCreationListener delegate) Modified: tapestry/tapestry5/trunk/tapestry-core/src/main/java/org/apache/tapestry5/internal/services/javascript/CoreJavaScriptStack.java URL: http://svn.apache.org/viewvc/tapestry/tapestry5/trunk/tapestry-core/src/main/java/org/apache/tapestry5/internal/services/javascript/CoreJavaScriptStack.java?rev=1140164&r1=1140163&r2=1140164&view=diff ============================================================================== --- tapestry/tapestry5/trunk/tapestry-core/src/main/java/org/apache/tapestry5/internal/services/javascript/CoreJavaScriptStack.java (original) +++ tapestry/tapestry5/trunk/tapestry-core/src/main/java/org/apache/tapestry5/internal/services/javascript/CoreJavaScriptStack.java Mon Jun 27 13:57:43 2011 @@ -32,7 +32,7 @@ import org.apache.tapestry5.services.jav import org.apache.tapestry5.services.javascript.StylesheetLink; /** - * JavaScriptStack based on the information retrieved from {@link ClientInfrastructure}. + * JavaScriptStack for core components. * * @since 5.2.0 */