[GitHub] [tinkerpop] lyndonbauto commented on a diff in pull request #1700: gremlin-go: support per-request arguments in bytecode

lyndonbauto commented on code in PR #1700: URL: https://github.com/apache/tinkerpop/pull/1700#discussion_r902069270 ## gremlin-go/driver/connection_test.go: ## @@ -1121,4 +1121,26 @@ func TestConnection(t *testing.T) { // This routine. assert.Equa

[GitHub] [tinkerpop] lyndonbauto commented on pull request #1709: TINKERPOP-2617 Clean up Java connection pool logic

lyndonbauto commented on PR #1709: URL: https://github.com/apache/tinkerpop/pull/1709#issuecomment-1160994147 @divijvaidya do you have time to look at this? I think you have the most context on Java connection pooling. -- This is an automated message from the Apache Git Service. To respon

[GitHub] [tinkerpop] lyndonbauto commented on pull request #1714: TINKERPOP-2751: Throw exception if transaction attempted on non transaction supported Graph

lyndonbauto commented on PR #1714: URL: https://github.com/apache/tinkerpop/pull/1714#issuecomment-1160993595 Nice - I remember briefly looking for the culprit on this issue. VOTE+1 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to Git

[GitHub] [tinkerpop] spmallette merged pull request #1717: Match 3.5 changes in `gremlin-dotnet`

spmallette merged PR #1717: URL: https://github.com/apache/tinkerpop/pull/1717 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@tinke

[tinkerpop] branch 3.6-dev updated (2b7ac95595 -> 647800815c)

This is an automated email from the ASF dual-hosted git repository. spmallette pushed a change to branch 3.6-dev in repository https://gitbox.apache.org/repos/asf/tinkerpop.git from 2b7ac95595 Merge branch '3.5-dev' into 3.6-dev add b018aaacfa Match 3.5 changes in `gremlin-dotnet`

[tinkerpop] branch master updated (7f37355700 -> 017ccc9faa)

This is an automated email from the ASF dual-hosted git repository. spmallette pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/tinkerpop.git from 7f37355700 Merge branch '3.6-dev' add b018aaacfa Match 3.5 changes in `gremlin-dotnet` add 553b14630a

[GitHub] [tinkerpop] L0Lmaker commented on pull request #1690: TINKERPOP-2749: Gremlin Dotnet Windows Build fixes

L0Lmaker commented on PR #1690: URL: https://github.com/apache/tinkerpop/pull/1690#issuecomment-1160771672 Created a follow-up issue on JIRA. Link to issue: [TINKERPOP-2760](https://issues.apache.org/jira/browse/TINKERPOP-2760) -- This is an automated message from the Apache Git Servic

[GitHub] [tinkerpop] L0Lmaker commented on a diff in pull request #1717: Match 3.5 changes in `gremlin-dotnet`

L0Lmaker commented on code in PR #1717: URL: https://github.com/apache/tinkerpop/pull/1717#discussion_r901941814 ## gremlin-dotnet/src/pom.xml: ## @@ -65,14 +65,16 @@ limitations under the License.

[GitHub] [tinkerpop] L0Lmaker commented on a diff in pull request #1717: Match 3.5 changes in `gremlin-dotnet`

L0Lmaker commented on code in PR #1717: URL: https://github.com/apache/tinkerpop/pull/1717#discussion_r901941814 ## gremlin-dotnet/src/pom.xml: ## @@ -65,14 +65,16 @@ limitations under the License.

[GitHub] [tinkerpop] spmallette commented on pull request #1716: fix version key race in Manifest

spmallette commented on PR #1716: URL: https://github.com/apache/tinkerpop/pull/1716#issuecomment-1160747745 thanks for contributing, but i'm not sure i understand the discussion that was referenced and thus not sure i understand why the manifest version needs a special `tinkerpopVersion`.

[GitHub] [tinkerpop] spmallette commented on pull request #1706: Doc Update: Add Session OpProcessor `close` message back to Provider Documentation

spmallette commented on PR #1706: URL: https://github.com/apache/tinkerpop/pull/1706#issuecomment-1160745844 cherry-picked as 0a572133aab44c3f9d5cc3b6cb463950a21937e2 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[GitHub] [tinkerpop] spmallette closed pull request #1706: Doc Update: Add Session OpProcessor `close` message back to Provider Documentation

spmallette closed pull request #1706: Doc Update: Add Session OpProcessor `close` message back to Provider Documentation URL: https://github.com/apache/tinkerpop/pull/1706 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use t

[tinkerpop] branch 3.6-dev updated (ee394b79e9 -> 2b7ac95595)

This is an automated email from the ASF dual-hosted git repository. spmallette pushed a change to branch 3.6-dev in repository https://gitbox.apache.org/repos/asf/tinkerpop.git from ee394b79e9 Merge branch 'pr-1698' into 3.6-dev add 0a572133aa Adding `close` message back to provider doc

[tinkerpop] branch 3.5-dev updated (24da24ff11 -> 0a572133aa)

This is an automated email from the ASF dual-hosted git repository. spmallette pushed a change to branch 3.5-dev in repository https://gitbox.apache.org/repos/asf/tinkerpop.git from 24da24ff11 Updated CHANGELOG CTR add 0a572133aa Adding `close` message back to provider doc as it was add

[tinkerpop] 01/03: Adding `close` message back to provider doc as it was added back in 3.5.2

This is an automated email from the ASF dual-hosted git repository. spmallette pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/tinkerpop.git commit 0a572133aab44c3f9d5cc3b6cb463950a21937e2 Author: Yang Xia <55853655+xia...@users.noreply.github.com> AuthorDate: T

[tinkerpop] branch master updated (df0c7367d9 -> 7f37355700)

This is an automated email from the ASF dual-hosted git repository. spmallette pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/tinkerpop.git from df0c7367d9 Merge branch '3.6-dev' new 0a572133aa Adding `close` message back to provider doc as it was add

[tinkerpop] 02/03: Merge branch '3.5-dev' into 3.6-dev

This is an automated email from the ASF dual-hosted git repository. spmallette pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/tinkerpop.git commit 2b7ac95595c2c6218976a520f0cffa9d23cbdd05 Merge: ee394b79e9 0a572133aa Author: Stephen Mallette AuthorDate: Mon Ju

[tinkerpop] 03/03: Merge branch '3.6-dev'

This is an automated email from the ASF dual-hosted git repository. spmallette pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/tinkerpop.git commit 7f37355700e2cf99dbdf41a393e910ca77d35f35 Merge: df0c7367d9 2b7ac95595 Author: Stephen Mallette AuthorDate: Mon Ju

[tinkerpop] branch 3.5-dev updated (be70714c28 -> 24da24ff11)

This is an automated email from the ASF dual-hosted git repository. spmallette pushed a change to branch 3.5-dev in repository https://gitbox.apache.org/repos/asf/tinkerpop.git from be70714c28 Refactor gremlin-go documentation to be more consistent (#1718) add ee9faad047 Add missing re

[GitHub] [tinkerpop] spmallette merged pull request #1710: Complete ResponseStatusCodeEnum in in .NET (3.5-dev)

spmallette merged PR #1710: URL: https://github.com/apache/tinkerpop/pull/1710 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@tinke

[tinkerpop] branch 3.6-dev updated (3fa2be6b3d -> ee394b79e9)

This is an automated email from the ASF dual-hosted git repository. spmallette pushed a change to branch 3.6-dev in repository https://gitbox.apache.org/repos/asf/tinkerpop.git from 3fa2be6b3d Merging 3.5-dev into 3.6-dev and fixing conflicts in gremlin-go docs add ee9faad047 Add missi

[GitHub] [tinkerpop] spmallette merged pull request #1698: Complete ResponseStatusCodeEnum in .NET (3.6-dev)

spmallette merged PR #1698: URL: https://github.com/apache/tinkerpop/pull/1698 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@tinke

[tinkerpop] 02/05: Updated CHANGELOG CTR

This is an automated email from the ASF dual-hosted git repository. spmallette pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/tinkerpop.git commit 24da24ff11f0547124d81119d8eb3ed8804c7a91 Author: Stephen Mallette AuthorDate: Mon Jun 20 14:27:44 2022 -0400

[tinkerpop] 03/05: Merge branch '3.5-dev' into 3.6-dev

This is an automated email from the ASF dual-hosted git repository. spmallette pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/tinkerpop.git commit 0f2f71c85c2b2dc3097bdd9d90a928f7569962ac Merge: 3fa2be6b3d 24da24ff11 Author: Stephen Mallette AuthorDate: Mon Ju

[tinkerpop] 05/05: Merge branch '3.6-dev'

This is an automated email from the ASF dual-hosted git repository. spmallette pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/tinkerpop.git commit df0c7367d97a440fb0f1d6c3d8a5f26a07ae01b2 Merge: 9b97286447 ee394b79e9 Author: Stephen Mallette AuthorDate: Mon Ju

[tinkerpop] branch master updated (9b97286447 -> df0c7367d9)

This is an automated email from the ASF dual-hosted git repository. spmallette pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/tinkerpop.git from 9b97286447 Minor formatting CTR add ee9faad047 Add missing response status codes in .NET. add 8752c04

[tinkerpop] 01/05: Merge branch 'pr-1710' into 3.5-dev

This is an automated email from the ASF dual-hosted git repository. spmallette pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/tinkerpop.git commit 91ad781b12f5c6ca03d29418119026b601dd15be Merge: be70714c28 8752c04163 Author: Stephen Mallette AuthorDate: Mon Ju

[tinkerpop] 04/05: Merge branch 'pr-1698' into 3.6-dev

This is an automated email from the ASF dual-hosted git repository. spmallette pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/tinkerpop.git commit ee394b79e91158dea05b87eaa7e6f13c8513e90b Merge: 0f2f71c85c 93e384eff2 Author: Stephen Mallette AuthorDate: Mon Ju

[GitHub] [tinkerpop] spmallette commented on pull request #1657: TINKERPOP-2742 Give graph providers a hint of property cardinality

spmallette commented on PR #1657: URL: https://github.com/apache/tinkerpop/pull/1657#issuecomment-1160732540 new PR at: #1719 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[GitHub] [tinkerpop] spmallette commented on pull request #1699: fix: Traversal.graph is empty in StepStrategy.apply() with `count().is(0)`

spmallette commented on PR #1699: URL: https://github.com/apache/tinkerpop/pull/1699#issuecomment-1160731883 sorry no one has had a chance to look at this until now. i think you've identified the problem well. A few things: 1. you supplied an example in the PR description where this w

[GitHub] [tinkerpop] spmallette closed pull request #1657: TINKERPOP-2742 Give graph providers a hint of property cardinality

spmallette closed pull request #1657: TINKERPOP-2742 Give graph providers a hint of property cardinality URL: https://github.com/apache/tinkerpop/pull/1657 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [tinkerpop] spmallette commented on pull request #1697: TINKERPOP-2734 Fix potential SessionedClient NPE

spmallette commented on PR #1697: URL: https://github.com/apache/tinkerpop/pull/1697#issuecomment-1160721290 sounds good @simonz-bq - that's what i saw too. i could envision where you had a multiple hosts and the session happened to pick an unavailable one at random and then separately a di

[GitHub] [tinkerpop] L0Lmaker commented on a diff in pull request #1717: Match 3.5 changes in `gremlin-dotnet`

L0Lmaker commented on code in PR #1717: URL: https://github.com/apache/tinkerpop/pull/1717#discussion_r901912227 ## gremlin-dotnet/src/pom.xml: ## @@ -65,14 +65,16 @@ limitations under the License.

[GitHub] [tinkerpop] simonz-bq commented on pull request #1697: TINKERPOP-2734 Fix potential SessionedClient NPE

simonz-bq commented on PR #1697: URL: https://github.com/apache/tinkerpop/pull/1697#issuecomment-1160709486 > if so, what circumstance allows that to happen and how does this change either potentially fix or better expose that problem? In the case that initializing the connection pool

[GitHub] [tinkerpop] L0Lmaker commented on a diff in pull request #1714: TINKERPOP-2751: Throw exception if transaction attempted on non transaction supported Graph

L0Lmaker commented on code in PR #1714: URL: https://github.com/apache/tinkerpop/pull/1714#discussion_r901888980 ## gremlin-server/src/main/java/org/apache/tinkerpop/gremlin/server/op/session/SessionOpProcessor.java: ## @@ -526,6 +526,11 @@ protected void handleGraphOperation(fi

[GitHub] [tinkerpop] spmallette commented on pull request #1697: TINKERPOP-2734 Fix potential SessionedClient NPE

spmallette commented on PR #1697: URL: https://github.com/apache/tinkerpop/pull/1697#issuecomment-1160660043 > which may indicate the connection pool hasn't been initialized in SessionedClient.initializeImplementation() I understand what it is doing, but I'm more asking, is there a th

[GitHub] [tinkerpop] dependabot[bot] closed pull request #1687: Bump github.com/stretchr/testify from 1.7.0 to 1.7.2 in /gremlin-go

dependabot[bot] closed pull request #1687: Bump github.com/stretchr/testify from 1.7.0 to 1.7.2 in /gremlin-go URL: https://github.com/apache/tinkerpop/pull/1687 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL abo

[GitHub] [tinkerpop] dependabot[bot] commented on pull request #1687: Bump github.com/stretchr/testify from 1.7.0 to 1.7.2 in /gremlin-go

dependabot[bot] commented on PR #1687: URL: https://github.com/apache/tinkerpop/pull/1687#issuecomment-1160574686 Superseded by #1722. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [tinkerpop] dependabot[bot] opened a new pull request, #1722: Bump github.com/stretchr/testify from 1.7.0 to 1.7.3 in /gremlin-go

dependabot[bot] opened a new pull request, #1722: URL: https://github.com/apache/tinkerpop/pull/1722 Bumps [github.com/stretchr/testify](https://github.com/stretchr/testify) from 1.7.0 to 1.7.3. Commits https://github.com/stretchr/testify/commit/07dc7ee5abe6d1c0ef6449f731ca9bf0

[tinkerpop] branch dependabot/go_modules/gremlin-go/3.5-dev/github.com/stretchr/testify-1.7.3 created (now 51b91f7a72)

This is an automated email from the ASF dual-hosted git repository. github-bot pushed a change to branch dependabot/go_modules/gremlin-go/3.5-dev/github.com/stretchr/testify-1.7.3 in repository https://gitbox.apache.org/repos/asf/tinkerpop.git at 51b91f7a72 Bump github.com/stretchr/testif

[GitHub] [tinkerpop] dependabot[bot] opened a new pull request, #1721: Bump typescript from 4.7.3 to 4.7.4 in /gremlint

dependabot[bot] opened a new pull request, #1721: URL: https://github.com/apache/tinkerpop/pull/1721 Bumps [typescript](https://github.com/Microsoft/TypeScript) from 4.7.3 to 4.7.4. Release notes Sourced from https://github.com/Microsoft/TypeScript/releases";>typescript's releases

[GitHub] [tinkerpop] dependabot[bot] commented on pull request #1685: Bump eslint from 7.32.0 to 8.17.0 in /gremlin-javascript/src/main/javascript/gremlin-javascript

dependabot[bot] commented on PR #1685: URL: https://github.com/apache/tinkerpop/pull/1685#issuecomment-1160569220 Superseded by #1720. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[tinkerpop] branch dependabot/npm_and_yarn/gremlint/3.5-dev/typescript-4.7.4 created (now bea9576965)

This is an automated email from the ASF dual-hosted git repository. github-bot pushed a change to branch dependabot/npm_and_yarn/gremlint/3.5-dev/typescript-4.7.4 in repository https://gitbox.apache.org/repos/asf/tinkerpop.git at bea9576965 Bump typescript from 4.7.3 to 4.7.4 in /gremlint

[GitHub] [tinkerpop] dependabot[bot] closed pull request #1685: Bump eslint from 7.32.0 to 8.17.0 in /gremlin-javascript/src/main/javascript/gremlin-javascript

dependabot[bot] closed pull request #1685: Bump eslint from 7.32.0 to 8.17.0 in /gremlin-javascript/src/main/javascript/gremlin-javascript URL: https://github.com/apache/tinkerpop/pull/1685 -- This is an automated message from the Apache Git Service. To respond to the message, please log on t

[tinkerpop] branch dependabot/npm_and_yarn/gremlin-javascript/src/main/javascript/gremlin-javascript/3.5-dev/eslint-8.18.0 created (now cfe6359a02)

This is an automated email from the ASF dual-hosted git repository. github-bot pushed a change to branch dependabot/npm_and_yarn/gremlin-javascript/src/main/javascript/gremlin-javascript/3.5-dev/eslint-8.18.0 in repository https://gitbox.apache.org/repos/asf/tinkerpop.git at cfe6359a02 Bu

[GitHub] [tinkerpop] dependabot[bot] opened a new pull request, #1720: Bump eslint from 7.32.0 to 8.18.0 in /gremlin-javascript/src/main/javascript/gremlin-javascript

dependabot[bot] opened a new pull request, #1720: URL: https://github.com/apache/tinkerpop/pull/1720 Bumps [eslint](https://github.com/eslint/eslint) from 7.32.0 to 8.18.0. Release notes Sourced from https://github.com/eslint/eslint/releases";>eslint's releases. v8.18.0 Fe

[GitHub] [tinkerpop] alexey-temnikov commented on pull request #1697: TINKERPOP-2734 Fix potential SessionedClient NPE

alexey-temnikov commented on PR #1697: URL: https://github.com/apache/tinkerpop/pull/1697#issuecomment-1160552531 @spmallette, in the reported error logs the cause exception stack trace got swallowed - `Could not initialize client for Optional[..]` which may indicate the connection pool has

[GitHub] [tinkerpop] spmallette commented on pull request #1697: TINKERPOP-2734 Fix potential SessionedClient NPE

spmallette commented on PR #1697: URL: https://github.com/apache/tinkerpop/pull/1697#issuecomment-1160459458 generally speaking, i don't really see anything wrong with this change. i dont' think it introduces anything bad and the decoupling of logic is probably a good idea. could we questio

[tinkerpop] branch master updated: Minor formatting CTR

This is an automated email from the ASF dual-hosted git repository. spmallette pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/tinkerpop.git The following commit(s) were added to refs/heads/master by this push: new 9b97286447 Minor formatting CTR 9b9728644

[GitHub] [tinkerpop] spmallette merged pull request #1701: TINKERPOP-2708 follow-up: Remove javascript connectOnStartup API on master branch

spmallette merged PR #1701: URL: https://github.com/apache/tinkerpop/pull/1701 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@tinke

[GitHub] [tinkerpop] FlorianHockmann commented on a diff in pull request #1717: Match 3.5 changes in `gremlin-dotnet`

FlorianHockmann commented on code in PR #1717: URL: https://github.com/apache/tinkerpop/pull/1717#discussion_r901332629 ## gremlin-dotnet/src/pom.xml: ## @@ -65,14 +65,16 @@ limitations under the License.