[GitHub] [tinkerpop] Cole-Greer commented on pull request #2094: TINKERPOP-2959 Allowed parsing of parameters with the grammar

2023-06-15 Thread via GitHub
Cole-Greer commented on PR #2094: URL: https://github.com/apache/tinkerpop/pull/2094#issuecomment-1593795756 Thanks for putting this all together Stephen. I'm a big fan of anything which reduces the gap between gremlin-lang and gremlin-groovy. This is a bit out of my wheelhouse but I took

[GitHub] [tinkerpop] Cole-Greer commented on a diff in pull request #2094: TINKERPOP-2959 Allowed parsing of parameters with the grammar

2023-06-15 Thread via GitHub
Cole-Greer commented on code in PR #2094: URL: https://github.com/apache/tinkerpop/pull/2094#discussion_r1231588579 ## gremlin-language/src/main/antlr4/Gremlin.g4: ## @@ -1403,7 +1521,7 @@ genericLiteralMap | LBRACK mapEntry (COMMA mapEntry)* RBRACK ; -// allow

[GitHub] [tinkerpop] xiazcy commented on pull request #2090: TINKERPOP-2958 Added cancel for query timeout task when query completes.

2023-06-15 Thread via GitHub
xiazcy commented on PR #2090: URL: https://github.com/apache/tinkerpop/pull/2090#issuecomment-1593739096 LGTM, VOTE +1 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [tinkerpop] vkagamlyk commented on a diff in pull request #2094: TINKERPOP-2959 Allowed parsing of parameters with the grammar

2023-06-15 Thread via GitHub
vkagamlyk commented on code in PR #2094: URL: https://github.com/apache/tinkerpop/pull/2094#discussion_r1231535172 ## gremlin-core/src/test/java/org/apache/tinkerpop/gremlin/language/grammar/ArgumentVisitorTest.java: ## @@ -0,0 +1,260 @@ +/* + * Licensed to the Apache Software

[GitHub] [tinkerpop] xiazcy commented on pull request #2094: TINKERPOP-2959 Allowed parsing of parameters with the grammar

2023-06-15 Thread via GitHub
xiazcy commented on PR #2094: URL: https://github.com/apache/tinkerpop/pull/2094#issuecomment-1593701729 This feature definitely opens up improvement opportunties. I'm not too familiar with many of the technical details, but on a high level the change looks good. I also like how the

[GitHub] [tinkerpop] vkagamlyk commented on a diff in pull request #2094: TINKERPOP-2959 Allowed parsing of parameters with the grammar

2023-06-15 Thread via GitHub
vkagamlyk commented on code in PR #2094: URL: https://github.com/apache/tinkerpop/pull/2094#discussion_r1231504873 ## gremlin-core/src/main/java/org/apache/tinkerpop/gremlin/language/grammar/ArgumentVisitor.java: ## @@ -0,0 +1,420 @@ +/* + * Licensed to the Apache Software

[GitHub] [tinkerpop] codecov-commenter commented on pull request #2098: Bump netty from 3.7.1.Final to 3.10.6.Final

2023-06-15 Thread via GitHub
codecov-commenter commented on PR #2098: URL: https://github.com/apache/tinkerpop/pull/2098#issuecomment-1593270133 ## [Codecov](https://app.codecov.io/gh/apache/tinkerpop/pull/2098?src=pr=h1_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache) Report >

[GitHub] [tinkerpop] dependabot[bot] opened a new pull request, #2098: Bump netty from 3.7.1.Final to 3.10.6.Final

2023-06-15 Thread via GitHub
dependabot[bot] opened a new pull request, #2098: URL: https://github.com/apache/tinkerpop/pull/2098 Bumps [netty](https://github.com/netty/netty) from 3.7.1.Final to 3.10.6.Final. Commits https://github.com/netty/netty/commit/5f56a03bcb0aa23bdc9f68686e5c2abcf963a9cd;>5f56a03

[tinkerpop] branch dependabot/maven/3.5-dev/io.netty-netty-3.10.6.Final created (now 79d54a79e1)

2023-06-15 Thread github-bot
This is an automated email from the ASF dual-hosted git repository. github-bot pushed a change to branch dependabot/maven/3.5-dev/io.netty-netty-3.10.6.Final in repository https://gitbox.apache.org/repos/asf/tinkerpop.git at 79d54a79e1 Bump netty from 3.7.1.Final to 3.10.6.Final No new

[tinkerpop] branch dependabot/maven/3.5-dev/org.apache.maven.plugins-maven-antrun-plugin-3.1.0 deleted (was 019235f0c2)

2023-06-15 Thread github-bot
This is an automated email from the ASF dual-hosted git repository. github-bot pushed a change to branch dependabot/maven/3.5-dev/org.apache.maven.plugins-maven-antrun-plugin-3.1.0 in repository https://gitbox.apache.org/repos/asf/tinkerpop.git was 019235f0c2 Bump maven-antrun-plugin from

[GitHub] [tinkerpop] dependabot[bot] commented on pull request #1982: Bump maven-antrun-plugin from 1.8 to 3.1.0

2023-06-15 Thread via GitHub
dependabot[bot] commented on PR #1982: URL: https://github.com/apache/tinkerpop/pull/1982#issuecomment-1593055671 OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor version,

[GitHub] [tinkerpop] spmallette closed pull request #1982: Bump maven-antrun-plugin from 1.8 to 3.1.0

2023-06-15 Thread via GitHub
spmallette closed pull request #1982: Bump maven-antrun-plugin from 1.8 to 3.1.0 URL: https://github.com/apache/tinkerpop/pull/1982 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[tinkerpop] branch 3.6-dev updated (9613c1e37d -> 727dcc0af3)

2023-06-15 Thread spmallette
This is an automated email from the ASF dual-hosted git repository. spmallette pushed a change to branch 3.6-dev in repository https://gitbox.apache.org/repos/asf/tinkerpop.git from 9613c1e37d Merge branch '3.5-dev' into 3.6-dev add 727dcc0af3 Bumped to maven-antrun-plugin 3.1.0 CTR

[tinkerpop] branch master updated: Bumped to maven-antrun-plugin 3.1.0 CTR

2023-06-15 Thread spmallette
This is an automated email from the ASF dual-hosted git repository. spmallette pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/tinkerpop.git The following commit(s) were added to refs/heads/master by this push: new 727dcc0af3 Bumped to maven-antrun-plugin

[GitHub] [tinkerpop] spmallette merged pull request #2079: [TINKERPOP-2955] Support SSL in WebSocketClient

2023-06-15 Thread via GitHub
spmallette merged PR #2079: URL: https://github.com/apache/tinkerpop/pull/2079 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[tinkerpop] branch master updated (c067697f66 -> 3e0fa8f600)

2023-06-15 Thread spmallette
This is an automated email from the ASF dual-hosted git repository. spmallette pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/tinkerpop.git from c067697f66 Merge branch '3.6-dev' add 35a99f0a5e [TINKERPOP-2955] Support SSL in WebSocketClient new

[tinkerpop] branch 3.5-dev updated (6d3d42a415 -> 98d24d0dc1)

2023-06-15 Thread spmallette
This is an automated email from the ASF dual-hosted git repository. spmallette pushed a change to branch 3.5-dev in repository https://gitbox.apache.org/repos/asf/tinkerpop.git from 6d3d42a415 Bump Microsoft.Extensions.Logging.Abstractions in /gremlin-dotnet add 35a99f0a5e

[tinkerpop] 01/03: Merge branch 'pr-2079' into 3.5-dev

2023-06-15 Thread spmallette
This is an automated email from the ASF dual-hosted git repository. spmallette pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/tinkerpop.git commit 98d24d0dc1332e547e5acfefa4db3b5219a5d1ce Merge: 6d3d42a415 35a99f0a5e Author: Stephen Mallette AuthorDate: Thu

[tinkerpop] branch 3.6-dev updated (f00cfe5592 -> 9613c1e37d)

2023-06-15 Thread spmallette
This is an automated email from the ASF dual-hosted git repository. spmallette pushed a change to branch 3.6-dev in repository https://gitbox.apache.org/repos/asf/tinkerpop.git from f00cfe5592 Merge branch '3.5-dev' into 3.6-dev add 35a99f0a5e [TINKERPOP-2955] Support SSL in

[tinkerpop] 03/03: Merge branch '3.6-dev'

2023-06-15 Thread spmallette
This is an automated email from the ASF dual-hosted git repository. spmallette pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/tinkerpop.git commit 3e0fa8f600971781982ab6e661e1e986eeb68fe0 Merge: c067697f66 9613c1e37d Author: Stephen Mallette AuthorDate: Thu

[tinkerpop] 02/03: Merge branch '3.5-dev' into 3.6-dev

2023-06-15 Thread spmallette
This is an automated email from the ASF dual-hosted git repository. spmallette pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/tinkerpop.git commit 9613c1e37da1ba74d523e5a62f50555c6328cb28 Merge: f00cfe5592 98d24d0dc1 Author: Stephen Mallette AuthorDate: Thu

[tinkerpop] branch TINKERPOP-2959 updated (f08fac16c0 -> cd1eb8b133)

2023-06-15 Thread spmallette
This is an automated email from the ASF dual-hosted git repository. spmallette pushed a change to branch TINKERPOP-2959 in repository https://gitbox.apache.org/repos/asf/tinkerpop.git omit f08fac16c0 TINKERPOP-2959 Allowed parsing of parameters with the grammar new cd1eb8b133