Re: [PR] feat: `gremlin-javascript` browser support [tinkerpop]

2024-03-04 Thread via GitHub
tien commented on PR #2506: URL: https://github.com/apache/tinkerpop/pull/2506#issuecomment-1977996547 @kenhuuu thanks for this. I'll try to find another VOTE +1 if possible. Would be beneficial for me to get this in early because there's a work project I'm on that's currently using this.

Re: [PR] feat: `gremlin-javascript` browser support [tinkerpop]

2024-03-04 Thread via GitHub
kenhuuu commented on PR #2506: URL: https://github.com/apache/tinkerpop/pull/2506#issuecomment-1977977554 VOTE +1. Thanks again for your willingness to contribute. It is much appreciated. I'm not sure if you are familiar with our policy but it takes a VOTE+1 from three different

Re: [PR] feat: `gremlin-javascript` browser support [tinkerpop]

2024-03-04 Thread via GitHub
kenhuuu commented on PR #2506: URL: https://github.com/apache/tinkerpop/pull/2506#issuecomment-1977973238 > @kenhuuu regarding the user agent header [used](https://tinkerpop.apache.org/docs/current/dev/provider/#_graph_driver_provider_requirements) by Gremlin server > > This is

Re: [PR] feat: `gremlin-javascript` browser support [tinkerpop]

2024-03-04 Thread via GitHub
kenhuuu commented on code in PR #2506: URL: https://github.com/apache/tinkerpop/pull/2506#discussion_r1512135739 ## gremlin-javascript/src/main/javascript/gremlin-javascript/lib/utils.js: ## @@ -112,8 +95,36 @@ exports.getUserAgentHeader = function getUserAgentHeader() {

Re: [PR] feat: `gremlin-javascript` browser support [tinkerpop]

2024-03-04 Thread via GitHub
tien commented on PR #2506: URL: https://github.com/apache/tinkerpop/pull/2506#issuecomment-1977944006 @kenhuuu regarding the user agent header [used](https://tinkerpop.apache.org/docs/current/dev/provider/#_graph_driver_provider_requirements) by Gremlin server This is likely a

Re: [PR] feat: `gremlin-javascript` browser support [tinkerpop]

2024-03-04 Thread via GitHub
tien commented on code in PR #2506: URL: https://github.com/apache/tinkerpop/pull/2506#discussion_r1512022240 ## gremlin-javascript/src/main/javascript/gremlin-javascript/lib/utils.js: ## @@ -112,8 +95,36 @@ exports.getUserAgentHeader = function getUserAgentHeader() { return

Re: [PR] feat: `gremlin-javascript` browser support [tinkerpop]

2024-03-04 Thread via GitHub
kenhuuu commented on code in PR #2506: URL: https://github.com/apache/tinkerpop/pull/2506#discussion_r1511974766 ## gremlin-javascript/src/main/javascript/gremlin-javascript/lib/utils.js: ## @@ -112,8 +95,36 @@ exports.getUserAgentHeader = function getUserAgentHeader() {

Re: [PR] Avoiding expensive hash computation in filter ranking strategy [tinkerpop]

2024-03-04 Thread via GitHub
kenhuuu commented on PR #2504: URL: https://github.com/apache/tinkerpop/pull/2504#issuecomment-1977710799 I don't completely follow the changes being made here but they seem to be well tested so my VOTE is +1. -- This is an automated message from the Apache Git Service. To respond to the

Re: [PR] feat: `gremlin-javascript` browser support [tinkerpop]

2024-03-04 Thread via GitHub
tien commented on PR #2506: URL: https://github.com/apache/tinkerpop/pull/2506#issuecomment-1977625588 > VOTE +1 Thanks , just made a small change, updating the browser example package.json description. -- This is an automated message from the Apache Git Service. To respond to

Re: [PR] feat: `gremlin-javascript` browser support [tinkerpop]

2024-03-04 Thread via GitHub
vkagamlyk commented on PR #2506: URL: https://github.com/apache/tinkerpop/pull/2506#issuecomment-1977529989 VOTE +1 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

Re: [PR] feat: `gremlin-javascript` browser support [tinkerpop]

2024-03-04 Thread via GitHub
vkagamlyk commented on PR #2506: URL: https://github.com/apache/tinkerpop/pull/2506#issuecomment-1977275669 > > @tien I got an error `index.js:22 Uncaught SyntaxError: The requested module '/@fs/C:/_Projects/tinkerpop-tien/gremlin-javascript/src/main/javascript/gremlin-javascript/index.js'

Re: [PR] feat: `gremlin-javascript` browser support [tinkerpop]

2024-03-04 Thread via GitHub
tien commented on PR #2506: URL: https://github.com/apache/tinkerpop/pull/2506#issuecomment-1977244785 > @tien I got an error `index.js:22 Uncaught SyntaxError: The requested module '/@fs/C:/_Projects/tinkerpop-tien/gremlin-javascript/src/main/javascript/gremlin-javascript/index.js' does

(tinkerpop) 03/03: Merge branch '3.7-dev'

2024-03-04 Thread spmallette
This is an automated email from the ASF dual-hosted git repository. spmallette pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/tinkerpop.git commit d52b0b1217ae1425b327e2841b3bb5928dc5c95a Merge: 03e9f24f06 06af2ec6d5 Author: Stephen Mallette AuthorDate: Mon

(tinkerpop) branch 3.6-dev updated (1efe40b288 -> beb1a5f35d)

2024-03-04 Thread spmallette
This is an automated email from the ASF dual-hosted git repository. spmallette pushed a change to branch 3.6-dev in repository https://gitbox.apache.org/repos/asf/tinkerpop.git from 1efe40b288 TINKERPOP-3054 Fix requestId Deserialization in `gremlin-python` (#2494) add beb1a5f35d

(tinkerpop) branch master updated (03e9f24f06 -> d52b0b1217)

2024-03-04 Thread spmallette
This is an automated email from the ASF dual-hosted git repository. spmallette pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/tinkerpop.git from 03e9f24f06 Merge branch '3.7-dev' new beb1a5f35d Improve performance of PathRetractionStrategy new

(tinkerpop) 02/03: Merge branch '3.6-dev' into 3.7-dev

2024-03-04 Thread spmallette
This is an automated email from the ASF dual-hosted git repository. spmallette pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/tinkerpop.git commit 06af2ec6d58d5727ebc9c70f85bc4a199273d9ce Merge: cc9b3cf02c beb1a5f35d Author: Stephen Mallette AuthorDate: Mon

(tinkerpop) branch 3.7-dev updated (cc9b3cf02c -> 06af2ec6d5)

2024-03-04 Thread spmallette
This is an automated email from the ASF dual-hosted git repository. spmallette pushed a change to branch 3.7-dev in repository https://gitbox.apache.org/repos/asf/tinkerpop.git from cc9b3cf02c Merge branch '3.6-dev' into 3.7-dev add beb1a5f35d Improve performance of

(tinkerpop) 01/03: Improve performance of PathRetractionStrategy

2024-03-04 Thread spmallette
This is an automated email from the ASF dual-hosted git repository. spmallette pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/tinkerpop.git commit beb1a5f35d27e0e76d3a75f2cceb6546b503b297 Author: Stephen Mallette AuthorDate: Fri Mar 1 09:25:09 2024 -0500

Re: [PR] feat: `gremlin-javascript` browser support [tinkerpop]

2024-03-04 Thread via GitHub
vkagamlyk commented on PR #2506: URL: https://github.com/apache/tinkerpop/pull/2506#issuecomment-1977112339 @tien I got an error `index.js:22 Uncaught SyntaxError: The requested module '/@fs/C:/_Projects/tinkerpop-tien/gremlin-javascript/src/main/javascript/gremlin-javascript/index.js'

(tinkerpop) branch dependabot/maven/3.6-dev/ch.qos.logback-logback-classic-1.5.1 deleted (was 5303556b48)

2024-03-04 Thread github-bot
This is an automated email from the ASF dual-hosted git repository. github-bot pushed a change to branch dependabot/maven/3.6-dev/ch.qos.logback-logback-classic-1.5.1 in repository https://gitbox.apache.org/repos/asf/tinkerpop.git was 5303556b48 Bump ch.qos.logback:logback-classic from

Re: [PR] Bump ch.qos.logback:logback-classic from 1.2.11 to 1.5.1 [tinkerpop]

2024-03-04 Thread via GitHub
dependabot[bot] closed pull request #2508: Bump ch.qos.logback:logback-classic from 1.2.11 to 1.5.1 URL: https://github.com/apache/tinkerpop/pull/2508 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

Re: [PR] Bump ch.qos.logback:logback-classic from 1.2.11 to 1.5.1 [tinkerpop]

2024-03-04 Thread via GitHub
dependabot[bot] commented on PR #2508: URL: https://github.com/apache/tinkerpop/pull/2508#issuecomment-1976773833 Superseded by #2512. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

(tinkerpop) branch dependabot/maven/3.6-dev/ch.qos.logback-logback-classic-1.5.3 created (now c474cd7301)

2024-03-04 Thread github-bot
This is an automated email from the ASF dual-hosted git repository. github-bot pushed a change to branch dependabot/maven/3.6-dev/ch.qos.logback-logback-classic-1.5.3 in repository https://gitbox.apache.org/repos/asf/tinkerpop.git at c474cd7301 Bump ch.qos.logback:logback-classic from

[PR] Bump ch.qos.logback:logback-classic from 1.2.11 to 1.5.3 [tinkerpop]

2024-03-04 Thread via GitHub
dependabot[bot] opened a new pull request, #2512: URL: https://github.com/apache/tinkerpop/pull/2512 Bumps [ch.qos.logback:logback-classic](https://github.com/qos-ch/logback) from 1.2.11 to 1.5.3. Commits