[GitHub] [tinkerpop] mikepersonick commented on a diff in pull request #1929: Modifications to mergeV/E semantics

mikepersonick commented on code in PR #1929: URL: https://github.com/apache/tinkerpop/pull/1929#discussion_r1064010332 ## gremlin-core/src/main/java/org/apache/tinkerpop/gremlin/process/traversal/step/map/MergeStep.java: ## @@ -0,0 +1,299 @@ +/* + * Licensed to the Apache Softwa

[GitHub] [tinkerpop] mikepersonick commented on a diff in pull request #1929: Modifications to mergeV/E semantics

mikepersonick commented on code in PR #1929: URL: https://github.com/apache/tinkerpop/pull/1929#discussion_r1064010260 ## gremlin-core/src/main/java/org/apache/tinkerpop/gremlin/process/traversal/step/map/MergeStep.java: ## @@ -0,0 +1,299 @@ +/* + * Licensed to the Apache Softwa

[GitHub] [tinkerpop] mikepersonick commented on a diff in pull request #1929: Modifications to mergeV/E semantics

mikepersonick commented on code in PR #1929: URL: https://github.com/apache/tinkerpop/pull/1929#discussion_r1063542207 ## gremlin-test/src/main/java/org/apache/tinkerpop/gremlin/features/StepDefinition.java: ## @@ -290,6 +298,15 @@ public void iteratedToList() { }

[GitHub] [tinkerpop] mikepersonick commented on a diff in pull request #1929: Modifications to mergeV/E semantics

mikepersonick commented on code in PR #1929: URL: https://github.com/apache/tinkerpop/pull/1929#discussion_r1063541978 ## gremlin-dotnet/test/Gremlin.Net.IntegrationTest/Gherkin/CommonSteps.cs: ## @@ -131,9 +132,16 @@ public void TranslateTraversal(string traversalText)

[GitHub] [tinkerpop] mikepersonick commented on a diff in pull request #1929: Modifications to mergeV/E semantics

mikepersonick commented on code in PR #1929: URL: https://github.com/apache/tinkerpop/pull/1929#discussion_r1063539064 ## gremlin-dotnet/test/Gremlin.Net.IntegrationTest/Gherkin/CommonSteps.cs: ## @@ -131,9 +132,16 @@ public void TranslateTraversal(string traversalText)

[GitHub] [tinkerpop] mikepersonick commented on a diff in pull request #1929: Modifications to mergeV/E semantics

mikepersonick commented on code in PR #1929: URL: https://github.com/apache/tinkerpop/pull/1929#discussion_r1063499610 ## gremlin-core/src/main/java/org/apache/tinkerpop/gremlin/process/traversal/step/map/MergeStep.java: ## @@ -0,0 +1,299 @@ +/* + * Licensed to the Apache Softwa

[GitHub] [tinkerpop] mikepersonick commented on a diff in pull request #1929: Modifications to mergeV/E semantics

mikepersonick commented on code in PR #1929: URL: https://github.com/apache/tinkerpop/pull/1929#discussion_r1063494138 ## tinkergraph-gremlin/src/test/java/org/apache/tinkerpop/gremlin/tinkergraph/TinkerGraphFeatureTest.java: ## @@ -33,7 +33,11 @@ tags = "not @RemoteOnl

[GitHub] [tinkerpop] mikepersonick commented on a diff in pull request #1929: Modifications to mergeV/E semantics

mikepersonick commented on code in PR #1929: URL: https://github.com/apache/tinkerpop/pull/1929#discussion_r1063493920 ## tinkergraph-gremlin/src/test/java/org/apache/tinkerpop/gremlin/tinkergraph/TinkerGraphFeatureTest.java: ## @@ -33,7 +33,11 @@ tags = "not @RemoteOnl

[GitHub] [tinkerpop] mikepersonick commented on a diff in pull request #1929: Modifications to mergeV/E semantics

mikepersonick commented on code in PR #1929: URL: https://github.com/apache/tinkerpop/pull/1929#discussion_r1063492695 ## gremlin-test/src/main/java/org/apache/tinkerpop/gremlin/features/StepDefinition.java: ## @@ -290,6 +298,15 @@ public void iteratedToList() { }

[GitHub] [tinkerpop] mikepersonick commented on a diff in pull request #1929: Modifications to mergeV/E semantics

mikepersonick commented on code in PR #1929: URL: https://github.com/apache/tinkerpop/pull/1929#discussion_r1063492048 ## gremlin-dotnet/test/Gremlin.Net.IntegrationTest/Gherkin/CommonSteps.cs: ## @@ -131,9 +132,16 @@ public void TranslateTraversal(string traversalText)

[GitHub] [tinkerpop] mikepersonick commented on a diff in pull request #1929: Modifications to mergeV/E semantics

mikepersonick commented on code in PR #1929: URL: https://github.com/apache/tinkerpop/pull/1929#discussion_r1063488908 ## gremlin-core/src/main/java/org/apache/tinkerpop/gremlin/util/iterator/IteratorUtils.java: ## @@ -260,10 +301,40 @@ public static Iterator cast(final Iterato

[GitHub] [tinkerpop] mikepersonick commented on a diff in pull request #1929: Modifications to mergeV/E semantics

mikepersonick commented on code in PR #1929: URL: https://github.com/apache/tinkerpop/pull/1929#discussion_r1063488308 ## gremlin-core/src/main/java/org/apache/tinkerpop/gremlin/util/iterator/IteratorUtils.java: ## @@ -163,6 +192,7 @@ public static Map collectMap(final Iterato

[GitHub] [tinkerpop] mikepersonick commented on a diff in pull request #1929: Modifications to mergeV/E semantics

mikepersonick commented on code in PR #1929: URL: https://github.com/apache/tinkerpop/pull/1929#discussion_r1063486411 ## gremlin-core/src/main/java/org/apache/tinkerpop/gremlin/util/iterator/IteratorUtils.java: ## @@ -116,39 +120,64 @@ public S next() { thr