spmallette merged PR #2618:
URL: https://github.com/apache/tinkerpop/pull/2618
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@tinke
upadhyay-prashant commented on PR #2618:
URL: https://github.com/apache/tinkerpop/pull/2618#issuecomment-2138585668
> This PR should target the 3.6-dev branch. That way it will go into the
next 3.6.x/3.7.x release. If you target it to the master branch (like it is
now), the change will only
codecov-commenter commented on PR #2618:
URL: https://github.com/apache/tinkerpop/pull/2618#issuecomment-2138504760
##
[Codecov](https://app.codecov.io/gh/apache/tinkerpop/pull/2618?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comme
kenhuuu commented on PR #2618:
URL: https://github.com/apache/tinkerpop/pull/2618#issuecomment-2133809461
This PR should target the 3.6-dev branch. That way it will go into the next
3.6.x/3.7.x release. If you target it to the master branch (like it is now),
the change will only go into 4.0
upadhyay-prashant commented on PR #2618:
URL: https://github.com/apache/tinkerpop/pull/2618#issuecomment-2130377858
Previous pull request for this same fix.
https://github.com/apache/tinkerpop/pull/2614
The previous pull request got closed because the branch got deleted.
--
This
upadhyay-prashant commented on PR #2614:
URL: https://github.com/apache/tinkerpop/pull/2614#issuecomment-2130376703
@kenhuuu can you please take a look. I raised another pull request with the
fix and your nits addressed.
https://github.com/apache/tinkerpop/pull/2618
--
This is an auto
upadhyay-prashant opened a new pull request, #2618:
URL: https://github.com/apache/tinkerpop/pull/2618
CAUSE:
In some cases when credentials expire, or servers encounters a
blip and closes all connections. The driver gets close message on all
connections. While processing those c
upadhyay-prashant closed pull request #2614: Fixing connection cleanup in case
of mass connection breaking.
URL: https://github.com/apache/tinkerpop/pull/2614
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above
upadhyay-prashant closed pull request #2600: Fixing connection cleanup in case
of mass connection breaking.
URL: https://github.com/apache/tinkerpop/pull/2600
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above
kenhuuu commented on PR #2614:
URL: https://github.com/apache/tinkerpop/pull/2614#issuecomment-2123808155
VOTE +1 pending resolution of some nits.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
kenhuuu commented on code in PR #2614:
URL: https://github.com/apache/tinkerpop/pull/2614#discussion_r1609211829
##
gremlin-driver/src/main/java/org/apache/tinkerpop/gremlin/driver/ConnectionPool.java:
##
@@ -663,18 +664,19 @@ public String getPoolInfo(final Connection
connecti
kenhuuu commented on code in PR #2614:
URL: https://github.com/apache/tinkerpop/pull/2614#discussion_r1609211829
##
gremlin-driver/src/main/java/org/apache/tinkerpop/gremlin/driver/ConnectionPool.java:
##
@@ -663,18 +664,19 @@ public String getPoolInfo(final Connection
connecti
kenhuuu commented on PR #2614:
URL: https://github.com/apache/tinkerpop/pull/2614#issuecomment-2123803916
Could you rebase and retarget this PR to point to 3.6-dev? This change most
likely applies to version 3.6.x and above rather than 4.0.x (master).
--
This is an automated message from
upadhyay-prashant opened a new pull request, #2614:
URL: https://github.com/apache/tinkerpop/pull/2614
CAUSE:
In some cases when credentials expire, or servers encounters a
blip and closes all connections. The driver gets close message on all
connections. While processing those c
spmallette commented on code in PR #2600:
URL: https://github.com/apache/tinkerpop/pull/2600#discussion_r1601811702
##
gremlin-driver/src/main/java/org/apache/tinkerpop/gremlin/driver/ConnectionPool.java:
##
@@ -665,13 +665,22 @@ private void appendConnections(final StringBuilde
spmallette commented on code in PR #2600:
URL: https://github.com/apache/tinkerpop/pull/2600#discussion_r1601811702
##
gremlin-driver/src/main/java/org/apache/tinkerpop/gremlin/driver/ConnectionPool.java:
##
@@ -665,13 +665,22 @@ private void appendConnections(final StringBuilde
codecov-commenter commented on PR #2600:
URL: https://github.com/apache/tinkerpop/pull/2600#issuecomment-2105503241
##
[Codecov](https://app.codecov.io/gh/apache/tinkerpop/pull/2600?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comme
upadhyay-prashant opened a new pull request, #2600:
URL: https://github.com/apache/tinkerpop/pull/2600
CAUSE:
In some cases when credentials expire, or servers encounters a
blip and closes all connections. The driver gets close message on all
connections. While processing those c
18 matches
Mail list logo
