Re: [PR] Bytecode removal from Java GLV [tinkerpop]

2024-06-13 Thread via GitHub
vkagamlyk commented on PR #2648: URL: https://github.com/apache/tinkerpop/pull/2648#issuecomment-2166598483 VOTE +1 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsub

Re: [PR] Bytecode removal from Java GLV [tinkerpop]

2024-06-13 Thread via GitHub
vkagamlyk merged PR #2648: URL: https://github.com/apache/tinkerpop/pull/2648 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@tinker

Re: [PR] Bytecode removal from Java GLV [tinkerpop]

2024-06-13 Thread via GitHub
Cole-Greer commented on PR #2648: URL: https://github.com/apache/tinkerpop/pull/2648#issuecomment-2166654918 VOTE +1 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsu

Re: [PR] Bytecode removal from Java GLV [tinkerpop]

2024-06-13 Thread via GitHub
vkagamlyk commented on code in PR #2648: URL: https://github.com/apache/tinkerpop/pull/2648#discussion_r1638800470 ## gremlin-core/src/main/java/org/apache/tinkerpop/gremlin/process/traversal/util/BytecodeHelper.java: ## @@ -177,7 +175,7 @@ import java.util.stream.Stream; /*

Re: [PR] Bytecode removal from Java GLV [tinkerpop]

2024-06-13 Thread via GitHub
Cole-Greer commented on code in PR #2648: URL: https://github.com/apache/tinkerpop/pull/2648#discussion_r1638798422 ## gremlin-core/src/main/java/org/apache/tinkerpop/gremlin/process/traversal/util/BytecodeHelper.java: ## @@ -177,7 +175,7 @@ import java.util.stream.Stream; /

Re: [PR] Bytecode removal from Java GLV [tinkerpop]

2024-06-13 Thread via GitHub
kenhuuu commented on PR #2648: URL: https://github.com/apache/tinkerpop/pull/2648#issuecomment-2166620519 VOTE +1 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubsc

Re: [PR] Bytecode removal from Java GLV [tinkerpop]

2024-06-13 Thread via GitHub
xiazcy commented on PR #2648: URL: https://github.com/apache/tinkerpop/pull/2648#issuecomment-2166464087 VOTE +1 Thanks for putting together the work! Looking forward to the rest of the changes. -- This is an automated message from the Apache Git Service. To respond to the message, pl

Re: [PR] Bytecode removal from Java GLV [tinkerpop]

2024-06-11 Thread via GitHub
vkagamlyk commented on code in PR #2648: URL: https://github.com/apache/tinkerpop/pull/2648#discussion_r1635554947 ## gremlin-core/src/main/java/org/apache/tinkerpop/gremlin/jsr223/GremlinLangScriptEngine.java: ## @@ -79,7 +79,7 @@ public GremlinScriptEngineFactory getFactory()

Re: [PR] Bytecode removal from Java GLV [tinkerpop]

2024-06-11 Thread via GitHub
xiazcy commented on code in PR #2648: URL: https://github.com/apache/tinkerpop/pull/2648#discussion_r1635171704 ## gremlin-core/src/main/java/org/apache/tinkerpop/gremlin/jsr223/GremlinLangScriptEngine.java: ## @@ -79,7 +79,7 @@ public GremlinScriptEngineFactory getFactory() {