Re: [PR] Fixflaky [tinkerpop]

2024-03-15 Thread via GitHub
saivivek116 commented on PR #2523: URL: https://github.com/apache/tinkerpop/pull/2523#issuecomment-2000313968 Thank you for your feedback. The workflow I've proposed is primarily designed to automate the steps I've taken to demonstrate that the test method is flaky. However, upon

Re: [PR] Fixflaky [tinkerpop]

2024-03-15 Thread via GitHub
Cole-Greer commented on PR #2523: URL: https://github.com/apache/tinkerpop/pull/2523#issuecomment-294972 No worries, if this is just a matter of swapping the HashSet with a LinkedHashSet, that makes perfect sense to me and I would be happy to merge that right away. If you think that

Re: [PR] Fixflaky [tinkerpop]

2024-03-14 Thread via GitHub
saivivek116 closed pull request #2523: Fixflaky URL: https://github.com/apache/tinkerpop/pull/2523 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] Fixflaky [tinkerpop]

2024-03-14 Thread via GitHub
saivivek116 commented on PR #2523: URL: https://github.com/apache/tinkerpop/pull/2523#issuecomment-1998822127 I apologize for the insufficient details in the PR. I am currently preparing a new pull request with a comprehensive description and all the necessary details to ensure clarity.

Re: [PR] Fixflaky [tinkerpop]

2024-03-14 Thread via GitHub
Cole-Greer commented on PR #2523: URL: https://github.com/apache/tinkerpop/pull/2523#issuecomment-1998628668 Hi @saivivek116, thanks for the submission. Could you give a quick description of the changes? Was the test flaky simply due to the unpredictable ordering of HashSet elements? What

[PR] Fixflaky [tinkerpop]

2024-03-14 Thread via GitHub
saivivek116 opened a new pull request, #2523: URL: https://github.com/apache/tinkerpop/pull/2523 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To