Re: [PR] Optimize `to_dict` Method in `GraphBinaryWriter` [tinkerpop]

2024-06-11 Thread via GitHub
Cole-Greer closed pull request #2607: Optimize `to_dict` Method in `GraphBinaryWriter` URL: https://github.com/apache/tinkerpop/pull/2607 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

Re: [PR] Optimize `to_dict` Method in `GraphBinaryWriter` [tinkerpop]

2024-06-11 Thread via GitHub
Cole-Greer commented on PR #2607: URL: https://github.com/apache/tinkerpop/pull/2607#issuecomment-2161194961 I am going to close this PR for now as it's become inactive and I'm not currently understanding the value of this caching strategy. If you believe this to be a mistake, please update

Re: [PR] Optimize `to_dict` Method in `GraphBinaryWriter` [tinkerpop]

2024-06-05 Thread via GitHub
Cole-Greer commented on PR #2607: URL: https://github.com/apache/tinkerpop/pull/2607#issuecomment-2150516155 Hi @vatsalcode, I wanted to follow up on if you have any performance numbers for certain cases here. I'm not sure I'm understanding the which cases may benefit from this caching, as

Re: [PR] Optimize `to_dict` Method in `GraphBinaryWriter` [tinkerpop]

2024-05-17 Thread via GitHub
Cole-Greer commented on PR #2607: URL: https://github.com/apache/tinkerpop/pull/2607#issuecomment-2118414811 Hi @vatsalcode, thanks for opening this PR. I was hoping you could share a few additional details as to which scenarios you've seen significant performance gains from this caching ap

[PR] Optimize `to_dict` Method in `GraphBinaryWriter` [tinkerpop]

2024-05-15 Thread via GitHub
vatsalcode opened a new pull request, #2607: URL: https://github.com/apache/tinkerpop/pull/2607 ### Description: This pull request optimizes the `to_dict` method in the `GraphBinaryWriter` class by introducing a cache for serializer lookups. This enhancement improves performance by r