Re: [PR] Refactor DropStep for extensibility [tinkerpop]

2024-05-22 Thread via GitHub
porunov commented on PR #2609: URL: https://github.com/apache/tinkerpop/pull/2609#issuecomment-2126052583 > I'm good with the change, but I have similar question as Stephen. Is it worth adding one extra util file just for the removed events registration? I don't quite see these method used

Re: [PR] Refactor DropStep for extensibility [tinkerpop]

2024-05-21 Thread via GitHub
xiazcy commented on PR #2609: URL: https://github.com/apache/tinkerpop/pull/2609#issuecomment-2123482424 I'm good with the change, but I have similar question as Stephen. Is it worth adding one extra util file just for the removed events registration? I don't quite see these method used els

Re: [PR] Refactor DropStep for extensibility [tinkerpop]

2024-05-17 Thread via GitHub
porunov commented on PR #2609: URL: https://github.com/apache/tinkerpop/pull/2609#issuecomment-2117794791 > do you think there should be utilities for all of these sorts of things? like [this similar sort of code](https://github.com/apache/tinkerpop/blob/master/gremlin-core/src/main/java/or

Re: [PR] Refactor DropStep for extensibility [tinkerpop]

2024-05-17 Thread via GitHub
spmallette commented on PR #2609: URL: https://github.com/apache/tinkerpop/pull/2609#issuecomment-2117782677 do you think there should be utilities for all of these sorts of things? like [this similar sort of code](https://github.com/apache/tinkerpop/blob/master/gremlin-core/src/main/java/o

Re: [PR] Refactor DropStep for extensibility [tinkerpop]

2024-05-17 Thread via GitHub
codecov-commenter commented on PR #2609: URL: https://github.com/apache/tinkerpop/pull/2609#issuecomment-2117475117 ## [Codecov](https://app.codecov.io/gh/apache/tinkerpop/pull/2609?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comme

[PR] Refactor DropStep for extensibility [tinkerpop]

2024-05-17 Thread via GitHub
porunov opened a new pull request, #2609: URL: https://github.com/apache/tinkerpop/pull/2609 This will allow reuse callback registration logic for extended classes of `DropStep` which overwrite the default `filter` implementation. Related discussion where the conclusion was made to re