xiazcy merged PR #2599:
URL: https://github.com/apache/tinkerpop/pull/2599
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@tinkerpop
xiazcy commented on PR #2599:
URL: https://github.com/apache/tinkerpop/pull/2599#issuecomment-2176537502
Thank you for the contribution! As lazy consensus has been reached, I'll be
merging this PR today if there are no further comments.
One small note, it does look like this PR is mi
FlorianHockmann commented on code in PR #2599:
URL: https://github.com/apache/tinkerpop/pull/2599#discussion_r1636336119
##
gremlin-javascript/src/main/javascript/gremlin-javascript/lib/structure/graph.ts:
##
@@ -119,6 +134,13 @@ export class VertexProperty extends
Element {
FlorianHockmann commented on code in PR #2599:
URL: https://github.com/apache/tinkerpop/pull/2599#discussion_r1636325328
##
gremlin-javascript/src/main/javascript/gremlin-javascript/lib/structure/graph.ts:
##
@@ -43,27 +42,32 @@ export class Graph {
}
}
-class Element {
+c
tien commented on code in PR #2599:
URL: https://github.com/apache/tinkerpop/pull/2599#discussion_r1636140098
##
gremlin-javascript/src/main/javascript/gremlin-javascript/lib/structure/graph.ts:
##
@@ -43,27 +42,32 @@ export class Graph {
}
}
-class Element {
+class Elemen
tien commented on code in PR #2599:
URL: https://github.com/apache/tinkerpop/pull/2599#discussion_r1636137624
##
gremlin-javascript/src/main/javascript/gremlin-javascript/lib/structure/graph.ts:
##
@@ -43,27 +42,32 @@ export class Graph {
}
}
-class Element {
+class Elemen
joshsh commented on code in PR #2599:
URL: https://github.com/apache/tinkerpop/pull/2599#discussion_r1632159790
##
gremlin-javascript/src/main/javascript/gremlin-javascript/lib/structure/graph.ts:
##
@@ -43,27 +42,32 @@ export class Graph {
}
}
-class Element {
+class Elem
joshsh commented on code in PR #2599:
URL: https://github.com/apache/tinkerpop/pull/2599#discussion_r1632159247
##
gremlin-javascript/src/main/javascript/gremlin-javascript/lib/structure/graph.ts:
##
@@ -43,27 +42,32 @@ export class Graph {
}
}
-class Element {
+class Elem
tien commented on code in PR #2599:
URL: https://github.com/apache/tinkerpop/pull/2599#discussion_r1632121152
##
gremlin-javascript/src/main/javascript/gremlin-javascript/lib/structure/graph.ts:
##
@@ -43,27 +42,32 @@ export class Graph {
}
}
-class Element {
+class Elemen
tien commented on code in PR #2599:
URL: https://github.com/apache/tinkerpop/pull/2599#discussion_r1632124863
##
gremlin-javascript/src/main/javascript/gremlin-javascript/lib/structure/io/type-serializers.ts:
##
@@ -349,9 +349,9 @@ export class EdgeSerializer extends TypeSeriali
tien commented on code in PR #2599:
URL: https://github.com/apache/tinkerpop/pull/2599#discussion_r1632124783
##
gremlin-javascript/src/main/javascript/gremlin-javascript/lib/structure/graph.ts:
##
@@ -73,20 +77,26 @@ export class Vertex =
Record> extends
}
}
-export clas
tien commented on code in PR #2599:
URL: https://github.com/apache/tinkerpop/pull/2599#discussion_r1632122117
##
gremlin-javascript/src/main/javascript/gremlin-javascript/lib/structure/graph.ts:
##
@@ -119,6 +134,13 @@ export class VertexProperty extends
Element {
}
}
+ex
tien commented on code in PR #2599:
URL: https://github.com/apache/tinkerpop/pull/2599#discussion_r1632121441
##
gremlin-javascript/src/main/javascript/gremlin-javascript/lib/structure/graph.ts:
##
@@ -73,20 +77,26 @@ export class Vertex =
Record> extends
}
}
-export clas
tien commented on code in PR #2599:
URL: https://github.com/apache/tinkerpop/pull/2599#discussion_r1632121152
##
gremlin-javascript/src/main/javascript/gremlin-javascript/lib/structure/graph.ts:
##
@@ -43,27 +42,32 @@ export class Graph {
}
}
-class Element {
+class Elemen
FlorianHockmann commented on code in PR #2599:
URL: https://github.com/apache/tinkerpop/pull/2599#discussion_r1622405611
##
gremlin-javascript/src/main/javascript/gremlin-javascript/lib/structure/graph.ts:
##
@@ -73,20 +77,26 @@ export class Vertex =
Record> extends
}
}
-
tien commented on PR #2599:
URL: https://github.com/apache/tinkerpop/pull/2599#issuecomment-2124083417
Hey @vkagamlyk, as per my comment
[here](https://github.com/apache/tinkerpop/pull/2599#issuecomment-2118831749)
I've removed all none GLV's feature parity changes, so this PR will just be
vkagamlyk commented on PR #2599:
URL: https://github.com/apache/tinkerpop/pull/2599#issuecomment-2123627926
Hi @tien,
I think this is a good direction for improvement for TinkerPop 5/6 when/if
we introduce schema, but now it is important to have similar capabilities in
all GLV's.
tien commented on PR #2599:
URL: https://github.com/apache/tinkerpop/pull/2599#issuecomment-2118834947
I'm happy to pursue this with a Jira ticket or via the dev list as mentioned
if you guys think a utility like this is valuable to be included in the core
gremlin lib.
--
This is an auto
tien commented on PR #2599:
URL: https://github.com/apache/tinkerpop/pull/2599#issuecomment-2118834748
I mainly included the utility function as a demonstration of what a strong
TypeScript definition can enable.
As for the benefit of having an utility function like that, with TypeScri
tien commented on PR #2599:
URL: https://github.com/apache/tinkerpop/pull/2599#issuecomment-2118831749
Hey guys, thanks for the feedbacks, yes that make sense. So I've reduced the
scope of the PR change to just improving the TypeScript definition for graph
structures: vertex, edge, etc
--
Cole-Greer commented on PR #2599:
URL: https://github.com/apache/tinkerpop/pull/2599#issuecomment-2118255079
Hi @tien, thanks for putting this together.
I agree with Florian that for this type of change, it is best to start with
a JIRA or dev list post before starting implementation.
FlorianHockmann commented on PR #2599:
URL: https://github.com/apache/tinkerpop/pull/2599#issuecomment-2112453850
If I'm not mistaken, then this PR does two things which are mostly separate
from each other, right? It extends the type definitions for existing types like
`Vertex`, `Edge`, and
codecov-commenter commented on PR #2599:
URL: https://github.com/apache/tinkerpop/pull/2599#issuecomment-2102504936
##
[Codecov](https://app.codecov.io/gh/apache/tinkerpop/pull/2599?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comme
tien opened a new pull request, #2599:
URL: https://github.com/apache/tinkerpop/pull/2599
- Improve structures type definitions
- Add fully type safe utility to easily parse and interact with vertex
properties:
```ts
const rawVertex = {
id: 0,
label: 'thing',
prop
24 matches
Mail list logo
