Re: git commit: TS-2415: use standard continuations to release UrlRewrite objects

2013-12-04 Thread James Peach
On Dec 4, 2013, at 2:04 PM, Leif Hedstrom wrote: > On Dec 4, 2013, at 9:11 AM, James Peach wrote: > >> On Dec 4, 2013, at 7:37 AM, Leif Hedstrom wrote: >> >>> On Dec 3, 2013, at 10:30 PM, jpe...@apache.org wrote: >>> >>> >>> Fwiw, this new_Deleter does not have the same semantics as t

Re: git commit: TS-2415: use standard continuations to release UrlRewrite objects

2013-12-04 Thread Leif Hedstrom
On Dec 4, 2013, at 9:11 AM, James Peach wrote: > On Dec 4, 2013, at 7:37 AM, Leif Hedstrom wrote: > >> On Dec 3, 2013, at 10:30 PM, jpe...@apache.org wrote: >>> >> >> >> Fwiw, this new_Deleter does not have the same semantics as the old code. The >> old code would schedule the deletion on t

Re: git commit: TS-2415: use standard continuations to release UrlRewrite objects

2013-12-04 Thread James Peach
On Dec 4, 2013, at 7:37 AM, Leif Hedstrom wrote: > On Dec 3, 2013, at 10:30 PM, jpe...@apache.org wrote: > >> Updated Branches: >> refs/heads/master 2b6a5f6bb -> 0f9305dc6 >> >> >> TS-2415: use standard continuations to release UrlRewrite objects >> >> UrlRewrite uses a custom continuation to

Re: git commit: TS-2415: use standard continuations to release UrlRewrite objects

2013-12-04 Thread Leif Hedstrom
On Dec 3, 2013, at 10:30 PM, jpe...@apache.org wrote: > Updated Branches: > refs/heads/master 2b6a5f6bb -> 0f9305dc6 > > > TS-2415: use standard continuations to release UrlRewrite objects > > UrlRewrite uses a custom continuation to release the old object > after it is no longer needed. We ca

git commit: TS-2415: use standard continuations to release UrlRewrite objects

2013-12-03 Thread jpeach
Updated Branches: refs/heads/master 2b6a5f6bb -> 0f9305dc6 TS-2415: use standard continuations to release UrlRewrite objects UrlRewrite uses a custom continuation to release the old object after it is no longer needed. We can use library code for this instead. Use new_Deleter to free the old U