changeset cba100c1c8ab in modules/stock:default
details: https://hg.tryton.org/modules/stock?cmd=changeset&node=cba100c1c8ab
description:
        Do not modify iterated list to not miss product

        issue10872
        review372361002
diffstat:

 product.py |  8 ++++----
 1 files changed, 4 insertions(+), 4 deletions(-)

diffs (25 lines):

diff -r cea1542cb019 -r cba100c1c8ab product.py
--- a/product.py        Mon Oct 18 01:22:26 2021 +0200
+++ b/product.py        Thu Oct 21 00:07:14 2021 +0200
@@ -1042,8 +1042,8 @@
         revisions = []
         costs = defaultdict(list)
         if self.model.__name__ == 'product.product':
-            products = records = list(self.records)
-            for product in products:
+            records = list(self.records)
+            for product in list(records):
                 revision = self.get_revision(Revision)
                 revision.product = product
                 revision.template = product.template
@@ -1056,8 +1056,8 @@
                     costs[cost].append(product)
                     records.remove(product)
         elif self.model.__name__ == 'product.template':
-            templates = records = list(self.records)
-            for template in templates:
+            records = list(self.records)
+            for template in list(records):
                 revision = self.get_revision(Revision)
                 revision.template = template
                 revisions.append(revision)

Reply via email to