changeset 90119d5e76d0 in sao:5.0
details: https://hg.tryton.org/sao?cmd=changeset&node=90119d5e76d0
description:
        Test if value is not null before using its keys in set_on_change

        issue11497
        review421171003
        (grafted from 3d7c4160bb3852ee7a8e1244090d6fabff5ac457)
        (grafted from df4c0d705b32c187264899c50b8857b9db261482)
diffstat:

 src/model.js |  6 +++---
 1 files changed, 3 insertions(+), 3 deletions(-)

diffs (30 lines):

diff -r d3693e200999 -r 90119d5e76d0 src/model.js
--- a/src/model.js      Fri May 20 08:23:19 2022 +0200
+++ b/src/model.js      Tue May 31 23:50:48 2022 +0200
@@ -2152,7 +2152,7 @@
                 return this._set_value(record, value, false, true);
             }
             var prm = jQuery.when();
-            if (value.add || value.update) {
+            if (value && (value.add || value.update)) {
                 var context = this.get_context(record);
                 var fields = record._values[this.name].model.fields;
                 var field_names = {};
@@ -2192,7 +2192,7 @@
                     to_remove.push(record2);
                 }
             });
-            if (value.remove) {
+            if (value && value.remove) {
                 value.remove.forEach(function(record_id) {
                     var record2 = group.get(record_id);
                     if (record2) {
@@ -2204,7 +2204,7 @@
                 group.remove(record2, false, true, false, false);
             }.bind(this));
 
-            if (value.add || value.update) {
+            if (value && (value.add || value.update)) {
                 prm = prm.then(function(fields) {
                     var promises = [];
                     group.add_fields(fields);

Reply via email to