[GitHub] [incubator-tvm] cchung100m commented on a change in pull request #5511: [AutoTVM][TOPI] AutoTVM incorrect measurement

cchung100m commented on a change in pull request #5511: URL: https://github.com/apache/incubator-tvm/pull/5511#discussion_r421266463 ## File path: topi/python/topi/mali/conv2d.py ## @@ -138,20 +138,15 @@ def _schedule_spatial_pack(cfg, s, output, conv, data_vec, kernel_vec):

[GitHub] [incubator-tvm] roastduck commented on pull request #5382: [TE] Fix MakeLoopNest for warp memory

roastduck commented on pull request #5382: URL: https://github.com/apache/incubator-tvm/pull/5382#issuecomment-625044388 @yongfeng-nv Thanks. Your improved test helps a lot. I call `tvm.driver.build_module.form_irmodule` directly, in order not to run the transformation passes in `low

[GitHub] [incubator-tvm] FrozenGene commented on a change in pull request #5492: [RUNTIME] Hexagon driver for offloading kernels to simulator

FrozenGene commented on a change in pull request #5492: URL: https://github.com/apache/incubator-tvm/pull/5492#discussion_r421245002 ## File path: src/runtime/hexagon/sim/driver/CMakeLists.txt ## @@ -0,0 +1,62 @@ +# Licensed to the Apache Software Foundation (ASF) under one +#

[GitHub] [incubator-tvm] yongfeng-nv commented on a change in pull request #5382: [TE] Fix MakeLoopNest for warp memory

yongfeng-nv commented on a change in pull request #5382: URL: https://github.com/apache/incubator-tvm/pull/5382#discussion_r421228975 ## File path: src/te/operation/op_util.cc ## @@ -164,9 +164,21 @@ MakeLoopNest(const Stage& stage, value_map[iv] = dom->min; } e

[GitHub] [incubator-tvm] roastduck commented on a change in pull request #5498: [Optimization] Warp level reduction support for CUDA

roastduck commented on a change in pull request #5498: URL: https://github.com/apache/incubator-tvm/pull/5498#discussion_r421221319 ## File path: src/tir/transforms/lower_warp_memory.cc ## @@ -265,10 +265,11 @@ class WarpAccessRewriter : protected StmtExprMutator { <

[GitHub] [incubator-tvm] ANSHUMAN87 commented on pull request #5523: [Refactor][std::string --> String] IRModule is updated with String

ANSHUMAN87 commented on pull request #5523: URL: https://github.com/apache/incubator-tvm/pull/5523#issuecomment-625007100 @tqchen : Your comment is handled now, Thanks! @jroesch : The issue is resolved, test cases are passing now! ---

[GitHub] [incubator-tvm] jroesch commented on a change in pull request #5526: [Rust] Add first stage of updating and rewriting Rust bindings.

jroesch commented on a change in pull request #5526: URL: https://github.com/apache/incubator-tvm/pull/5526#discussion_r421208546 ## File path: rust/tvm-sys/src/byte_array.rs ## @@ -0,0 +1,64 @@ +use std::os::raw::c_char; + +use crate::ffi::TVMByteArray; + +/// A struct holding

[GitHub] [incubator-tvm] spectrometerHBH commented on pull request #5483: [TIR][Printer] text format printer considering future parsing use

spectrometerHBH commented on pull request #5483: URL: https://github.com/apache/incubator-tvm/pull/5483#issuecomment-624997033 Relay's type printing requires attr and relayExpr printing, so It is not straightforward to make type printing independent. Meanwhile, relay's attir printing overl

[GitHub] [incubator-tvm] roastduck commented on a change in pull request #5382: [TE] Fix MakeLoopNest for warp memory

roastduck commented on a change in pull request #5382: URL: https://github.com/apache/incubator-tvm/pull/5382#discussion_r421205351 ## File path: src/te/operation/op_util.cc ## @@ -164,9 +164,21 @@ MakeLoopNest(const Stage& stage, value_map[iv] = dom->min; } els

[GitHub] [incubator-tvm] shoubhik opened a new pull request #5536: [WIP][Do NOT Merge]V0.6.0 quantization backport

shoubhik opened a new pull request #5536: URL: https://github.com/apache/incubator-tvm/pull/5536 Thanks for contributing to TVM! Please refer to guideline https://tvm.apache.org/docs/contribute/ for useful information and tips. After the pull request is submitted, please request code rev

[GitHub] [incubator-tvm] tqchen commented on a change in pull request #5533: Cache ObjectPtr instead of raw pointers in bound analyzer

tqchen commented on a change in pull request #5533: URL: https://github.com/apache/incubator-tvm/pull/5533#discussion_r421182713 ## File path: include/tvm/arith/analyzer.h ## @@ -107,6 +107,7 @@ class ConstIntBound : public ObjectRef { */ class ConstIntBoundAnalyzer { publ

[GitHub] [incubator-tvm] tqchen commented on a change in pull request #5533: Cache ObjectPtr instead of raw pointers in bound analyzer

tqchen commented on a change in pull request #5533: URL: https://github.com/apache/incubator-tvm/pull/5533#discussion_r421182713 ## File path: include/tvm/arith/analyzer.h ## @@ -107,6 +107,7 @@ class ConstIntBound : public ObjectRef { */ class ConstIntBoundAnalyzer { publ

[GitHub] [incubator-tvm] tqchen commented on a change in pull request #5533: Cache ObjectPtr instead of raw pointers in bound analyzer

tqchen commented on a change in pull request #5533: URL: https://github.com/apache/incubator-tvm/pull/5533#discussion_r421182429 ## File path: include/tvm/runtime/object.h ## @@ -350,6 +350,39 @@ inline RelayRefType GetRef(const ObjectType* ptr); template inline SubRef Downc

[GitHub] [incubator-tvm] kparzysz-quic opened a new pull request #5535: Changes to cpp_rpc to make it work on Android (+ Hexagon offloading)

kparzysz-quic opened a new pull request #5535: URL: https://github.com/apache/incubator-tvm/pull/5535 - Implement `getNextString` to break up `std::string` into words. `stringstream` just doesn't work on Android. - `string::find_last_of` doesn't look for the last substring, but the last

[GitHub] [incubator-tvm] kparzysz-quic commented on a change in pull request #5533: Cache ObjectPtr instead of raw pointers in bound analyzer

kparzysz-quic commented on a change in pull request #5533: URL: https://github.com/apache/incubator-tvm/pull/5533#discussion_r421140419 ## File path: include/tvm/arith/analyzer.h ## @@ -107,6 +107,7 @@ class ConstIntBound : public ObjectRef { */ class ConstIntBoundAnalyzer {

[GitHub] [incubator-tvm] kparzysz-quic commented on a change in pull request #5533: Cache ObjectPtr instead of raw pointers in bound analyzer

kparzysz-quic commented on a change in pull request #5533: URL: https://github.com/apache/incubator-tvm/pull/5533#discussion_r421138163 ## File path: include/tvm/runtime/object.h ## @@ -350,6 +350,39 @@ inline RelayRefType GetRef(const ObjectType* ptr); template inline SubRe

[GitHub] [incubator-tvm] jroesch commented on pull request #5526: [Rust] Add first stage of updating and rewriting Rust bindings.

jroesch commented on pull request #5526: URL: https://github.com/apache/incubator-tvm/pull/5526#issuecomment-624927829 Yeah @ehsanmok I'm hoping to reduce the effort for us to use/consume. My goal is effectively to get to: ``` #[external_pass] fn pass(func: relay::Function, ...

[GitHub] [incubator-tvm] kparzysz-quic commented on a change in pull request #5533: Cache ObjectPtr instead of raw pointers in bound analyzer

kparzysz-quic commented on a change in pull request #5533: URL: https://github.com/apache/incubator-tvm/pull/5533#discussion_r421127973 ## File path: include/tvm/arith/analyzer.h ## @@ -107,6 +107,7 @@ class ConstIntBound : public ObjectRef { */ class ConstIntBoundAnalyzer {

[GitHub] [incubator-tvm] tqchen commented on a change in pull request #5533: Cache ObjectPtr instead of raw pointers in bound analyzer

tqchen commented on a change in pull request #5533: URL: https://github.com/apache/incubator-tvm/pull/5533#discussion_r421129652 ## File path: include/tvm/runtime/object.h ## @@ -350,6 +350,39 @@ inline RelayRefType GetRef(const ObjectType* ptr); template inline SubRef Downc

[GitHub] [incubator-tvm] kparzysz-quic commented on a change in pull request #5533: Cache ObjectPtr instead of raw pointers in bound analyzer

kparzysz-quic commented on a change in pull request #5533: URL: https://github.com/apache/incubator-tvm/pull/5533#discussion_r421127973 ## File path: include/tvm/arith/analyzer.h ## @@ -107,6 +107,7 @@ class ConstIntBound : public ObjectRef { */ class ConstIntBoundAnalyzer {

[GitHub] [incubator-tvm] kparzysz-quic commented on a change in pull request #5533: Cache ObjectPtr instead of raw pointers in bound analyzer

kparzysz-quic commented on a change in pull request #5533: URL: https://github.com/apache/incubator-tvm/pull/5533#discussion_r421127447 ## File path: include/tvm/arith/analyzer.h ## @@ -107,6 +107,7 @@ class ConstIntBound : public ObjectRef { */ class ConstIntBoundAnalyzer {

[GitHub] [incubator-tvm] tqchen commented on a change in pull request #5533: Cache ObjectPtr instead of raw pointers in bound analyzer

tqchen commented on a change in pull request #5533: URL: https://github.com/apache/incubator-tvm/pull/5533#discussion_r421124915 ## File path: include/tvm/arith/analyzer.h ## @@ -107,6 +107,7 @@ class ConstIntBound : public ObjectRef { */ class ConstIntBoundAnalyzer { publ

[GitHub] [incubator-tvm] mbrookhart opened a new pull request #5534: fix a few bugs with shape inference and types in the ONNX importer

mbrookhart opened a new pull request #5534: URL: https://github.com/apache/incubator-tvm/pull/5534 @tmoreau89 @jroesch Thanks! This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [incubator-tvm] ehsanmok edited a comment on pull request #5526: [Rust] Add first stage of updating and rewriting Rust bindings.

ehsanmok edited a comment on pull request #5526: URL: https://github.com/apache/incubator-tvm/pull/5526#issuecomment-624800522 These changes make good sense in general. I'm glad Rust is receiving more love and attention. Wish I had time to spend on these line of work.

[GitHub] [incubator-tvm] kevinthesun commented on a change in pull request #5532: [Fix] Fix conv2d alter op for arm cpu

kevinthesun commented on a change in pull request #5532: URL: https://github.com/apache/incubator-tvm/pull/5532#discussion_r421057402 ## File path: topi/python/topi/arm_cpu/conv2d_alter_op.py ## @@ -139,6 +140,7 @@ def _alter_conv2d_layout(attrs, inputs, tinfos, out_type):

[GitHub] [incubator-tvm] kevinthesun commented on a change in pull request #5511: [AutoTVM][TOPI] AutoTVM incorrect measurement

kevinthesun commented on a change in pull request #5511: URL: https://github.com/apache/incubator-tvm/pull/5511#discussion_r421056807 ## File path: topi/python/topi/mali/conv2d.py ## @@ -138,20 +138,15 @@ def _schedule_spatial_pack(cfg, s, output, conv, data_vec, kernel_vec):

[GitHub] [incubator-tvm] kparzysz-quic opened a new pull request #5533: Cache ObjectPtr instead of raw pointers in bound analyzer

kparzysz-quic opened a new pull request #5533: URL: https://github.com/apache/incubator-tvm/pull/5533 The objects that the raw pointers point to can be deallocated and new objects can be allocated at the same address, all while these pointers are still in the cache. This can lead to unexpe

[incubator-tvm] branch master updated (79e29ab -> 900254d)

This is an automated email from the ASF dual-hosted git repository. masahi pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/incubator-tvm.git. from 79e29ab LRN only supports 4D tensors, remove it from alter_op_layout (#5520) add 900254d Fix an issue

[GitHub] [incubator-tvm] tqchen commented on a change in pull request #5523: [Refactor][std::string --> String] IRModule is updated with String

tqchen commented on a change in pull request #5523: URL: https://github.com/apache/incubator-tvm/pull/5523#discussion_r421034694 ## File path: src/printer/relay_text_printer.cc ## @@ -918,13 +918,29 @@ static const char* kSemVer = "v0.0.4"; //- Implements AsText // - rela

[GitHub] [incubator-tvm] kparzysz-quic commented on pull request #5492: [RUNTIME] Hexagon driver for offloading kernels to simulator

kparzysz-quic commented on pull request #5492: URL: https://github.com/apache/incubator-tvm/pull/5492#issuecomment-624830922 Added `sim_dev` as an external project. It will be built automatically with `USE_HEXAGON_DEVICE=sim`. --

[incubator-tvm] branch master updated (4a262ec -> 79e29ab)

This is an automated email from the ASF dual-hosted git repository. tqchen pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/incubator-tvm.git. from 4a262ec [RUNTIME] Improve PackedFunc robustness (#5517) add 79e29ab LRN only supports 4D tensors, remov

[GitHub] [incubator-tvm] tqchen commented on pull request #5517: [RUNTIME] Improve PackedFunc robustness

tqchen commented on pull request #5517: URL: https://github.com/apache/incubator-tvm/pull/5517#issuecomment-624825618 THanks @siju-samuel @zhiics This is an automated message from the Apache Git Service. To respond to the me

[incubator-tvm] branch master updated (e2bd43b -> 4a262ec)

This is an automated email from the ASF dual-hosted git repository. tqchen pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/incubator-tvm.git. from e2bd43b [RPC] Fix the multihop cpu case (#5522) add 4a262ec [RUNTIME] Improve PackedFunc robustness (#5

[GitHub] [incubator-tvm] icemelon9 opened a new pull request #5532: [Fix] Fix conv2d alter op for arm cpu

icemelon9 opened a new pull request #5532: URL: https://github.com/apache/incubator-tvm/pull/5532 https://discuss.tvm.ai/t/autotuner-fails-for-cnn-in-new-dev-branch/6099 This is an automated message from the Apache Git Servic

[GitHub] [incubator-tvm] yongfeng-nv commented on a change in pull request #5382: [TE] Fix MakeLoopNest for warp memory

yongfeng-nv commented on a change in pull request #5382: URL: https://github.com/apache/incubator-tvm/pull/5382#discussion_r421003668 ## File path: src/te/operation/op_util.cc ## @@ -164,9 +164,21 @@ MakeLoopNest(const Stage& stage, value_map[iv] = dom->min; } e

[GitHub] [incubator-tvm] maheshambule edited a comment on pull request #5528: POC refactor tflite frontend

maheshambule edited a comment on pull request #5528: URL: https://github.com/apache/incubator-tvm/pull/5528#issuecomment-624809315 Thanks for the response. > Few more points to consider: Let me clarify, the points which I mentioned are not for in or against both the approaches

[GitHub] [incubator-tvm] maheshambule commented on pull request #5528: POC refactor tflite frontend

maheshambule commented on pull request #5528: URL: https://github.com/apache/incubator-tvm/pull/5528#issuecomment-624809315 Thanks for the response. > Few more points to consider: Let me clarify, the points which I mentioned are not for in or against both the approaches (table

[GitHub] [incubator-tvm] ehsanmok commented on a change in pull request #5527: [Rust] Second stage of Rust Refactor

ehsanmok commented on a change in pull request #5527: URL: https://github.com/apache/incubator-tvm/pull/5527#discussion_r420987364 ## File path: rust/tvm-rt/README.md ## @@ -0,0 +1,235 @@ + + + + + + + + + + + + + + + + + +# TVM Runtime Frontend Support + +This crate provides a

[GitHub] [incubator-tvm] ehsanmok commented on pull request #5526: [Rust] Add first stage of updating and rewriting Rust bindings.

ehsanmok commented on pull request #5526: URL: https://github.com/apache/incubator-tvm/pull/5526#issuecomment-624800522 These changes make very good sense. I'm glad Rust is receiving more love and attention. This is an autom

[GitHub] [incubator-tvm] u99127 commented on a change in pull request #5508: [TFLITE]GATHER_ND

u99127 commented on a change in pull request #5508: URL: https://github.com/apache/incubator-tvm/pull/5508#discussion_r420955608 ## File path: tests/python/frontend/tflite/test_forward.py ## @@ -343,6 +343,36 @@ def test_forward_gather(): _test_gather((1, 3, 3), [20],

[GitHub] [incubator-tvm] tqchen commented on pull request #4312: [TOPI][Relay][OP] Dynamic NMS and strided_slice

tqchen commented on pull request #4312: URL: https://github.com/apache/incubator-tvm/pull/4312#issuecomment-624783943 ping @kevinthesun @icemelon9 @yongwww please followup This is an automated message from the Apache Git Ser

[GitHub] [incubator-tvm] u99127 commented on pull request #5528: POC refactor tflite frontend

u99127 commented on pull request #5528: URL: https://github.com/apache/incubator-tvm/pull/5528#issuecomment-624774462 Thanks for the discussion and prompting this. I agree with you entirely with the motivation behind this that we should look to simplify the frontend, the amount of copy pa

[GitHub] [incubator-tvm] jroesch commented on a change in pull request #5526: [Rust] Add first stage of updating and rewriting Rust bindings.

jroesch commented on a change in pull request #5526: URL: https://github.com/apache/incubator-tvm/pull/5526#discussion_r420950375 ## File path: rust/tvm-sys/src/context.rs ## @@ -0,0 +1,293 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contri

[GitHub] [incubator-tvm] jroesch commented on a change in pull request #5526: [Rust] Add first stage of updating and rewriting Rust bindings.

jroesch commented on a change in pull request #5526: URL: https://github.com/apache/incubator-tvm/pull/5526#discussion_r420949949 ## File path: rust/tvm-sys/src/lib.rs ## @@ -0,0 +1,54 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor

[GitHub] [incubator-tvm] jroesch commented on pull request #5526: [Rust] Add first stage of updating and rewriting Rust bindings.

jroesch commented on pull request #5526: URL: https://github.com/apache/incubator-tvm/pull/5526#issuecomment-624770902 @nhynes thanks for the review. I opened this at like 2:30am last night before going to bed. Will provide some more context. The goal of my refactor to is to turn on

[GitHub] [incubator-tvm] jroesch commented on a change in pull request #5526: [Rust] Add first stage of updating and rewriting Rust bindings.

jroesch commented on a change in pull request #5526: URL: https://github.com/apache/incubator-tvm/pull/5526#discussion_r420937306 ## File path: rust/tvm-sys/src/value.rs ## @@ -0,0 +1,95 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contribut

[GitHub] [incubator-tvm] jroesch commented on a change in pull request #5526: [Rust] Add first stage of updating and rewriting Rust bindings.

jroesch commented on a change in pull request #5526: URL: https://github.com/apache/incubator-tvm/pull/5526#discussion_r420936324 ## File path: rust/tvm-sys/src/packed_func.rs ## @@ -0,0 +1,380 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more co

[GitHub] [incubator-tvm] jroesch commented on a change in pull request #5526: [Rust] Add first stage of updating and rewriting Rust bindings.

jroesch commented on a change in pull request #5526: URL: https://github.com/apache/incubator-tvm/pull/5526#discussion_r420936324 ## File path: rust/tvm-sys/src/packed_func.rs ## @@ -0,0 +1,380 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more co

[GitHub] [incubator-tvm] comaniac commented on a change in pull request #5422: [RELAY][Convert Layout] Specify additional layouts in convert layout pass

comaniac commented on a change in pull request #5422: URL: https://github.com/apache/incubator-tvm/pull/5422#discussion_r420935901 ## File path: python/tvm/relay/op/nn/_nn.py ## @@ -141,20 +142,29 @@ def convert_conv2d(attrs, inputs, tinfos, desired_layout): from tvm impor

[GitHub] [incubator-tvm] jroesch commented on a change in pull request #5526: [Rust] Add first stage of updating and rewriting Rust bindings.

jroesch commented on a change in pull request #5526: URL: https://github.com/apache/incubator-tvm/pull/5526#discussion_r420935736 ## File path: rust/tvm-sys/src/datatype.rs ## @@ -0,0 +1,179 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contr

[GitHub] [incubator-tvm] jroesch commented on a change in pull request #5526: [Rust] Add first stage of updating and rewriting Rust bindings.

jroesch commented on a change in pull request #5526: URL: https://github.com/apache/incubator-tvm/pull/5526#discussion_r420935232 ## File path: rust/tvm-sys/src/datatype.rs ## @@ -0,0 +1,179 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contr

[GitHub] [incubator-tvm] jroesch commented on a change in pull request #5526: [Rust] Add first stage of updating and rewriting Rust bindings.

jroesch commented on a change in pull request #5526: URL: https://github.com/apache/incubator-tvm/pull/5526#discussion_r420934977 ## File path: rust/tvm-sys/src/datatype.rs ## @@ -0,0 +1,179 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contr

[GitHub] [incubator-tvm] mbaret commented on a change in pull request #5479: [Relay-TFLite] FP32 and Quantized Object Detection Model

mbaret commented on a change in pull request #5479: URL: https://github.com/apache/incubator-tvm/pull/5479#discussion_r420935075 ## File path: python/tvm/relay/frontend/tflite.py ## @@ -320,6 +321,45 @@ def dequantize(self, expr, tensor):

[GitHub] [incubator-tvm] nhynes commented on a change in pull request #5526: [Rust] Add first stage of updating and rewriting Rust bindings.

nhynes commented on a change in pull request #5526: URL: https://github.com/apache/incubator-tvm/pull/5526#discussion_r420911319 ## File path: rust/tvm-sys/src/array.rs ## @@ -0,0 +1,62 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributo

[GitHub] [incubator-tvm] maheshambule commented on pull request #5474: [Frontend][TFLite] ADD_N operator

maheshambule commented on pull request #5474: URL: https://github.com/apache/incubator-tvm/pull/5474#issuecomment-624749216 @tqchen Could you please help in merging this PR? This is an automated message from the Apache Git Se

[GitHub] [incubator-tvm] tmoreau89 commented on pull request #5520: LRN only supports 4D tensors, remove it from alter_op_layout

tmoreau89 commented on pull request #5520: URL: https://github.com/apache/incubator-tvm/pull/5520#issuecomment-624747974 @merrymercy if you can review this change by the end of the day thanks! This is an automated message fro

[GitHub] [incubator-tvm] mikeseven opened a new issue #5531: [BUG] topi/python/x86/conv2d_avx_* is incomplete, won't run

mikeseven opened a new issue #5531: URL: https://github.com/apache/incubator-tvm/issues/5531 In conv2d_avx_1x1.py and conv2d_avx_common.py, some methods are missing declaration of oc_bn. When code is called, python crashes. I believe oc_bn should be at least 1 and that seems to work

[GitHub] [incubator-tvm] mikeseven opened a new issue #5529: [BUG] ConvertLayout pass doesn't handle ops attributes

mikeseven opened a new issue #5529: URL: https://github.com/apache/incubator-tvm/issues/5529 While converting layout from TensorFlow, from NHWC to NCHW, I noticed LRN axis was not converted from using axis=3 to axis=1. Looking at the code, I don't find where ConvertLayout pass would

[GitHub] [incubator-tvm] mbrookhart opened a new pull request #5530: Fix an issue with ONNX Upsample

mbrookhart opened a new pull request #5530: URL: https://github.com/apache/incubator-tvm/pull/5530 Update one test to hit the broken usecase. @masahi another small onnx bug, if you don't mind. Thank you! This is an aut

[GitHub] [incubator-tvm] cchung100m commented on pull request #5501: [TIR][REFACTOR] std::string -> String Migration in TIR nodes

cchung100m commented on pull request #5501: URL: https://github.com/apache/incubator-tvm/pull/5501#issuecomment-624733116 Hi @tqchen @zhiics Thanks for your kind feedback and I will keep work on it. This is an automat

[GitHub] [incubator-tvm] maheshambule commented on pull request #5528: POC refactor tflite frontend

maheshambule commented on pull request #5528: URL: https://github.com/apache/incubator-tvm/pull/5528#issuecomment-624726976 I thought of adding all the op attributes in table/map but decorator seemed to be more pythonic. Few more points to consider: 1. Sometimes equality checks c

[GitHub] [incubator-tvm] zhiics commented on issue #5490: [REFACTOR] std::string -> String Migration in IR nodes

zhiics commented on issue #5490: URL: https://github.com/apache/incubator-tvm/issues/5490#issuecomment-624723623 @ANSHUMAN87 Welcome to contribute. I've busy with other things recently. Thanks. This is an automated message f

[GitHub] [incubator-tvm] tqchen commented on pull request #5483: [TIR][Printer] text format printer considering future parsing use

tqchen commented on pull request #5483: URL: https://github.com/apache/incubator-tvm/pull/5483#issuecomment-624696569 Going to merge it in two days This is an automated message from the Apache Git Service. To respond to the m

[GitHub] [incubator-tvm] tqchen commented on pull request #5485: [TOPI][Winograd] Optimization of Conv2d Winograd algorithm on Tensor …

tqchen commented on pull request #5485: URL: https://github.com/apache/incubator-tvm/pull/5485#issuecomment-624695979 cc @FrozenGene This is an automated message from the Apache Git Service. To respond to the message, please

[incubator-tvm] branch master updated (7eb2451 -> e2bd43b)

This is an automated email from the ASF dual-hosted git repository. tqchen pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/incubator-tvm.git. from 7eb2451 fix prelu importer and add tests: (#5521) add e2bd43b [RPC] Fix the multihop cpu case (#5522)

[GitHub] [incubator-tvm] tqchen commented on a change in pull request #5517: [RUNTIME] Improve PackedFunc robustness

tqchen commented on a change in pull request #5517: URL: https://github.com/apache/incubator-tvm/pull/5517#discussion_r420852646 ## File path: include/tvm/runtime/packed_func.h ## @@ -45,6 +45,15 @@ #define TVM_RUNTIME_HEADER_ONLY 0 #endif +// Always inline macro only use i

[GitHub] [incubator-tvm] tqchen edited a comment on pull request #5526: [Rust] Add first stage of updating and rewriting Rust bindings.

tqchen edited a comment on pull request #5526: URL: https://github.com/apache/incubator-tvm/pull/5526#issuecomment-624695329 cc @nhynes @kazum This is an automated message from the Apache Git Service. To respond to the messa

[GitHub] [incubator-tvm] tqchen commented on pull request #5526: [Rust] Add first stage of updating and rewriting Rust bindings.

tqchen commented on pull request #5526: URL: https://github.com/apache/incubator-tvm/pull/5526#issuecomment-624695329 cc @nhynes This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [incubator-tvm] tqchen edited a comment on issue #5490: [REFACTOR] std::string -> String Migration in IR nodes

tqchen edited a comment on issue #5490: URL: https://github.com/apache/incubator-tvm/issues/5490#issuecomment-624408382 ## IMPORTANT NOTE as shown in the intiial example, we will need to update the converter(via `_update_from_std_str`) to keep backward compatibility of the nodes.

[GitHub] [incubator-tvm] u99127 commented on pull request #5528: POC refactor tflite frontend

u99127 commented on pull request #5528: URL: https://github.com/apache/incubator-tvm/pull/5528#issuecomment-624679105 > > > > Have you seen #5519 ? > > Ramana > > Just now. I replied there. Yours goes further than #5519 and I'll think through it a bit more. My init

[GitHub] [incubator-tvm] maheshambule commented on pull request #5528: POC refactor tflite frontend

maheshambule commented on pull request #5528: URL: https://github.com/apache/incubator-tvm/pull/5528#issuecomment-624668670 > Have you seen #5519 ? > > Ramana Just now. I replied there. This is an automated mess

[GitHub] [incubator-tvm] maheshambule commented on pull request #5519: [RFC] Make tflite frontend more data driven / improve errors.

maheshambule commented on pull request #5519: URL: https://github.com/apache/incubator-tvm/pull/5519#issuecomment-624668257 @u99127, I am also working on refactoring TFLite frontend. This is a sample implementation https://github.com/apache/incubator-tvm/pull/5528. I would love to hear you

[GitHub] [incubator-tvm] u99127 commented on pull request #5528: POC refactor tflite frontend

u99127 commented on pull request #5528: URL: https://github.com/apache/incubator-tvm/pull/5528#issuecomment-624665048 Have you seen #5519 ? Ramana This is an automated message from the Apache Git Service. To respo

[GitHub] [incubator-tvm] maheshambule commented on pull request #5528: POC refactor tflite frontend

maheshambule commented on pull request #5528: URL: https://github.com/apache/incubator-tvm/pull/5528#issuecomment-624659434 @FrozenGene, @anijain2305, @siju-samuel, @u99127, @mbaret Could you please review and let me know your thoughts?

[GitHub] [incubator-tvm] maheshambule opened a new pull request #5528: POC refactor tflite frontend

maheshambule opened a new pull request #5528: URL: https://github.com/apache/incubator-tvm/pull/5528 Thanks for contributing to TVM! Please refer to guideline https://tvm.apache.org/docs/contribute/ for useful information and tips. After the pull request is submitted, please request code

[GitHub] [incubator-tvm] siju-samuel commented on a change in pull request #5517: [RUNTIME] Improve PackedFunc robustness

siju-samuel commented on a change in pull request #5517: URL: https://github.com/apache/incubator-tvm/pull/5517#discussion_r420731146 ## File path: include/tvm/runtime/packed_func.h ## @@ -1280,30 +1303,30 @@ struct unpack_call_by_signature { template struct unpack_call_by_si

[GitHub] [incubator-tvm] Robeast commented on issue #5060: [uTVM][Runtime] Deprecate uTVM Standalone Runtime

Robeast commented on issue #5060: URL: https://github.com/apache/incubator-tvm/issues/5060#issuecomment-624592461 Hi @liangfu is there any update on your current implementation efforts? We are really looking forward to it!!

[GitHub] [incubator-tvm] roastduck commented on pull request #3865: Add lift_if_then_else pass

roastduck commented on pull request #3865: URL: https://github.com/apache/incubator-tvm/pull/3865#issuecomment-624575446 Hi everyone, I'm wondering if we can merge this pass into the default lowering procedure? Hoisting `if` statements can be very helpful for sparse applications, since `Lo

[GitHub] [incubator-tvm] lhutton1 commented on a change in pull request #5422: [RELAY][Convert Layout] Specify additional layouts in convert layout pass

lhutton1 commented on a change in pull request #5422: URL: https://github.com/apache/incubator-tvm/pull/5422#discussion_r420688732 ## File path: python/tvm/relay/op/nn/_nn.py ## @@ -141,20 +142,29 @@ def convert_conv2d(attrs, inputs, tinfos, desired_layout): from tvm impor

[GitHub] [incubator-tvm] jroesch opened a new pull request #5527: [Rust] Second stage of Rust Refactor

jroesch opened a new pull request #5527: URL: https://github.com/apache/incubator-tvm/pull/5527 See #5526, this PR implements the object system and basic types. This is an automated message from the Apache Git Service. To re

[GitHub] [incubator-tvm] jroesch commented on pull request #5525: [Rust] Second stage of Rust Refactor

jroesch commented on pull request #5525: URL: https://github.com/apache/incubator-tvm/pull/5525#issuecomment-624542676 Confused my remotes with both branches closing to point to ones on my fork. This is an automated message f

[GitHub] [incubator-tvm] jroesch opened a new pull request #5526: [Rust] Add first stage of updating and rewriting Rust bindings.

jroesch opened a new pull request #5526: URL: https://github.com/apache/incubator-tvm/pull/5526 I plan on sending an RFC tomorrow on the greater refactor but my goal is to restructure the current Rust code into 4 crates: - `tvm-sys` containing the lowest level bindings to `libruntimetvm.

[GitHub] [incubator-tvm] jroesch commented on pull request #5524: [Rust] Add first stage of updating and rewriting Rust bindings.

jroesch commented on pull request #5524: URL: https://github.com/apache/incubator-tvm/pull/5524#issuecomment-624541301 I pushed to the wrong remote, closing for fresh issue. This is an automated message from the Apache Git S

[GitHub] [incubator-tvm] jroesch opened a new pull request #5525: [Rust] Second stage of Rust Refactor

jroesch opened a new pull request #5525: URL: https://github.com/apache/incubator-tvm/pull/5525 See #5524, this PR implements changes to TVM required for the `tvm-rt` crate to expose the object system for consumption in the high level crate. --

[incubator-tvm] 01/01: Add tvm-rt

This is an automated email from the ASF dual-hosted git repository. jroesch pushed a commit to branch rust-tvm-rt in repository https://gitbox.apache.org/repos/asf/incubator-tvm.git commit d8d3147e304bdf5336acf22fb7616a9e59c2ad71 Author: Jared Roesch AuthorDate: Wed May 6 02:22:08 2020 -0700

[incubator-tvm] branch rust-tvm-rt created (now d8d3147)

This is an automated email from the ASF dual-hosted git repository. jroesch pushed a change to branch rust-tvm-rt in repository https://gitbox.apache.org/repos/asf/incubator-tvm.git. at d8d3147 Add tvm-rt This branch includes the following new commits: new d8d3147 Add tvm-rt The

[GitHub] [incubator-tvm] ANSHUMAN87 commented on pull request #5523: [Refactor][std::string --> String] IRModule is updated with String

ANSHUMAN87 commented on pull request #5523: URL: https://github.com/apache/incubator-tvm/pull/5523#issuecomment-624539441 @jroesch: Thanks a lot for your feedback! There is a break in python binding because of this change. I am working on it currently. Will resolve ASAP. Thanks! ---

[incubator-tvm] branch rust-tvm-sys updated (5662f8e -> dd2bcd0)

This is an automated email from the ASF dual-hosted git repository. jroesch pushed a change to branch rust-tvm-sys in repository https://gitbox.apache.org/repos/asf/incubator-tvm.git. discard 5662f8e Add tvm-sys add 12e737f Make "none" DataType explicit (#5491) add 3f33b25 [Hexagon

[GitHub] [incubator-tvm] lhutton1 commented on a change in pull request #5422: [RELAY][Convert Layout] Specify additional layouts in convert layout pass

lhutton1 commented on a change in pull request #5422: URL: https://github.com/apache/incubator-tvm/pull/5422#discussion_r420644527 ## File path: docs/dev/convert_layout.rst ## @@ -218,24 +224,49 @@ Second example is for a lightly-layout sensitive operator - batch normalization

[GitHub] [incubator-tvm] giuseros commented on issue #5514: RPC error for large arrays

giuseros commented on issue #5514: URL: https://github.com/apache/incubator-tvm/issues/5514#issuecomment-624534491 Hi @tqchen , Thanks for the prompt fix! It is now working fine (it was also nice to dig a bit around the RPC part of the codebase). I will close the issue now. ---

[GitHub] [incubator-tvm] jroesch commented on pull request #5523: [Refactor][std::string --> String] IRModule is updated with String

jroesch commented on pull request #5523: URL: https://github.com/apache/incubator-tvm/pull/5523#issuecomment-624531258 Looks good to me, assuming all tests pass. I could use this in my next set of PRs. This is an automated m

[GitHub] [incubator-tvm] jroesch commented on pull request #5328: [Rust][Runtime] Add basic object system support.

jroesch commented on pull request #5328: URL: https://github.com/apache/incubator-tvm/pull/5328#issuecomment-624530829 Closing in favor of finer grained PRs. This is an automated message from the Apache Git Service. To respon

[GitHub] [incubator-tvm] jroesch commented on pull request #5524: [Rust] Add first stage of updating and rewriting Rust bindings.

jroesch commented on pull request #5524: URL: https://github.com/apache/incubator-tvm/pull/5524#issuecomment-624530409 @binarybana @robo-corg @mwillsey @vegaluisjose @MarisaKirisame @mbrookhart @tqchen This is an automated

[incubator-tvm] branch rust-tvm-sys updated (79131d5 -> 5662f8e)

This is an automated email from the ASF dual-hosted git repository. jroesch pushed a change to branch rust-tvm-sys in repository https://gitbox.apache.org/repos/asf/incubator-tvm.git. discard 79131d5 Add the tvm-sys crate as the lowest level bindings. add 5662f8e Add tvm-sys This update

[incubator-tvm] branch rust-tvm-sys updated (79131d5 -> 5662f8e)

This is an automated email from the ASF dual-hosted git repository. jroesch pushed a change to branch rust-tvm-sys in repository https://gitbox.apache.org/repos/asf/incubator-tvm.git. discard 79131d5 Add the tvm-sys crate as the lowest level bindings. add 5662f8e Add tvm-sys This update

[GitHub] [incubator-tvm] lhutton1 commented on a change in pull request #5422: [RELAY][Convert Layout] Specify additional layouts in convert layout pass

lhutton1 commented on a change in pull request #5422: URL: https://github.com/apache/incubator-tvm/pull/5422#discussion_r420644527 ## File path: docs/dev/convert_layout.rst ## @@ -218,24 +224,49 @@ Second example is for a lightly-layout sensitive operator - batch normalization

[incubator-tvm] branch rust-tvm-sys updated (84e7d53 -> 79131d5)

This is an automated email from the ASF dual-hosted git repository. jroesch pushed a change to branch rust-tvm-sys in repository https://gitbox.apache.org/repos/asf/incubator-tvm.git. omit 84e7d53 Tests are passing omit 6e7ef97 New function interface omit 8ca7efd Repair tests for

[GitHub] [incubator-tvm] lhutton1 commented on a change in pull request #5422: [RELAY][Convert Layout] Specify additional layouts in convert layout pass

lhutton1 commented on a change in pull request #5422: URL: https://github.com/apache/incubator-tvm/pull/5422#discussion_r420642814 ## File path: docs/dev/convert_layout.rst ## @@ -116,16 +117,21 @@ These steps happen for each operator in sequence, where ConvertLayout pass keep

[GitHub] [incubator-tvm] jroesch opened a new pull request #5524: [Rust] Add first stage of updating and rewriting Rust bindings.

jroesch opened a new pull request #5524: URL: https://github.com/apache/incubator-tvm/pull/5524 I plan on sending an RFC tomorrow on the greater refactor but my goal is to restructure the current Rust code into 4 crates: - `tvm-sys` containing the lowest level bindings to `libruntimetvm.

[incubator-tvm] branch rust-tvm-sys created (now 84e7d53)

This is an automated email from the ASF dual-hosted git repository. jroesch pushed a change to branch rust-tvm-sys in repository https://gitbox.apache.org/repos/asf/incubator-tvm.git. at 84e7d53 Tests are passing No new revisions were added by this update.

  1   2   >