[GitHub] [incubator-tvm] junrushao1994 commented on a change in pull request #5585: [Runtime] Introduce runtime::Array

2020-05-16 Thread GitBox
junrushao1994 commented on a change in pull request #5585: URL: https://github.com/apache/incubator-tvm/pull/5585#discussion_r426217781 ## File path: include/tvm/runtime/container.h ## @@ -189,6 +189,759 @@ class InplaceArrayBase { } }; +/*! + * \brief iterator adapter

[GitHub] [incubator-tvm] junrushao1994 commented on a change in pull request #5585: [Runtime] Introduce runtime::Array

2020-05-16 Thread GitBox
junrushao1994 commented on a change in pull request #5585: URL: https://github.com/apache/incubator-tvm/pull/5585#discussion_r426215116 ## File path: include/tvm/runtime/container.h ## @@ -189,6 +189,758 @@ class InplaceArrayBase { } }; +/*! + * \brief iterator adapter

[GitHub] [incubator-tvm] roastduck commented on pull request #5606: [CUDA] Fix codegen for warp shuffle intrinsics

2020-05-16 Thread GitBox
roastduck commented on pull request #5606: URL: https://github.com/apache/incubator-tvm/pull/5606#issuecomment-629730692 I improved the existing `test_lower_warp_memory_cuda_half_a_warp` by adding an extra dimension, to cover this PR.

[GitHub] [incubator-tvm] junrushao1994 commented on a change in pull request #5585: [Runtime] Introduce runtime::Array

2020-05-16 Thread GitBox
junrushao1994 commented on a change in pull request #5585: URL: https://github.com/apache/incubator-tvm/pull/5585#discussion_r426207287 ## File path: include/tvm/runtime/container.h ## @@ -189,6 +189,759 @@ class InplaceArrayBase { } }; +/*! + * \brief iterator adapter

[GitHub] [incubator-tvm] junrushao1994 commented on a change in pull request #5585: [Runtime] Introduce runtime::Array

2020-05-16 Thread GitBox
junrushao1994 commented on a change in pull request #5585: URL: https://github.com/apache/incubator-tvm/pull/5585#discussion_r426207084 ## File path: include/tvm/runtime/container.h ## @@ -189,6 +189,759 @@ class InplaceArrayBase { } }; +/*! + * \brief iterator adapter

[GitHub] [incubator-tvm] junrushao1994 commented on a change in pull request #5585: [Runtime] Introduce runtime::Array

2020-05-16 Thread GitBox
junrushao1994 commented on a change in pull request #5585: URL: https://github.com/apache/incubator-tvm/pull/5585#discussion_r426206719 ## File path: include/tvm/runtime/container.h ## @@ -189,6 +189,759 @@ class InplaceArrayBase { } }; +/*! + * \brief iterator adapter

[GitHub] [incubator-tvm] junrushao1994 commented on a change in pull request #5585: [Runtime] Introduce runtime::Array

2020-05-16 Thread GitBox
junrushao1994 commented on a change in pull request #5585: URL: https://github.com/apache/incubator-tvm/pull/5585#discussion_r426204481 ## File path: include/tvm/runtime/container.h ## @@ -189,6 +189,759 @@ class InplaceArrayBase { } }; +/*! + * \brief iterator adapter

[GitHub] [incubator-tvm] junrushao1994 commented on a change in pull request #5585: [Runtime] Introduce runtime::Array

2020-05-16 Thread GitBox
junrushao1994 commented on a change in pull request #5585: URL: https://github.com/apache/incubator-tvm/pull/5585#discussion_r426203839 ## File path: include/tvm/runtime/container.h ## @@ -189,6 +189,759 @@ class InplaceArrayBase { } }; +/*! + * \brief iterator adapter

[GitHub] [incubator-tvm] junrushao1994 commented on a change in pull request #5585: [Runtime] Introduce runtime::Array

2020-05-16 Thread GitBox
junrushao1994 commented on a change in pull request #5585: URL: https://github.com/apache/incubator-tvm/pull/5585#discussion_r426204049 ## File path: include/tvm/runtime/container.h ## @@ -189,6 +189,759 @@ class InplaceArrayBase { } }; +/*! + * \brief iterator adapter

[GitHub] [incubator-tvm] junrushao1994 commented on a change in pull request #5585: [Runtime] Introduce runtime::Array

2020-05-16 Thread GitBox
junrushao1994 commented on a change in pull request #5585: URL: https://github.com/apache/incubator-tvm/pull/5585#discussion_r426204036 ## File path: include/tvm/runtime/container.h ## @@ -189,6 +189,759 @@ class InplaceArrayBase { } }; +/*! + * \brief iterator adapter

[GitHub] [incubator-tvm] junrushao1994 commented on a change in pull request #5585: [Runtime] Introduce runtime::Array

2020-05-16 Thread GitBox
junrushao1994 commented on a change in pull request #5585: URL: https://github.com/apache/incubator-tvm/pull/5585#discussion_r426203839 ## File path: include/tvm/runtime/container.h ## @@ -189,6 +189,759 @@ class InplaceArrayBase { } }; +/*! + * \brief iterator adapter

[GitHub] [incubator-tvm] junrushao1994 commented on a change in pull request #5585: [Runtime] Introduce runtime::Array

2020-05-16 Thread GitBox
junrushao1994 commented on a change in pull request #5585: URL: https://github.com/apache/incubator-tvm/pull/5585#discussion_r426200479 ## File path: include/tvm/runtime/container.h ## @@ -189,6 +189,759 @@ class InplaceArrayBase { } }; +/*! + * \brief iterator adapter

[GitHub] [incubator-tvm] junrushao1994 commented on a change in pull request #5585: [Runtime] Introduce runtime::Array

2020-05-16 Thread GitBox
junrushao1994 commented on a change in pull request #5585: URL: https://github.com/apache/incubator-tvm/pull/5585#discussion_r426200217 ## File path: src/te/schedule/schedule_lang.cc ## @@ -267,10 +272,12 @@ Stage& Stage::fuse(const Array& axes, IterVar* p_target) { //

[GitHub] [incubator-tvm] junrushao1994 commented on a change in pull request #5585: [Runtime] Introduce runtime::Array

2020-05-16 Thread GitBox
junrushao1994 commented on a change in pull request #5585: URL: https://github.com/apache/incubator-tvm/pull/5585#discussion_r426200217 ## File path: src/te/schedule/schedule_lang.cc ## @@ -267,10 +272,12 @@ Stage& Stage::fuse(const Array& axes, IterVar* p_target) { //

[GitHub] [incubator-tvm] tqchen opened a new pull request #5609: [REFACTOR][IR] Streamline ir/op Registry

2020-05-16 Thread GitBox
tqchen opened a new pull request #5609: URL: https://github.com/apache/incubator-tvm/pull/5609 This PR refactors the attrregistry mechanism in the ir/op into a separate common base. The common base will provide a foundation for other attr related registries such as target and pass.

[GitHub] [incubator-tvm] tqchen commented on pull request #5609: [REFACTOR][IR] Streamline ir/op Registry

2020-05-16 Thread GitBox
tqchen commented on pull request #5609: URL: https://github.com/apache/incubator-tvm/pull/5609#issuecomment-629714398 cc @zhiics @junrushao1994 @yzhliu @icemelon9 This is an automated message from the Apache Git Service. To

[GitHub] [incubator-tvm] tqchen commented on a change in pull request #5585: [Runtime] Introduce runtime::Array

2020-05-16 Thread GitBox
tqchen commented on a change in pull request #5585: URL: https://github.com/apache/incubator-tvm/pull/5585#discussion_r426190765 ## File path: src/te/schedule/schedule_lang.cc ## @@ -267,10 +272,12 @@ Stage& Stage::fuse(const Array& axes, IterVar* p_target) { // NOLINT(*

[GitHub] [incubator-tvm] tqchen commented on a change in pull request #5585: [Runtime] Introduce runtime::Array

2020-05-16 Thread GitBox
tqchen commented on a change in pull request #5585: URL: https://github.com/apache/incubator-tvm/pull/5585#discussion_r426189610 ## File path: include/tvm/runtime/container.h ## @@ -189,6 +189,759 @@ class InplaceArrayBase { } }; +/*! + * \brief iterator adapter that

[GitHub] [incubator-tvm] tqchen commented on issue #5608: Failed to compile Rust examples on SGX

2020-05-16 Thread GitBox
tqchen commented on issue #5608: URL: https://github.com/apache/incubator-tvm/issues/5608#issuecomment-629685927 cc @nhynes This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [incubator-tvm] tqchen commented on pull request #5606: [CUDA] Fix codegen for warp shuffle intrinsics

2020-05-16 Thread GitBox
tqchen commented on pull request #5606: URL: https://github.com/apache/incubator-tvm/pull/5606#issuecomment-629668824 Thanks @roastduck can you please add a regression test as per http://tvm.apache.org/docs/contribute/code_review.html#ensure-test-coverage

[GitHub] [incubator-tvm] tqchen merged pull request #5607: [VTA][Bugfix] RPC Server error fix on Pynq FPGA

2020-05-16 Thread GitBox
tqchen merged pull request #5607: URL: https://github.com/apache/incubator-tvm/pull/5607 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[incubator-tvm] branch master updated (ce3f73d -> 63f84a1)

2020-05-16 Thread tqchen
This is an automated email from the ASF dual-hosted git repository. tqchen pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/incubator-tvm.git. from ce3f73d [PYTORCH]Matmul fix for batch_matmul (#5604) add 63f84a1 fix rpc server bug on VTA (#5607) No

[GitHub] [incubator-tvm] cchung100m commented on pull request #5511: [AutoTVM][TOPI] AutoTVM incorrect measurement

2020-05-16 Thread GitBox
cchung100m commented on pull request #5511: URL: https://github.com/apache/incubator-tvm/pull/5511#issuecomment-629620151 Hi @kevinthesun Thanks for the feedback. I am still thinking how to do this task, currently. Therefore, I will turn it to draft now.

[GitHub] [incubator-tvm] roastduck commented on a change in pull request #5483: [TIR][Printer] text format printer considering future parsing use

2020-05-16 Thread GitBox
roastduck commented on a change in pull request #5483: URL: https://github.com/apache/incubator-tvm/pull/5483#discussion_r426130269 ## File path: src/printer/tir_text_printer.cc ## @@ -0,0 +1,597 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more

[GitHub] [incubator-tvm] kevinthesun commented on a change in pull request #5511: [AutoTVM][TOPI] AutoTVM incorrect measurement

2020-05-16 Thread GitBox
kevinthesun commented on a change in pull request #5511: URL: https://github.com/apache/incubator-tvm/pull/5511#discussion_r426125601 ## File path: topi/python/topi/mali/conv2d.py ## @@ -138,20 +138,15 @@ def _schedule_spatial_pack(cfg, s, output, conv, data_vec, kernel_vec):

[GitHub] [incubator-tvm] junrushao1994 commented on pull request #5585: [Runtime] Introduce runtime::Array

2020-05-16 Thread GitBox
junrushao1994 commented on pull request #5585: URL: https://github.com/apache/incubator-tvm/pull/5585#issuecomment-629594362 @tqchen @zhiics Review comments addressed, please take another look :-) This is an automated