[GitHub] [incubator-tvm] tqchen commented on a change in pull request #5719: [Object] Restore the StrMap behavior in JSON/SHash/SEqual

tqchen commented on a change in pull request #5719: URL: https://github.com/apache/incubator-tvm/pull/5719#discussion_r434314213 ## File path: include/tvm/node/container.h ## @@ -82,6 +82,21 @@ class MapNode : public Object { /*! \brief the data content */ ContainerType

[GitHub] [incubator-tvm] ANSHUMAN87 commented on a change in pull request #5718: [Object][FFI] Introduce runtime::String::CanConvertFrom

ANSHUMAN87 commented on a change in pull request #5718: URL: https://github.com/apache/incubator-tvm/pull/5718#discussion_r434310738 ## File path: src/ir/attrs.cc ## @@ -37,7 +37,7 @@ void DictAttrsNode::InitByPackedArgs(const runtime::TVMArgs& args, bool allow_un

[GitHub] [incubator-tvm] ANSHUMAN87 commented on a change in pull request #5718: [Object][FFI] Introduce runtime::String::CanConvertFrom

ANSHUMAN87 commented on a change in pull request #5718: URL: https://github.com/apache/incubator-tvm/pull/5718#discussion_r434311351 ## File path: src/ir/attrs.cc ## @@ -37,7 +37,7 @@ void DictAttrsNode::InitByPackedArgs(const runtime::TVMArgs& args, bool allow_un

[GitHub] [incubator-tvm] ANSHUMAN87 commented on a change in pull request #5718: [Object][FFI] Introduce runtime::String::CanConvertFrom

ANSHUMAN87 commented on a change in pull request #5718: URL: https://github.com/apache/incubator-tvm/pull/5718#discussion_r434310738 ## File path: src/ir/attrs.cc ## @@ -37,7 +37,7 @@ void DictAttrsNode::InitByPackedArgs(const runtime::TVMArgs& args, bool allow_un

[GitHub] [incubator-tvm] ANSHUMAN87 commented on a change in pull request #5718: [Object][FFI] Introduce runtime::String::CanConvertFrom

ANSHUMAN87 commented on a change in pull request #5718: URL: https://github.com/apache/incubator-tvm/pull/5718#discussion_r434310738 ## File path: src/ir/attrs.cc ## @@ -37,7 +37,7 @@ void DictAttrsNode::InitByPackedArgs(const runtime::TVMArgs& args, bool allow_un

[GitHub] [incubator-tvm] junrushao1994 commented on a change in pull request #5718: [Object][FFI] Introduce runtime::String::CanConvertFrom

junrushao1994 commented on a change in pull request #5718: URL: https://github.com/apache/incubator-tvm/pull/5718#discussion_r434308571 ## File path: src/ir/attrs.cc ## @@ -37,7 +37,7 @@ void DictAttrsNode::InitByPackedArgs(const runtime::TVMArgs& args, bool allow_un

[GitHub] [incubator-tvm] junrushao1994 edited a comment on pull request #5687: [Object] Unify StrMapNode and MapNode

junrushao1994 edited a comment on pull request #5687: URL: https://github.com/apache/incubator-tvm/pull/5687#issuecomment-637902225 Follow-up PR #5718 per our [discussion](https://github.com/apache/incubator-tvm/pull/5687#discussion_r434212540) in this thread

[GitHub] [incubator-tvm] junrushao1994 commented on pull request #5687: [Object] Unify StrMapNode and MapNode

junrushao1994 commented on pull request #5687: URL: https://github.com/apache/incubator-tvm/pull/5687#issuecomment-637952674 Another follow-up PR #5719 that restores some unwanted change of behavior when `StrMap` is removed

[GitHub] [incubator-tvm] junrushao1994 opened a new pull request #5719: [Object] Restore the StrMap behavior in JSON/SHash/SEqual

junrushao1994 opened a new pull request #5719: URL: https://github.com/apache/incubator-tvm/pull/5719 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[GitHub] [incubator-tvm] junrushao1994 commented on a change in pull request #5718: [Object][FFI] Introduce runtime::String::CanConvertFrom

junrushao1994 commented on a change in pull request #5718: URL: https://github.com/apache/incubator-tvm/pull/5718#discussion_r434302862 ## File path: src/ir/attrs.cc ## @@ -37,7 +37,7 @@ void DictAttrsNode::InitByPackedArgs(const runtime::TVMArgs& args, bool allow_un

[GitHub] [incubator-tvm] ANSHUMAN87 commented on a change in pull request #5718: [Object][FFI] Introduce runtime::String::CanConvertFrom

ANSHUMAN87 commented on a change in pull request #5718: URL: https://github.com/apache/incubator-tvm/pull/5718#discussion_r434299250 ## File path: src/ir/attrs.cc ## @@ -37,7 +37,7 @@ void DictAttrsNode::InitByPackedArgs(const runtime::TVMArgs& args, bool allow_un

[GitHub] [incubator-tvm] dhruvaray commented on pull request #5447: [TOPI,RELAY][TFLITE] Sparse to dense operator

dhruvaray commented on pull request #5447: URL: https://github.com/apache/incubator-tvm/pull/5447#issuecomment-637941805 @anijain2305 - Please review and merge This is an automated message from the Apache Git Service. To

[GitHub] [incubator-tvm] junrushao1994 commented on a change in pull request #5718: [Object][FFI] Introduce runtime::String::CanConvertFrom

junrushao1994 commented on a change in pull request #5718: URL: https://github.com/apache/incubator-tvm/pull/5718#discussion_r434289143 ## File path: include/tvm/runtime/container.h ## @@ -1301,6 +1301,10 @@ class String : public ObjectRef { */ operator std::string()

[GitHub] [incubator-tvm] tobegit3hub edited a comment on pull request #5714: Rename tvm_dso_op to libtvm_dso_op

tobegit3hub edited a comment on pull request #5714: URL: https://github.com/apache/incubator-tvm/pull/5714#issuecomment-637920202 Thanks @zhiics and @tqchen . We have add the basic user document for TVMDSOOp in [discuss](https://discuss.tvm.ai/t/add-the-document-for-tvmdsoop/6622).

[GitHub] [incubator-tvm] tobegit3hub commented on pull request #5714: Rename tvm_dso_op to libtvm_dso_op

tobegit3hub commented on pull request #5714: URL: https://github.com/apache/incubator-tvm/pull/5714#issuecomment-637920202 Thanks @zhiics and @tqchen . We have add the basic user document for TVMDSOOp in [discuss](https://discuss.tvm.ai/t/add-the-document-for-tvmdsoop/6622). We have

[GitHub] [incubator-tvm] tqchen commented on a change in pull request #5718: [Object][FFI] Introduce runtime::String::CanConvertFrom

tqchen commented on a change in pull request #5718: URL: https://github.com/apache/incubator-tvm/pull/5718#discussion_r434270105 ## File path: include/tvm/runtime/container.h ## @@ -1301,6 +1301,10 @@ class String : public ObjectRef { */ operator std::string() const {

[GitHub] [incubator-tvm] junrushao1994 commented on pull request #5687: [Object] Unify StrMapNode and MapNode

junrushao1994 commented on pull request #5687: URL: https://github.com/apache/incubator-tvm/pull/5687#issuecomment-637902225 Follow-up PR: #5718 This is an automated message from the Apache Git Service. To respond to the

[GitHub] [incubator-tvm] junrushao1994 opened a new pull request #5718: [Object][FFI] Introduce runtime::String::CanConvertFrom

junrushao1994 opened a new pull request #5718: URL: https://github.com/apache/incubator-tvm/pull/5718 which helps to decide if a `TVMArgValue` can be converted to `runtime::String` This is an automated message from the

[GitHub] [incubator-tvm] liangfu commented on a change in pull request #5655: Add MicroTVM tutorial using the STM32F746 discovery board

liangfu commented on a change in pull request #5655: URL: https://github.com/apache/incubator-tvm/pull/5655#discussion_r433008686 ## File path: tutorials/micro/README.txt ## @@ -0,0 +1,4 @@ +.. _tutorial-micro: + +Micro TVM + Review comment:

[GitHub] [incubator-tvm] tqchen commented on pull request #5687: [Object] Unify StrMapNode and MapNode

tqchen commented on pull request #5687: URL: https://github.com/apache/incubator-tvm/pull/5687#issuecomment-637861386 thanks @junrushao1994 This is an automated message from the Apache Git Service. To respond to the message,

[incubator-tvm] branch master updated (062a244 -> 4347b41)

This is an automated email from the ASF dual-hosted git repository. tqchen pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/incubator-tvm.git. from 062a244 Rename tvm_dso_op to libtvm_dso_op (#5714) add 4347b41 [Object] Unify StrMapNode and MapNode

[GitHub] [incubator-tvm] tqchen merged pull request #5687: [Object] Unify StrMapNode and MapNode

tqchen merged pull request #5687: URL: https://github.com/apache/incubator-tvm/pull/5687 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [incubator-tvm] junrushao1994 commented on pull request #5687: [Object] Unify StrMapNode and MapNode

junrushao1994 commented on pull request #5687: URL: https://github.com/apache/incubator-tvm/pull/5687#issuecomment-637860352 @tqchen CI is green now, can you take another look? Thanks! This is an automated message from the

[GitHub] [incubator-tvm] junrushao1994 commented on pull request #5687: [Object] Unify StrMapNode and MapNode

junrushao1994 commented on pull request #5687: URL: https://github.com/apache/incubator-tvm/pull/5687#issuecomment-637844354 @tqchen Sounds good. I will do it in a separate PR then This is an automated message from the

[GitHub] [incubator-tvm] tqchen commented on pull request #5687: [Object] Unify StrMapNode and MapNode

tqchen commented on pull request #5687: URL: https://github.com/apache/incubator-tvm/pull/5687#issuecomment-637844108 See my followup comments on the CanConvertFrom, although we could also bring that as a separate PR This

[GitHub] [incubator-tvm] tqchen commented on a change in pull request #5687: [Object] Unify StrMapNode and MapNode

tqchen commented on a change in pull request #5687: URL: https://github.com/apache/incubator-tvm/pull/5687#discussion_r434212540 ## File path: src/runtime/graph/graph_runtime.cc ## @@ -418,6 +419,9 @@ PackedFunc GraphRuntime::GetFunction(const std::string& name, int

[GitHub] [incubator-tvm] tqchen commented on a change in pull request #5687: [Object] Unify StrMapNode and MapNode

tqchen commented on a change in pull request #5687: URL: https://github.com/apache/incubator-tvm/pull/5687#discussion_r434212264 ## File path: src/runtime/graph/graph_runtime.cc ## @@ -418,6 +419,9 @@ PackedFunc GraphRuntime::GetFunction(const std::string& name, int

[GitHub] [incubator-tvm] tqchen commented on a change in pull request #5687: [Object] Unify StrMapNode and MapNode

tqchen commented on a change in pull request #5687: URL: https://github.com/apache/incubator-tvm/pull/5687#discussion_r434212264 ## File path: src/runtime/graph/graph_runtime.cc ## @@ -418,6 +419,9 @@ PackedFunc GraphRuntime::GetFunction(const std::string& name, int

[GitHub] [incubator-tvm] junrushao1994 commented on a change in pull request #5687: [Object] Unify StrMapNode and MapNode

junrushao1994 commented on a change in pull request #5687: URL: https://github.com/apache/incubator-tvm/pull/5687#discussion_r434169926 ## File path: src/runtime/graph/graph_runtime.cc ## @@ -418,6 +419,9 @@ PackedFunc GraphRuntime::GetFunction(const std::string& name,

[GitHub] [incubator-tvm] areusch edited a comment on pull request #5655: Add MicroTVM tutorial using the STM32F746 discovery board

areusch edited a comment on pull request #5655: URL: https://github.com/apache/incubator-tvm/pull/5655#issuecomment-637760600 Hey Tom, to get this to build further along in the CI, I think you can add the following line to docs/conf.py: '../tutorials/micro' I added this

[GitHub] [incubator-tvm] areusch commented on pull request #5655: Add MicroTVM tutorial using the STM32F746 discovery board

areusch commented on pull request #5655: URL: https://github.com/apache/incubator-tvm/pull/5655#issuecomment-637760600 Hey Tom, to get this to build further along in the CI, I think you can add the following line to docs/conf.py: '../tutorials/micro' I added this around

[GitHub] [incubator-tvm] tqchen commented on pull request #5655: Add MicroTVM tutorial using the STM32F746 discovery board

tqchen commented on pull request #5655: URL: https://github.com/apache/incubator-tvm/pull/5655#issuecomment-637756370 @tom-gall please look into the CI failure This is an automated message from the Apache Git Service. To

[GitHub] [incubator-tvm] kevinthesun commented on a change in pull request #4312: [TOPI][Relay][OP] Dynamic NMS and strided_slice

kevinthesun commented on a change in pull request #4312: URL: https://github.com/apache/incubator-tvm/pull/4312#discussion_r434115162 ## File path: python/tvm/relay/frontend/tensorflow.py ## @@ -614,6 +614,53 @@ def _impl(inputs, attr, params, mod): return out

[GitHub] [incubator-tvm] kevinthesun commented on a change in pull request #4312: [TOPI][Relay][OP] Dynamic NMS and strided_slice

kevinthesun commented on a change in pull request #4312: URL: https://github.com/apache/incubator-tvm/pull/4312#discussion_r434115162 ## File path: python/tvm/relay/frontend/tensorflow.py ## @@ -614,6 +614,53 @@ def _impl(inputs, attr, params, mod): return out

[GitHub] [incubator-tvm] kevinthesun commented on a change in pull request #4312: [TOPI][Relay][OP] Dynamic NMS and strided_slice

kevinthesun commented on a change in pull request #4312: URL: https://github.com/apache/incubator-tvm/pull/4312#discussion_r434111309 ## File path: python/tvm/relay/frontend/tensorflow.py ## @@ -1119,7 +1166,11 @@ def _impl(inputs, attr, params, mod): try:

[GitHub] [incubator-tvm] kevinthesun commented on a change in pull request #4312: [TOPI][Relay][OP] Dynamic NMS and strided_slice

kevinthesun commented on a change in pull request #4312: URL: https://github.com/apache/incubator-tvm/pull/4312#discussion_r434111490 ## File path: python/tvm/relay/frontend/tensorflow.py ## @@ -1128,16 +1179,7 @@ def _impl(inputs, attr, params, mod): size =

[GitHub] [incubator-tvm] ANSHUMAN87 opened a new pull request #5717: [REFACTOR][IR] Migrate Pass/PassContext ObjectRef to not-null

ANSHUMAN87 opened a new pull request #5717: URL: https://github.com/apache/incubator-tvm/pull/5717 Refer #5318 @tqchen, @jroesch : Please help review, Thanks! This is an automated message from the Apache Git Service.

[GitHub] [incubator-tvm] junrushao1994 commented on pull request #5687: [Draft][Object] Unify StrMapNode and MapNode

junrushao1994 commented on pull request #5687: URL: https://github.com/apache/incubator-tvm/pull/5687#issuecomment-637740903 Per our offline discussion, we decided that we use a new name ObjectPtrEqual/ObjectPtrHash for previous ObjectEqual/ObjectHash, and the new

[GitHub] [incubator-tvm] junrushao1994 commented on a change in pull request #5687: [Draft][Object] Unify StrMapNode and MapNode

junrushao1994 commented on a change in pull request #5687: URL: https://github.com/apache/incubator-tvm/pull/5687#discussion_r434100950 ## File path: include/tvm/node/container.h ## @@ -49,11 +50,24 @@ using runtime::ObjectRef; using runtime::String; using

[GitHub] [incubator-tvm] aGiant commented on pull request #5713: [BUGFIX][CRT] Fix Compilation Error in CRT

aGiant commented on pull request #5713: URL: https://github.com/apache/incubator-tvm/pull/5713#issuecomment-637735690 It works, many thanks :) This is an automated message from the Apache Git Service. To respond to the

[GitHub] [incubator-tvm] mbrookhart commented on pull request #5619: Add Scatter to Topi/Relay/ONNX via hybrid script

mbrookhart commented on pull request #5619: URL: https://github.com/apache/incubator-tvm/pull/5619#issuecomment-637732830 @jwfromm @masahi @Laurawly @Huyuwei I finally found time to get back to this and fix the issues with GPU/i386. Could you take a look? Thanks!

[GitHub] [incubator-tvm] tqchen commented on a change in pull request #5687: [Draft][Object] Unify StrMapNode and MapNode

tqchen commented on a change in pull request #5687: URL: https://github.com/apache/incubator-tvm/pull/5687#discussion_r434092626 ## File path: src/runtime/graph/graph_runtime.cc ## @@ -418,6 +419,9 @@ PackedFunc GraphRuntime::GetFunction(const std::string& name, int

[GitHub] [incubator-tvm] junrushao1994 commented on a change in pull request #5687: [Draft][Object] Unify StrMapNode and MapNode

junrushao1994 commented on a change in pull request #5687: URL: https://github.com/apache/incubator-tvm/pull/5687#discussion_r434092224 ## File path: include/tvm/node/container.h ## @@ -49,11 +50,24 @@ using runtime::ObjectRef; using runtime::String; using

[GitHub] [incubator-tvm] junrushao1994 commented on a change in pull request #5687: [Draft][Object] Unify StrMapNode and MapNode

junrushao1994 commented on a change in pull request #5687: URL: https://github.com/apache/incubator-tvm/pull/5687#discussion_r434092013 ## File path: include/tvm/node/container.h ## @@ -49,11 +50,24 @@ using runtime::ObjectRef; using runtime::String; using

[GitHub] [incubator-tvm] junrushao1994 commented on a change in pull request #5687: [Draft][Object] Unify StrMapNode and MapNode

junrushao1994 commented on a change in pull request #5687: URL: https://github.com/apache/incubator-tvm/pull/5687#discussion_r434090825 ## File path: include/tvm/runtime/container.h ## @@ -1151,6 +1151,42 @@ class String : public ObjectRef { */ inline String

[GitHub] [incubator-tvm] tqchen commented on a change in pull request #5687: [Draft][Object] Unify StrMapNode and MapNode

tqchen commented on a change in pull request #5687: URL: https://github.com/apache/incubator-tvm/pull/5687#discussion_r434089882 ## File path: include/tvm/runtime/container.h ## @@ -1151,6 +1151,42 @@ class String : public ObjectRef { */ inline String

[GitHub] [incubator-tvm] kevinthesun commented on a change in pull request #5619: Add Scatter to Topi/Relay/ONNX via hybrid script

kevinthesun commented on a change in pull request #5619: URL: https://github.com/apache/incubator-tvm/pull/5619#discussion_r434057734 ## File path: python/tvm/relay/op/_transform.py ## @@ -383,6 +391,13 @@ def argwhere_shape_func(attrs, inputs, out_ndims): return

[GitHub] [incubator-tvm] notoraptor commented on a change in pull request #5716: [topi][relay] Add operation gather to relay.

notoraptor commented on a change in pull request #5716: URL: https://github.com/apache/incubator-tvm/pull/5716#discussion_r434051229 ## File path: topi/include/topi/transform.h ## @@ -982,6 +982,54 @@ inline Tensor tile(const Tensor& x, Array reps, std::string name = "T_t

[GitHub] [incubator-tvm] abergeron commented on a change in pull request #5716: [topi][relay] Add operation gather to relay.

abergeron commented on a change in pull request #5716: URL: https://github.com/apache/incubator-tvm/pull/5716#discussion_r434044772 ## File path: topi/include/topi/transform.h ## @@ -982,6 +982,54 @@ inline Tensor tile(const Tensor& x, Array reps, std::string name = "T_t }

[GitHub] [incubator-tvm] junrushao1994 commented on pull request #5687: [Draft][Object] Unify StrMapNode and MapNode

junrushao1994 commented on pull request #5687: URL: https://github.com/apache/incubator-tvm/pull/5687#issuecomment-637690190 CC @tqchen @jwfromm: this PR is ready for review! Please take a look if you are interested. This

[GitHub] [incubator-tvm] junrushao1994 commented on a change in pull request #5687: [Draft][Object] Unify StrMapNode and MapNode

junrushao1994 commented on a change in pull request #5687: URL: https://github.com/apache/incubator-tvm/pull/5687#discussion_r434039911 ## File path: src/runtime/graph/graph_runtime.cc ## @@ -418,6 +419,9 @@ PackedFunc GraphRuntime::GetFunction(const std::string& name,

[GitHub] [incubator-tvm] notoraptor opened a new pull request #5716: [topi][relay] Add operation gather to relay.

notoraptor opened a new pull request #5716: URL: https://github.com/apache/incubator-tvm/pull/5716 Hi! This is a PR to add operation `gather` to relay, the same operation as in torch: https://pytorch.org/docs/stable/torch.html#torch.gather

[GitHub] [incubator-tvm] junrushao1994 commented on a change in pull request #5687: [Draft][Object] Unify StrMapNode and MapNode

junrushao1994 commented on a change in pull request #5687: URL: https://github.com/apache/incubator-tvm/pull/5687#discussion_r434037129 ## File path: include/tvm/runtime/container.h ## @@ -1151,6 +1151,42 @@ class String : public ObjectRef { */ inline String

[GitHub] [incubator-tvm] junrushao1994 commented on a change in pull request #5687: [Draft][Object] Unify StrMapNode and MapNode

junrushao1994 commented on a change in pull request #5687: URL: https://github.com/apache/incubator-tvm/pull/5687#discussion_r434035004 ## File path: include/tvm/node/container.h ## @@ -49,11 +50,24 @@ using runtime::ObjectRef; using runtime::String; using

[incubator-tvm] branch master updated (3d06063 -> 062a244)

This is an automated email from the ASF dual-hosted git repository. tqchen pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/incubator-tvm.git. from 3d06063 [BUGFIX][CRT] Fix Compilation Error in CRT (#5713) add 062a244 Rename tvm_dso_op to

[GitHub] [incubator-tvm] tqchen commented on issue #5709: tvm/apps/bundle_deploy/build --> make failed

tqchen commented on issue #5709: URL: https://github.com/apache/incubator-tvm/issues/5709#issuecomment-637661955 #5713 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[incubator-tvm] branch master updated: [BUGFIX][CRT] Fix Compilation Error in CRT (#5713)

This is an automated email from the ASF dual-hosted git repository. tqchen pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-tvm.git The following commit(s) were added to refs/heads/master by this push: new 3d06063 [BUGFIX][CRT] Fix Compilation

[GitHub] [incubator-tvm] tqchen merged pull request #5714: Rename tvm_dso_op to libtvm_dso_op

tqchen merged pull request #5714: URL: https://github.com/apache/incubator-tvm/pull/5714 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [incubator-tvm] tqchen closed issue #5709: tvm/apps/bundle_deploy/build --> make failed

tqchen closed issue #5709: URL: https://github.com/apache/incubator-tvm/issues/5709 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [incubator-tvm] tqchen merged pull request #5713: [BUGFIX][CRT] Fix Compilation Error in CRT

tqchen merged pull request #5713: URL: https://github.com/apache/incubator-tvm/pull/5713 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [incubator-tvm] mbrookhart commented on issue #5667: [TEST][FLAKY] tests/python/contrib/test_cudnn.py

mbrookhart commented on issue #5667: URL: https://github.com/apache/incubator-tvm/issues/5667#issuecomment-637656260 I can reproduce this consistently on my desktop system with Cuda 10.0 and Cudnn 7.6.5. This is an

[GitHub] [incubator-tvm] siju-samuel opened a new pull request #5715: [MXNET]Softmin, trunc op support added

siju-samuel opened a new pull request #5715: URL: https://github.com/apache/incubator-tvm/pull/5715 - softmin - trunc ops support added to Mxnet frontend @masahi @FrozenGene please help to review and merge.

[GitHub] [incubator-tvm] tobegit3hub opened a new pull request #5714: Rename tvm_dso_op to libtvm_dso_op

tobegit3hub opened a new pull request #5714: URL: https://github.com/apache/incubator-tvm/pull/5714 Rename the library of TVMDSOOp to `libtvm_dso_op.so` instead of `tvm_dso_op.so`. It is a quick fix to follow the convention of library name and is useful to integrate with `TensorFlow