[GitHub] [incubator-tvm] siju-samuel commented on a change in pull request #5834: Improve type handling in PyTorch frontend

2020-06-18 Thread GitBox
siju-samuel commented on a change in pull request #5834: URL: https://github.com/apache/incubator-tvm/pull/5834#discussion_r442078508 ## File path: python/tvm/relay/frontend/pytorch.py ## @@ -115,64 +115,70 @@ def inplace_add_to_add(op_name): return False + #

[GitHub] [incubator-tvm] siju-samuel commented on a change in pull request #5834: Improve type handling in PyTorch frontend

2020-06-18 Thread GitBox
siju-samuel commented on a change in pull request #5834: URL: https://github.com/apache/incubator-tvm/pull/5834#discussion_r442078508 ## File path: python/tvm/relay/frontend/pytorch.py ## @@ -115,64 +115,70 @@ def inplace_add_to_add(op_name): return False + #

[GitHub] [incubator-tvm] siju-samuel commented on a change in pull request #5834: Improve type handling in PyTorch frontend

2020-06-18 Thread GitBox
siju-samuel commented on a change in pull request #5834: URL: https://github.com/apache/incubator-tvm/pull/5834#discussion_r442071688 ## File path: python/tvm/relay/frontend/pytorch.py ## @@ -1733,12 +1780,19 @@ def _convert_dtype_value(val):

[GitHub] [incubator-tvm] t-vi commented on a change in pull request #5834: Improve type handling in PyTorch frontend

2020-06-18 Thread GitBox
t-vi commented on a change in pull request #5834: URL: https://github.com/apache/incubator-tvm/pull/5834#discussion_r442070736 ## File path: python/tvm/relay/frontend/pytorch.py ## @@ -1733,12 +1780,19 @@ def _convert_dtype_value(val):

[GitHub] [incubator-tvm] t-vi commented on a change in pull request #5834: Improve type handling in PyTorch frontend

2020-06-18 Thread GitBox
t-vi commented on a change in pull request #5834: URL: https://github.com/apache/incubator-tvm/pull/5834#discussion_r442066203 ## File path: python/tvm/relay/frontend/pytorch.py ## @@ -1733,12 +1780,19 @@ def _convert_dtype_value(val):

[GitHub] [incubator-tvm] t-vi commented on a change in pull request #5834: Improve type handling in PyTorch frontend

2020-06-18 Thread GitBox
t-vi commented on a change in pull request #5834: URL: https://github.com/apache/incubator-tvm/pull/5834#discussion_r442070171 ## File path: python/tvm/relay/frontend/pytorch.py ## @@ -115,64 +115,70 @@ def inplace_add_to_add(op_name): return False + # operator

[GitHub] [incubator-tvm] t-vi commented on a change in pull request #5834: Improve type handling in PyTorch frontend

2020-06-18 Thread GitBox
t-vi commented on a change in pull request #5834: URL: https://github.com/apache/incubator-tvm/pull/5834#discussion_r442066837 ## File path: python/tvm/relay/frontend/pytorch.py ## @@ -115,64 +115,70 @@ def inplace_add_to_add(op_name): return False + # operator

[GitHub] [incubator-tvm] t-vi commented on a change in pull request #5834: Improve type handling in PyTorch frontend

2020-06-18 Thread GitBox
t-vi commented on a change in pull request #5834: URL: https://github.com/apache/incubator-tvm/pull/5834#discussion_r442066203 ## File path: python/tvm/relay/frontend/pytorch.py ## @@ -1733,12 +1780,19 @@ def _convert_dtype_value(val):

[GitHub] [incubator-tvm] siju-samuel commented on a change in pull request #5839: [Torch][Quantized] Fix converting serialized quantized models

2020-06-18 Thread GitBox
siju-samuel commented on a change in pull request #5839: URL: https://github.com/apache/incubator-tvm/pull/5839#discussion_r442066028 ## File path: python/tvm/relay/frontend/pytorch.py ## @@ -595,15 +601,18 @@ def _impl(inputs, input_types): return

<    1   2