[GitHub] [incubator-tvm] hypercubestart commented on pull request #5881: [WIP][Relay] Mutual Recursion Support

hypercubestart commented on pull request #5881: URL: https://github.com/apache/incubator-tvm/pull/5881#issuecomment-678063156 ready for review @MarisaKirisame @jroesch @slyubomirsky @joshpoll @tqchen @wweic @weberlo This is

[incubator-tvm] branch master updated (470dfc3 -> 4876813)

This is an automated email from the ASF dual-hosted git repository. ziheng pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/incubator-tvm.git. from 470dfc3 [Torch] Fix dtype handling for modules with integer parameters (#6311) add 4876813 [COREML]mul

[GitHub] [incubator-tvm] ZihengJiang merged pull request #6296: [COREML]multiple output support, reshape, split ops added

ZihengJiang merged pull request #6296: URL: https://github.com/apache/incubator-tvm/pull/6296 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [incubator-tvm] FrozenGene commented on pull request #6312: [TEST][FLAKY] fix random fail

FrozenGene commented on pull request #6312: URL: https://github.com/apache/incubator-tvm/pull/6312#issuecomment-678025301 Have increased size and error. When to run 100 times, previous code will occur 6 errors, 1000 times will occur 44 errors. New code doesn't have check error. Wish this c

[GitHub] [incubator-tvm] masahi closed issue #6300: [Frontend][PyTorch] Cast to Long gets translated into cast to float32

masahi closed issue #6300: URL: https://github.com/apache/incubator-tvm/issues/6300 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [incubator-tvm] masahi commented on issue #6300: [Frontend][PyTorch] Cast to Long gets translated into cast to float32

masahi commented on issue #6300: URL: https://github.com/apache/incubator-tvm/issues/6300#issuecomment-678017963 #6311 is merged This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [incubator-tvm] siju-samuel commented on pull request #6311: [Torch] Fix dtype handling for modules with integer parameters

siju-samuel commented on pull request #6311: URL: https://github.com/apache/incubator-tvm/pull/6311#issuecomment-678003248 Thanks @masahi. This PR is merged. This is an automated message from the Apache Git Service. To respon

[incubator-tvm] branch master updated (91ea9bc -> 470dfc3)

This is an automated email from the ASF dual-hosted git repository. sijusamuel pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/incubator-tvm.git. from 91ea9bc Changed TVMCTVMContext to TVMContext (#6306) add 470dfc3 [Torch] Fix dtype handling for mod

[GitHub] [incubator-tvm] siju-samuel merged pull request #6311: [Torch] Fix dtype handling for modules with integer parameters

siju-samuel merged pull request #6311: URL: https://github.com/apache/incubator-tvm/pull/6311 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [incubator-tvm] kevinthesun opened a new pull request #6318: [Frontend][Pytorch]Add Pytorch advanced indexing

kevinthesun opened a new pull request #6318: URL: https://github.com/apache/incubator-tvm/pull/6318 This PR adds support for Pytorch advanced indexing ```aten::index``` and also fixes an issue in Pytorch slice mapping. @masahi @yongwww @zhiics -

[incubator-tvm] branch master updated (e52c5ba -> 91ea9bc)

This is an automated email from the ASF dual-hosted git repository. tqchen pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/incubator-tvm.git. from e52c5ba Constant input attr added to fully connected operation in TFLite frontend (#6228) add 91ea9bc

[GitHub] [incubator-tvm] tqchen merged pull request #6306: Changed TVMCTVMContext to TVMContext

tqchen merged pull request #6306: URL: https://github.com/apache/incubator-tvm/pull/6306 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to g

[GitHub] [incubator-tvm] tqchen commented on pull request #6306: Changed TVMCTVMContext to TVMContext

tqchen commented on pull request #6306: URL: https://github.com/apache/incubator-tvm/pull/6306#issuecomment-677976433 Thanks @mplemay ! This is an automated message from the Apache Git Service. To respond to the message, plea

[GitHub] [incubator-tvm] jwfromm commented on a change in pull request #6315: [Target] Add python binding to new JSON target construction.

jwfromm commented on a change in pull request #6315: URL: https://github.com/apache/incubator-tvm/pull/6315#discussion_r474346651 ## File path: tests/python/unittest/test_target_target.py ## @@ -80,7 +80,31 @@ def test_target_create(): assert tgt is not None +def t

[GitHub] [incubator-tvm] tqchen commented on pull request #6317: [TIR] Enforce buffer pointer var type to be consistent with dtype.

tqchen commented on pull request #6317: URL: https://github.com/apache/incubator-tvm/pull/6317#issuecomment-677974351 cc @spectrometerHBH This is an automated message from the Apache Git Service. To respond to the message, p

[GitHub] [incubator-tvm] tqchen opened a new pull request #6317: [TIR] Enforce buffer pointer var type to be consistent with dtype.

tqchen opened a new pull request #6317: URL: https://github.com/apache/incubator-tvm/pull/6317 Now that we have type_annotation in `tir::Var`. We should make sure that the type annotation to be consistent with the dtype in Buffer declaration and Allocation. This change allows futu

[GitHub] [incubator-tvm] tqchen commented on pull request #6312: [TEST][FLAKY] fix random fail

tqchen commented on pull request #6312: URL: https://github.com/apache/incubator-tvm/pull/6312#issuecomment-677972731 I do think increase the size and error range should help, and as long as the error happens in low probability(we can calculate the confidence) we should be fine.

[GitHub] [incubator-tvm] electriclilies commented on a change in pull request #6316: Dynamic Strided Slice

electriclilies commented on a change in pull request #6316: URL: https://github.com/apache/incubator-tvm/pull/6316#discussion_r474312010 ## File path: python/tvm/relay/op/transform.py ## @@ -827,13 +828,17 @@ def strided_slice(data, begin, end, strides=None, slice_mode="end"):

[GitHub] [incubator-tvm] FrozenGene edited a comment on pull request #6312: [TEST][FLAKY] fix random fail

FrozenGene edited a comment on pull request #6312: URL: https://github.com/apache/incubator-tvm/pull/6312#issuecomment-677964220 @tqchen I undenstand your concern. However, I have done some experiments and the generated data is random, we can not make sure completely like `np.mean(na) < 0.

[GitHub] [incubator-tvm] FrozenGene commented on pull request #6312: [TEST][FLAKY] fix random fail

FrozenGene commented on pull request #6312: URL: https://github.com/apache/incubator-tvm/pull/6312#issuecomment-677964220 @tqchen I undenstand your concern. However, I have dine some experiments and the generated data is random, we can not make sure completely like `np.mean(na) < 0.2` alwa

[GitHub] [incubator-tvm] FrozenGene edited a comment on pull request #6312: [TEST][FLAKY] fix random fail

FrozenGene edited a comment on pull request #6312: URL: https://github.com/apache/incubator-tvm/pull/6312#issuecomment-677964220 @tqchen I undenstand your concern. However, I have done some experiments and the generated data is random, we can not make sure completely like `np.mean(na) < 0.

[GitHub] [incubator-tvm] FrozenGene edited a comment on pull request #6312: [TEST][FLAKY] fix random fail

FrozenGene edited a comment on pull request #6312: URL: https://github.com/apache/incubator-tvm/pull/6312#issuecomment-677964220 @tqchen I undenstand your concern. However, I have done some experiments and the generated data is random, we can not make sure completely like `np.mean(na) < 0.

[GitHub] [incubator-tvm] masahi commented on pull request #6298: [BUG_FIX] Fix resize test

masahi commented on pull request #6298: URL: https://github.com/apache/incubator-tvm/pull/6298#issuecomment-677954667 oh CI is failing because there is nearest + half_pixel combination in pytorch frontend ... https://github.com/apache/incubator-tvm/blob/939a42b4e976a41e8513b720421d3

[GitHub] [incubator-tvm] comaniac commented on a change in pull request #6315: [Target] Add python binding to new JSON target construction.

comaniac commented on a change in pull request #6315: URL: https://github.com/apache/incubator-tvm/pull/6315#discussion_r474311026 ## File path: tests/python/unittest/test_target_target.py ## @@ -80,7 +80,31 @@ def test_target_create(): assert tgt is not None +def

[GitHub] [incubator-tvm] jwfromm commented on a change in pull request #6315: [Target] Add python binding to new JSON target construction.

jwfromm commented on a change in pull request #6315: URL: https://github.com/apache/incubator-tvm/pull/6315#discussion_r474308603 ## File path: python/tvm/target/target.py ## @@ -364,9 +394,11 @@ def create(target_str): See the note on :py:mod:`tvm.target` on tar

[GitHub] [incubator-tvm] jwfromm commented on a change in pull request #6315: [Target] Add python binding to new JSON target construction.

jwfromm commented on a change in pull request #6315: URL: https://github.com/apache/incubator-tvm/pull/6315#discussion_r474308217 ## File path: tests/python/unittest/test_target_target.py ## @@ -80,7 +80,31 @@ def test_target_create(): assert tgt is not None +def t

[GitHub] [incubator-tvm] jwfromm commented on a change in pull request #6315: [Target] Add python binding to new JSON target construction.

jwfromm commented on a change in pull request #6315: URL: https://github.com/apache/incubator-tvm/pull/6315#discussion_r474294457 ## File path: tests/python/unittest/test_target_target.py ## @@ -80,7 +80,31 @@ def test_target_create(): assert tgt is not None +def t

[GitHub] [incubator-tvm] masahi commented on a change in pull request #6314: [Relay] Support for PyTorch Non-Maximum Suppression

masahi commented on a change in pull request #6314: URL: https://github.com/apache/incubator-tvm/pull/6314#discussion_r474278914 ## File path: tests/python/frontend/pytorch/test_forward.py ## @@ -1606,6 +1633,39 @@ def verify_script_model(pt_model, ishapes):

[GitHub] [incubator-tvm] masahi commented on a change in pull request #6314: [Relay] Support for PyTorch Non-Maximum Suppression

masahi commented on a change in pull request #6314: URL: https://github.com/apache/incubator-tvm/pull/6314#discussion_r474278914 ## File path: tests/python/frontend/pytorch/test_forward.py ## @@ -1606,6 +1633,39 @@ def verify_script_model(pt_model, ishapes):

[GitHub] [incubator-tvm] yongwww commented on a change in pull request #6314: [Relay] Support for PyTorch Non-Maximum Suppression

yongwww commented on a change in pull request #6314: URL: https://github.com/apache/incubator-tvm/pull/6314#discussion_r474275131 ## File path: tests/python/frontend/pytorch/test_forward.py ## @@ -1606,6 +1633,39 @@ def verify_script_model(pt_model, ishapes):

[GitHub] [incubator-tvm] comaniac commented on a change in pull request #6310: [Ansor][AutoTVM v2.0] Phase 2: Evolutionary Search

comaniac commented on a change in pull request #6310: URL: https://github.com/apache/incubator-tvm/pull/6310#discussion_r474264101 ## File path: src/auto_scheduler/search_policy/sketch_policy_rules.h ## @@ -201,6 +201,26 @@ class InitVectorization : public InitPopulationRule {

[GitHub] [incubator-tvm] tqchen commented on a change in pull request #6315: [Target] Add python binding to new JSON target construction.

tqchen commented on a change in pull request #6315: URL: https://github.com/apache/incubator-tvm/pull/6315#discussion_r474257087 ## File path: python/tvm/target/target.py ## @@ -364,9 +394,11 @@ def create(target_str): See the note on :py:mod:`tvm.target` on targ

[GitHub] [incubator-tvm] tqchen commented on a change in pull request #6315: [Target] Add python binding to new JSON target construction.

tqchen commented on a change in pull request #6315: URL: https://github.com/apache/incubator-tvm/pull/6315#discussion_r474257087 ## File path: python/tvm/target/target.py ## @@ -364,9 +394,11 @@ def create(target_str): See the note on :py:mod:`tvm.target` on targ

[GitHub] [incubator-tvm] comaniac commented on a change in pull request #6315: [Target] Add python binding to new JSON target construction.

comaniac commented on a change in pull request #6315: URL: https://github.com/apache/incubator-tvm/pull/6315#discussion_r474254880 ## File path: tests/python/unittest/test_target_target.py ## @@ -80,7 +80,31 @@ def test_target_create(): assert tgt is not None +def

[GitHub] [incubator-tvm] masahi commented on a change in pull request #6314: [Relay] Support for PyTorch Non-Maximum Suppression

masahi commented on a change in pull request #6314: URL: https://github.com/apache/incubator-tvm/pull/6314#discussion_r474253877 ## File path: tests/python/frontend/pytorch/test_forward.py ## @@ -1606,6 +1633,39 @@ def verify_script_model(pt_model, ishapes):

[GitHub] [incubator-tvm] masahi commented on a change in pull request #6314: [Relay] Support for PyTorch Non-Maximum Suppression

masahi commented on a change in pull request #6314: URL: https://github.com/apache/incubator-tvm/pull/6314#discussion_r474253877 ## File path: tests/python/frontend/pytorch/test_forward.py ## @@ -1606,6 +1633,39 @@ def verify_script_model(pt_model, ishapes):

[GitHub] [incubator-tvm] mbrookhart opened a new pull request #6316: Dynamic Strided Slice

mbrookhart opened a new pull request #6316: URL: https://github.com/apache/incubator-tvm/pull/6316 This PR splits the dynamic-parameter version of strided slice from the constant parameter version, improves the shape funcs to pass more unit test, and supports executing the constant paramet

[GitHub] [incubator-tvm] yongwww commented on a change in pull request #6314: [Relay] Support for PyTorch Non-Maximum Suppression

yongwww commented on a change in pull request #6314: URL: https://github.com/apache/incubator-tvm/pull/6314#discussion_r474250004 ## File path: tests/python/frontend/pytorch/test_forward.py ## @@ -1606,6 +1633,39 @@ def verify_script_model(pt_model, ishapes):

[GitHub] [incubator-tvm] masahi commented on a change in pull request #6314: [Relay] Support for PyTorch Non-Maximum Suppression

masahi commented on a change in pull request #6314: URL: https://github.com/apache/incubator-tvm/pull/6314#discussion_r474243010 ## File path: tests/python/frontend/pytorch/test_forward.py ## @@ -1606,6 +1633,39 @@ def verify_script_model(pt_model, ishapes):

[GitHub] [incubator-tvm] jwfromm commented on a change in pull request #6315: [Target] Add python binding to new JSON target construction.

jwfromm commented on a change in pull request #6315: URL: https://github.com/apache/incubator-tvm/pull/6315#discussion_r474239652 ## File path: tests/python/unittest/test_target_target.py ## @@ -80,7 +80,31 @@ def test_target_create(): assert tgt is not None +def t

[GitHub] [incubator-tvm] junrushao1994 commented on a change in pull request #6315: [Target] Add python binding to new JSON target construction.

junrushao1994 commented on a change in pull request #6315: URL: https://github.com/apache/incubator-tvm/pull/6315#discussion_r474239482 ## File path: python/tvm/target/target.py ## @@ -364,9 +394,11 @@ def create(target_str): See the note on :py:mod:`tvm.target`

[GitHub] [incubator-tvm] comaniac commented on a change in pull request #6315: [Target] Add python binding to new JSON target construction.

comaniac commented on a change in pull request #6315: URL: https://github.com/apache/incubator-tvm/pull/6315#discussion_r474234075 ## File path: python/tvm/target/target.py ## @@ -364,9 +394,11 @@ def create(target_str): See the note on :py:mod:`tvm.target` on ta

[GitHub] [incubator-tvm] junrushao1994 commented on a change in pull request #6315: [Target] Add python binding to new JSON target construction.

junrushao1994 commented on a change in pull request #6315: URL: https://github.com/apache/incubator-tvm/pull/6315#discussion_r474217829 ## File path: python/tvm/target/target.py ## @@ -364,9 +394,11 @@ def create(target_str): See the note on :py:mod:`tvm.target`

[GitHub] [incubator-tvm] comaniac commented on pull request #6302: [tvmc] command line driver 'compile' (part 2/4)

comaniac commented on pull request #6302: URL: https://github.com/apache/incubator-tvm/pull/6302#issuecomment-677843479 > One thing to note is that given we are updating the target convention to use the json as an input, it might be helpful to think about what is the target that can be acc

[GitHub] [incubator-tvm] tqchen commented on pull request #6315: [Target] Add python binding to new JSON target construction.

tqchen commented on pull request #6315: URL: https://github.com/apache/incubator-tvm/pull/6315#issuecomment-677842257 also cc @zhiics @comaniac @yzhliu This is an automated message from the Apache Git Service. To respond to

[GitHub] [incubator-tvm] tqchen edited a comment on pull request #6315: [Target] Add python binding to new JSON target construction.

tqchen edited a comment on pull request #6315: URL: https://github.com/apache/incubator-tvm/pull/6315#issuecomment-677842257 also cc @zhiics @comaniac @yzhliu @leandron This is an automated message from the Apache Git Servic

[GitHub] [incubator-tvm] anijain2305 commented on pull request #6228: Constant input attr added to fully connected operation in TFLite frontend

anijain2305 commented on pull request #6228: URL: https://github.com/apache/incubator-tvm/pull/6228#issuecomment-677834409 Thanks @d-smirnov @mbaret This is merged! This is an automated message from the Apache Git Service. To

[incubator-tvm] branch master updated (f577aa6 -> e52c5ba)

This is an automated email from the ASF dual-hosted git repository. anijain2305 pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/incubator-tvm.git. from f577aa6 [RELAY][DYN] Implementation of the dynamic pad operator (#6284) add e52c5ba Constant inpu

[GitHub] [incubator-tvm] anijain2305 merged pull request #6228: Constant input attr added to fully connected operation in TFLite frontend

anijain2305 merged pull request #6228: URL: https://github.com/apache/incubator-tvm/pull/6228 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [incubator-tvm] jwfromm commented on pull request #6315: [Target] Add python binding to new JSON target construction.

jwfromm commented on pull request #6315: URL: https://github.com/apache/incubator-tvm/pull/6315#issuecomment-677832849 @junrushao1994 can you review this PR? This is an automated message from the Apache Git Service. To respon

[GitHub] [incubator-tvm] jwfromm opened a new pull request #6315: [Target] Add python binding to new JSON target construction.

jwfromm opened a new pull request #6315: URL: https://github.com/apache/incubator-tvm/pull/6315 This PR adds the ability to create targets from a configuration dictionary. It's a very thin wrapper around the c++ version of this feature introduced in #6218. --

[GitHub] [incubator-tvm] interesaaat commented on issue #6300: [Frontend][PyTorch] Cast to Long gets translated into cast to float32

interesaaat commented on issue #6300: URL: https://github.com/apache/incubator-tvm/issues/6300#issuecomment-677829408 It worked, no more casts are needed and the warnings disappeared. This is an automated message from the Ap

[GitHub] [incubator-tvm] electriclilies closed issue #6309: [TEST][FLAKY] test_normal fails intermittently

electriclilies closed issue #6309: URL: https://github.com/apache/incubator-tvm/issues/6309 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above t

[GitHub] [incubator-tvm] junrushao1994 commented on pull request #6302: [tvmc] command line driver 'compile' (part 2/4)

junrushao1994 commented on pull request #6302: URL: https://github.com/apache/incubator-tvm/pull/6302#issuecomment-677825250 @tqchen I am thinking about unifying target creation from legacy string, JSON file and tags. This i

[GitHub] [incubator-tvm] tqchen commented on pull request #6302: [tvmc] command line driver 'compile' (part 2/4)

tqchen commented on pull request #6302: URL: https://github.com/apache/incubator-tvm/pull/6302#issuecomment-677824198 One thing to note is that given we are updating the target convention to use the json as an input, it might be helpful to think about what is the target that can be accepte

[GitHub] [incubator-tvm] electriclilies commented on issue #6309: [TEST][FLAKY] test_normal fails intermittently

electriclilies commented on issue #6309: URL: https://github.com/apache/incubator-tvm/issues/6309#issuecomment-677824222 Thanks @FrozenGene @tqchen! This is an automated message from the Apache Git Service. To respond to the

[GitHub] [incubator-tvm] tqchen commented on issue #6299: [DISCUSS][RFC] Apache TVM Graduation

tqchen commented on issue #6299: URL: https://github.com/apache/incubator-tvm/issues/6299#issuecomment-677818823 Thanks Furkan. I have updated the status file. This is an automated message from the Apache Git Service. To resp

[GitHub] [incubator-tvm] comaniac commented on a change in pull request #6269: [Ansor][AutoTVM v2.0] Phase 2: Basic GPU Sketch Search Policy

comaniac commented on a change in pull request #6269: URL: https://github.com/apache/incubator-tvm/pull/6269#discussion_r474161410 ## File path: src/auto_scheduler/search_policy/sketch_policy_rules.h ## @@ -73,84 +73,51 @@ class SketchGenerationRule {

[GitHub] [incubator-tvm] tvm-archiver commented on issue #6299: [DISCUSS][RFC] Apache TVM Graduation

tvm-archiver commented on issue #6299: URL: https://github.com/apache/incubator-tvm/issues/6299#issuecomment-677785789 Hi, Apart from being a great project, TVM has an active and growing community. It has a good understanding of the Apache Way [1] which is most important. I

[GitHub] [incubator-tvm] zhiics commented on pull request #6313: [Relay] Make check stricter: disallow inserting function with free vars into module.

zhiics commented on pull request #6313: URL: https://github.com/apache/incubator-tvm/pull/6313#issuecomment-677784002 Creating a function and binding those free vars should fix some of the failing tests? This is an automated

[GitHub] [incubator-tvm] junrushao1994 commented on pull request #6313: [Relay] Make check stricter: disallow inserting function with free vars into module.

junrushao1994 commented on pull request #6313: URL: https://github.com/apache/incubator-tvm/pull/6313#issuecomment-677781483 Looks like it cannot pass CI because there are some test cases that free variables exist... This is

[GitHub] [incubator-tvm] gussmith23 commented on pull request #5812: Bring Your Own Datatypes

gussmith23 commented on pull request #5812: URL: https://github.com/apache/incubator-tvm/pull/5812#issuecomment-677769793 @slyubomirsky I heard from Zach that you have been looking into how documentation is done in modern TVM. I need to document the datatypes framework, which is distribute

[GitHub] [incubator-tvm] tqchen commented on pull request #6312: [TEST][FLAKY] fix random fail

tqchen commented on pull request #6312: URL: https://github.com/apache/incubator-tvm/pull/6312#issuecomment-677755546 We should avoid the usage of seed to resolve the test error wrt to randomness. Since setting seed can hide problems in real usecases. Instead, we should make sure t

[GitHub] [incubator-tvm] comaniac commented on a change in pull request #6310: [Ansor][AutoTVM v2.0] Phase 2: Evolutionary Search

comaniac commented on a change in pull request #6310: URL: https://github.com/apache/incubator-tvm/pull/6310#discussion_r474084480 ## File path: src/auto_scheduler/search_policy/sketch_policy_rules.h ## @@ -201,6 +201,26 @@ class InitVectorization : public InitPopulationRule {

[GitHub] [incubator-tvm] comaniac commented on a change in pull request #6310: [Ansor][AutoTVM v2.0] Phase 2: Evolutionary Search

comaniac commented on a change in pull request #6310: URL: https://github.com/apache/incubator-tvm/pull/6310#discussion_r474080839 ## File path: src/auto_scheduler/search_policy/sketch_policy.cc ## @@ -327,8 +335,150 @@ Array SketchPolicyNode::EvolutionarySearch(const Array& i

[GitHub] [incubator-tvm] leandron commented on a change in pull request #6302: [tvmc] command line driver 'compile' (part 2/4)

leandron commented on a change in pull request #6302: URL: https://github.com/apache/incubator-tvm/pull/6302#discussion_r474080780 ## File path: python/tvm/driver/tvmc/compiler.py ## @@ -0,0 +1,407 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more cont

[GitHub] [incubator-tvm] leandron commented on a change in pull request #6302: [tvmc] command line driver 'compile' (part 2/4)

leandron commented on a change in pull request #6302: URL: https://github.com/apache/incubator-tvm/pull/6302#discussion_r474062879 ## File path: python/tvm/driver/tvmc/compiler.py ## @@ -0,0 +1,407 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more cont

[GitHub] [incubator-tvm] tqchen closed issue #5298: [CRT][FLAKY] Flaky failures on 32bit platforms

tqchen closed issue #5298: URL: https://github.com/apache/incubator-tvm/issues/5298 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [incubator-tvm] tqchen commented on issue #5298: [CRT][FLAKY] Flaky failures on 32bit platforms

tqchen commented on issue #5298: URL: https://github.com/apache/incubator-tvm/issues/5298#issuecomment-677732398 Thanks @areusch This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [incubator-tvm] leandron commented on a change in pull request #6302: [tvmc] command line driver 'compile' (part 2/4)

leandron commented on a change in pull request #6302: URL: https://github.com/apache/incubator-tvm/pull/6302#discussion_r474062879 ## File path: python/tvm/driver/tvmc/compiler.py ## @@ -0,0 +1,407 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more cont

[GitHub] [incubator-tvm] leandron commented on a change in pull request #6302: [tvmc] command line driver 'compile' (part 2/4)

leandron commented on a change in pull request #6302: URL: https://github.com/apache/incubator-tvm/pull/6302#discussion_r474055620 ## File path: python/tvm/driver/tvmc/compiler.py ## @@ -0,0 +1,407 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more cont

[GitHub] [incubator-tvm] leandron commented on a change in pull request #6302: [tvmc] command line driver 'compile' (part 2/4)

leandron commented on a change in pull request #6302: URL: https://github.com/apache/incubator-tvm/pull/6302#discussion_r474056126 ## File path: python/tvm/driver/tvmc/compiler.py ## @@ -0,0 +1,407 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more cont

[GitHub] [incubator-tvm] leandron commented on a change in pull request #6302: [tvmc] command line driver 'compile' (part 2/4)

leandron commented on a change in pull request #6302: URL: https://github.com/apache/incubator-tvm/pull/6302#discussion_r474045263 ## File path: python/tvm/driver/tvmc/compiler.py ## @@ -0,0 +1,407 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more cont

[GitHub] [incubator-tvm] leandron commented on a change in pull request #6302: [tvmc] command line driver 'compile' (part 2/4)

leandron commented on a change in pull request #6302: URL: https://github.com/apache/incubator-tvm/pull/6302#discussion_r474039627 ## File path: python/tvm/driver/tvmc/compiler.py ## @@ -0,0 +1,407 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more cont

[GitHub] [incubator-tvm] leandron commented on a change in pull request #6302: [tvmc] command line driver 'compile' (part 2/4)

leandron commented on a change in pull request #6302: URL: https://github.com/apache/incubator-tvm/pull/6302#discussion_r474039627 ## File path: python/tvm/driver/tvmc/compiler.py ## @@ -0,0 +1,407 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more cont

[GitHub] [incubator-tvm] leandron commented on a change in pull request #6302: [tvmc] command line driver 'compile' (part 2/4)

leandron commented on a change in pull request #6302: URL: https://github.com/apache/incubator-tvm/pull/6302#discussion_r474014203 ## File path: python/tvm/driver/tvmc/compiler.py ## @@ -0,0 +1,407 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more cont

[GitHub] [incubator-tvm] jwfromm commented on a change in pull request #6251: [ONNX] Add Clip importer to handle when min/max are provided as inputs.

jwfromm commented on a change in pull request #6251: URL: https://github.com/apache/incubator-tvm/pull/6251#discussion_r474016831 ## File path: python/tvm/relay/frontend/onnx.py ## @@ -1875,6 +1876,20 @@ def _impl_v1(cls, inputs, attr, params): return _vision.roi_align

[GitHub] [incubator-tvm] leandron commented on a change in pull request #6302: [tvmc] command line driver 'compile' (part 2/4)

leandron commented on a change in pull request #6302: URL: https://github.com/apache/incubator-tvm/pull/6302#discussion_r474014203 ## File path: python/tvm/driver/tvmc/compiler.py ## @@ -0,0 +1,407 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more cont

[GitHub] [incubator-tvm] yongwww commented on pull request #6314: [Relay] Support for PyTorch Non-Maximum Suppression

yongwww commented on pull request #6314: URL: https://github.com/apache/incubator-tvm/pull/6314#issuecomment-677634878 @masahi have incorporated your comments, please take another look, thanks! This is an automated message f

[GitHub] [incubator-tvm] masahi commented on a change in pull request #6314: [Relay] Support for PyTorch Non-Maximum Suppression

masahi commented on a change in pull request #6314: URL: https://github.com/apache/incubator-tvm/pull/6314#discussion_r473897729 ## File path: tests/python/frontend/pytorch/test_forward.py ## @@ -1428,6 +1428,48 @@ def test_forward_upsample3d(): verify_model(torch.nn.Upsam

[GitHub] [incubator-tvm] masahi commented on a change in pull request #6314: [Relay] Support for PyTorch Non-Maximum Suppression

masahi commented on a change in pull request #6314: URL: https://github.com/apache/incubator-tvm/pull/6314#discussion_r473897729 ## File path: tests/python/frontend/pytorch/test_forward.py ## @@ -1428,6 +1428,48 @@ def test_forward_upsample3d(): verify_model(torch.nn.Upsam

[GitHub] [incubator-tvm] masahi commented on a change in pull request #6314: [Relay] Support for PyTorch Non-Maximum Suppression

masahi commented on a change in pull request #6314: URL: https://github.com/apache/incubator-tvm/pull/6314#discussion_r473891771 ## File path: tests/python/frontend/pytorch/test_forward.py ## @@ -1428,6 +1428,48 @@ def test_forward_upsample3d(): verify_model(torch.nn.Upsam

[GitHub] [incubator-tvm] masahi commented on a change in pull request #6314: [Relay] Support for PyTorch Non-Maximum Suppression

masahi commented on a change in pull request #6314: URL: https://github.com/apache/incubator-tvm/pull/6314#discussion_r473891771 ## File path: tests/python/frontend/pytorch/test_forward.py ## @@ -1428,6 +1428,48 @@ def test_forward_upsample3d(): verify_model(torch.nn.Upsam

[GitHub] [incubator-tvm] masahi commented on a change in pull request #6314: [Relay] Support for PyTorch Non-Maximum Suppression

masahi commented on a change in pull request #6314: URL: https://github.com/apache/incubator-tvm/pull/6314#discussion_r473889810 ## File path: tests/python/frontend/pytorch/test_forward.py ## @@ -1428,6 +1428,48 @@ def test_forward_upsample3d(): verify_model(torch.nn.Upsam

[GitHub] [incubator-tvm] masahi commented on a change in pull request #6314: [Relay] Support for PyTorch Non-Maximum Suppression

masahi commented on a change in pull request #6314: URL: https://github.com/apache/incubator-tvm/pull/6314#discussion_r473873857 ## File path: python/tvm/relay/frontend/pytorch.py ## @@ -2060,10 +2060,57 @@ def _get_convert_map(prelude): "aten::type_as"

[GitHub] [incubator-tvm] leandron commented on a change in pull request #6302: [tvmc] command line driver 'compile' (part 2/4)

leandron commented on a change in pull request #6302: URL: https://github.com/apache/incubator-tvm/pull/6302#discussion_r473811542 ## File path: python/tvm/driver/tvmc/compiler.py ## @@ -0,0 +1,407 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more cont

[GitHub] [incubator-tvm] leandron commented on a change in pull request #6302: [tvmc] command line driver 'compile' (part 2/4)

leandron commented on a change in pull request #6302: URL: https://github.com/apache/incubator-tvm/pull/6302#discussion_r473810441 ## File path: python/tvm/driver/tvmc/__init__.py ## @@ -14,3 +14,8 @@ # KIND, either express or implied. See the License for the # specific lang

[GitHub] [incubator-tvm] yongwww opened a new pull request #6314: [Relay] Support for PyTorch Non-Maximum Suppression

yongwww opened a new pull request #6314: URL: https://github.com/apache/incubator-tvm/pull/6314 @masahi @alexwong @kevinthesun @zhiics please help take a look This is an automated message from the Apache Git Service. To respo

[GitHub] [incubator-tvm] jcf94 edited a comment on pull request #6312: [TEST][FLAKY] fix random fail

jcf94 edited a comment on pull request #6312: URL: https://github.com/apache/incubator-tvm/pull/6312#issuecomment-677476774 ~~Should we set the random seed for python random module & numpy random module?~~ Nerver mind, I noticed that this only used the random engine inside TVM. ---

[GitHub] [incubator-tvm] jcf94 commented on pull request #6312: [TEST][FLAKY] fix random fail

jcf94 commented on pull request #6312: URL: https://github.com/apache/incubator-tvm/pull/6312#issuecomment-677476774 Should we set the random seed for python random module & numpy random module? This is an automated message f

[GitHub] [incubator-tvm] nolanliou commented on issue #6268: TVMError: Check failed: it != type_definitions.end(): There is no definition of static_tensor_float32_*

nolanliou commented on issue #6268: URL: https://github.com/apache/incubator-tvm/issues/6268#issuecomment-677471992 Same problem This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [incubator-tvm] junrushao1994 commented on pull request #6313: [Relay] Make check stricter: disallow inserting function with free vars into module.

junrushao1994 commented on pull request #6313: URL: https://github.com/apache/incubator-tvm/pull/6313#issuecomment-677466295 I see. I am for this particular change. Also @tqchen what do you think? This is an automated message

[GitHub] [incubator-tvm] MarisaKirisame commented on pull request #6313: [Relay] Make check stricter: disallow inserting function with free vars into module.

MarisaKirisame commented on pull request #6313: URL: https://github.com/apache/incubator-tvm/pull/6313#issuecomment-677464749 @junrushao1994 ppl was adding graph to irmodule. i add check to make it warning but tq say we should wait for a big version to make them error. ---

[GitHub] [incubator-tvm] junrushao1994 commented on pull request #6313: [Relay] Make check stricter: disallow inserting function with free vars into module.

junrushao1994 commented on pull request #6313: URL: https://github.com/apache/incubator-tvm/pull/6313#issuecomment-677464440 I agree. If there is no specific reason, we should make the check as restrictive and possible to make sure we fail early. I was wondering why it was just a warning b

[GitHub] [incubator-tvm] MarisaKirisame opened a new pull request #6313: [Relay] Make check stricter: disallow inserting function with free vars into module.

MarisaKirisame opened a new pull request #6313: URL: https://github.com/apache/incubator-tvm/pull/6313 Previously it was warning, but it had been the source of many bug in developing. This will check those bugs as soon as possible. @jroesch @zhiics @junrushao1994 can you guys review? -

[GitHub] [incubator-tvm] srkreddy1238 commented on issue #6299: [DISCUSS][RFC] Apache TVM Graduation

srkreddy1238 commented on issue #6299: URL: https://github.com/apache/incubator-tvm/issues/6299#issuecomment-677456765 +1, feeling very happy and great to be part of TVM. This is an automated message from the Apache Git Servi

[GitHub] [incubator-tvm] FrozenGene opened a new pull request #6312: [TEST][FLAKY] fix random fail

FrozenGene opened a new pull request #6312: URL: https://github.com/apache/incubator-tvm/pull/6312 fix https://github.com/apache/incubator-tvm/issues/6309 This is an automated message from the Apache Git Service. To respo