[GitHub] [tvm] comaniac closed issue #7732: [Bug][Auto-scheduler] generated cuda code

2021-03-24 Thread GitBox
comaniac closed issue #7732: URL: https://github.com/apache/tvm/issues/7732 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact

[GitHub] [tvm] comaniac commented on issue #7732: [Bug][Auto-scheduler] generated cuda code

2021-03-24 Thread GitBox
comaniac commented on issue #7732: URL: https://github.com/apache/tvm/issues/7732#issuecomment-806393664 You are not supposed to run the generated kernel by your own, so this is not a limitation to me. Since this is not a bug, I'm going to close this issue. For future questions, please pos

[GitHub] [tvm] Haoran-Solar commented on issue #7732: [Bug][Auto-scheduler] generated cuda code

2021-03-24 Thread GitBox
Haoran-Solar commented on issue #7732: URL: https://github.com/apache/tvm/issues/7732#issuecomment-806391681 Thanks for reply. I just started to try auto-scheduler, I change nothing in file tune_conv2d, just want to have a test. Using prams from last layer in ResNet-50, just the tutorial

[GitHub] [tvm] masahi commented on pull request #7722: [Topi, Relay] Add cumprod

2021-03-24 Thread GitBox
masahi commented on pull request #7722: URL: https://github.com/apache/tvm/pull/7722#issuecomment-806353561 thanks @AndrewZhaoLuo @mbrookhart @jwfromm -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[tvm] branch main updated: [Topi, Relay] Add cumprod (#7722)

2021-03-24 Thread masahi
This is an automated email from the ASF dual-hosted git repository. masahi pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/tvm.git The following commit(s) were added to refs/heads/main by this push: new 8e23806 [Topi, Relay] Add cumprod (#7722) 8e23806 is d

[GitHub] [tvm] masahi merged pull request #7722: [Topi, Relay] Add cumprod

2021-03-24 Thread GitBox
masahi merged pull request #7722: URL: https://github.com/apache/tvm/pull/7722 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please cont

[GitHub] [tvm] altanh commented on pull request #7731: [Relay][Pass] ConcretizeLike and EliminateIdentity rewrites for SimplifyExpr

2021-03-24 Thread GitBox
altanh commented on pull request #7731: URL: https://github.com/apache/tvm/pull/7731#issuecomment-806348360 Ended up having to make ToScalar return an optional value due to a custom datatype test (which as far as I can tell, we don't have a good way of supporting conversion at compile time

[tvm] branch main updated (3ba5868 -> 7130e80)

2021-03-24 Thread zhaowu
This is an automated email from the ASF dual-hosted git repository. zhaowu pushed a change to branch main in repository https://gitbox.apache.org/repos/asf/tvm.git. from 3ba5868 [TensorIR] Fix parser autocompletion mode (#7737) add 7130e80 Better grouped convolution for CPU targets (#

[GitHub] [tvm] FrozenGene commented on pull request #6137: Better grouped convolution for CPU targets

2021-03-24 Thread GitBox
FrozenGene commented on pull request #6137: URL: https://github.com/apache/tvm/pull/6137#issuecomment-806327714 Thanks @Wheest Merged now -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the spec

[GitHub] [tvm] FrozenGene merged pull request #6137: Better grouped convolution for CPU targets

2021-03-24 Thread GitBox
FrozenGene merged pull request #6137: URL: https://github.com/apache/tvm/pull/6137 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please

[GitHub] [tvm] mvermeulen opened a new pull request #7740: [ROCM] Fix missing header, caused compilation failure.

2021-03-24 Thread GitBox
mvermeulen opened a new pull request #7740: URL: https://github.com/apache/tvm/pull/7740 Thanks for contributing to TVM! Please refer to guideline https://tvm.apache.org/docs/contribute/ for useful information and tips. After the pull request is submitted, please request code reviews fro

[GitHub] [tvm] schell commented on pull request #7503: [Rust] Make TVM Rust bindings installable via Cargo.

2021-03-24 Thread GitBox
schell commented on pull request #7503: URL: https://github.com/apache/tvm/pull/7503#issuecomment-806240649 Any luck @jroesch @tqchen ? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specif

[GitHub] [tvm] hogepodge commented on pull request #7641: [docs] Getting Started with TVM: Auto Tuning with Python

2021-03-24 Thread GitBox
hogepodge commented on pull request #7641: URL: https://github.com/apache/tvm/pull/7641#issuecomment-806237862 @tqchen @leandron ready for final review -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [tvm] hogepodge commented on pull request #7638: [docs] Getting Started: Introduction and Installation

2021-03-24 Thread GitBox
hogepodge commented on pull request #7638: URL: https://github.com/apache/tvm/pull/7638#issuecomment-806236079 @tqchen ready for review -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specif

[GitHub] [tvm] hogepodge commented on pull request #7643: [docs] Getting Started with TVM: AutoTVM and Matrix Multiply

2021-03-24 Thread GitBox
hogepodge commented on pull request #7643: URL: https://github.com/apache/tvm/pull/7643#issuecomment-806235620 @tqchen ready for review -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specif

[tvm] branch ci-docker-staging updated (8cbc164 -> 7e48aa8)

2021-03-24 Thread areusch
This is an automated email from the ASF dual-hosted git repository. areusch pushed a change to branch ci-docker-staging in repository https://gitbox.apache.org/repos/asf/tvm.git. discard 8cbc164 Merge remote-tracking branch 'origin/main' into test_mdw_qemu_changes discard 87be5dd fix path

[tvm] 01/01: test CI with staging containers

2021-03-24 Thread areusch
This is an automated email from the ASF dual-hosted git repository. areusch pushed a commit to branch ci-docker-staging in repository https://gitbox.apache.org/repos/asf/tvm.git commit 7e48aa8ef6e2ee540bb8c374ed326cd929cc756f Author: Andrew Reusch AuthorDate: Wed Mar 24 15:39:15 2021 -0700

[GitHub] [tvm] hogepodge commented on pull request #7642: [docs] Getting Started With TVM: Tensor Expressions

2021-03-24 Thread GitBox
hogepodge commented on pull request #7642: URL: https://github.com/apache/tvm/pull/7642#issuecomment-806226992 @comaniac @Hzfengsy changes committed, ready for review -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use th

[GitHub] [tvm] altanh commented on a change in pull request #7731: [Relay][Pass] ConcretizeLike and EliminateIdentity rewrites for SimplifyExpr

2021-03-24 Thread GitBox
altanh commented on a change in pull request #7731: URL: https://github.com/apache/tvm/pull/7731#discussion_r600912352 ## File path: src/relay/transforms/simplify_expr.h ## @@ -0,0 +1,79 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contribut

[GitHub] [tvm] tqchen commented on pull request #7737: [TensorIR] Fix parser autocompletion mode

2021-03-24 Thread GitBox
tqchen commented on pull request #7737: URL: https://github.com/apache/tvm/pull/7737#issuecomment-806195883 Thanks @Hzfengsy @MasterJH5574 . This PR is merged -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL ab

[GitHub] [tvm] comaniac commented on pull request #7739: [TVMC] Externalize load from compile_module (compiler.py line 132)

2021-03-24 Thread GitBox
comaniac commented on pull request #7739: URL: https://github.com/apache/tvm/pull/7739#issuecomment-806190266 I'm fine with this change. Leave on others. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above t

[GitHub] [tvm] CircleSpin commented on pull request #7739: [TVMC] Externalize load from compile_module (compiler.py line 132)

2021-03-24 Thread GitBox
CircleSpin commented on pull request #7739: URL: https://github.com/apache/tvm/pull/7739#issuecomment-806185373 @comaniac @mdw-octoml @leandron @jwfromm -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above t

[GitHub] [tvm] CircleSpin opened a new pull request #7739: [TVMC] Externalize load from compile_module (compiler.py line 132)

2021-03-24 Thread GitBox
CircleSpin opened a new pull request #7739: URL: https://github.com/apache/tvm/pull/7739 This PR moves the load component from compile_module to drive_compile to make it cleaner for python scripting. It prevents "double dipping" the load in frontends more than once. The flow is now

[GitHub] [tvm] altanh commented on a change in pull request #7731: [Relay][Pass] ConcretizeLike and EliminateIdentity rewrites for SimplifyExpr

2021-03-24 Thread GitBox
altanh commented on a change in pull request #7731: URL: https://github.com/apache/tvm/pull/7731#discussion_r600865480 ## File path: src/relay/transforms/simplify_expr.cc ## @@ -249,36 +249,214 @@ class FullElementwise : public SimplifyPattern { }; /*! - * \brief ExprSimpli

[GitHub] [tvm] mbrookhart commented on a change in pull request #7731: [Relay][Pass] ConcretizeLike and EliminateIdentity rewrites for SimplifyExpr

2021-03-24 Thread GitBox
mbrookhart commented on a change in pull request #7731: URL: https://github.com/apache/tvm/pull/7731#discussion_r600863750 ## File path: src/relay/transforms/simplify_expr.cc ## @@ -249,36 +249,214 @@ class FullElementwise : public SimplifyPattern { }; /*! - * \brief ExprSi

[GitHub] [tvm] mbrookhart commented on a change in pull request #7731: [Relay][Pass] ConcretizeLike and EliminateIdentity rewrites for SimplifyExpr

2021-03-24 Thread GitBox
mbrookhart commented on a change in pull request #7731: URL: https://github.com/apache/tvm/pull/7731#discussion_r600863512 ## File path: src/relay/transforms/simplify_expr.cc ## @@ -249,36 +249,214 @@ class FullElementwise : public SimplifyPattern { }; /*! - * \brief ExprSi

[GitHub] [tvm] mbrookhart commented on a change in pull request #7731: [Relay][Pass] ConcretizeLike and EliminateIdentity rewrites for SimplifyExpr

2021-03-24 Thread GitBox
mbrookhart commented on a change in pull request #7731: URL: https://github.com/apache/tvm/pull/7731#discussion_r600863124 ## File path: src/relay/transforms/simplify_expr.cc ## @@ -249,36 +249,214 @@ class FullElementwise : public SimplifyPattern { }; /*! - * \brief ExprSi

[tvm] branch main updated (cfe2e28 -> 3ba5868)

2021-03-24 Thread tqchen
This is an automated email from the ASF dual-hosted git repository. tqchen pushed a change to branch main in repository https://gitbox.apache.org/repos/asf/tvm.git. from cfe2e28 [crt] fix heap corruption from bad allocation (#7735) add 3ba5868 [TensorIR] Fix parser autocompletion mode

[GitHub] [tvm] tqchen merged pull request #7737: [TensorIR] Fix parser autocompletion mode

2021-03-24 Thread GitBox
tqchen merged pull request #7737: URL: https://github.com/apache/tvm/pull/7737 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please cont

[GitHub] [tvm] AndrewZhaoLuo commented on a change in pull request #7722: [Topi, Relay] Add cumprod

2021-03-24 Thread GitBox
AndrewZhaoLuo commented on a change in pull request #7722: URL: https://github.com/apache/tvm/pull/7722#discussion_r600860418 ## File path: python/tvm/topi/cuda/scan.py ## @@ -514,10 +616,54 @@ def cumsum(data, axis=None, dtype=None, exclusive=None): The result has the

[GitHub] [tvm] altanh commented on a change in pull request #7731: [Relay][Pass] ConcretizeLike and EliminateIdentity rewrites for SimplifyExpr

2021-03-24 Thread GitBox
altanh commented on a change in pull request #7731: URL: https://github.com/apache/tvm/pull/7731#discussion_r600860158 ## File path: src/relay/transforms/simplify_expr.h ## @@ -0,0 +1,79 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contribut

[GitHub] [tvm] altanh commented on a change in pull request #7731: [Relay][Pass] ConcretizeLike and EliminateIdentity rewrites for SimplifyExpr

2021-03-24 Thread GitBox
altanh commented on a change in pull request #7731: URL: https://github.com/apache/tvm/pull/7731#discussion_r600858602 ## File path: src/relay/transforms/simplify_expr.cc ## @@ -249,36 +249,214 @@ class FullElementwise : public SimplifyPattern { }; /*! - * \brief ExprSimpli

[GitHub] [tvm] altanh commented on a change in pull request #7731: [Relay][Pass] ConcretizeLike and EliminateIdentity rewrites for SimplifyExpr

2021-03-24 Thread GitBox
altanh commented on a change in pull request #7731: URL: https://github.com/apache/tvm/pull/7731#discussion_r600858326 ## File path: src/relay/transforms/simplify_expr.cc ## @@ -249,36 +249,214 @@ class FullElementwise : public SimplifyPattern { }; /*! - * \brief ExprSimpli

[GitHub] [tvm] comaniac commented on a change in pull request #7731: [Relay][Pass] ConcretizeLike and EliminateIdentity rewrites for SimplifyExpr

2021-03-24 Thread GitBox
comaniac commented on a change in pull request #7731: URL: https://github.com/apache/tvm/pull/7731#discussion_r600852619 ## File path: src/relay/transforms/simplify_expr.h ## @@ -0,0 +1,79 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contrib

[GitHub] [tvm] mbrookhart commented on a change in pull request #7722: [Topi, Relay] Add cumprod

2021-03-24 Thread GitBox
mbrookhart commented on a change in pull request #7722: URL: https://github.com/apache/tvm/pull/7722#discussion_r600849643 ## File path: python/tvm/relay/op/_transform.py ## @@ -19,16 +19,17 @@ # pylint: disable=too-many-local-variables, too-many-arguments, no-else-return f

[GitHub] [tvm] masahi commented on a change in pull request #7722: [Topi, Relay] Add cumprod

2021-03-24 Thread GitBox
masahi commented on a change in pull request #7722: URL: https://github.com/apache/tvm/pull/7722#discussion_r600848449 ## File path: python/tvm/relay/op/_transform.py ## @@ -19,16 +19,17 @@ # pylint: disable=too-many-local-variables, too-many-arguments, no-else-return from

[GitHub] [tvm] masahi commented on a change in pull request #7722: [Topi, Relay] Add cumprod

2021-03-24 Thread GitBox
masahi commented on a change in pull request #7722: URL: https://github.com/apache/tvm/pull/7722#discussion_r600847541 ## File path: python/tvm/topi/cuda/scan.py ## @@ -514,10 +616,54 @@ def cumsum(data, axis=None, dtype=None, exclusive=None): The result has the same s

[GitHub] [tvm] altanh commented on a change in pull request #7731: [Relay][Pass] ConcretizeLike and EliminateIdentity rewrites for SimplifyExpr

2021-03-24 Thread GitBox
altanh commented on a change in pull request #7731: URL: https://github.com/apache/tvm/pull/7731#discussion_r600844682 ## File path: src/relay/transforms/simplify_expr.h ## @@ -0,0 +1,79 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contribut

[GitHub] [tvm] mbrookhart commented on a change in pull request #7722: [Topi, Relay] Add cumprod

2021-03-24 Thread GitBox
mbrookhart commented on a change in pull request #7722: URL: https://github.com/apache/tvm/pull/7722#discussion_r600842607 ## File path: python/tvm/topi/cuda/scan.py ## @@ -514,10 +616,54 @@ def cumsum(data, axis=None, dtype=None, exclusive=None): The result has the sa

[GitHub] [tvm] AndrewZhaoLuo commented on a change in pull request #7722: [Topi, Relay] Add cumprod

2021-03-24 Thread GitBox
AndrewZhaoLuo commented on a change in pull request #7722: URL: https://github.com/apache/tvm/pull/7722#discussion_r600838442 ## File path: python/tvm/topi/cuda/scan.py ## @@ -514,10 +616,54 @@ def cumsum(data, axis=None, dtype=None, exclusive=None): The result has the

[GitHub] [tvm] mbrookhart commented on a change in pull request #7731: [Relay][Pass] ConcretizeLike and EliminateIdentity rewrites for SimplifyExpr

2021-03-24 Thread GitBox
mbrookhart commented on a change in pull request #7731: URL: https://github.com/apache/tvm/pull/7731#discussion_r600836110 ## File path: src/relay/transforms/simplify_expr.cc ## @@ -249,36 +249,214 @@ class FullElementwise : public SimplifyPattern { }; /*! - * \brief ExprSi

[GitHub] [tvm] mbrookhart commented on a change in pull request #7722: [Topi, Relay] Add cumprod

2021-03-24 Thread GitBox
mbrookhart commented on a change in pull request #7722: URL: https://github.com/apache/tvm/pull/7722#discussion_r600830424 ## File path: python/tvm/topi/cuda/scan.py ## @@ -514,10 +616,54 @@ def cumsum(data, axis=None, dtype=None, exclusive=None): The result has the sa

[GitHub] [tvm] altanh commented on a change in pull request #7731: [Relay][Pass] ConcretizeLike and EliminateIdentity Passes

2021-03-24 Thread GitBox
altanh commented on a change in pull request #7731: URL: https://github.com/apache/tvm/pull/7731#discussion_r600826676 ## File path: src/relay/transforms/simplify_expr.cc ## @@ -249,36 +248,214 @@ class FullElementwise : public SimplifyPattern { }; /*! - * \brief ExprSimpli

[GitHub] [tvm] altanh commented on a change in pull request #7731: [Relay][Pass] ConcretizeLike and EliminateIdentity Passes

2021-03-24 Thread GitBox
altanh commented on a change in pull request #7731: URL: https://github.com/apache/tvm/pull/7731#discussion_r600824893 ## File path: src/relay/transforms/simplify_expr.cc ## @@ -249,36 +248,214 @@ class FullElementwise : public SimplifyPattern { }; /*! - * \brief ExprSimpli

[GitHub] [tvm] altanh commented on a change in pull request #7731: [Relay][Pass] ConcretizeLike and EliminateIdentity Passes

2021-03-24 Thread GitBox
altanh commented on a change in pull request #7731: URL: https://github.com/apache/tvm/pull/7731#discussion_r600823616 ## File path: src/relay/transforms/simplify_expr.cc ## @@ -249,36 +248,214 @@ class FullElementwise : public SimplifyPattern { }; /*! - * \brief ExprSimpli

[GitHub] [tvm] areusch edited a comment on issue #7590: [CI][FLAKY] Qemu pipeline timeout

2021-03-24 Thread GitBox
areusch edited a comment on issue #7590: URL: https://github.com/apache/tvm/issues/7590#issuecomment-806095709 https://ci.tlcpack.ai/blue/organizations/jenkins/tvm/detail/PR-7438/12/pipeline/ `INFO: NODE_NAME=node.aladdin.cudabuild EXECUTOR_NUMBER=1` -- This is an automated messag

[GitHub] [tvm] areusch commented on issue #7590: [CI][FLAKY] Qemu pipeline timeout

2021-03-24 Thread GitBox
areusch commented on issue #7590: URL: https://github.com/apache/tvm/issues/7590#issuecomment-806095709 https://ci.tlcpack.ai/blue/organizations/jenkins/tvm/detail/PR-7438/12/pipeline/ -- This is an automated message from the Apache Git Service. To respond to the message, please log on t

[GitHub] [tvm] tqchen commented on a change in pull request #7696: [GO] Fix go bindings

2021-03-24 Thread GitBox
tqchen commented on a change in pull request #7696: URL: https://github.com/apache/tvm/pull/7696#discussion_r600805865 ## File path: golang/Makefile ## @@ -25,7 +25,7 @@ NATIVE_SRC = tvm_runtime_pack.cc GOPATH=$(CURDIR)/gopath GOPATHDIR=${GOPATH}/src/${TARGET}/ CGO_CPPFLAGS=

[GitHub] [tvm] comaniac commented on a change in pull request #7731: [Relay][Pass] ConcretizeLike and EliminateIdentity Passes

2021-03-24 Thread GitBox
comaniac commented on a change in pull request #7731: URL: https://github.com/apache/tvm/pull/7731#discussion_r600800776 ## File path: src/relay/transforms/simplify_expr.cc ## @@ -249,36 +248,214 @@ class FullElementwise : public SimplifyPattern { }; /*! - * \brief ExprSimp

[GitHub] [tvm] hogepodge commented on a change in pull request #7642: [docs] Getting Started With TVM: Tensor Expressions

2021-03-24 Thread GitBox
hogepodge commented on a change in pull request #7642: URL: https://github.com/apache/tvm/pull/7642#discussion_r600791467 ## File path: tutorials/get_started/tensor_expr_get_started.py ## @@ -302,18 +385,452 @@ fadd_cl(a, b, c) tvm.testing.assert_allclose(c.asnumpy(),

[GitHub] [tvm] altanh commented on a change in pull request #7731: [Relay][Pass] ConcretizeLike and EliminateIdentity Passes

2021-03-24 Thread GitBox
altanh commented on a change in pull request #7731: URL: https://github.com/apache/tvm/pull/7731#discussion_r600785922 ## File path: src/relay/transforms/concretize_like.cc ## @@ -0,0 +1,182 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contr

[GitHub] [tvm] hogepodge commented on a change in pull request #7642: [docs] Getting Started With TVM: Tensor Expressions

2021-03-24 Thread GitBox
hogepodge commented on a change in pull request #7642: URL: https://github.com/apache/tvm/pull/7642#discussion_r600785887 ## File path: tutorials/get_started/tensor_expr_get_started.py ## @@ -163,52 +145,156 @@ fadd(a, b, c) tvm.testing.assert_allclose(c.asnumpy(), a.asnumpy(

[GitHub] [tvm] altanh commented on pull request #7731: [Relay][Pass] ConcretizeLike and EliminateIdentity Passes

2021-03-24 Thread GitBox
altanh commented on pull request #7731: URL: https://github.com/apache/tvm/pull/7731#issuecomment-806077018 @comaniac @mbrookhart I've merged them and updated the unit tests -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[GitHub] [tvm] csullivan commented on issue #7730: [Bug] Missing broadcast_to before batch_matmul for CuBLAS

2021-03-24 Thread GitBox
csullivan commented on issue #7730: URL: https://github.com/apache/tvm/issues/7730#issuecomment-806073946 Reasonable and doable for the short term. The downside being that it only fixes the problem for one target at a time. We would also need to add broadcast support to RocBLAS and CBLAS/M

[GitHub] [tvm] AndrewZhaoLuo commented on pull request #7722: [Topi, Relay] Add cumprod

2021-03-24 Thread GitBox
AndrewZhaoLuo commented on pull request #7722: URL: https://github.com/apache/tvm/pull/7722#issuecomment-806073342 @masahi PTAL. I've implemented all your suggested changes. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[GitHub] [tvm] areusch commented on pull request #7557: Clean up uTVM demo runtime, add ONNX model test and tutorial

2021-03-24 Thread GitBox
areusch commented on pull request #7557: URL: https://github.com/apache/tvm/pull/7557#issuecomment-806070247 @mdw-octoml please retrigger this against the CI, it should now be possible to make it pass as ci-qemu has the onnx package. -- This is an automated message from the Apache Git Se

[GitHub] [tvm] comaniac commented on issue #7730: [Bug] Missing broadcast_to before batch_matmul for CuBLAS

2021-03-24 Thread GitBox
comaniac commented on issue #7730: URL: https://github.com/apache/tvm/issues/7730#issuecomment-806069140 Another direction I can think of is adding the broadcast support in CuBLAS batch_matmul so that we could have a unified behavior of batch_matmul op in Relay, and we don't need to change

[GitHub] [tvm] areusch commented on a change in pull request #7653: Rename GraphRuntime to GraphExecutor

2021-03-24 Thread GitBox
areusch commented on a change in pull request #7653: URL: https://github.com/apache/tvm/pull/7653#discussion_r600763358 ## File path: apps/android_deploy/app/src/main/java/org/apache/tvm/android/demo/MainActivity.java ## @@ -224,108 +224,115 @@ protected void onPostExecute(Int

[GitHub] [tvm] areusch commented on pull request #7733: [crt] fix shift out of type bounds

2021-03-24 Thread GitBox
areusch commented on pull request #7733: URL: https://github.com/apache/tvm/pull/7733#issuecomment-806059563 thanks @rafzi, this change looks good to me. can you retrigger the CI by adding an empty commit? looks like it got stuck on task_rust. -- This is an automated message from the Apa

[tvm] branch main updated (63d8e97 -> cfe2e28)

2021-03-24 Thread areusch
This is an automated email from the ASF dual-hosted git repository. areusch pushed a change to branch main in repository https://gitbox.apache.org/repos/asf/tvm.git. from 63d8e97 [µTVM] Rev ci-qemu to 0.02 (Introduce onnx python dependency) (#7728) add cfe2e28 [crt] fix heap corrupti

[GitHub] [tvm] areusch merged pull request #7735: [crt] fix heap corruption from bad allocation

2021-03-24 Thread GitBox
areusch merged pull request #7735: URL: https://github.com/apache/tvm/pull/7735 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please con

[GitHub] [tvm] csullivan edited a comment on issue #7730: [Bug] Missing broadcast_to before batch_matmul for CuBLAS

2021-03-24 Thread GitBox
csullivan edited a comment on issue #7730: URL: https://github.com/apache/tvm/issues/7730#issuecomment-806052775 Thanks @comaniac @masahi. Yes the problem is that different targets, and target specific topi implementations, can support different optimizations. In the case of using the blas

[GitHub] [tvm] csullivan commented on issue #7730: [Bug] Missing broadcast_to before batch_matmul for CuBLAS

2021-03-24 Thread GitBox
csullivan commented on issue #7730: URL: https://github.com/apache/tvm/issues/7730#issuecomment-806052775 Thanks @comaniac @masahi. Yes the problem is that different targets, and target specific topi implementations, can support different optimizations. In the case of using the blas librar

[GitHub] [tvm] michalpiszczek opened a new pull request #7738: [AutoTVM] Catch cuda errors when using LocalRunner

2021-03-24 Thread GitBox
michalpiszczek opened a new pull request #7738: URL: https://github.com/apache/tvm/pull/7738 This block in `measure_methods.py` intended to capture CUDA errors caused by invalid kernels generated during AutoTuning: ```Python except TVMError as exc: msg = str(exc)

[GitHub] [tvm] mbrookhart commented on pull request #7731: [Relay][Pass] ConcretizeLike and EliminateIdentity Passes

2021-03-24 Thread GitBox
mbrookhart commented on pull request #7731: URL: https://github.com/apache/tvm/pull/7731#issuecomment-806029284 Yeah, as long as we aren't commonly manifesting full sized arrays of zero or one, that should be fine. Given the full/zeros/ones ops and their like counterparts, plus auto-broadc

[GitHub] [tvm] cnv1989 commented on a change in pull request #7653: Rename GraphRuntime to GraphExecutor

2021-03-24 Thread GitBox
cnv1989 commented on a change in pull request #7653: URL: https://github.com/apache/tvm/pull/7653#discussion_r600716290 ## File path: apps/android_deploy/app/src/main/java/org/apache/tvm/android/demo/MainActivity.java ## @@ -224,108 +224,115 @@ protected void onPostExecute(Int

[GitHub] [tvm] altanh commented on pull request #7731: [Relay][Pass] ConcretizeLike and EliminateIdentity Passes

2021-03-24 Thread GitBox
altanh commented on pull request #7731: URL: https://github.com/apache/tvm/pull/7731#issuecomment-806028276 Ah, well looks like this might only make sense for constants that only have one element, unless we want to loop over every single element and check that it is equal to 0 or 1. But if

[GitHub] [tvm] cnv1989 commented on a change in pull request #7653: Rename GraphRuntime to GraphExecutor

2021-03-24 Thread GitBox
cnv1989 commented on a change in pull request #7653: URL: https://github.com/apache/tvm/pull/7653#discussion_r600716290 ## File path: apps/android_deploy/app/src/main/java/org/apache/tvm/android/demo/MainActivity.java ## @@ -224,108 +224,115 @@ protected void onPostExecute(Int

[GitHub] [tvm] hogepodge commented on a change in pull request #7642: [docs] Getting Started With TVM: Tensor Expressions

2021-03-24 Thread GitBox
hogepodge commented on a change in pull request #7642: URL: https://github.com/apache/tvm/pull/7642#discussion_r600710517 ## File path: tutorials/get_started/tensor_expr_get_started.py ## @@ -255,41 +340,39 @@ fadd1(a, b, c) tvm.testing.assert_allclose(c.asnumpy(), a.asnumpy(

[GitHub] [tvm] altanh commented on pull request #7731: [Relay][Pass] ConcretizeLike and EliminateIdentity Passes

2021-03-24 Thread GitBox
altanh commented on pull request #7731: URL: https://github.com/apache/tvm/pull/7731#issuecomment-806019388 > I think I agree that merging these with SimplifyExpr would be a win in terms of our ability to control the order of execution. > > On the simplification of things like `x * c

[GitHub] [tvm] mbrookhart commented on pull request #7731: [Relay][Pass] ConcretizeLike and EliminateIdentity Passes

2021-03-24 Thread GitBox
mbrookhart commented on pull request #7731: URL: https://github.com/apache/tvm/pull/7731#issuecomment-806018953 It looks like you have a windows build issue? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL abo

[GitHub] [tvm] mbrookhart commented on pull request #7731: [Relay][Pass] ConcretizeLike and EliminateIdentity Passes

2021-03-24 Thread GitBox
mbrookhart commented on pull request #7731: URL: https://github.com/apache/tvm/pull/7731#issuecomment-806017937 I think I agree that merging these with SimplifyExpr would be a win in terms of our ability to control the order of execution. On the simplification of things like `x * con

[GitHub] [tvm] comaniac commented on pull request #7731: [Relay][Pass] ConcretizeLike and EliminateIdentity Passes

2021-03-24 Thread GitBox
comaniac commented on pull request #7731: URL: https://github.com/apache/tvm/pull/7731#issuecomment-806008203 If the purpose is just for testing, then I'll prefer to have them in a single pass. You can still test the pattern one-by-one as SimplifyExpr does now. Since the unrelated patterns

[GitHub] [tvm] altanh commented on pull request #7731: [Relay][Pass] ConcretizeLike and EliminateIdentity Passes

2021-03-24 Thread GitBox
altanh commented on pull request #7731: URL: https://github.com/apache/tvm/pull/7731#issuecomment-806004438 > Overall LGTM. Meanwhile I have some questions about the design: > > 1. It seems to me that ConcretizeLike and EliminateIdentity can also be merged to SImplifyExpr in term

[tvm] branch main updated (1fe0abc -> 63d8e97)

2021-03-24 Thread moreau
This is an automated email from the ASF dual-hosted git repository. moreau pushed a change to branch main in repository https://gitbox.apache.org/repos/asf/tvm.git. from 1fe0abc [TVMC] Python Scripting Init Files (#7698) add 63d8e97 [µTVM] Rev ci-qemu to 0.02 (Introduce onnx python de

[GitHub] [tvm] tmoreau89 commented on pull request #7728: [µTVM] Rev ci-qemu to 0.02 (Introduce onnx python dependency)

2021-03-24 Thread GitBox
tmoreau89 commented on pull request #7728: URL: https://github.com/apache/tvm/pull/7728#issuecomment-806002893 Thanks @mdw-octoml @areusch the PR has been merged -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [tvm] tmoreau89 merged pull request #7728: [µTVM] Rev ci-qemu to 0.02 (Introduce onnx python dependency)

2021-03-24 Thread GitBox
tmoreau89 merged pull request #7728: URL: https://github.com/apache/tvm/pull/7728 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please c

[GitHub] [tvm] altanh commented on a change in pull request #7731: [Relay][Pass] ConcretizeLike and EliminateIdentity Passes

2021-03-24 Thread GitBox
altanh commented on a change in pull request #7731: URL: https://github.com/apache/tvm/pull/7731#discussion_r600683869 ## File path: src/relay/transforms/simplify_expr.cc ## @@ -22,44 +22,37 @@ * \brief A pass for simplifying the Relay expression. */ +#include "simplify_e

[GitHub] [tvm] areusch commented on a change in pull request #7728: [µTVM] Rev ci-qemu to 0.02 (Introduce onnx python dependency)

2021-03-24 Thread GitBox
areusch commented on a change in pull request #7728: URL: https://github.com/apache/tvm/pull/7728#discussion_r600683088 ## File path: docker/Dockerfile.ci_qemu ## @@ -64,3 +64,7 @@ RUN bash /install/ubuntu_install_qemu.sh COPY install/ubuntu_install_zephyr.sh /install/ubuntu_i

[GitHub] [tvm] comaniac commented on pull request #7731: [Relay][Pass] ConcretizeLike and EliminateIdentity Passes

2021-03-24 Thread GitBox
comaniac commented on pull request #7731: URL: https://github.com/apache/tvm/pull/7731#issuecomment-805995681 Also cc @mbrookhart -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific co

[GitHub] [tvm] comaniac commented on a change in pull request #7731: [Relay][Pass] ConcretizeLike and EliminateIdentity Passes

2021-03-24 Thread GitBox
comaniac commented on a change in pull request #7731: URL: https://github.com/apache/tvm/pull/7731#discussion_r600673972 ## File path: src/relay/transforms/concretize_like.cc ## @@ -0,0 +1,182 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more con

[GitHub] [tvm] tqchen commented on pull request #7731: [Relay][Pass] ConcretizeLike and EliminateIdentity Passes

2021-03-24 Thread GitBox
tqchen commented on pull request #7731: URL: https://github.com/apache/tvm/pull/7731#issuecomment-805976301 cc @comaniac @yzhliu please help to review this PR -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL ab

[GitHub] [tvm] comaniac commented on issue #7732: [Bug][Auto-scheduler] generated cuda code

2021-03-24 Thread GitBox
comaniac commented on issue #7732: URL: https://github.com/apache/tvm/issues/7732#issuecomment-805973967 How many trials did you try and how did you apply the schedule from the log file? It's possible for auto-scheduler to generate invalid kernels during the tuning, but they shouldn't be p

[GitHub] [tvm] jwfromm commented on pull request #7698: [TVMC] Python Scripting Init Files

2021-03-24 Thread GitBox
jwfromm commented on pull request #7698: URL: https://github.com/apache/tvm/pull/7698#issuecomment-805949425 Thanks @CircleSpin @leandron and @comaniac. This is now merged. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[GitHub] [tvm] Hzfengsy opened a new pull request #7737: [TensorIR] Fix parser autocompletion mode

2021-03-24 Thread GitBox
Hzfengsy opened a new pull request #7737: URL: https://github.com/apache/tvm/pull/7737 This PR will fix the Script parser autocompletion mode and add checks for opaque blocks (which is not allowed now) Co-authored-by: Ruihang Lai cc @tqchen @junrushao1994 -- This is an au

[tvm] branch main updated (8131364 -> 1fe0abc)

2021-03-24 Thread jwfromm
This is an automated email from the ASF dual-hosted git repository. jwfromm pushed a change to branch main in repository https://gitbox.apache.org/repos/asf/tvm.git. from 8131364 [ONNX] Onnx node tests (#7720) add 1fe0abc [TVMC] Python Scripting Init Files (#7698) No new revisions we

[GitHub] [tvm] jwfromm merged pull request #7698: [TVMC] Python Scripting Init Files

2021-03-24 Thread GitBox
jwfromm merged pull request #7698: URL: https://github.com/apache/tvm/pull/7698 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please con

[GitHub] [tvm] euntaik opened a new pull request #7736: [frontend][tflite] float16 quant support

2021-03-24 Thread GitBox
euntaik opened a new pull request #7736: URL: https://github.com/apache/tvm/pull/7736 add float16 quant support for fc and transpose_conv -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the spec

[GitHub] [tvm] rafzi opened a new pull request #7735: [crt] fix heap corruption from bad allocation

2021-03-24 Thread GitBox
rafzi opened a new pull request #7735: URL: https://github.com/apache/tvm/pull/7735 The type of runtime->storage_pool was changed at some point from TVMNDArray to TVMGraphRuntimeStorageEntry. This change was not reflected in the call to the allocation for its buffer. If this unclaimed spac

[GitHub] [tvm] Wheest commented on pull request #6137: Better grouped convolution for CPU targets

2021-03-24 Thread GitBox
Wheest commented on pull request #6137: URL: https://github.com/apache/tvm/pull/6137#issuecomment-805772836 > @Wheest Seems you have wrong rebase. please refer this documentation : https://tvm.apache.org/docs/contribute/git_howto.html Believe I have fixed the rebase/commit problems,

[GitHub] [tvm] majercakdavid opened a new issue #7734: [Web] tvmjs runtime error when loading, missing "runtime.SystemLib"

2021-03-24 Thread GitBox
majercakdavid opened a new issue #7734: URL: https://github.com/apache/tvm/issues/7734 I would like to report a problem with the JS runtime. Currently when being run the instantiation of tvm run smoothly, not resulting in any error: ``` try { this.tvm = await tvmjs.instantiate(

[GitHub] [tvm] wxyhv commented on issue #4118: [RFC] Dynamic Shape Support - Graph Dispatching

2021-03-24 Thread GitBox
wxyhv commented on issue #4118: URL: https://github.com/apache/tvm/issues/4118#issuecomment-805659240 Dose any progress in dynamic input shape inference? I am expecting it -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and u

[GitHub] [tvm] zhuwenxi commented on pull request #7619: [BugFix] Fix the race condition issue of packed func. (#7246).

2021-03-24 Thread GitBox
zhuwenxi commented on pull request #7619: URL: https://github.com/apache/tvm/pull/7619#issuecomment-805634130 @tqchen Please take a look at my latest commit if you have time, thank you. -- This is an automated message from the Apache Git Service. To respond to the message, please log on t

[GitHub] [tvm] jroesch edited a comment on pull request #7518: [RFC]TECompiler: Staged refactor and removal of compile engine

2021-03-24 Thread GitBox
jroesch edited a comment on pull request #7518: URL: https://github.com/apache/tvm/pull/7518#issuecomment-805600377 cc @mbaret -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comme

[GitHub] [tvm] jroesch commented on pull request #7518: [RFC]TECompiler: Staged refactor and removal of compile engine

2021-03-24 Thread GitBox
jroesch commented on pull request #7518: URL: https://github.com/apache/tvm/pull/7518#issuecomment-805600377 cc @MatthewARM -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[GitHub] [tvm] jroesch commented on pull request #7518: [RFC]TECompiler: Staged refactor and removal of compile engine

2021-03-24 Thread GitBox
jroesch commented on pull request #7518: URL: https://github.com/apache/tvm/pull/7518#issuecomment-805594912 Modulo some left over polish work and documentation I think this is ready for review @icemelon9 @comaniac @csullivan @tkonolige @rkimball @junrushao1994 @areusch @mehrdadh -- Th

[GitHub] [tvm] jroesch commented on pull request #7518: [RFC]TECompiler: Staged refactor and removal of compile engine

2021-03-24 Thread GitBox
jroesch commented on pull request #7518: URL: https://github.com/apache/tvm/pull/7518#issuecomment-805594042 Need to port fix from #7703 but otherwise ready for review. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

[GitHub] [tvm] rafzi opened a new pull request #7733: [crt] fix shift out of type bounds

2021-03-24 Thread GitBox
rafzi opened a new pull request #7733: URL: https://github.com/apache/tvm/pull/7733 When running with "-fsanitize=undefined" I got the following error: tvm/src/runtime/crt/common/crt_runtime_api.c:213:32: runtime error: left shift of 32770 by 16 places cannot be represented in ty

[GitHub] [tvm] xiebaiyuan commented on issue #7705: build tvm failed with libbacktrace.a : ld: symbol(s) not found for architecture x86_64

2021-03-24 Thread GitBox
xiebaiyuan commented on issue #7705: URL: https://github.com/apache/tvm/issues/7705#issuecomment-805570369 config.log > This file contains any messages produced by compilers while running configure, to aid debugging if configure makes a mistake. It was created by

[GitHub] [tvm] xiebaiyuan commented on issue #7705: build tvm failed with libbacktrace.a : ld: symbol(s) not found for architecture x86_64

2021-03-24 Thread GitBox
xiebaiyuan commented on issue #7705: URL: https://github.com/apache/tvm/issues/7705#issuecomment-805563728 @tkonolige https://github.com/tkonolige/incubator-tvm/tree/fix_libbacktrace_macos USE_LIBBACKTRACE=On ➜ build git:(fix_libbacktrace_macos) cmake .. -- The C compiler i

  1   2   >