[GitHub] [tvm] CaptainDuke commented on pull request #7880: [BugFix]: Convert tuple to int

2021-04-23 Thread GitBox
CaptainDuke commented on pull request #7880: URL: https://github.com/apache/tvm/pull/7880#issuecomment-826020768 @tqchen @jcf94 I pushed a new commit again but CI for ARM failed once more. How could I pass this test in a easier way? ``` + docker/bash.sh tlcpack/ci-arm:v0.03

[GitHub] [tvm] mherkazandjian opened a new pull request #7917: allow libbacktrace to be used when cross compiling the runtime

2021-04-23 Thread GitBox
mherkazandjian opened a new pull request #7917: URL: https://github.com/apache/tvm/pull/7917 This PR fixes issue #7916 to build for aarch64 the cmake variable ``-DCMAKE_HOST=aarch64-linux-gnu`` should be passed that is in turn propagated to the autotools (configure step) for

[GitHub] [tvm] mherkazandjian opened a new issue #7916: libbacktrace does not inherit the CMAKE_C_COMPILER and CMAKE_CXX_COMPILER values of the top level project

2021-04-23 Thread GitBox
mherkazandjian opened a new issue #7916: URL: https://github.com/apache/tvm/issues/7916 This issue is a followup of the discussion in the following thread: https://discuss.tvm.apache.org/t/cross-compile-the-runtime-only-for-aarch64/9800 basically (just to minimize duplication of

[GitHub] [tvm] mehrdadh opened a new pull request #7915: [microTVM] Refactor zephyr installation

2021-04-23 Thread GitBox
mehrdadh opened a new pull request #7915: URL: https://github.com/apache/tvm/pull/7915 This PR: - Refactors zephyr project installation for RVM and CI to use the same script. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [tvm] gromero opened a new pull request #7914: [µTVM]: Zephyr: Add mps2_an521 board to the CI

2021-04-23 Thread GitBox
gromero opened a new pull request #7914: URL: https://github.com/apache/tvm/pull/7914 Since Arm reference board mps2_an521 is now added as a test platform to test µTVM with Zephyr and that test platform runs by default emulated, plus Zephyr docker images were updated to use Zephyr

[GitHub] [tvm] srinidhigoud commented on a change in pull request #7901: [Frontend][Tensorflow] SelectV2 and BroadcastArgs op support for tf2 models

2021-04-23 Thread GitBox
srinidhigoud commented on a change in pull request #7901: URL: https://github.com/apache/tvm/pull/7901#discussion_r619547983 ## File path: python/tvm/relay/frontend/tensorflow.py ## @@ -2833,6 +2872,7 @@ def _impl(inputs, attr, params, mod): "Round": AttrCvt("round"),

[GitHub] [tvm] srinidhigoud commented on a change in pull request #7901: [Frontend][Tensorflow] SelectV2 and BroadcastArgs op support for tf2 models

2021-04-23 Thread GitBox
srinidhigoud commented on a change in pull request #7901: URL: https://github.com/apache/tvm/pull/7901#discussion_r619547779 ## File path: python/tvm/relay/frontend/tensorflow.py ## @@ -1765,6 +1765,44 @@ def _impl(inputs, attr, params, mod): return _impl +def

[GitHub] [tvm] giuseros commented on pull request #7785: [AOT] Introducing AOT in TVM

2021-04-23 Thread GitBox
giuseros commented on pull request #7785: URL: https://github.com/apache/tvm/pull/7785#issuecomment-825992689 Hi @areusch , I reworked most of the comments except the ones concerning the stack allocator where the discussion is still going on -- This is an automated message from the

[GitHub] [tvm] giuseros commented on a change in pull request #7785: [AOT] Introducing AOT in TVM

2021-04-23 Thread GitBox
giuseros commented on a change in pull request #7785: URL: https://github.com/apache/tvm/pull/7785#discussion_r619541593 ## File path: src/runtime/crt/memory/stack_allocator.c ## @@ -16,17 +16,22 @@ * specific language governing permissions and limitations * under the

[GitHub] [tvm] tqchen commented on pull request #7895: [ConvertLayout] Keep span in ConvertLayout

2021-04-23 Thread GitBox
tqchen commented on pull request #7895: URL: https://github.com/apache/tvm/pull/7895#issuecomment-825990889 Thanks @lixiaoquan ! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[tvm] branch main updated (c7ac5ee -> 60c170e)

2021-04-23 Thread tqchen
This is an automated email from the ASF dual-hosted git repository. tqchen pushed a change to branch main in repository https://gitbox.apache.org/repos/asf/tvm.git. from c7ac5ee [µTVM] Clone Zephyr 2.5.0 from maintenance branch (#7891) add 60c170e [ConvertLayout] Keep span in

[GitHub] [tvm] tqchen merged pull request #7895: [ConvertLayout] Keep span in ConvertLayout

2021-04-23 Thread GitBox
tqchen merged pull request #7895: URL: https://github.com/apache/tvm/pull/7895 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please

[GitHub] [tvm] giuseros commented on pull request #7785: [AOT] Introducing AOT in TVM

2021-04-23 Thread GitBox
giuseros commented on pull request #7785: URL: https://github.com/apache/tvm/pull/7785#issuecomment-825989178 Hi @areusch , I addressed most of the comments except the stack_allocator. Let's discuss a bit more on the thread here -- This is an automated message from the Apache Git

[GitHub] [tvm-rfcs] tqchen edited a comment on pull request #2: [RFC] RFC Process Update

2021-04-23 Thread GitBox
tqchen edited a comment on pull request #2: URL: https://github.com/apache/tvm-rfcs/pull/2#issuecomment-825933735 One concern is the need to move RFC text around depending on its implementation status. In practice it would add additional maintainace overheads and also loses the history of

[GitHub] [tvm] areusch commented on a change in pull request #7902: [FIX,VM] Fix get_outputs on the vm with a single output

2021-04-23 Thread GitBox
areusch commented on a change in pull request #7902: URL: https://github.com/apache/tvm/pull/7902#discussion_r619499432 ## File path: src/runtime/vm/vm.cc ## @@ -142,11 +142,21 @@ PackedFunc VirtualMachine::GetFunction(const std::string& name, }); } else if (name ==

[GitHub] [tvm] tmoreau89 commented on pull request #7891: [µTVM] Clone Zephyr 2.5.0 from maintenance branch

2021-04-23 Thread GitBox
tmoreau89 commented on pull request #7891: URL: https://github.com/apache/tvm/pull/7891#issuecomment-825950385 Thank you @gromero @mehrdadh the PR has been merged -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

[tvm] branch main updated (4467a9c -> c7ac5ee)

2021-04-23 Thread moreau
This is an automated email from the ASF dual-hosted git repository. moreau pushed a change to branch main in repository https://gitbox.apache.org/repos/asf/tvm.git. from 4467a9c RelayTextPrinter is now non-recursive. ExpandDataflow refactored (#7817) add c7ac5ee [µTVM] Clone Zephyr

[GitHub] [tvm] tmoreau89 merged pull request #7891: [µTVM] Clone Zephyr 2.5.0 from maintenance branch

2021-04-23 Thread GitBox
tmoreau89 merged pull request #7891: URL: https://github.com/apache/tvm/pull/7891 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please

[GitHub] [tvm] mehrdadh commented on a change in pull request #7903: [Graph Executor Debugger] Fix parameter dump

2021-04-23 Thread GitBox
mehrdadh commented on a change in pull request #7903: URL: https://github.com/apache/tvm/pull/7903#discussion_r619518394 ## File path: src/runtime/graph_executor/debug/graph_executor_debug.cc ## @@ -208,25 +201,74 @@ class GraphExecutorDebug : public GraphExecutor { }

[GitHub] [tvm-rfcs] tqchen commented on pull request #2: [RFC] RFC Process Update

2021-04-23 Thread GitBox
tqchen commented on pull request #2: URL: https://github.com/apache/tvm-rfcs/pull/2#issuecomment-825933735 I think my main concern is the need to move RFC text around depending on its implementation status. In practice it would add additional maintainace overheads and also loses the

[GitHub] [tvm] zxybazh commented on a change in pull request #7809: [Target][Lowering] Update Op Intrinsic Lowering Mechanism And Intrinsic Lowering Pass

2021-04-23 Thread GitBox
zxybazh commented on a change in pull request #7809: URL: https://github.com/apache/tvm/pull/7809#discussion_r619494697 ## File path: src/tir/transforms/lower_intrin.cc ## @@ -42,28 +42,38 @@ class IntrinInjecter : public tvm::arith::IRMutatorWithAnalyzer {

[GitHub] [tvm] areusch commented on a change in pull request #7903: [Graph Executor Debugger] Fix parameter dump

2021-04-23 Thread GitBox
areusch commented on a change in pull request #7903: URL: https://github.com/apache/tvm/pull/7903#discussion_r619492054 ## File path: src/runtime/graph_executor/debug/graph_executor_debug.cc ## @@ -208,25 +201,74 @@ class GraphExecutorDebug : public GraphExecutor { }

[GitHub] [tvm] areusch commented on a change in pull request #7785: [AOT] Introducing AOT in TVM

2021-04-23 Thread GitBox
areusch commented on a change in pull request #7785: URL: https://github.com/apache/tvm/pull/7785#discussion_r619491548 ## File path: src/runtime/crt/memory/stack_allocator.c ## @@ -16,17 +16,22 @@ * specific language governing permissions and limitations * under the

[GitHub] [tvm-rfcs] hogepodge commented on pull request #2: [RFC] RFC Process Update

2021-04-23 Thread GitBox
hogepodge commented on pull request #2: URL: https://github.com/apache/tvm-rfcs/pull/2#issuecomment-825909082 @tqchen @jroesch I updated the process to more closely match the Rust process. A few comments on it: * I still kept it more lightweight than the Rust process. As a smaller

[GitHub] [tvm] altanh closed pull request #7416: [WIP][Relay][BBNF] Lift nodes used across scope for basic block normal form

2021-04-23 Thread GitBox
altanh closed pull request #7416: URL: https://github.com/apache/tvm/pull/7416 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please

[GitHub] [tvm] mbrookhart commented on pull request #7456: [QNN][TFLite] TFLite rounding mode support

2021-04-23 Thread GitBox
mbrookhart commented on pull request #7456: URL: https://github.com/apache/tvm/pull/7456#issuecomment-825867803 @FrozenGene Any chance you can rebase and fix CI? Thanks! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[GitHub] [tvm] mbrookhart edited a comment on pull request #7583: [Frontend][Tensorflow] dynamic support for StridedSlice

2021-04-23 Thread GitBox
mbrookhart edited a comment on pull request #7583: URL: https://github.com/apache/tvm/pull/7583#issuecomment-825867096 @wangxiang2713 Thanks for the contribution. Any chance you can get back to this? -- This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [tvm] mbrookhart commented on pull request #7583: [Frontend][Tensorflow] dynamic support for StridedSlice

2021-04-23 Thread GitBox
mbrookhart commented on pull request #7583: URL: https://github.com/apache/tvm/pull/7583#issuecomment-825867096 @wangxiang2713 Any chance you can get back to this? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[GitHub] [tvm] mbrookhart commented on a change in pull request #7817: RelayTextPrinter is now non-recursive. ExpandDataflow refactored

2021-04-23 Thread GitBox
mbrookhart commented on a change in pull request #7817: URL: https://github.com/apache/tvm/pull/7817#discussion_r612799914 ## File path: include/tvm/relay/expr_functor.h ## @@ -410,72 +414,82 @@ Expr PostOrderRewrite(const Expr& expr, ExprRewriter* rewriter); */ void

[GitHub] [tvm] mbrookhart commented on pull request #7817: RelayTextPrinter is now non-recursive. ExpandDataflow refactored

2021-04-23 Thread GitBox
mbrookhart commented on pull request #7817: URL: https://github.com/apache/tvm/pull/7817#issuecomment-825866449 Thanks @d-smirnov -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[tvm] branch main updated (0b24cbf -> 4467a9c)

2021-04-23 Thread mbrookhart
This is an automated email from the ASF dual-hosted git repository. mbrookhart pushed a change to branch main in repository https://gitbox.apache.org/repos/asf/tvm.git. from 0b24cbf Remove unnecessary bracelet around make_int (#7907) add 4467a9c RelayTextPrinter is now non-recursive.

[GitHub] [tvm] mbrookhart merged pull request #7817: RelayTextPrinter is now non-recursive. ExpandDataflow refactored

2021-04-23 Thread GitBox
mbrookhart merged pull request #7817: URL: https://github.com/apache/tvm/pull/7817 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please

[GitHub] [tvm] comaniac commented on a change in pull request #7901: [Frontend][Tensorflow] SelectV2 and BroadcastArgs op support for tf2 models

2021-04-23 Thread GitBox
comaniac commented on a change in pull request #7901: URL: https://github.com/apache/tvm/pull/7901#discussion_r619443233 ## File path: python/tvm/relay/frontend/tensorflow.py ## @@ -1765,6 +1765,44 @@ def _impl(inputs, attr, params, mod): return _impl +def

[GitHub] [tvm] zxybazh commented on pull request #7913: [TIR][SPIR-V] Fix computing clz on int64 input for vulkan

2021-04-23 Thread GitBox
zxybazh commented on pull request #7913: URL: https://github.com/apache/tvm/pull/7913#issuecomment-825851423 Looks good to me. Thanks for the quick fix! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [tvm] manupa-arm commented on a change in pull request #7785: [AOT] Introducing AOT in TVM

2021-04-23 Thread GitBox
manupa-arm commented on a change in pull request #7785: URL: https://github.com/apache/tvm/pull/7785#discussion_r619408979 ## File path: src/runtime/crt/memory/stack_allocator.c ## @@ -16,17 +16,22 @@ * specific language governing permissions and limitations * under the

[GitHub] [tvm] mehrdadh commented on a change in pull request #7903: [Graph Executor Debugger] Fix parameter dump

2021-04-23 Thread GitBox
mehrdadh commented on a change in pull request #7903: URL: https://github.com/apache/tvm/pull/7903#discussion_r619411388 ## File path: src/runtime/graph_executor/debug/graph_executor_debug.cc ## @@ -208,25 +201,74 @@ class GraphExecutorDebug : public GraphExecutor { }

[GitHub] [tvm] manupa-arm commented on a change in pull request #7785: [AOT] Introducing AOT in TVM

2021-04-23 Thread GitBox
manupa-arm commented on a change in pull request #7785: URL: https://github.com/apache/tvm/pull/7785#discussion_r619408979 ## File path: src/runtime/crt/memory/stack_allocator.c ## @@ -16,17 +16,22 @@ * specific language governing permissions and limitations * under the

[GitHub] [tvm] manupa-arm commented on a change in pull request #7785: [AOT] Introducing AOT in TVM

2021-04-23 Thread GitBox
manupa-arm commented on a change in pull request #7785: URL: https://github.com/apache/tvm/pull/7785#discussion_r619408979 ## File path: src/runtime/crt/memory/stack_allocator.c ## @@ -16,17 +16,22 @@ * specific language governing permissions and limitations * under the

[GitHub] [tvm] tqchen merged pull request #7907: Remove unnecessary bracket around make_int

2021-04-23 Thread GitBox
tqchen merged pull request #7907: URL: https://github.com/apache/tvm/pull/7907 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please

[GitHub] [tvm] tqchen commented on pull request #7907: Remove unnecessary bracket around make_int

2021-04-23 Thread GitBox
tqchen commented on pull request #7907: URL: https://github.com/apache/tvm/pull/7907#issuecomment-825819103 Thank you @ghostplant ! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [tvm] areusch commented on a change in pull request #7785: [AOT] Introducing AOT in TVM

2021-04-23 Thread GitBox
areusch commented on a change in pull request #7785: URL: https://github.com/apache/tvm/pull/7785#discussion_r619396774 ## File path: src/runtime/crt/memory/stack_allocator.c ## @@ -16,17 +16,22 @@ * specific language governing permissions and limitations * under the

[GitHub] [tvm] giuseros commented on a change in pull request #7785: [AOT] Introducing AOT in TVM

2021-04-23 Thread GitBox
giuseros commented on a change in pull request #7785: URL: https://github.com/apache/tvm/pull/7785#discussion_r619396142 ## File path: include/tvm/runtime/crt/stack_allocator.h ## @@ -0,0 +1,58 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more

[GitHub] [tvm] manupa-arm commented on a change in pull request #7785: [AOT] Introducing AOT in TVM

2021-04-23 Thread GitBox
manupa-arm commented on a change in pull request #7785: URL: https://github.com/apache/tvm/pull/7785#discussion_r619384477 ## File path: src/runtime/crt/memory/stack_allocator.c ## @@ -16,17 +16,22 @@ * specific language governing permissions and limitations * under the

[GitHub] [tvm] tkonolige commented on pull request #7902: [FIX,VM] Fix get_outputs on the vm with a single output

2021-04-23 Thread GitBox
tkonolige commented on pull request #7902: URL: https://github.com/apache/tvm/pull/7902#issuecomment-825803396 @areusch Can you review? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [tvm] areusch commented on a change in pull request #7785: [AOT] Introducing AOT in TVM

2021-04-23 Thread GitBox
areusch commented on a change in pull request #7785: URL: https://github.com/apache/tvm/pull/7785#discussion_r619380889 ## File path: src/runtime/crt/memory/stack_allocator.c ## @@ -16,17 +16,22 @@ * specific language governing permissions and limitations * under the

[GitHub] [tvm] giuseros commented on a change in pull request #7785: [AOT] Introducing AOT in TVM

2021-04-23 Thread GitBox
giuseros commented on a change in pull request #7785: URL: https://github.com/apache/tvm/pull/7785#discussion_r619379316 ## File path: src/runtime/crt/memory/stack_allocator.c ## @@ -16,17 +16,22 @@ * specific language governing permissions and limitations * under the

[GitHub] [tvm] areusch commented on a change in pull request #7903: [Graph Executor Debugger] Fix parameter dump

2021-04-23 Thread GitBox
areusch commented on a change in pull request #7903: URL: https://github.com/apache/tvm/pull/7903#discussion_r619374951 ## File path: src/runtime/graph_executor/debug/graph_executor_debug.cc ## @@ -282,17 +324,17 @@ class GraphExecutorDebug : public GraphExecutor { PackedFunc

[GitHub] [tvm] junrushao1994 commented on pull request #7913: [TIR][SPIR-V] Fix computing clz on int64 input for vulkan

2021-04-23 Thread GitBox
junrushao1994 commented on pull request #7913: URL: https://github.com/apache/tvm/pull/7913#issuecomment-825797041 Thanks Masa for the fix, and thanks Xiyou for reporting this issue :-) -- This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [tvm] manupa-arm commented on a change in pull request #7785: [AOT] Introducing AOT in TVM

2021-04-23 Thread GitBox
manupa-arm commented on a change in pull request #7785: URL: https://github.com/apache/tvm/pull/7785#discussion_r619372859 ## File path: src/runtime/crt/memory/stack_allocator.c ## @@ -16,17 +16,22 @@ * specific language governing permissions and limitations * under the

[tvm] branch main updated (373bac2 -> de0bff8)

2021-04-23 Thread jwfromm
This is an automated email from the ASF dual-hosted git repository. jwfromm pushed a change to branch main in repository https://gitbox.apache.org/repos/asf/tvm.git. from 373bac2 [Relay] Shape func fix for all_class_nms and where op (#7910) add de0bff8 [ONNX] Support importing Conv

[tvm] branch main updated (83baec3 -> 373bac2)

2021-04-23 Thread mbrookhart
This is an automated email from the ASF dual-hosted git repository. mbrookhart pushed a change to branch main in repository https://gitbox.apache.org/repos/asf/tvm.git. from 83baec3 Bring back GraphRuntimeFactory loader for now. (#7868) add 373bac2 [Relay] Shape func fix for

[GitHub] [tvm] jwfromm commented on pull request #7899: [ONNX] Support importing Conv with missing attributes

2021-04-23 Thread GitBox
jwfromm commented on pull request #7899: URL: https://github.com/apache/tvm/pull/7899#issuecomment-825793536 Thanks @mbrookhart! This is now merged. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [tvm] jwfromm merged pull request #7899: [ONNX] Support importing Conv with missing attributes

2021-04-23 Thread GitBox
jwfromm merged pull request #7899: URL: https://github.com/apache/tvm/pull/7899 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please

[GitHub] [tvm] mbrookhart commented on pull request #7910: [Relay] Shape func fix for all_class_nms and where op

2021-04-23 Thread GitBox
mbrookhart commented on pull request #7910: URL: https://github.com/apache/tvm/pull/7910#issuecomment-825793458 Thanks @masahi -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [tvm] mbrookhart merged pull request #7910: [Relay] Shape func fix for all_class_nms and where op

2021-04-23 Thread GitBox
mbrookhart merged pull request #7910: URL: https://github.com/apache/tvm/pull/7910 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please

[GitHub] [tvm] areusch commented on a change in pull request #7785: [AOT] Introducing AOT in TVM

2021-04-23 Thread GitBox
areusch commented on a change in pull request #7785: URL: https://github.com/apache/tvm/pull/7785#discussion_r619364867 ## File path: src/runtime/crt/memory/stack_allocator.c ## @@ -16,17 +16,22 @@ * specific language governing permissions and limitations * under the

[GitHub] [tvm] comaniac commented on a change in pull request #7898: [TE] Fix bug if find a loop in compute_at attach path

2021-04-23 Thread GitBox
comaniac commented on a change in pull request #7898: URL: https://github.com/apache/tvm/pull/7898#discussion_r619359694 ## File path: tests/python/unittest/test_te_schedule.py ## @@ -321,6 +321,33 @@ def test_legalize_invalid_attach(): assert isinstance(stmt,

[GitHub] [tvm] manupa-arm commented on a change in pull request #7785: [AOT] Introducing AOT in TVM

2021-04-23 Thread GitBox
manupa-arm commented on a change in pull request #7785: URL: https://github.com/apache/tvm/pull/7785#discussion_r619359010 ## File path: src/runtime/crt/memory/stack_allocator.c ## @@ -16,17 +16,22 @@ * specific language governing permissions and limitations * under the

[GitHub] [tvm] areusch commented on a change in pull request #7785: [AOT] Introducing AOT in TVM

2021-04-23 Thread GitBox
areusch commented on a change in pull request #7785: URL: https://github.com/apache/tvm/pull/7785#discussion_r619326998 ## File path: include/tvm/runtime/crt/stack_allocator.h ## @@ -0,0 +1,58 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more

[GitHub] [tvm] tqchen commented on a change in pull request #7897: Enable StackVM in AutoTVM

2021-04-23 Thread GitBox
tqchen commented on a change in pull request #7897: URL: https://github.com/apache/tvm/pull/7897#discussion_r619314060 ## File path: python/tvm/autotvm/measure/measure_methods.py ## @@ -485,9 +488,8 @@ def __call__(self, measure_input, tmp_dir, **kwargs): """

[GitHub] [tvm] gromero commented on pull request #7891: [µTVM] Clone Zephyr 2.5.0 from maintenance branch

2021-04-23 Thread GitBox
gromero commented on pull request #7891: URL: https://github.com/apache/tvm/pull/7891#issuecomment-825727145 @tmoreau89 Hi Thierry! I'm wondering if you could please collect that patch now CI is happy with it? -- This is an automated message from the Apache Git Service. To respond to

[GitHub] [tvm] PENGUINLIONG commented on a change in pull request #7897: Enable StackVM in AutoTVM

2021-04-23 Thread GitBox
PENGUINLIONG commented on a change in pull request #7897: URL: https://github.com/apache/tvm/pull/7897#discussion_r619219223 ## File path: python/tvm/autotvm/measure/measure_methods.py ## @@ -485,9 +488,8 @@ def __call__(self, measure_input, tmp_dir, **kwargs): """

[GitHub] [tvm] PENGUINLIONG commented on a change in pull request #7897: Enable StackVM in AutoTVM

2021-04-23 Thread GitBox
PENGUINLIONG commented on a change in pull request #7897: URL: https://github.com/apache/tvm/pull/7897#discussion_r619219223 ## File path: python/tvm/autotvm/measure/measure_methods.py ## @@ -485,9 +488,8 @@ def __call__(self, measure_input, tmp_dir, **kwargs): """

[GitHub] [tvm] tqchen commented on a change in pull request #7809: [Target][Lowering] Update Op Intrinsic Lowering Mechanism And Intrinsic Lowering Pass

2021-04-23 Thread GitBox
tqchen commented on a change in pull request #7809: URL: https://github.com/apache/tvm/pull/7809#discussion_r619199095 ## File path: src/tir/transforms/lower_intrin.cc ## @@ -42,28 +42,38 @@ class IntrinInjecter : public tvm::arith::IRMutatorWithAnalyzer {

[GitHub] [tvm] tqchen commented on a change in pull request #7809: [Target][Lowering] Update Op Intrinsic Lowering Mechanism And Intrinsic Lowering Pass

2021-04-23 Thread GitBox
tqchen commented on a change in pull request #7809: URL: https://github.com/apache/tvm/pull/7809#discussion_r619197339 ## File path: src/target/llvm/intrin_rule_llvm.cc ## @@ -25,155 +25,175 @@ #include "intrin_rule_llvm.h" #include +#include namespace tvm {

[GitHub] [tvm] tqchen commented on a change in pull request #7897: Enable StackVM in AutoTVM

2021-04-23 Thread GitBox
tqchen commented on a change in pull request #7897: URL: https://github.com/apache/tvm/pull/7897#discussion_r619192943 ## File path: python/tvm/autotvm/measure/measure_methods.py ## @@ -485,9 +488,8 @@ def __call__(self, measure_input, tmp_dir, **kwargs): """

[GitHub] [tvm] giuseros commented on pull request #7785: [AOT] Introducing AOT in TVM

2021-04-23 Thread GitBox
giuseros commented on pull request #7785: URL: https://github.com/apache/tvm/pull/7785#issuecomment-825603629 Hi @areusch , I worked on your suggestions, this is what I did: * Moved meta_data.h in include/tvm/runtime. This is to use the runtime::kTvmExecutor{Graph,Aot} also from

[GitHub] [tvm] jcf94 commented on a change in pull request #7898: [TE] Fix bug if find a loop in compute_at attach path

2021-04-23 Thread GitBox
jcf94 commented on a change in pull request #7898: URL: https://github.com/apache/tvm/pull/7898#discussion_r619056528 ## File path: tests/python/unittest/test_te_schedule.py ## @@ -321,6 +321,33 @@ def test_legalize_invalid_attach(): assert isinstance(stmt,

[GitHub] [tvm] jcf94 commented on a change in pull request #7898: [TE] Fix bug if find a loop in compute_at attach path

2021-04-23 Thread GitBox
jcf94 commented on a change in pull request #7898: URL: https://github.com/apache/tvm/pull/7898#discussion_r619056528 ## File path: tests/python/unittest/test_te_schedule.py ## @@ -321,6 +321,33 @@ def test_legalize_invalid_attach(): assert isinstance(stmt,

[GitHub] [tvm] masahi opened a new pull request #7913: [TIR][SPIR-V] Fix computing clz on int64 input for vulkan

2021-04-23 Thread GitBox
masahi opened a new pull request #7913: URL: https://github.com/apache/tvm/pull/7913 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service,