[GitHub] [tvm] Hzfengsy commented on a change in pull request #8017: [IR] Add storage scope to PointerType

Hzfengsy commented on a change in pull request #8017: URL: https://github.com/apache/tvm/pull/8017#discussion_r630691285 ## File path: src/ir/type.cc ## @@ -43,21 +43,26 @@ TVM_STATIC_IR_FUNCTOR(ReprPrinter, vtable) p->stream << node->dtype; });

[GitHub] [tvm] huochaitiantang commented on pull request #8007: [ONNX] QLinearConv Support

huochaitiantang commented on pull request #8007: URL: https://github.com/apache/tvm/pull/8007#issuecomment-839378881 @mbrookhart, thanks! The idea looks good, it could solve the issue! -- This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [tvm] Hzfengsy commented on pull request #7925: Add a 'rolling_buffer' scheduling primitive

Hzfengsy commented on pull request #7925: URL: https://github.com/apache/tvm/pull/7925#issuecomment-839377569 It would be great if you can fix CI errors before requesting reviewing :) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

[tvm] branch main updated (0f41d47 -> 21a7b49)

This is an automated email from the ASF dual-hosted git repository. jcf94 pushed a change to branch main in repository https://gitbox.apache.org/repos/asf/tvm.git. from 0f41d47 Remove minimum seed constraint on XGB Tuner (#7992) add 21a7b49 Explicitly set HardwareParams in

[GitHub] [tvm] jcf94 merged pull request #8018: Explicitly set HardwareParams in test_auto_scheduler_sketch_generation.

jcf94 merged pull request #8018: URL: https://github.com/apache/tvm/pull/8018 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please

[GitHub] [tvm] jwfromm opened a new pull request #8022: [Relay][AlterOpLayout] Fix strided slice type change.

jwfromm opened a new pull request #8022: URL: https://github.com/apache/tvm/pull/8022 The current alter_op function for `strided_slice` ends up recasting `begin` and `end` to `Int32` due that being the default dtype of new `Integer`s. However, some frontends like Onnx use the max value of

[GitHub] [tvm] mehrdadh opened a new pull request #8021: [Fix][microTVM] QEMU RPC issue

mehrdadh opened a new pull request #8021: URL: https://github.com/apache/tvm/pull/8021 This issue happens when we send a large tensor over RPC to the zephyr qemu target specially when it runs on a fast machine. We fixed the RPC large transfer size for microTVM at #7838, however, #7838

[GitHub] [tvm] mehrdadh opened a new pull request #8020: [Fix] CI QEMU Install libpython3.8

mehrdadh opened a new pull request #8020: URL: https://github.com/apache/tvm/pull/8020 The microtvm debug shell fails without `libpython3.8` when you test it with QEMU. I have built the ci_qemu with these changes and it passes `test_zephyr.py`. -- This is an automated message from

[GitHub] [tvm] areusch edited a comment on pull request #7970: Bumped Ubuntu version to 18.04 for ci_gpu

areusch edited a comment on pull request #7970: URL: https://github.com/apache/tvm/pull/7970#issuecomment-839198983 hi guys, sorry for the delay here. we (@tkonolige and i) are going to attempt to update to 18.04 as part of #7995. we'll patch this PR and rev all the dockerfiles to 18.04,

[GitHub] [tvm] areusch commented on pull request #7970: Bumped Ubuntu version to 18.04 for ci_gpu

areusch commented on pull request #7970: URL: https://github.com/apache/tvm/pull/7970#issuecomment-839198983 hi guys, sorry for the delay here. we (@tkonolige and i) are going to attempt to update to 18.04 as part of #7995. we'll patch this PR and rev all the dockerfiles to 18.04, then

[GitHub] [tvm] manupa-arm opened a new pull request #8019: Adding workspace byte alignment

manupa-arm opened a new pull request #8019: URL: https://github.com/apache/tvm/pull/8019 * This commit adds byte alignment support for workspaces * Updating AoT tests to use calculate workspaces -- This is an automated message from the Apache Git Service. To respond to the

[GitHub] [tvm] stoa commented on a change in pull request #7742: Contributing the STM32 port

stoa commented on a change in pull request #7742: URL: https://github.com/apache/tvm/pull/7742#discussion_r630528798 ## File path: src/runtime/stm32/graph_runtime.cc ## @@ -0,0 +1,529 @@ +/* Review comment: Hello, Andrew @areusch My concern is imposing to

[GitHub] [tvm] areusch opened a new pull request #8018: Explicitly set HardwareParams in test_auto_scheduler_sketch_generation.

areusch opened a new pull request #8018: URL: https://github.com/apache/tvm/pull/8018 * This test depended on the number of CPU cores available, and failed when cores < 4. @junrushao1994 @merrymercy -- This is an automated message from the Apache Git Service. To respond to

[GitHub] [tvm] tkonolige commented on a change in pull request #8016: [DOCKER,CI] Add PAPI to docker images

tkonolige commented on a change in pull request #8016: URL: https://github.com/apache/tvm/pull/8016#discussion_r630410201 ## File path: docker/install/ubuntu_install_papi.sh ## @@ -0,0 +1,36 @@ +#!/bin/bash +# Licensed to the Apache Software Foundation (ASF) under one +# or

[GitHub] [tvm] areusch commented on a change in pull request #8016: [DOCKER,CI] Add PAPI to docker images

areusch commented on a change in pull request #8016: URL: https://github.com/apache/tvm/pull/8016#discussion_r630407604 ## File path: docker/install/ubuntu_install_papi.sh ## @@ -0,0 +1,36 @@ +#!/bin/bash +# Licensed to the Apache Software Foundation (ASF) under one +# or more

[GitHub] [tvm] jroesch commented on pull request #7992: Remove minimum seed constraint on XGB Tuner

jroesch commented on pull request #7992: URL: https://github.com/apache/tvm/pull/7992#issuecomment-838895182 @comaniac @merrymercy thanks for reviewing! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[tvm] branch main updated: Remove minimum seed constraint on XGB Tuner (#7992)

This is an automated email from the ASF dual-hosted git repository. jroesch pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/tvm.git The following commit(s) were added to refs/heads/main by this push: new 0f41d47 Remove minimum seed constraint on XGB Tuner

[GitHub] [tvm] jroesch merged pull request #7992: Remove minimum seed constraint on XGB Tuner

jroesch merged pull request #7992: URL: https://github.com/apache/tvm/pull/7992 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please

[GitHub] [tvm] tqchen commented on pull request #8017: [IR] Add storage scope to PointerType

tqchen commented on pull request #8017: URL: https://github.com/apache/tvm/pull/8017#issuecomment-838853629 cc @vinx13 @Hzfengsy @spectrometerHBH -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [tvm] tqchen commented on a change in pull request #8017: [IR] Add storage scope to PointerType

tqchen commented on a change in pull request #8017: URL: https://github.com/apache/tvm/pull/8017#discussion_r630374761 ## File path: python/tvm/ir/type.py ## @@ -73,8 +73,8 @@ class PointerType(Type): The type of pointer's element. """ -def __init__(self,

[GitHub] [tvm] mbrookhart commented on pull request #8007: [ONNX] QLinearConv Support

mbrookhart commented on pull request #8007: URL: https://github.com/apache/tvm/pull/8007#issuecomment-838852619 Hmm, what do you think about checking to see if the scale is constant, and if it's not, doing dequantize -> quantize instead of requantize? -- This is an automated message

[GitHub] [tvm] tqchen commented on a change in pull request #8017: [IR] Add storage scope to PointerType

tqchen commented on a change in pull request #8017: URL: https://github.com/apache/tvm/pull/8017#discussion_r630374276 ## File path: include/tvm/ir/type.h ## @@ -175,8 +182,9 @@ class PointerType : public Type { /*! * \brief Constructor * \param element_type The

[GitHub] [tvm] csullivan opened a new pull request #8017: [IR] Add storage scope to PointerType

csullivan opened a new pull request #8017: URL: https://github.com/apache/tvm/pull/8017 Add storage scope into which a PointerType may address. Scope is global by default. The storage scope field can allow for specialization during lowering and codegen (e.g. when the kernel function

[GitHub] [tvm] tkonolige opened a new pull request #8016: [DOCKER,CI] Add PAPI to docker images

tkonolige opened a new pull request #8016: URL: https://github.com/apache/tvm/pull/8016 This is needed for #7983. @areusch @tqchen -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [tvm] tqchen commented on pull request #7917: allow libbacktrace to be used when cross compiling the runtime

tqchen commented on pull request #7917: URL: https://github.com/apache/tvm/pull/7917#issuecomment-838776952 gentle ping @mherkazandjian please follow up on the review comments and let us merge soon ! -- This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [tvm] leandron commented on pull request #7922: [TVMC] add the support of the cross compiler options

leandron commented on pull request #7922: URL: https://github.com/apache/tvm/pull/7922#issuecomment-838775235 > > > > The change looks OK to me. Apart from my comments below, is there a chance to add a test case for this PR? > > > > > > > > > I will do the update of the patch.

[tvm] branch main updated (b418ff8 -> c30f099)

This is an automated email from the ASF dual-hosted git repository. jwfromm pushed a change to branch main in repository https://gitbox.apache.org/repos/asf/tvm.git. from b418ff8 adding Manupa to reviewers (#8012) add c30f099 Fix bug with non-fp32 gemm in onnx frontend. (#8011) No

[GitHub] [tvm] jwfromm merged pull request #8011: [Relay][Frontend][Onnx] Fix bug with non-fp32 gemm in onnx frontend.

jwfromm merged pull request #8011: URL: https://github.com/apache/tvm/pull/8011 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please

[GitHub] [tvm] giuseros commented on pull request #7815: Naming of the AOT executor function

giuseros commented on pull request #7815: URL: https://github.com/apache/tvm/pull/7815#issuecomment-838498449 I am closing this, as we can decide naming on the name-mangling PR: #8014 -- This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [tvm] giuseros closed pull request #7815: Naming of the AOT executor function

giuseros closed pull request #7815: URL: https://github.com/apache/tvm/pull/7815 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please

[GitHub] [tvm] tqchen commented on pull request #7980: [METAL] Split kernels and compile them separately

tqchen commented on pull request #7980: URL: https://github.com/apache/tvm/pull/7980#issuecomment-838487632 cc @masahi @csullivan please help to review the PR -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [tvm] tqchen commented on a change in pull request #7980: [METAL] Split kernels and compile them separately

tqchen commented on a change in pull request #7980: URL: https://github.com/apache/tvm/pull/7980#discussion_r630173046 ## File path: src/runtime/metal/metal_module.mm ## @@ -71,6 +73,28 @@ void SaveToBinary(dmlc::Stream* stream) final { return ""; } } + +

[GitHub] [tvm] giuseros commented on a change in pull request #8014: [AOT] Name mangling in AOT

giuseros commented on a change in pull request #8014: URL: https://github.com/apache/tvm/pull/8014#discussion_r630169041 ## File path: tests/python/relay/aot/aot_test_utils.py ## @@ -55,28 +62,16 @@ def subprocess_with_stdout_and_log(cmd, cwd, logfile, stdout):

[GitHub] [tvm] giuseros commented on pull request #8014: [AOT] Name mangling in AOT

giuseros commented on pull request #8014: URL: https://github.com/apache/tvm/pull/8014#issuecomment-838480901 I marked the naming comments "resolved". The meaning is that we will discuss those on the RFC here: https://discuss.tvm.apache.org/t/mini-rfc-name-mangling-in-aot/ -- This is

[GitHub] [tvm] giuseros commented on a change in pull request #8014: [AOT] Name mangling in AOT

giuseros commented on a change in pull request #8014: URL: https://github.com/apache/tvm/pull/8014#discussion_r630167126 ## File path: python/tvm/relay/build_module.py ## @@ -145,7 +150,10 @@ def build(self, mod, target=None, target_host=None, params=None, executor="graph

[GitHub] [tvm] giuseros commented on a change in pull request #8014: [AOT] Name mangling in AOT

giuseros commented on a change in pull request #8014: URL: https://github.com/apache/tvm/pull/8014#discussion_r630166332 ## File path: python/tvm/micro/model_library_format.py ## @@ -55,17 +55,19 @@ def _populate_codegen_dir(mod, codegen_dir: str): mod_indices = {"lib":

[GitHub] [tvm] tqchen commented on a change in pull request #7711: [Texture support][Part 0] Device API and runtime support

tqchen commented on a change in pull request #7711: URL: https://github.com/apache/tvm/pull/7711#discussion_r630153926 ## File path: src/runtime/opencl/opencl_common.h ## @@ -289,6 +319,24 @@ class OpenCLThreadEntry { // get the global workspace static OpenCLThreadEntry*

[GitHub] [tvm] Mousius commented on a change in pull request #8014: [AOT] Name mangling in AOT

Mousius commented on a change in pull request #8014: URL: https://github.com/apache/tvm/pull/8014#discussion_r630137920 ## File path: include/tvm/runtime/module.h ## @@ -231,7 +231,7 @@ constexpr const char* tvm_param_prefix = "__tvm_param__"; /*! \brief A PackedFunc that

[GitHub] [tvm] ZihengJiang commented on pull request #7711: [Texture support][Part 0] Device API and runtime support

ZihengJiang commented on pull request #7711: URL: https://github.com/apache/tvm/pull/7711#issuecomment-838399646 LGTM. @tqchen, could you check whether the pr look good to you? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[GitHub] [tvm] leandron commented on pull request #8012: [COMMUNITY] New Reviewer -- Manupa Karunaratne

leandron commented on pull request #8012: URL: https://github.com/apache/tvm/pull/8012#issuecomment-838363044 Congratulations @manupa-arm Merged now @tmoreau89 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[tvm] branch main updated: adding Manupa to reviewers (#8012)

This is an automated email from the ASF dual-hosted git repository. leandron pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/tvm.git The following commit(s) were added to refs/heads/main by this push: new b418ff8 adding Manupa to reviewers (#8012) b418ff8

[GitHub] [tvm] leandron merged pull request #8012: [COMMUNITY] New Reviewer -- Manupa Karunaratne

leandron merged pull request #8012: URL: https://github.com/apache/tvm/pull/8012 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please

[GitHub] [tvm] manupa-arm commented on pull request #8012: [COMMUNITY] New Reviewer -- Manupa Karunaratne

manupa-arm commented on pull request #8012: URL: https://github.com/apache/tvm/pull/8012#issuecomment-838031551 > Congrats, Manupa :D Thanks! Cody and Thierry. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

[GitHub] [tvm] zotanika opened a new pull request #8015: [Caffe Frontend] adding Reduction op

zotanika opened a new pull request #8015: URL: https://github.com/apache/tvm/pull/8015 Thanks for contributing to TVM! Please refer to guideline https://tvm.apache.org/docs/contribute/ for useful information and tips. After the pull request is submitted, please request code reviews from