[GitHub] [tvm] YuchenJin commented on pull request #8825: refactor optimize GEMM on CPU tutorial

2021-08-25 Thread GitBox
YuchenJin commented on pull request #8825: URL: https://github.com/apache/tvm/pull/8825#issuecomment-906071746 Thank you @adstraw for your good work to improve this tutorial! As a side note, this tutorial and [Working with Operators Using Tensor

[GitHub] [tvm] YuchenJin commented on a change in pull request #8825: refactor optimize GEMM on CPU tutorial

2021-08-25 Thread GitBox
YuchenJin commented on a change in pull request #8825: URL: https://github.com/apache/tvm/pull/8825#discussion_r696266194 ## File path: tutorials/optimize/opt_gemm.py ## @@ -293,23 +300,26 @@ # Allocate write cache CC = s.cache_write(C, "global") -xo, yo, xi, yi =

[GitHub] [tvm] elvin-n commented on a change in pull request #8793: Enable python debug runtime for exported network libraries

2021-08-25 Thread GitBox
elvin-n commented on a change in pull request #8793: URL: https://github.com/apache/tvm/pull/8793#discussion_r696265207 ## File path: tests/python/unittest/test_runtime_module_based_interface.py ## @@ -90,6 +90,25 @@ def test_cpu(): tvm.testing.assert_allclose(out,

[GitHub] [tvm] csullivan commented on a change in pull request #8823: [Hexagon] Rework tvm.target.hexagon() interface

2021-08-25 Thread GitBox
csullivan commented on a change in pull request #8823: URL: https://github.com/apache/tvm/pull/8823#discussion_r696264693 ## File path: python/tvm/target/target.py ## @@ -413,79 +413,118 @@ def bifrost(model="unknown", options=None): return Target(" ".join(["opencl"] +

[GitHub] [tvm-rfcs] Meteorix commented on pull request #25: [RFC]PyTorchTVM

2021-08-25 Thread GitBox
Meteorix commented on pull request #25: URL: https://github.com/apache/tvm-rfcs/pull/25#issuecomment-906066691 > Is this supposed to be useful for accelerating PyTorch training? From my perspective, we are a little far from supporting PyTorch training. I can think of 2 possible

[tvm] branch jcf94-patch-1 updated (d056704 -> a324b32)

2021-08-25 Thread jcf94
This is an automated email from the ASF dual-hosted git repository. jcf94 pushed a change to branch jcf94-patch-1 in repository https://gitbox.apache.org/repos/asf/tvm.git. from d056704 Update test_arith_rewrite_simplify.py add a324b32 Update test_arith_rewrite_simplify.py No new

[tvm] branch jcf94-patch-1 updated (ed83401 -> d056704)

2021-08-25 Thread jcf94
This is an automated email from the ASF dual-hosted git repository. jcf94 pushed a change to branch jcf94-patch-1 in repository https://gitbox.apache.org/repos/asf/tvm.git. from ed83401 Update test_arith_rewrite_simplify.py add d056704 Update test_arith_rewrite_simplify.py No new

[tvm] branch jcf94-patch-1 updated (68c255c -> ed83401)

2021-08-25 Thread jcf94
This is an automated email from the ASF dual-hosted git repository. jcf94 pushed a change to branch jcf94-patch-1 in repository https://gitbox.apache.org/repos/asf/tvm.git. from 68c255c Update rewrite_simplify.cc add ed83401 Update test_arith_rewrite_simplify.py No new revisions

[tvm] 01/01: Update rewrite_simplify.cc

2021-08-25 Thread jcf94
This is an automated email from the ASF dual-hosted git repository. jcf94 pushed a commit to branch jcf94-patch-1 in repository https://gitbox.apache.org/repos/asf/tvm.git commit 68c255c7a45a71bfe7ff505a94f6db459b7b5847 Author: Chenfan AuthorDate: Thu Aug 26 11:15:07 2021 +0800 Update

[tvm] branch jcf94-patch-1 created (now 68c255c)

2021-08-25 Thread jcf94
This is an automated email from the ASF dual-hosted git repository. jcf94 pushed a change to branch jcf94-patch-1 in repository https://gitbox.apache.org/repos/asf/tvm.git. at 68c255c Update rewrite_simplify.cc This branch includes the following new commits: new 68c255c Update

[GitHub] [tvm] FrozenGene commented on a change in pull request #8808: [BYOC][TensorRT] Add TensorRT own int8 calibration support to TensorRT BYOC integration

2021-08-25 Thread GitBox
FrozenGene commented on a change in pull request #8808: URL: https://github.com/apache/tvm/pull/8808#discussion_r696234249 ## File path: src/runtime/contrib/tensorrt/tensorrt_runtime.cc ## @@ -66,7 +78,16 @@ class TensorRTRuntime : public JSONRuntimeBase {

[GitHub] [tvm] FrozenGene commented on a change in pull request #8808: [BYOC][TensorRT] Add TensorRT own int8 calibration support to TensorRT BYOC integration

2021-08-25 Thread GitBox
FrozenGene commented on a change in pull request #8808: URL: https://github.com/apache/tvm/pull/8808#discussion_r696234249 ## File path: src/runtime/contrib/tensorrt/tensorrt_runtime.cc ## @@ -66,7 +78,16 @@ class TensorRTRuntime : public JSONRuntimeBase {

[GitHub] [tvm] jcf94 commented on a change in pull request #8808: [BYOC][TensorRT] Add TensorRT own int8 calibration support to TensorRT BYOC integration

2021-08-25 Thread GitBox
jcf94 commented on a change in pull request #8808: URL: https://github.com/apache/tvm/pull/8808#discussion_r696218247 ## File path: src/runtime/contrib/tensorrt/tensorrt_runtime.cc ## @@ -125,17 +147,26 @@ class TensorRTRuntime : public JSONRuntimeBase { /*! \brief Run

[GitHub] [tvm] AndrewZhaoLuo commented on pull request #8850: [AMP] Bump up tolerance on flaky test

2021-08-25 Thread GitBox
AndrewZhaoLuo commented on pull request #8850: URL: https://github.com/apache/tvm/pull/8850#issuecomment-906011467 It actually failed 1/1000 times... Bumped up again and now 1000 runs pass -- This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [tvm] jcf94 commented on a change in pull request #8808: [BYOC][TensorRT] Add TensorRT own int8 calibration support to TensorRT BYOC integration

2021-08-25 Thread GitBox
jcf94 commented on a change in pull request #8808: URL: https://github.com/apache/tvm/pull/8808#discussion_r696218247 ## File path: src/runtime/contrib/tensorrt/tensorrt_runtime.cc ## @@ -125,17 +147,26 @@ class TensorRTRuntime : public JSONRuntimeBase { /*! \brief Run

[GitHub] [tvm] jcf94 commented on a change in pull request #8808: [BYOC][TensorRT] Add TensorRT own int8 calibration support to TensorRT BYOC integration

2021-08-25 Thread GitBox
jcf94 commented on a change in pull request #8808: URL: https://github.com/apache/tvm/pull/8808#discussion_r696218247 ## File path: src/runtime/contrib/tensorrt/tensorrt_runtime.cc ## @@ -125,17 +147,26 @@ class TensorRTRuntime : public JSONRuntimeBase { /*! \brief Run

[GitHub] [tvm] jcf94 commented on a change in pull request #8808: [BYOC][TensorRT] Add TensorRT own int8 calibration support to TensorRT BYOC integration

2021-08-25 Thread GitBox
jcf94 commented on a change in pull request #8808: URL: https://github.com/apache/tvm/pull/8808#discussion_r696225637 ## File path: src/runtime/contrib/tensorrt/tensorrt_runtime.cc ## @@ -66,7 +78,16 @@ class TensorRTRuntime : public JSONRuntimeBase {

[tvm] branch main updated (0648fff -> f1ca91d)

2021-08-25 Thread jwfromm
This is an automated email from the ASF dual-hosted git repository. jwfromm pushed a change to branch main in repository https://gitbox.apache.org/repos/asf/tvm.git. from 0648fff [BUG] ToBasicBlockNormalForm immutability (#8778) add f1ca91d [GRAPH EXECUTOR,VM] Add benchmarking

[GitHub] [tvm] jwfromm merged pull request #8807: [GRAPH EXECUTOR,VM] Add benchmarking function to graph executor and vm

2021-08-25 Thread GitBox
jwfromm merged pull request #8807: URL: https://github.com/apache/tvm/pull/8807 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [tvm] jcf94 commented on a change in pull request #8808: [BYOC][TensorRT] Add TensorRT own int8 calibration support to TensorRT BYOC integration

2021-08-25 Thread GitBox
jcf94 commented on a change in pull request #8808: URL: https://github.com/apache/tvm/pull/8808#discussion_r696218247 ## File path: src/runtime/contrib/tensorrt/tensorrt_runtime.cc ## @@ -125,17 +147,26 @@ class TensorRTRuntime : public JSONRuntimeBase { /*! \brief Run

[GitHub] [tvm] jcf94 commented on a change in pull request #8808: [BYOC][TensorRT] Add TensorRT own int8 calibration support to TensorRT BYOC integration

2021-08-25 Thread GitBox
jcf94 commented on a change in pull request #8808: URL: https://github.com/apache/tvm/pull/8808#discussion_r696218247 ## File path: src/runtime/contrib/tensorrt/tensorrt_runtime.cc ## @@ -125,17 +147,26 @@ class TensorRTRuntime : public JSONRuntimeBase { /*! \brief Run

[GitHub] [tvm] tmoreau89 commented on a change in pull request #8823: [Hexagon] Rework tvm.target.hexagon() interface

2021-08-25 Thread GitBox
tmoreau89 commented on a change in pull request #8823: URL: https://github.com/apache/tvm/pull/8823#discussion_r696212695 ## File path: python/tvm/target/target.py ## @@ -413,79 +413,118 @@ def bifrost(model="unknown", options=None): return Target(" ".join(["opencl"] +

[GitHub] [tvm] shingjan commented on pull request #8851: [AutoTVM] Use popenpool in local_executor

2021-08-25 Thread GitBox
shingjan commented on pull request #8851: URL: https://github.com/apache/tvm/pull/8851#issuecomment-905979559 @vinx13 just moved all testing utility functions of autotvm to `tvm.testing`. About `LocalFuture` and `LocalExecutor`, they do seem very much like `PopenPoolExecutor` now. Maybe

[GitHub] [tvm] tmoreau89 commented on pull request #8825: refactor optimize GEMM on CPU tutorial

2021-08-25 Thread GitBox
tmoreau89 commented on pull request #8825: URL: https://github.com/apache/tvm/pull/8825#issuecomment-905976858 Also @were and @yuruofeifei who were the original authors of the tutorial -- This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [tvm] tmoreau89 commented on a change in pull request #8825: refactor optimize GEMM on CPU tutorial

2021-08-25 Thread GitBox
tmoreau89 commented on a change in pull request #8825: URL: https://github.com/apache/tvm/pull/8825#discussion_r696207834 ## File path: tutorials/optimize/opt_gemm.py ## @@ -293,23 +300,26 @@ # Allocate write cache CC = s.cache_write(C, "global") -xo, yo, xi, yi =

[GitHub] [tvm] tmoreau89 commented on a change in pull request #8825: refactor optimize GEMM on CPU tutorial

2021-08-25 Thread GitBox
tmoreau89 commented on a change in pull request #8825: URL: https://github.com/apache/tvm/pull/8825#discussion_r696207437 ## File path: tutorials/optimize/opt_gemm.py ## @@ -335,24 +345,27 @@ CC = s.cache_write(C, "global") -xo, yo, xi, yi = s[C].tile(C.op.axis[0],

[GitHub] [tvm] tmoreau89 commented on a change in pull request #8825: refactor optimize GEMM on CPU tutorial

2021-08-25 Thread GitBox
tmoreau89 commented on a change in pull request #8825: URL: https://github.com/apache/tvm/pull/8825#discussion_r696207278 ## File path: tutorials/optimize/opt_gemm.py ## @@ -227,43 +228,49 @@

[GitHub] [tvm] vinx13 edited a comment on pull request #8851: [AutoTVM] Use popenpool in local_executor

2021-08-25 Thread GitBox
vinx13 edited a comment on pull request #8851: URL: https://github.com/apache/tvm/pull/8851#issuecomment-905971689 Similar to the fix you did for auto scheduler, `test_autotvm_executor` is not really a module and it shouldn't be imported. Anything common for tests should probably be moved

[GitHub] [tvm] tmoreau89 commented on a change in pull request #8825: refactor optimize GEMM on CPU tutorial

2021-08-25 Thread GitBox
tmoreau89 commented on a change in pull request #8825: URL: https://github.com/apache/tvm/pull/8825#discussion_r696206314 ## File path: tutorials/optimize/opt_gemm.py ## @@ -293,23 +300,26 @@ # Allocate write cache CC = s.cache_write(C, "global") -xo, yo, xi, yi =

[GitHub] [tvm] tmoreau89 commented on a change in pull request #8825: refactor optimize GEMM on CPU tutorial

2021-08-25 Thread GitBox
tmoreau89 commented on a change in pull request #8825: URL: https://github.com/apache/tvm/pull/8825#discussion_r696206243 ## File path: tutorials/optimize/opt_gemm.py ## @@ -227,43 +228,49 @@

[GitHub] [tvm] vinx13 commented on pull request #8851: [AutoTVM] Use popenpool in local_executor

2021-08-25 Thread GitBox
vinx13 commented on pull request #8851: URL: https://github.com/apache/tvm/pull/8851#issuecomment-905971689 Similar to the fix you did for auto scheduler, `test_autotvm_executor` is not really a module and it shouldn't be imported. Anything common for tests should probably be moved to

[GitHub] [tvm] shingjan edited a comment on pull request #8851: [AutoTVM] Use popenpool in local_executor

2021-08-25 Thread GitBox
shingjan edited a comment on pull request #8851: URL: https://github.com/apache/tvm/pull/8851#issuecomment-905970632 Author's note: 1. There is a weird `ModuleNotFoundError: No module named 'test_autotvm_executor'` during the execution of `test_autotvm_executor.py`. Still working

[GitHub] [tvm] shingjan commented on pull request #8851: [AutoTVM] Use popenpool in local_executor

2021-08-25 Thread GitBox
shingjan commented on pull request #8851: URL: https://github.com/apache/tvm/pull/8851#issuecomment-905970632 1. There is a weird `ModuleNotFoundError: No module named 'test_autotvm_executor'` during the execution of `test_autotvm_executor.py`. Still working on a fix. 2. The

[GitHub] [tvm] shingjan opened a new pull request #8851: [AutoTVM] Use popenpool in local_executor

2021-08-25 Thread GitBox
shingjan opened a new pull request #8851: URL: https://github.com/apache/tvm/pull/8851 This PR intends to replace `multiprocessing.pool` with `popenpool` in `autotvm/local_executor`. -- This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [tvm] mbs-octoml commented on pull request #8423: Implementation of relay_to_tir target hook

2021-08-25 Thread GitBox
mbs-octoml commented on pull request #8423: URL: https://github.com/apache/tvm/pull/8423#issuecomment-905945252 Ah, I think I see why -- #8849 (or parent thereof) bypasses LowerTE in favor of it's own transformation which calls out to compile_engine.py directly. -- This is an

[GitHub] [tvm] mbs-octoml commented on pull request #8423: Implementation of relay_to_tir target hook

2021-08-25 Thread GitBox
mbs-octoml commented on pull request #8423: URL: https://github.com/apache/tvm/pull/8423#issuecomment-905940632 I've started looking at #8849 and was surprised it's not depending on this extension point. I must have missed something? Anything I can do to help this one along? -- This is

[GitHub] [tvm] junrushao1994 commented on pull request #8850: [AMP] Bump up tolerance on flaky test

2021-08-25 Thread GitBox
junrushao1994 commented on pull request #8850: URL: https://github.com/apache/tvm/pull/8850#issuecomment-905936211 Would you mind running the tests for like 1k times using pytest-repeat and make sure the test is not flaky? -- This is an automated message from the Apache Git Service. To

[tvm] branch main updated (4a9b5b5 -> 0648fff)

2021-08-25 Thread junrushao
This is an automated email from the ASF dual-hosted git repository. junrushao pushed a change to branch main in repository https://gitbox.apache.org/repos/asf/tvm.git. from 4a9b5b5 Update CI Lint Image Version (#8841) add 0648fff [BUG] ToBasicBlockNormalForm immutability (#8778) No

[GitHub] [tvm] junrushao1994 commented on pull request #8778: [BUG] ToBasicBlockNormalForm immutability

2021-08-25 Thread GitBox
junrushao1994 commented on pull request #8778: URL: https://github.com/apache/tvm/pull/8778#issuecomment-905920923 Finally the CI is green! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [tvm] junrushao1994 merged pull request #8778: [BUG] ToBasicBlockNormalForm immutability

2021-08-25 Thread GitBox
junrushao1994 merged pull request #8778: URL: https://github.com/apache/tvm/pull/8778 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [tvm] trevor-m commented on a change in pull request #8808: [BYOC][TensorRT] Add TensorRT own int8 calibration support to TensorRT BYOC integration

2021-08-25 Thread GitBox
trevor-m commented on a change in pull request #8808: URL: https://github.com/apache/tvm/pull/8808#discussion_r695107832 ## File path: src/runtime/contrib/tensorrt/tensorrt_builder.cc ## @@ -238,14 +253,15 @@ void TensorRTBuilder::CleanUp() { #endif builder_->destroy();

[GitHub] [tvm] tqchen edited a comment on pull request #8847: [Pass] Make Module Pass always return a new IRModule

2021-08-25 Thread GitBox
tqchen edited a comment on pull request #8847: URL: https://github.com/apache/tvm/pull/8847#issuecomment-905909951 I think it was due to the fact that we are designing the Module to look like a mutable interface while in nature we want something immutable. As a result some of the passes

[GitHub] [tvm] tqchen commented on pull request #8847: [Pass] Make Module Pass always return a new IRModule

2021-08-25 Thread GitBox
tqchen commented on pull request #8847: URL: https://github.com/apache/tvm/pull/8847#issuecomment-905909951 I think it was due to the fact that we are designing the Module to look like a mutable interface while in nature we want something immutable. As a result some of the passes are

[tvm] branch main updated (5a6b75d -> 4a9b5b5)

2021-08-25 Thread moreau
This is an automated email from the ASF dual-hosted git repository. moreau pushed a change to branch main in repository https://gitbox.apache.org/repos/asf/tvm.git. from 5a6b75d [Pre-commit] Add pre-commit configuration to perform minimal checks locally (#8382) add 4a9b5b5 Update CI

[GitHub] [tvm] tmoreau89 merged pull request #8841: Update CI Lint Image Version

2021-08-25 Thread GitBox
tmoreau89 merged pull request #8841: URL: https://github.com/apache/tvm/pull/8841 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [tvm] csullivan commented on a change in pull request #8823: [Hexagon] Rework tvm.target.hexagon() interface

2021-08-25 Thread GitBox
csullivan commented on a change in pull request #8823: URL: https://github.com/apache/tvm/pull/8823#discussion_r696091607 ## File path: python/tvm/target/target.py ## @@ -413,79 +413,118 @@ def bifrost(model="unknown", options=None): return Target(" ".join(["opencl"] +

[GitHub] [tvm] AndrewZhaoLuo commented on pull request #8850: [AMP] Bump up tolerance on flaky test

2021-08-25 Thread GitBox
AndrewZhaoLuo commented on pull request #8850: URL: https://github.com/apache/tvm/pull/8850#issuecomment-905827889 @masahi -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[GitHub] [tvm] AndrewZhaoLuo opened a new pull request #8850: [AMP] Bump up tolerance on flaky test

2021-08-25 Thread GitBox
AndrewZhaoLuo opened a new pull request #8850: URL: https://github.com/apache/tvm/pull/8850 https://ci.tlcpack.ai/blue/organizations/jenkins/tvm/detail/PR-8810/3/pipeline <-- flakiness here -- This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [tvm] mbs-octoml commented on pull request #8835: Change target string to Target object in the TE compiler and interpreter

2021-08-25 Thread GitBox
mbs-octoml commented on pull request #8835: URL: https://github.com/apache/tvm/pull/8835#issuecomment-905810621 I'm fine with 1, and in the future: 4. Ensure all Targets are created at the top level and shared throughout the code rather than created on-the-fly for various 'default'

[GitHub] [tvm] guberti commented on pull request #8748: [microTVM][RVM] Add Arduino RVM

2021-08-25 Thread GitBox
guberti commented on pull request #8748: URL: https://github.com/apache/tvm/pull/8748#issuecomment-905798037 Thanks for the second round of comments Mehrdad! They should be addressed by 32882c4. -- This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [tvm] guberti commented on a change in pull request #8748: [microTVM][RVM] Add Arduino RVM

2021-08-25 Thread GitBox
guberti commented on a change in pull request #8748: URL: https://github.com/apache/tvm/pull/8748#discussion_r696031380 ## File path: apps/microtvm/reference-vm/arduino/Vagrantfile ## @@ -0,0 +1,66 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more

[GitHub] [tvm] guberti commented on a change in pull request #8748: [microTVM][RVM] Add Arduino RVM

2021-08-25 Thread GitBox
guberti commented on a change in pull request #8748: URL: https://github.com/apache/tvm/pull/8748#discussion_r695902185 ## File path: apps/microtvm/reference-vm/base-box-tool.py ## @@ -439,26 +473,27 @@ def parse_args(): "--provider", choices=ALL_PROVIDERS,

[GitHub] [tvm] guberti commented on a change in pull request #8748: [microTVM][RVM] Add Arduino RVM

2021-08-25 Thread GitBox
guberti commented on a change in pull request #8748: URL: https://github.com/apache/tvm/pull/8748#discussion_r695902185 ## File path: apps/microtvm/reference-vm/base-box-tool.py ## @@ -439,26 +473,27 @@ def parse_args(): "--provider", choices=ALL_PROVIDERS,

[tvm] branch main updated (a31ebf7 -> 5a6b75d)

2021-08-25 Thread tqchen
This is an automated email from the ASF dual-hosted git repository. tqchen pushed a change to branch main in repository https://gitbox.apache.org/repos/asf/tvm.git. from a31ebf7 [Hexagon] Reuse Hexagon SDK analysis across cmake files (#8822) add 5a6b75d [Pre-commit] Add pre-commit

[GitHub] [tvm] tqchen commented on pull request #8382: [Pre-commit] Add pre-commit configuration to perform minimal checks locally

2021-08-25 Thread GitBox
tqchen commented on pull request #8382: URL: https://github.com/apache/tvm/pull/8382#issuecomment-905781697 Thanks @mikepapadim ! This is now merged -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [tvm] tqchen merged pull request #8382: [Pre-commit] Add pre-commit configuration to perform minimal checks locally

2021-08-25 Thread GitBox
tqchen merged pull request #8382: URL: https://github.com/apache/tvm/pull/8382 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [tvm] comaniac commented on a change in pull request #8497: [Runtime] add set_output_zero_copy

2021-08-25 Thread GitBox
comaniac commented on a change in pull request #8497: URL: https://github.com/apache/tvm/pull/8497#discussion_r696007010 ## File path: tests/cpp/build_module_test.cc ## @@ -199,3 +199,129 @@ TEST(BuildModule, Heterogeneous) { ICHECK_LT(std::fabs(p_out[i] - (i + (i + 1.0)

[GitHub] [tvm] jverma-quic commented on a change in pull request #8773: Add support for QLinearMul ONNX op

2021-08-25 Thread GitBox
jverma-quic commented on a change in pull request #8773: URL: https://github.com/apache/tvm/pull/8773#discussion_r695992594 ## File path: python/tvm/relay/frontend/onnx.py ## @@ -3279,6 +3279,40 @@ def get_scalar(x, dtype="float32"): return _qnn.op.quantize(out,

[GitHub] [tvm] kparzysz-quic commented on a change in pull request #8823: [Hexagon] Rework tvm.target.hexagon() interface

2021-08-25 Thread GitBox
kparzysz-quic commented on a change in pull request #8823: URL: https://github.com/apache/tvm/pull/8823#discussion_r695984580 ## File path: python/tvm/target/target.py ## @@ -413,79 +413,118 @@ def bifrost(model="unknown", options=None): return Target(" ".join(["opencl"]

[GitHub] [tvm] manupa-arm opened a new pull request #8849: [5/6] Arm(R) Ethos(TM)-U NPU codegen integration

2021-08-25 Thread GitBox
manupa-arm opened a new pull request #8849: URL: https://github.com/apache/tvm/pull/8849 This commit integrates the codegen for Arm® Ethos™-U. * Adding Conv2D tests and a mobilenet_v1 conv2d offload test. This PR is blocked on merging #8795 , #8806 and #8811. Since this is built

[GitHub] [tvm] junrushao1994 commented on pull request #8835: Change target string to Target object in the TE compiler and interpreter

2021-08-25 Thread GitBox
junrushao1994 commented on pull request #8835: URL: https://github.com/apache/tvm/pull/8835#issuecomment-905745045 Hey Lily, I could imagine there are tons of challenges here and thank you for the really hard work! I feel like option 1 might be the most convenient way we could go

[GitHub] [tvm] zxybazh removed a comment on pull request #8823: [Hexagon] Rework tvm.target.hexagon() interface

2021-08-25 Thread GitBox
zxybazh removed a comment on pull request #8823: URL: https://github.com/apache/tvm/pull/8823#issuecomment-905732933 LGTM. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[GitHub] [tvm] zxybazh commented on pull request #8823: [Hexagon] Rework tvm.target.hexagon() interface

2021-08-25 Thread GitBox
zxybazh commented on pull request #8823: URL: https://github.com/apache/tvm/pull/8823#issuecomment-905732933 LGTM. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [tvm] csullivan commented on a change in pull request #8823: [Hexagon] Rework tvm.target.hexagon() interface

2021-08-25 Thread GitBox
csullivan commented on a change in pull request #8823: URL: https://github.com/apache/tvm/pull/8823#discussion_r695962970 ## File path: python/tvm/target/target.py ## @@ -413,79 +413,118 @@ def bifrost(model="unknown", options=None): return Target(" ".join(["opencl"] +

[GitHub] [tvm] ccjoechou opened a new issue #8848: pooling convert layout bug in pooling.cc and in test_pass_convert_op_layout.py?

2021-08-25 Thread GitBox
ccjoechou opened a new issue #8848: URL: https://github.com/apache/tvm/issues/8848 We are prototyping a BYOC flow and have a need to convert the layout of each nn.max_pool2d call in IR graph to use the attrs["layout"] = "NHWC" format. Based on our analysis, we found 2 possible issues

[GitHub] [tvm] sergey-grovety commented on issue #8717: Fusion of operations and cast in mobilenet v1 conv2d causing large feature maps

2021-08-25 Thread GitBox
sergey-grovety commented on issue #8717: URL: https://github.com/apache/tvm/issues/8717#issuecomment-905720857 Hello @Mousius, I would like to clarify something about the part of the problem related to casting to int16. Please look at

[GitHub] [tvm] electriclilies edited a comment on pull request #8835: Change target string to Target object in the TE compiler and interpreter

2021-08-25 Thread GitBox
electriclilies edited a comment on pull request #8835: URL: https://github.com/apache/tvm/pull/8835#issuecomment-905711627 @mbs-octoml I was doing a bit of debugging yesterday and saw that behavior too-- there are some cases where we try to look up a target that is LLVM CPU in a map but

[GitHub] [tvm] electriclilies commented on pull request #8835: Change target string to Target object in the TE compiler and interpreter

2021-08-25 Thread GitBox
electriclilies commented on pull request #8835: URL: https://github.com/apache/tvm/pull/8835#issuecomment-905711627 @mbs-octoml I was doing a bit of debugging yesterday and saw that behavior too-- there are some cases where we try to look up a target that is LLVM CPU in a map but we don't

[GitHub] [tvm] mbrookhart commented on a change in pull request #8773: Add support for QLinearMul ONNX op

2021-08-25 Thread GitBox
mbrookhart commented on a change in pull request #8773: URL: https://github.com/apache/tvm/pull/8773#discussion_r695939489 ## File path: python/tvm/relay/frontend/onnx.py ## @@ -3279,6 +3279,40 @@ def get_scalar(x, dtype="float32"): return _qnn.op.quantize(out,

[GitHub] [tvm] mehrdadh commented on pull request #8841: Update CI Lint Image Version

2021-08-25 Thread GitBox
mehrdadh commented on pull request #8841: URL: https://github.com/apache/tvm/pull/8841#issuecomment-905708492 @junrushao1994 sure, since this is almost done, I'll send a separate PR. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [tvm] jverma-quic commented on a change in pull request #8773: Add support for QLinearMul ONNX op

2021-08-25 Thread GitBox
jverma-quic commented on a change in pull request #8773: URL: https://github.com/apache/tvm/pull/8773#discussion_r695936244 ## File path: python/tvm/relay/frontend/onnx.py ## @@ -3279,6 +3279,40 @@ def get_scalar(x, dtype="float32"): return _qnn.op.quantize(out,

[GitHub] [tvm] tmoreau89 commented on issue #8842: [Test][Possible flaky test] QEMU timeout on zephyr test_relay

2021-08-25 Thread GitBox
tmoreau89 commented on issue #8842: URL: https://github.com/apache/tvm/issues/8842#issuecomment-905703540 Thanks for starting this issue @mehrdadh. For reference this happened in this PR. The issue was circumvented by re-triggering CI. Changes are likely unrelated to QEMU or uTVM

[GitHub] [tvm] tmoreau89 commented on pull request #8822: [Hexagon] Reuse Hexagon SDK analysis across cmake files

2021-08-25 Thread GitBox
tmoreau89 commented on pull request #8822: URL: https://github.com/apache/tvm/pull/8822#issuecomment-905702962 Flaky test issue is being tracked here: https://github.com/apache/tvm/issues/8842 -- This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [tvm] tmoreau89 commented on pull request #8822: [Hexagon] Reuse Hexagon SDK analysis across cmake files

2021-08-25 Thread GitBox
tmoreau89 commented on pull request #8822: URL: https://github.com/apache/tvm/pull/8822#issuecomment-905702785 Thank you @kparzysz-quic @tkonolige @Lunderberg - the PR has been merged -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

[tvm] branch main updated (977bdbd -> a31ebf7)

2021-08-25 Thread moreau
This is an automated email from the ASF dual-hosted git repository. moreau pushed a change to branch main in repository https://gitbox.apache.org/repos/asf/tvm.git. from 977bdbd Force CMake targets in top-level Makefile to run (#8840) add a31ebf7 [Hexagon] Reuse Hexagon SDK analysis

[GitHub] [tvm] tmoreau89 merged pull request #8822: [Hexagon] Reuse Hexagon SDK analysis across cmake files

2021-08-25 Thread GitBox
tmoreau89 merged pull request #8822: URL: https://github.com/apache/tvm/pull/8822 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [tvm] comaniac commented on a change in pull request #8843: [Pattern matching] Add an option to rewrite the graph only once

2021-08-25 Thread GitBox
comaniac commented on a change in pull request #8843: URL: https://github.com/apache/tvm/pull/8843#discussion_r695929809 ## File path: tests/python/relay/test_dataflow_pattern.py ## @@ -1793,3 +1825,4 @@ def test_partition_constant_embedding(): test_IfPattern()

[GitHub] [tvm] tmoreau89 commented on issue #8838: [Tracking Issue][ONNX] Quantized operator support in ONNX importer

2021-08-25 Thread GitBox
tmoreau89 commented on issue #8838: URL: https://github.com/apache/tvm/issues/8838#issuecomment-905696426 Adding @cconvey to the table who is working on `QLinearMatMul` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

[GitHub] [tvm] junrushao1994 commented on pull request #8841: Update CI Lint Image Version

2021-08-25 Thread GitBox
junrushao1994 commented on pull request #8841: URL: https://github.com/apache/tvm/pull/8841#issuecomment-905693422 hey would you mind also updating ci-cpu/gpu? Thanks a lot! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[GitHub] [tvm] hgt312 commented on pull request #8847: [Pass] Make Module Pass always return a new IRModule

2021-08-25 Thread GitBox
hgt312 commented on pull request #8847: URL: https://github.com/apache/tvm/pull/8847#issuecomment-905689897 The motivation is just to prevent processing one module with the same pass multiple times, it makes the result unexpected and I found that function pass always return a new Module.

[GitHub] [tvm] junrushao1994 commented on pull request #8847: [Pass] Make Module Pass always return a new IRModule

2021-08-25 Thread GitBox
junrushao1994 commented on pull request #8847: URL: https://github.com/apache/tvm/pull/8847#issuecomment-905680014 I am curious too. Isn’t copy-on-write good enough? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

[GitHub] [tvm] tkonolige commented on a change in pull request #8793: Enable python debug runtime for exported network libraries

2021-08-25 Thread GitBox
tkonolige commented on a change in pull request #8793: URL: https://github.com/apache/tvm/pull/8793#discussion_r695902578 ## File path: tests/python/unittest/test_runtime_module_based_interface.py ## @@ -90,6 +90,25 @@ def test_cpu(): tvm.testing.assert_allclose(out,

[GitHub] [tvm] guberti commented on a change in pull request #8748: [microTVM][RVM] Add Arduino RVM

2021-08-25 Thread GitBox
guberti commented on a change in pull request #8748: URL: https://github.com/apache/tvm/pull/8748#discussion_r695902185 ## File path: apps/microtvm/reference-vm/base-box-tool.py ## @@ -439,26 +473,27 @@ def parse_args(): "--provider", choices=ALL_PROVIDERS,

[tvm] branch main updated: Force CMake targets in top-level Makefile to run (#8840)

2021-08-25 Thread leandron
This is an automated email from the ASF dual-hosted git repository. leandron pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/tvm.git The following commit(s) were added to refs/heads/main by this push: new 977bdbd Force CMake targets in top-level Makefile

[GitHub] [tvm] leandron merged pull request #8840: Force CMake targets in top-level Makefile to run

2021-08-25 Thread GitBox
leandron merged pull request #8840: URL: https://github.com/apache/tvm/pull/8840 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [tvm] tqchen commented on pull request #8847: [Pass] Make Module Pass always return a new IRModule

2021-08-25 Thread GitBox
tqchen commented on pull request #8847: URL: https://github.com/apache/tvm/pull/8847#issuecomment-905589054 Thanks @hgt312 , may I ask the motivation of the change? The original intend of the code is that the pass should return a new module if necessary, but can perform copyon write

[GitHub] [tvm] Mousius commented on pull request #8835: Change target string to Target object in the TE compiler and interpreter

2021-08-25 Thread GitBox
Mousius commented on pull request #8835: URL: https://github.com/apache/tvm/pull/8835#issuecomment-905584474 Hmm, I picked on it calling into that block within `LowerTE` before the `shape_target` existed via this call: ``` std::pair> main_and_lowered =

[GitHub] [tvm] mbrookhart commented on a change in pull request #8845: Frontend: add onnx GlobalLpPool op

2021-08-25 Thread GitBox
mbrookhart commented on a change in pull request #8845: URL: https://github.com/apache/tvm/pull/8845#discussion_r695841609 ## File path: python/tvm/relay/frontend/onnx.py ## @@ -961,6 +961,18 @@ def _impl_v1(cls, inputs, attr, params): return _op.power(out, reci_p)

[GitHub] [tvm] kparzysz-quic commented on a change in pull request #8823: [Hexagon] Rework tvm.target.hexagon() interface

2021-08-25 Thread GitBox
kparzysz-quic commented on a change in pull request #8823: URL: https://github.com/apache/tvm/pull/8823#discussion_r695837217 ## File path: python/tvm/target/target.py ## @@ -413,79 +413,117 @@ def bifrost(model="unknown", options=None): return Target(" ".join(["opencl"]

[GitHub] [tvm] kparzysz-quic commented on a change in pull request #8823: [Hexagon] Rework tvm.target.hexagon() interface

2021-08-25 Thread GitBox
kparzysz-quic commented on a change in pull request #8823: URL: https://github.com/apache/tvm/pull/8823#discussion_r695835863 ## File path: python/tvm/target/target.py ## @@ -510,23 +548,27 @@ def validate_hvx_length(codegen_hvx, sim_args): + cpu_attr["post"]

[GitHub] [tvm] mbs-octoml commented on pull request #8835: Change target string to Target object in the TE compiler and interpreter

2021-08-25 Thread GitBox
mbs-octoml commented on pull request #8835: URL: https://github.com/apache/tvm/pull/8835#issuecomment-905573893 (3oz of coffee later) It will be the on-the-fly Target creation for the shape functions. By switching from String to Target we no longer implicitly identify distinct targets

[GitHub] [tvm] mbs-octoml commented on pull request #8835: Change target string to Target object in the TE compiler and interpreter

2021-08-25 Thread GitBox
mbs-octoml commented on pull request #8835: URL: https://github.com/apache/tvm/pull/8835#issuecomment-905558007 Are the hash and equality on Targets legit? Also, possibly relevant, there's a bit of hackery to force shape functions to end up on the 'cpu' target which is hard coded, so it

[GitHub] [tvm] Mousius commented on a change in pull request #8795: [2/6] Arm(R) Ethos(TM)-U NPU Relay passes and Conv2D op

2021-08-25 Thread GitBox
Mousius commented on a change in pull request #8795: URL: https://github.com/apache/tvm/pull/8795#discussion_r695768083 ## File path: python/tvm/relay/backend/contrib/ethosu/legalize.py ## @@ -0,0 +1,218 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or

[GitHub] [tvm-rfcs] u99127 commented on a change in pull request #11: [RFC] Arm Ethos-U Integration

2021-08-25 Thread GitBox
u99127 commented on a change in pull request #11: URL: https://github.com/apache/tvm-rfcs/pull/11#discussion_r695811906 ## File path: rfcs/0011_Arm_Ethos-U_Integration.md ## @@ -192,42 +191,42 @@ TVM_DLL int32_t ethosu_0(TVMValue* args, int* type_code, int num_args, TVMValue*

[GitHub] [tvm-rfcs] u99127 commented on a change in pull request #11: [RFC] Arm Ethos-U Integration

2021-08-25 Thread GitBox
u99127 commented on a change in pull request #11: URL: https://github.com/apache/tvm-rfcs/pull/11#discussion_r695811906 ## File path: rfcs/0011_Arm_Ethos-U_Integration.md ## @@ -192,42 +191,42 @@ TVM_DLL int32_t ethosu_0(TVMValue* args, int* type_code, int num_args, TVMValue*

[GitHub] [tvm] hgt312 opened a new pull request #8847: [Pass] Make Module Pass always return a new IRModule

2021-08-25 Thread GitBox
hgt312 opened a new pull request #8847: URL: https://github.com/apache/tvm/pull/8847 Thanks for contributing to TVM! Please refer to guideline https://tvm.apache.org/docs/contribute/ for useful information and tips. After the pull request is submitted, please request code reviews from

[GitHub] [tvm] mehrdadh opened a new pull request #8846: [microtvm][Zephyr] Increase timeout to fix flaky tests

2021-08-25 Thread GitBox
mehrdadh opened a new pull request #8846: URL: https://github.com/apache/tvm/pull/8846 This PR increases timeout to fix qemu flaky tests: https://github.com/apache/tvm/issues/8842 cc @Mousius @areusch @gromero -- This is an automated message from the Apache Git Service. To

[GitHub] [tvm] Lunderberg edited a comment on pull request #8840: Force CMake targets in top-level Makefile to run

2021-08-25 Thread GitBox
Lunderberg edited a comment on pull request #8840: URL: https://github.com/apache/tvm/pull/8840#issuecomment-905511312 Looks good to me, and thank you for the fix! Looks like I accidentally left that trap in #8317, since at the time none of the cmake rules produced a file with the same

[GitHub] [tvm] Mousius commented on a change in pull request #8833: [2/10] CMSIS-NN code generator for softmax

2021-08-25 Thread GitBox
Mousius commented on a change in pull request #8833: URL: https://github.com/apache/tvm/pull/8833#discussion_r695726706 ## File path: src/relay/backend/contrib/cmsisnn/codegen_cmsisnn.cc ## @@ -0,0 +1,199 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one +

[GitHub] [tvm] Lunderberg commented on pull request #8840: Force CMake targets in top-level Makefile to run

2021-08-25 Thread GitBox
Lunderberg commented on pull request #8840: URL: https://github.com/apache/tvm/pull/8840#issuecomment-905511312 Looks good to me, and thank you for the fix! Looks like I accidentally left that trap in #8317, since at the time none of the cmake rules produced a file with the same name as

  1   2   >