[GitHub] [tvm] mehrdadh opened a new pull request #8846: [microtvm][Zephyr] Increase timeout to fix flaky tests

2021-08-25 Thread GitBox
mehrdadh opened a new pull request #8846: URL: https://github.com/apache/tvm/pull/8846 This PR increases timeout to fix qemu flaky tests: https://github.com/apache/tvm/issues/8842 cc @Mousius @areusch @gromero -- This is an automated message from the Apache Git Service. To re

[GitHub] [tvm] Lunderberg edited a comment on pull request #8840: Force CMake targets in top-level Makefile to run

2021-08-25 Thread GitBox
Lunderberg edited a comment on pull request #8840: URL: https://github.com/apache/tvm/pull/8840#issuecomment-905511312 Looks good to me, and thank you for the fix! Looks like I accidentally left that trap in #8317, since at the time none of the cmake rules produced a file with the same na

[GitHub] [tvm] Mousius commented on a change in pull request #8833: [2/10] CMSIS-NN code generator for softmax

2021-08-25 Thread GitBox
Mousius commented on a change in pull request #8833: URL: https://github.com/apache/tvm/pull/8833#discussion_r695726706 ## File path: src/relay/backend/contrib/cmsisnn/codegen_cmsisnn.cc ## @@ -0,0 +1,199 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + *

[GitHub] [tvm] Lunderberg commented on pull request #8840: Force CMake targets in top-level Makefile to run

2021-08-25 Thread GitBox
Lunderberg commented on pull request #8840: URL: https://github.com/apache/tvm/pull/8840#issuecomment-905511312 Looks good to me, and thank you for the fix! Looks like I accidentally left that trap in #8317, since at the time none of the cmake rules produced a file with the same name as t

[GitHub] [tvm] mehrdadh edited a comment on pull request #8748: [microTVM][RVM] Add Arduino RVM

2021-08-25 Thread GitBox
mehrdadh edited a comment on pull request #8748: URL: https://github.com/apache/tvm/pull/8748#issuecomment-905432350 @guberti thanks for the fixes. Can you explain what does `platform-version` mean in the case of arduino? I think we need to document that in the help message. can you add fo

[GitHub] [tvm] mehrdadh commented on a change in pull request #8748: [microTVM][RVM] Add Arduino RVM

2021-08-25 Thread GitBox
mehrdadh commented on a change in pull request #8748: URL: https://github.com/apache/tvm/pull/8748#discussion_r695680883 ## File path: apps/microtvm/reference-vm/arduino/Vagrantfile ## @@ -0,0 +1,66 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more con

[GitHub] [tvm] mehrdadh edited a comment on pull request #8748: [microTVM][RVM] Add Arduino RVM

2021-08-25 Thread GitBox
mehrdadh edited a comment on pull request #8748: URL: https://github.com/apache/tvm/pull/8748#issuecomment-905432350 @guberti thanks for the fixes. Can you explain what does `platform-version` mean in the case of arduino? I think we need to document that in the README file for people who w

[GitHub] [tvm] mehrdadh commented on pull request #8748: [microTVM][RVM] Add Arduino RVM

2021-08-25 Thread GitBox
mehrdadh commented on pull request #8748: URL: https://github.com/apache/tvm/pull/8748#issuecomment-905432350 @guberti thanks for the fixes. Can you explain what does `platform-version` mean in the case of arduino? -- This is an automated message from the Apache Git Service. To respond t

[GitHub] [tvm] mehrdadh commented on a change in pull request #8748: [microTVM][RVM] Add Arduino RVM

2021-08-25 Thread GitBox
mehrdadh commented on a change in pull request #8748: URL: https://github.com/apache/tvm/pull/8748#discussion_r695677385 ## File path: apps/microtvm/reference-vm/base-box-tool.py ## @@ -439,26 +473,27 @@ def parse_args(): "--provider", choices=ALL_PROVIDERS,

[GitHub] [tvm] Mousius opened a new pull request #8844: Apply CPPLint to CRT Tests

2021-08-25 Thread GitBox
Mousius opened a new pull request #8844: URL: https://github.com/apache/tvm/pull/8844 This one was a bit trickier as there was more usage of dynamic arrays and less safe casts. I've tried to minimise the changes to just those required to passing linting. -- This is an automated mess

[GitHub] [tvm] ashutosh-arm commented on a change in pull request #8833: [2/10] CMSIS-NN code generator for softmax

2021-08-25 Thread GitBox
ashutosh-arm commented on a change in pull request #8833: URL: https://github.com/apache/tvm/pull/8833#discussion_r695640554 ## File path: python/tvm/relay/backend/contrib/cmsisnn/codegen.py ## @@ -0,0 +1,140 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# o

[GitHub] [tvm] ekalda commented on pull request #8843: [Pattern matching] Add an option to rewrite the graph only once

2021-08-25 Thread GitBox
ekalda commented on pull request #8843: URL: https://github.com/apache/tvm/pull/8843#issuecomment-905394703 @mbrookhart @mbaret -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comm

[GitHub] [tvm] Mousius commented on a change in pull request #8833: [2/10] CMSIS-NN code generator for softmax

2021-08-25 Thread GitBox
Mousius commented on a change in pull request #8833: URL: https://github.com/apache/tvm/pull/8833#discussion_r695636290 ## File path: python/tvm/relay/backend/contrib/cmsisnn/codegen.py ## @@ -0,0 +1,140 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or mor

[GitHub] [tvm] elvin-n commented on pull request #8793: Enable python debug runtime for exported network libraries

2021-08-25 Thread GitBox
elvin-n commented on pull request #8793: URL: https://github.com/apache/tvm/pull/8793#issuecomment-905394016 @tkonolige addressed comments -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the spe

[GitHub] [tvm] ashutosh-arm commented on a change in pull request #8833: [2/10] CMSIS-NN code generator for softmax

2021-08-25 Thread GitBox
ashutosh-arm commented on a change in pull request #8833: URL: https://github.com/apache/tvm/pull/8833#discussion_r695629688 ## File path: tests/python/contrib/test_cmsisnn/test_softmax.py ## @@ -0,0 +1,197 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or

[GitHub] [tvm] ashutosh-arm commented on a change in pull request #8833: [2/10] CMSIS-NN code generator for softmax

2021-08-25 Thread GitBox
ashutosh-arm commented on a change in pull request #8833: URL: https://github.com/apache/tvm/pull/8833#discussion_r695627499 ## File path: src/relay/backend/contrib/cmsisnn/codegen_cmsisnn.cc ## @@ -0,0 +1,215 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under on

[GitHub] [tvm] ekalda opened a new pull request #8843: [Pattern matching] Add an option to rewrite the graph only once

2021-08-25 Thread GitBox
ekalda opened a new pull request #8843: URL: https://github.com/apache/tvm/pull/8843 If the graph returned from the callback consists of the original pattern, the rewriter will run in the loop which is not always desired. So this patch proposes an option to run the rewriter only once.

[GitHub] [tvm] mehrdadh commented on pull request #8841: Update CI Lint Image Version

2021-08-25 Thread GitBox
mehrdadh commented on pull request #8841: URL: https://github.com/apache/tvm/pull/8841#issuecomment-905376239 cc @leandron @jroesch @junrushao1994 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go t

[GitHub] [tvm] mehrdadh opened a new issue #8842: [Test][Possible flaky test] QEMU timeout on zephyr test_relay

2021-08-25 Thread GitBox
mehrdadh opened a new issue #8842: URL: https://github.com/apache/tvm/issues/8842 https://ci.tlcpack.ai/blue/organizations/jenkins/tvm/detail/PR-8822/4/pipeline/#step-203-log-1971 ``` === FAILURES ===

[GitHub] [tvm] mehrdadh opened a new pull request #8841: Update CI Lint Image Version

2021-08-25 Thread GitBox
mehrdadh opened a new pull request #8841: URL: https://github.com/apache/tvm/pull/8841 Updating image version for this issue: https://github.com/apache/tvm/issues/8836 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[GitHub] [tvm] Mousius commented on pull request #8840: Force CMake targets in top-level Makefile to run

2021-08-25 Thread GitBox
Mousius commented on pull request #8840: URL: https://github.com/apache/tvm/pull/8840#issuecomment-905364710 @Lunderberg could you take a look at this please? :smile_cat: -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and u

[GitHub] [tvm] Mousius opened a new pull request #8840: Force CMake targets in top-level Makefile to run

2021-08-25 Thread GitBox
Mousius opened a new pull request #8840: URL: https://github.com/apache/tvm/pull/8840 This is a bug I introduced in https://github.com/apache/tvm/pull/8809, because the built binary is now named `build/cpptest` when `make` checks that artifact it finds it exists already and skips running `

[GitHub] [tvm] ashutosh-arm commented on a change in pull request #8833: [2/10] CMSIS-NN code generator for softmax

2021-08-25 Thread GitBox
ashutosh-arm commented on a change in pull request #8833: URL: https://github.com/apache/tvm/pull/8833#discussion_r695599788 ## File path: src/relay/backend/contrib/cmsisnn/codegen_cmsisnn.cc ## @@ -0,0 +1,215 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under on

[GitHub] [tvm] ashutosh-arm commented on a change in pull request #8833: [2/10] CMSIS-NN code generator for softmax

2021-08-25 Thread GitBox
ashutosh-arm commented on a change in pull request #8833: URL: https://github.com/apache/tvm/pull/8833#discussion_r695598599 ## File path: python/tvm/relay/backend/contrib/cmsisnn/codegen.py ## @@ -0,0 +1,140 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# o

[GitHub] [tvm] ashutosh-arm commented on a change in pull request #8833: [2/10] CMSIS-NN code generator for softmax

2021-08-25 Thread GitBox
ashutosh-arm commented on a change in pull request #8833: URL: https://github.com/apache/tvm/pull/8833#discussion_r695597658 ## File path: python/tvm/relay/backend/contrib/cmsisnn/codegen.py ## @@ -0,0 +1,140 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# o

[GitHub] [tvm] ashutosh-arm commented on a change in pull request #8833: [2/10] CMSIS-NN code generator for softmax

2021-08-25 Thread GitBox
ashutosh-arm commented on a change in pull request #8833: URL: https://github.com/apache/tvm/pull/8833#discussion_r695595860 ## File path: tests/python/contrib/test_cmsisnn/test_softmax.py ## @@ -0,0 +1,197 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or

[GitHub] [tvm] Mousius commented on pull request #8835: Change target string to Target object in the TE compiler and interpreter

2021-08-25 Thread GitBox
Mousius commented on pull request #8835: URL: https://github.com/apache/tvm/pull/8835#issuecomment-905352332 Hmm, something weird is occurring here, unsure why those tests didn't run for me locally - but debugging `test_any.py` a bit I ran `tvm::Dump(per_target_module_)` and got (removed f

[GitHub] [tvm] ashutosh-arm commented on a change in pull request #8833: [2/10] CMSIS-NN code generator for softmax

2021-08-25 Thread GitBox
ashutosh-arm commented on a change in pull request #8833: URL: https://github.com/apache/tvm/pull/8833#discussion_r695582274 ## File path: python/tvm/relay/backend/contrib/cmsisnn/codegen.py ## @@ -0,0 +1,140 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# o

[GitHub] [tvm] jcf94 commented on pull request #8777: [PyTorch][WIP]Add PyTorchTVM: compile torchscript to tvm and export as pytorch_op

2021-08-25 Thread GitBox
jcf94 commented on pull request #8777: URL: https://github.com/apache/tvm/pull/8777#issuecomment-905338556 Looks great! We have ever implemented a similar approach to put a optimized tvm graph runtime back to TensorFlow and Pytorch through custom ops. For some reason we're not able to s

[GitHub] [tvm] manupa-arm commented on a change in pull request #8795: [2/6] Arm(R) Ethos(TM)-U NPU Relay passes and Conv2D op

2021-08-25 Thread GitBox
manupa-arm commented on a change in pull request #8795: URL: https://github.com/apache/tvm/pull/8795#discussion_r695571625 ## File path: python/tvm/relay/op/contrib/ethosu.py ## @@ -0,0 +1,251 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contribut

[GitHub] [tvm-rfcs] masahi commented on pull request #25: [RFC]PyTorchTVM

2021-08-25 Thread GitBox
masahi commented on pull request #25: URL: https://github.com/apache/tvm-rfcs/pull/25#issuecomment-905322526 Is this supposed to be useful for accelerating PyTorch training? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[GitHub] [tvm] Meteorix commented on pull request #8777: [PyTorch][WIP]Add PyTorchTVM: compile torchscript to tvm and export as pytorch_op

2021-08-25 Thread GitBox
Meteorix commented on pull request #8777: URL: https://github.com/apache/tvm/pull/8777#issuecomment-905320199 Update: * RFC: https://github.com/apache/tvm-rfcs/pull/25 * discuss: https://discuss.tvm.apache.org/t/rfc-pytorchtvm-compile-torchscript-to-tvm-and-use-accelerated-module-in-p

[GitHub] [tvm] manupa-arm commented on a change in pull request #8795: [2/6] Arm(R) Ethos(TM)-U NPU Relay passes and Conv2D op

2021-08-25 Thread GitBox
manupa-arm commented on a change in pull request #8795: URL: https://github.com/apache/tvm/pull/8795#discussion_r695550561 ## File path: python/tvm/relay/backend/contrib/ethosu/util.py ## @@ -0,0 +1,198 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more

[GitHub] [tvm] masahi commented on pull request #8810: [AMP] Disallow fp16 conversion for summation-like ops

2021-08-25 Thread GitBox
masahi commented on pull request #8810: URL: https://github.com/apache/tvm/pull/8810#issuecomment-905289599 @AndrewZhaoLuo A possible flaky test from test_to_mixed_precision.py: `test_let_statement_simple` https://ci.tlcpack.ai/blue/organizations/jenkins/tvm/detail/PR-8810/3/pipeline

[GitHub] [tvm] masahi commented on pull request #8781: [Frontend] [Torch] [ONNX] GRU layer

2021-08-25 Thread GitBox
masahi commented on pull request #8781: URL: https://github.com/apache/tvm/pull/8781#issuecomment-905267004 Thanks @vvchernov -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific commen

[tvm] branch main updated: [Frontend] [Torch] [ONNX] GRU layer (#8781)

2021-08-25 Thread masahi
This is an automated email from the ASF dual-hosted git repository. masahi pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/tvm.git The following commit(s) were added to refs/heads/main by this push: new b819364 [Frontend] [Torch] [ONNX] GRU layer (#8781) b8

[GitHub] [tvm] masahi merged pull request #8781: [Frontend] [Torch] [ONNX] GRU layer

2021-08-25 Thread GitBox
masahi merged pull request #8781: URL: https://github.com/apache/tvm/pull/8781 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...

[GitHub] [tvm] junrushao1994 commented on pull request #8778: [BUG] ToBasicBlockNormalForm immutability

2021-08-25 Thread GitBox
junrushao1994 commented on pull request #8778: URL: https://github.com/apache/tvm/pull/8778#issuecomment-905245825 Yeah there is some flakiness in the CI -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above t

[GitHub] [tvm] manupa-arm commented on a change in pull request #8795: [2/6] Arm(R) Ethos(TM)-U NPU Relay passes and Conv2D op

2021-08-25 Thread GitBox
manupa-arm commented on a change in pull request #8795: URL: https://github.com/apache/tvm/pull/8795#discussion_r695440184 ## File path: tests/python/contrib/test_ethosu/test_legalize.py ## @@ -0,0 +1,345 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or mo

<    1   2