[GitHub] [tvm] luohao123 opened a new issue #9086: [Docs] tvmc call tensorrt partition command line

2021-09-22 Thread GitBox
luohao123 opened a new issue #9086: URL: https://github.com/apache/tvm/issues/9086 Does tvmc supports call tensorrt target compile for model generate on cuda? I currently tuning a model, the different hardware performance: CPU: 1s GPU (cuda): 200ms TensorRT: unknown

[GitHub] [tvm] jiangjiajun opened a new issue #9085: [CI Image] Update ci-cpu/gpu image

2021-09-22 Thread GitBox
jiangjiajun opened a new issue #9085: URL: https://github.com/apache/tvm/issues/9085 Thanks for participating in the TVM community! We use https://discuss.tvm.ai for any general usage questions and discussions. The issue tracker is used for actionable items such as feature proposals discus

[GitHub] [tvm] junrushao1994 commented on pull request #9082: [CI] Update ci environment

2021-09-22 Thread GitBox
junrushao1994 commented on pull request #9082: URL: https://github.com/apache/tvm/pull/9082#issuecomment-925526383 Would you mind opening a CI upgrade thread in the issues? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[GitHub] [tvm] areusch opened a new issue #9084: [CI Problem] flaky tests/python/unittest/test_crt.py::test_autotune on main

2021-09-22 Thread GitBox
areusch opened a new issue #9084: URL: https://github.com/apache/tvm/issues/9084 ### Branch/PR Failing main ### Jenkins Link https://ci.tlcpack.ai/blue/organizations/jenkins/tvm/detail/main/1759/pipeline ### Flakiness Have you seen this multiple times

[GitHub] [tvm] junrushao1994 commented on pull request #9082: [CI] Update ci environment

2021-09-22 Thread GitBox
junrushao1994 commented on pull request #9082: URL: https://github.com/apache/tvm/pull/9082#issuecomment-925489284 Let’s get it in quickly -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the spe

[GitHub] [tvm] jiangjiajun opened a new pull request #9083: Add TVMC Frontend for PaddlePaddle

2021-09-22 Thread GitBox
jiangjiajun opened a new pull request #9083: URL: https://github.com/apache/tvm/pull/9083 PaddlePaddle is supported to import by `relay.from_paddle`, this pull request implements a TVM frontend for paddlepaddle, to provide a more efficient way to users. This pull request has requir

[GitHub] [tvm] jiangjiajun opened a new pull request #9082: [CI] Update ci environment

2021-09-22 Thread GitBox
jiangjiajun opened a new pull request #9082: URL: https://github.com/apache/tvm/pull/9082 In this pull request, `docker/install/ubuntu_install_paddle.sh` is modified to upgrade `paddlepaddle` to version 2.1.3 which is released this month. Thanks for contributing to TVM! Please

[GitHub] [tvm] jiangjiajun closed pull request #9081: [CI] Update ci environment

2021-09-22 Thread GitBox
jiangjiajun closed pull request #9081: URL: https://github.com/apache/tvm/pull/9081 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubs

[GitHub] [tvm] jiangjiajun opened a new pull request #9081: [CI] Update ci environment

2021-09-22 Thread GitBox
jiangjiajun opened a new pull request #9081: URL: https://github.com/apache/tvm/pull/9081 In this pull request, `docker/install/ubuntu_install_paddle.sh` is modified to upgrade `paddlepaddle` to version 2.1.3 which is released this month. Thanks for contributing to TVM! Please

[GitHub] [tvm] junrushao1994 commented on a change in pull request #9041: [TensorIR][M2a] Decompose-Reduction

2021-09-22 Thread GitBox
junrushao1994 commented on a change in pull request #9041: URL: https://github.com/apache/tvm/pull/9041#discussion_r714278995 ## File path: src/tir/schedule/primitive/reduction.cc ## @@ -21,6 +21,289 @@ namespace tvm { namespace tir { +bool ListContainsElement(const Array&

[GitHub] [tvm] binarybana opened a new pull request #9080: Some rust cleanups

2021-09-22 Thread GitBox
binarybana opened a new pull request #9080: URL: https://github.com/apache/tvm/pull/9080 * Turn off default features for bindgen * Upgrade some deps for smaller total dep tree * Switch (/complete switch) to thiserror * Remove unnecessary transmutes Thanks for contributing

[GitHub] [tvm] junrushao1994 commented on pull request #9061: [Meta Schedule][M3c] Database

2021-09-22 Thread GitBox
junrushao1994 commented on pull request #9061: URL: https://github.com/apache/tvm/pull/9061#issuecomment-925428557 Per discussion with @comaniac. The naming change: - `lookup_or_add` seems pretty random, and we should rename it as `commit_workload` which is more consistent with da

[tvm] branch main updated (184a4ed -> a2bf430)

2021-09-22 Thread kparzysz
This is an automated email from the ASF dual-hosted git repository. kparzysz pushed a change to branch main in repository https://gitbox.apache.org/repos/asf/tvm.git. from 184a4ed [ONNX][Relay] Add dynamic unsqueeze / expand_dims op (#9039) add a2bf430 [Hexagon] Pytestify Hexagon unit

[GitHub] [tvm] kparzysz-quic merged pull request #8955: [Hexagon] Pytestify Hexagon unit test

2021-09-22 Thread GitBox
kparzysz-quic merged pull request #8955: URL: https://github.com/apache/tvm/pull/8955 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsu

[GitHub] [tvm] comaniac commented on pull request #9061: [Meta Schedule][M3c] Database

2021-09-22 Thread GitBox
comaniac commented on pull request #9061: URL: https://github.com/apache/tvm/pull/9061#issuecomment-925410911 Took a fast pass and had an offline discussion with @junrushao1994. Two major points: 1. The APIs are bit confusing (e.g.,`lookup_or_add` and `add`). It might be better to use

[GitHub] [tvm-rfcs] areusch commented on a change in pull request #23: [RFC][TIR] Adding annotation field to tir.allocate

2021-09-22 Thread GitBox
areusch commented on a change in pull request #23: URL: https://github.com/apache/tvm-rfcs/pull/23#discussion_r714367967 ## File path: rfcs/0023-adding-annotation-field-to-tir.allocate.md ## @@ -0,0 +1,201 @@ + +- Feature Name: Adding annotatation field to tir.allocate nodes +-

[GitHub] [tvm] zxybazh opened a new pull request #9079: [Meta Schedule][M3a] SpaceGenerator

2021-09-22 Thread GitBox
zxybazh opened a new pull request #9079: URL: https://github.com/apache/tvm/pull/9079 This PR is part of the stage M3a of the meta schedule project (#8473). The architecture is re-designed by Junru and Xiyou. `SpaceGenerator` is designed to generate design spaces in order to select m

[GitHub] [tvm-rfcs] tqchen edited a comment on pull request #23: [RFC][TIR] Adding annotation field to tir.allocate

2021-09-22 Thread GitBox
tqchen edited a comment on pull request #23: URL: https://github.com/apache/tvm-rfcs/pull/23#issuecomment-925354280 There is generally tradeoffs between: - A0: The desire to preserve information during transformation. - A1: A growing set of attributes that is impossible to keep track

[GitHub] [tvm-rfcs] tqchen commented on pull request #23: [RFC][TIR] Adding annotation field to tir.allocate

2021-09-22 Thread GitBox
tqchen commented on pull request #23: URL: https://github.com/apache/tvm-rfcs/pull/23#issuecomment-925354280 There is generally a tradeoff between the: - A0: The desire to preserve information during transformation. - A1: A growing set of attributes that is impossible to keep track of(

[GitHub] [tvm-rfcs] mbs-octoml commented on a change in pull request #23: [RFC][TIR] Adding annotation field to tir.allocate

2021-09-22 Thread GitBox
mbs-octoml commented on a change in pull request #23: URL: https://github.com/apache/tvm-rfcs/pull/23#discussion_r714300783 ## File path: rfcs/0023-adding-annotation-field-to-tir.allocate.md ## @@ -0,0 +1,201 @@ + +- Feature Name: Adding annotatation field to tir.allocate nodes

[GitHub] [tvm-rfcs] mbs-octoml commented on a change in pull request #23: [RFC][TIR] Adding annotation field to tir.allocate

2021-09-22 Thread GitBox
mbs-octoml commented on a change in pull request #23: URL: https://github.com/apache/tvm-rfcs/pull/23#discussion_r714300783 ## File path: rfcs/0023-adding-annotation-field-to-tir.allocate.md ## @@ -0,0 +1,201 @@ + +- Feature Name: Adding annotatation field to tir.allocate nodes

[GitHub] [tvm] tqchen closed issue #8632: [Frontend][ONNX] No support for `RandomUniform`

2021-09-22 Thread GitBox
tqchen closed issue #8632: URL: https://github.com/apache/tvm/issues/8632 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@tvm.

[tvm] branch main updated (a5f9e9b -> 184a4ed)

2021-09-22 Thread mbrookhart
This is an automated email from the ASF dual-hosted git repository. mbrookhart pushed a change to branch main in repository https://gitbox.apache.org/repos/asf/tvm.git. from a5f9e9b [AutoTVM, Auto scheduler] Always use VM compiler for task extraction (#9069) add 184a4ed [ONNX][Relay]

[GitHub] [tvm] mbrookhart merged pull request #9039: [ONNX][Relay] Add dynamic unsqueeze / expand_dims op

2021-09-22 Thread GitBox
mbrookhart merged pull request #9039: URL: https://github.com/apache/tvm/pull/9039 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubsc

[tvm] branch main updated (dd66bad -> a5f9e9b)

2021-09-22 Thread masahi
This is an automated email from the ASF dual-hosted git repository. masahi pushed a change to branch main in repository https://gitbox.apache.org/repos/asf/tvm.git. from dd66bad Ensure AOT passes all intermediary storages to function calls (#9064) add a5f9e9b [AutoTVM, Auto scheduler

[GitHub] [tvm] masahi merged pull request #9069: [AutoTVM, Auto scheduler] Always use VM compiler for task extraction

2021-09-22 Thread GitBox
masahi merged pull request #9069: URL: https://github.com/apache/tvm/pull/9069 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...

[GitHub] [tvm] AndrewZhaoLuo commented on a change in pull request #9063: [ONNX] [#8838] QLinearLeakyRelu contrib op

2021-09-22 Thread GitBox
AndrewZhaoLuo commented on a change in pull request #9063: URL: https://github.com/apache/tvm/pull/9063#discussion_r71423 ## File path: python/tvm/relay/frontend/onnx.py ## @@ -3430,6 +3430,25 @@ def _impl_v10(cls, inputs, attr, params): return _qnn.op.quantize(out

[GitHub] [tvm-rfcs] manupa-arm edited a comment on pull request #22: [RFC][TIR] TIR Non-scalar Constants

2021-09-22 Thread GitBox
manupa-arm edited a comment on pull request #22: URL: https://github.com/apache/tvm-rfcs/pull/22#issuecomment-925285527 Since we have relay.Constants having the same need to parse in constants, it would be appreciated not to block progress on deciding on the mechanics of parsing in NDArray

[GitHub] [tvm-rfcs] manupa-arm commented on pull request #22: [RFC][TIR] TIR Non-scalar Constants

2021-09-22 Thread GitBox
manupa-arm commented on pull request #22: URL: https://github.com/apache/tvm-rfcs/pull/22#issuecomment-925285527 Since we have relay.Constants having the same need to parse in constants, it would be appreciated not to block progress on deciding on the mechanics of parsing in NDArrays in to

[tvm] branch main updated (76d0534 -> dd66bad)

2021-09-22 Thread areusch
This is an automated email from the ASF dual-hosted git repository. areusch pushed a change to branch main in repository https://gitbox.apache.org/repos/asf/tvm.git. from 76d0534 [iOS] Add tracker support into ios-rpc application (#7876) add dd66bad Ensure AOT passes all intermediary

[GitHub] [tvm] areusch closed issue #9036: [Bug] [BYOC] AoT Codegen produces invalid packed function call for relay models using multi-output subgraphs

2021-09-22 Thread GitBox
areusch closed issue #9036: URL: https://github.com/apache/tvm/issues/9036 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@tvm

[GitHub] [tvm] areusch merged pull request #9064: Ensure AOT passes all intermediary storages to function calls

2021-09-22 Thread GitBox
areusch merged pull request #9064: URL: https://github.com/apache/tvm/pull/9064 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr..

[GitHub] [tvm] shashwat14 opened a new issue #9078: [Bug] Softmax in TFLite converter is channel first instead of channel last

2021-09-22 Thread GitBox
shashwat14 opened a new issue #9078: URL: https://github.com/apache/tvm/issues/9078 Compiled a TFLite toy model (conv + softmax) using TVM0.7 to generate a softmax output. ### Expected behavior The uint8 output distribution of the output should look something like (below is tflit

[GitHub] [tvm-rfcs] manupa-arm commented on a change in pull request #23: [RFC][TIR] Adding annotation field to tir.allocate

2021-09-22 Thread GitBox
manupa-arm commented on a change in pull request #23: URL: https://github.com/apache/tvm-rfcs/pull/23#discussion_r714264586 ## File path: rfcs/0023-adding-annotation-field-to-tir.allocate.md ## @@ -0,0 +1,201 @@ + +- Feature Name: Adding annotatation field to tir.allocate nodes

[GitHub] [tvm] mbs-octoml commented on a change in pull request #9038: [Relay] Merge analysis/context_analysis.cc and transforms/device_annotation.cc

2021-09-22 Thread GitBox
mbs-octoml commented on a change in pull request #9038: URL: https://github.com/apache/tvm/pull/9038#discussion_r714263722 ## File path: src/relay/transforms/device_planner.cc ## @@ -0,0 +1,1986 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more c

[GitHub] [tvm] AndrewZhaoLuo commented on issue #8632: [Frontend][ONNX] No support for `RandomUniform`

2021-09-22 Thread GitBox
AndrewZhaoLuo commented on issue #8632: URL: https://github.com/apache/tvm/issues/8632#issuecomment-925280695 @SamKG is this issue able to be closed? I believe this is implemented now. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [tvm] mbs-octoml opened a new pull request #9077: [Relay] Prepare for merging context_analysis.cc and device_annotation.cc in #9038

2021-09-22 Thread GitBox
mbs-octoml opened a new pull request #9077: URL: https://github.com/apache/tvm/pull/9077 - Improve construction and deconstruction of "on_device" and "device_copy" calls since they will be center stage. - Move "device_copy" support out of memory.h into own module to mirror "on_device".

[GitHub] [tvm-rfcs] junrushao1994 commented on pull request #22: [RFC][TIR] TIR Non-scalar Constants

2021-09-22 Thread GitBox
junrushao1994 commented on pull request #22: URL: https://github.com/apache/tvm-rfcs/pull/22#issuecomment-925275388 @areusch Thanks for the discussion! Yep, I agree with you that we need to address these points, and it's certainly doable under the current design. @manupa-arm would you like

[GitHub] [tvm-rfcs] areusch commented on a change in pull request #23: [RFC][TIR] Adding annotation field to tir.allocate

2021-09-22 Thread GitBox
areusch commented on a change in pull request #23: URL: https://github.com/apache/tvm-rfcs/pull/23#discussion_r714256669 ## File path: rfcs/0023-adding-annotation-field-to-tir.allocate.md ## @@ -0,0 +1,201 @@ + +- Feature Name: Adding annotatation field to tir.allocate nodes +-

[GitHub] [tvm] comaniac commented on pull request #9061: [Meta Schedule][M3c] Database

2021-09-22 Thread GitBox
comaniac commented on pull request #9061: URL: https://github.com/apache/tvm/pull/9061#issuecomment-925260955 Will try to find time reviewing this PR this afternoon or tomorrow. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[tvm] branch main updated (287ee40 -> 76d0534)

2021-09-22 Thread areusch
This is an automated email from the ASF dual-hosted git repository. areusch pushed a change to branch main in repository https://gitbox.apache.org/repos/asf/tvm.git. from 287ee40 [PYTHON][FFI] Speed Up get DataType (#9072) add 76d0534 [iOS] Add tracker support into ios-rpc application

[GitHub] [tvm] areusch merged pull request #7876: [iOS] Add tracker support into ios-rpc application

2021-09-22 Thread GitBox
areusch merged pull request #7876: URL: https://github.com/apache/tvm/pull/7876 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr..

[GitHub] [tvm] areusch commented on pull request #7876: [iOS] Add tracker support into ios-rpc application

2021-09-22 Thread GitBox
areusch commented on pull request #7876: URL: https://github.com/apache/tvm/pull/7876#issuecomment-925259356 and thanks @echuraev ! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific c

[GitHub] [tvm] echuraev commented on pull request #9032: [Auto-Schedule][Fix] Fix hang while tune model through rpc

2021-09-22 Thread GitBox
echuraev commented on pull request #9032: URL: https://github.com/apache/tvm/pull/9032#issuecomment-925246472 > Found some minor change needed Sorry, only now I saw that you added the comment in this PR. Thank you for the change. -- This is an automated message from the Apache Git

[tvm] branch main updated: [PYTHON][FFI] Speed Up get DataType (#9072)

2021-09-22 Thread tqchen
This is an automated email from the ASF dual-hosted git repository. tqchen pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/tvm.git The following commit(s) were added to refs/heads/main by this push: new 287ee40 [PYTHON][FFI] Speed Up get DataType (#9072) 28

[GitHub] [tvm] tqchen commented on pull request #9072: [PYTHON][FFI] Speed Up get DataType

2021-09-22 Thread GitBox
tqchen commented on pull request #9072: URL: https://github.com/apache/tvm/pull/9072#issuecomment-925242756 Thanks @wangxiang2713 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific co

[GitHub] [tvm] tqchen merged pull request #9072: [PYTHON][FFI] Speed Up get DataType

2021-09-22 Thread GitBox
tqchen merged pull request #9072: URL: https://github.com/apache/tvm/pull/9072 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...

[GitHub] [tvm-rfcs] areusch commented on pull request #22: [RFC][TIR] TIR Non-scalar Constants

2021-09-22 Thread GitBox
areusch commented on pull request #22: URL: https://github.com/apache/tvm-rfcs/pull/22#issuecomment-925226956 @junrushao1994 so the concern is embedding e.g. the output of `NDArray::repr` into TIR text format, correct? That makes sense to me. It seems like small tir.constant (e.g. perhaps

[GitHub] [tvm] junrushao1994 commented on pull request #9059: [Meta Schedule][M3c] Argument Info

2021-09-22 Thread GitBox
junrushao1994 commented on pull request #9059: URL: https://github.com/apache/tvm/pull/9059#issuecomment-925217443 Thanks @mbrookhart :-) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the spec

[GitHub] [tvm] mbrookhart commented on pull request #9059: [Meta Schedule][M3c] Argument Info

2021-09-22 Thread GitBox
mbrookhart commented on pull request #9059: URL: https://github.com/apache/tvm/pull/9059#issuecomment-925216501 Running late to the party, but this looks good to me :D Thanks! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub a

[GitHub] [tvm] junrushao1994 commented on pull request #9061: [Meta Schedule][M3c] Database

2021-09-22 Thread GitBox
junrushao1994 commented on pull request #9061: URL: https://github.com/apache/tvm/pull/9061#issuecomment-925210745 CC @comaniac @mbrookhart @jroesch @ZihengJiang -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the UR

[GitHub] [tvm] mbs-octoml commented on a change in pull request #9038: [Relay] Merge analysis/context_analysis.cc and transforms/device_annotation.cc

2021-09-22 Thread GitBox
mbs-octoml commented on a change in pull request #9038: URL: https://github.com/apache/tvm/pull/9038#discussion_r714222399 ## File path: tests/python/relay/test_pass_plan_devices.py ## @@ -0,0 +1,1405 @@ +# Licensed to the Apache Software Foundation (ASF) under one Review comm

[GitHub] [tvm-rfcs] areusch edited a comment on pull request #34: Wiring up the PrimFunc resource_handle

2021-09-22 Thread GitBox
areusch edited a comment on pull request #34: URL: https://github.com/apache/tvm-rfcs/pull/34#issuecomment-925204958 okay I've done a bit more research on this one. Here is one source of tension here: - at present, `tir.call_packed` codegens to `TVMFuncCall` and `TVMFuncCall` does not i

[GitHub] [tvm-rfcs] areusch commented on pull request #34: Wiring up the PrimFunc resource_handle

2021-09-22 Thread GitBox
areusch commented on pull request #34: URL: https://github.com/apache/tvm-rfcs/pull/34#issuecomment-925204958 okay I've done a bit more research on this one. Here is the thing causing tension here: - at present, `tir.call_packed` codegens to `TVMFuncCall` and `TVMFuncCall` does not in f

[GitHub] [tvm] junrushao1994 commented on pull request #9023: [TE] Support negative indices

2021-09-22 Thread GitBox
junrushao1994 commented on pull request #9023: URL: https://github.com/apache/tvm/pull/9023#issuecomment-925198606 Ah no worries! I’m not suggesting changes :-) just unittests -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub a

[GitHub] [tvm] AndrewZhaoLuo commented on pull request #9023: [TE] Support negative indices

2021-09-22 Thread GitBox
AndrewZhaoLuo commented on pull request #9023: URL: https://github.com/apache/tvm/pull/9023#issuecomment-925189236 > It looks good to me given we want to fully support numpy-style negative indexing. On the API side, although I still think we can put this as a helper function in topi instea

[GitHub] [tvm] sergey-grovety commented on pull request #8990: [microTVM] Update support for ARMv7m intrinsic

2021-09-22 Thread GitBox
sergey-grovety commented on pull request #8990: URL: https://github.com/apache/tvm/pull/8990#issuecomment-925143913 > @sergey-grovety i chatted with @u99127 and he indicated his preference is to use the ARM FVP to test these schedules. those platforms should properly support SMLAD intrinsi

[GitHub] [tvm-rfcs] mbs-octoml commented on pull request #29: Migrating Target Attributes to IRModule

2021-09-22 Thread GitBox
mbs-octoml commented on pull request #29: URL: https://github.com/apache/tvm-rfcs/pull/29#issuecomment-925141756 [sorry, finger flub, sent too early] @areusch Got it. Yes, the 'configuration' needs to be fully under the user's control. I think I'm suggesting we need to collect the

[GitHub] [tvm-rfcs] mbs-octoml removed a comment on pull request #29: Migrating Target Attributes to IRModule

2021-09-22 Thread GitBox
mbs-octoml removed a comment on pull request #29: URL: https://github.com/apache/tvm-rfcs/pull/29#issuecomment-925139196 @areusch Got it. Yes, the 'configuration' needs to be fully under the user's control. I think I'm suggesting My comments were about what convention we shou

[GitHub] [tvm-rfcs] mbs-octoml commented on pull request #29: Migrating Target Attributes to IRModule

2021-09-22 Thread GitBox
mbs-octoml commented on pull request #29: URL: https://github.com/apache/tvm-rfcs/pull/29#issuecomment-925139196 @areusch Got it. Yes, the 'configuration' needs to be fully under the user's control. I think I'm suggesting My comments were about what convention we should settl

[GitHub] [tvm] manupa-arm commented on a change in pull request #9065: Move the allocates of AoT codegen to be TVMBAWs

2021-09-22 Thread GitBox
manupa-arm commented on a change in pull request #9065: URL: https://github.com/apache/tvm/pull/9065#discussion_r714157805 ## File path: src/tir/transforms/lower_tvm_builtin.cc ## @@ -115,7 +115,8 @@ class BuiltinLower : public StmtExprMutator { int64_t nbytes = GetVectorB

[GitHub] [tvm-rfcs] mbs-octoml commented on a change in pull request #10: Additional Target Hooks RFC

2021-09-22 Thread GitBox
mbs-octoml commented on a change in pull request #10: URL: https://github.com/apache/tvm-rfcs/pull/10#discussion_r714143075 ## File path: rfcs/0010-target-registered-compiler-flow-customisation.md ## @@ -0,0 +1,186 @@ +- Feature Name: `Target` registered compiler flow customisa

[GitHub] [tvm] mbs-octoml commented on issue #9013: [Bug] tutorials do not build from a clean source tree

2021-09-22 Thread GitBox
mbs-octoml commented on issue #9013: URL: https://github.com/apache/tvm/issues/9013#issuecomment-925108438 https://github.com/apache/tvm/pull/9076 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [tvm] mbs-octoml opened a new pull request #9076: BUG #8013: Remove register_alter_op_layout example from dev/use_pass_infra.py

2021-09-22 Thread GitBox
mbs-octoml opened a new pull request #9076: URL: https://github.com/apache/tvm/pull/9076 This tutorial registers a global layout transformation for conv2d for all targets which is not well-formed. Later uses of conv2d in the tutorials pick that layout up then assert fail in the conv2d

[GitHub] [tvm] kparzysz-quic opened a new pull request #9075: [Relay] Fix compiler warning in ExtractOperators

2021-09-22 Thread GitBox
kparzysz-quic opened a new pull request #9075: URL: https://github.com/apache/tvm/pull/9075 Fix clang warning: ``` 'OperatorExtractorWrapper::VisitExpr_' hides overloaded virtual functions ``` -- This is an automated message from the Apache Git Service. To respond to the messag

[GitHub] [tvm] csullivan commented on a change in pull request #9065: Move the allocates of AoT codegen to be TVMBAWs

2021-09-22 Thread GitBox
csullivan commented on a change in pull request #9065: URL: https://github.com/apache/tvm/pull/9065#discussion_r714123160 ## File path: tests/python/relay/aot/test_crt_aot.py ## @@ -589,5 +590,41 @@ def test_memory_planning(workspace_byte_alignment, main_workspace_size, sum_wo

[GitHub] [tvm] areusch commented on issue #9013: [Bug] tutorials do not build from a clean source tree

2021-09-22 Thread GitBox
areusch commented on issue #9013: URL: https://github.com/apache/tvm/issues/9013#issuecomment-925096671 thanks for the detailed investigation @mbs-octoml ! I do think we should make the compiler work multiple times in a row. certainly our unit tests require this and we will expose a bunch

[GitHub] [tvm] areusch commented on pull request #9031: [CI] Prevent the complete Jenkins pipeline to run when files commited only to `/docs`

2021-09-22 Thread GitBox
areusch commented on pull request #9031: URL: https://github.com/apache/tvm/pull/9031#issuecomment-925095695 blocked again by #9013 . @mikepapadim you could retrigger and hope we get a different node for docs: GPU run or wait for that one to get fixed. -- This is an automated message fro

[GitHub] [tvm-rfcs] areusch commented on pull request #28: Command Line Composition from Internal Registry

2021-09-22 Thread GitBox
areusch commented on pull request #28: URL: https://github.com/apache/tvm-rfcs/pull/28#issuecomment-925094957 thanks @Mousius for raising this! a couple questions for you -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and us

[GitHub] [tvm-rfcs] areusch commented on a change in pull request #28: Command Line Composition from Internal Registry

2021-09-22 Thread GitBox
areusch commented on a change in pull request #28: URL: https://github.com/apache/tvm-rfcs/pull/28#discussion_r714108829 ## File path: rfcs/0028-command-line-registry-composition.md ## @@ -0,0 +1,153 @@ +- Feature Name: Command Line Composition from Internal Registry +- Start D

[GitHub] [tvm] comaniac commented on pull request #9069: [AutoTVM, Auto scheduler] Always use VM compiler for task extraction

2021-09-22 Thread GitBox
comaniac commented on pull request #9069: URL: https://github.com/apache/tvm/pull/9069#issuecomment-925090394 Ah you're right. The TE compiler refactoring introduced this issue and your fix makes perfect sense to me. Thanks! cc @jroesch -- This is an automated message from the Apache

[GitHub] [tvm] Mousius commented on a change in pull request #9074: Improve tvmc error message from lazy-loading frontend imports

2021-09-22 Thread GitBox
Mousius commented on a change in pull request #9074: URL: https://github.com/apache/tvm/pull/9074#discussion_r714114150 ## File path: tests/python/driver/tvmc/test_frontends.py ## @@ -211,3 +212,43 @@ def test_load_model___wrong_language__to_pytorch(tflite_mobilenet_v1_1_quant

[GitHub] [tvm] leandron commented on a change in pull request #9074: Improve tvmc error message from lazy-loading frontend imports

2021-09-22 Thread GitBox
leandron commented on a change in pull request #9074: URL: https://github.com/apache/tvm/pull/9074#discussion_r714110303 ## File path: tests/python/driver/tvmc/test_frontends.py ## @@ -211,3 +212,43 @@ def test_load_model___wrong_language__to_pytorch(tflite_mobilenet_v1_1_quan

[GitHub] [tvm] junrushao1994 commented on a change in pull request #9059: [Meta Schedule][M3c] Argument Info

2021-09-22 Thread GitBox
junrushao1994 commented on a change in pull request #9059: URL: https://github.com/apache/tvm/pull/9059#discussion_r713641056 ## File path: include/tvm/meta_schedule/arg_info.h ## @@ -0,0 +1,111 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more c

[tvm] branch main updated (8f39da1 -> 4c8531d)

2021-09-22 Thread junrushao
This is an automated email from the ASF dual-hosted git repository. junrushao pushed a change to branch main in repository https://gitbox.apache.org/repos/asf/tvm.git. from 8f39da1 Complete docs. (#9070) add 4c8531d [Meta Schedule][M3c] Argument Info (#9059) No new revisions were add

[GitHub] [tvm] junrushao1994 merged pull request #9059: [Meta Schedule][M3c] Argument Info

2021-09-22 Thread GitBox
junrushao1994 merged pull request #9059: URL: https://github.com/apache/tvm/pull/9059 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsu

[GitHub] [tvm] gayatripk1 commented on a change in pull request #9063: [ONNX] [#8838] QLinearLeakyRelu contrib op

2021-09-22 Thread GitBox
gayatripk1 commented on a change in pull request #9063: URL: https://github.com/apache/tvm/pull/9063#discussion_r714082477 ## File path: python/tvm/relay/frontend/onnx.py ## @@ -3430,6 +3430,25 @@ def _impl_v10(cls, inputs, attr, params): return _qnn.op.quantize(out, y

[GitHub] [tvm] vinx13 commented on a change in pull request #9032: [Auto-Schedule][Fix] Fix hang while tune model through rpc

2021-09-22 Thread GitBox
vinx13 commented on a change in pull request #9032: URL: https://github.com/apache/tvm/pull/9032#discussion_r714046563 ## File path: python/tvm/auto_scheduler/measure.py ## @@ -917,11 +918,11 @@ def _timed_eval_func( get_const_tuple(build_res_arg.shape)

[GitHub] [tvm-rfcs] Mousius commented on pull request #31: C Device API

2021-09-22 Thread GitBox
Mousius commented on pull request #31: URL: https://github.com/apache/tvm-rfcs/pull/31#issuecomment-925026402 @areusch I've updated this and replied to your comments, could you please take another look - I believe implementing this is now blocked on the `PrimFunc` discussion but we should

[GitHub] [tvm] vinx13 commented on a change in pull request #9032: [Auto-Schedule][Fix] Fix hang while tune model through rpc

2021-09-22 Thread GitBox
vinx13 commented on a change in pull request #9032: URL: https://github.com/apache/tvm/pull/9032#discussion_r714046563 ## File path: python/tvm/auto_scheduler/measure.py ## @@ -917,11 +918,11 @@ def _timed_eval_func( get_const_tuple(build_res_arg.shape)

[GitHub] [tvm-rfcs] gromero commented on a change in pull request #33: [RFC][Project API] Extend metadata in ProjectOption

2021-09-22 Thread GitBox
gromero commented on a change in pull request #33: URL: https://github.com/apache/tvm-rfcs/pull/33#discussion_r714034324 ## File path: rfcs/0020-project_api_extend_metadata.md ## @@ -0,0 +1,252 @@ +- Feature Name: extend_metadata_in_projectoption +- Start Date: 2021-09-09 +- RF

[GitHub] [tvm-rfcs] Mousius commented on a change in pull request #31: C Device API

2021-09-22 Thread GitBox
Mousius commented on a change in pull request #31: URL: https://github.com/apache/tvm-rfcs/pull/31#discussion_r714041951 ## File path: rfcs/0031-devices-api.md ## @@ -0,0 +1,363 @@ +- Feature Name: C Device API +- Start Date: 02-08-2021 +- RFC PR: [apache/tvm-rfcs#31](https://g

[GitHub] [tvm-rfcs] Mousius commented on a change in pull request #31: C Device API

2021-09-22 Thread GitBox
Mousius commented on a change in pull request #31: URL: https://github.com/apache/tvm-rfcs/pull/31#discussion_r714041246 ## File path: rfcs/0031-devices-api.md ## @@ -0,0 +1,363 @@ +- Feature Name: C Device API +- Start Date: 02-08-2021 +- RFC PR: [apache/tvm-rfcs#31](https://g

[GitHub] [tvm] sunshinemyson commented on pull request #9046: Support verisilicon's NPU with BYOC framework

2021-09-22 Thread GitBox
sunshinemyson commented on pull request #9046: URL: https://github.com/apache/tvm/pull/9046#issuecomment-925017754 > > > @sunshinemyson thanks for the PR. did an initial review. could you post up an RFC (eg. open a PR to github.com/apache/tvm-rfcs) or pre-RFC to discuss.tvm.ai givi

[GitHub] [tvm-rfcs] Mousius commented on a change in pull request #31: C Device API

2021-09-22 Thread GitBox
Mousius commented on a change in pull request #31: URL: https://github.com/apache/tvm-rfcs/pull/31#discussion_r714038407 ## File path: rfcs/0031-devices-api.md ## @@ -0,0 +1,363 @@ +- Feature Name: C Device API +- Start Date: 02-08-2021 +- RFC PR: [apache/tvm-rfcs#31](https://g

[GitHub] [tvm-rfcs] Mousius commented on a change in pull request #31: C Device API

2021-09-22 Thread GitBox
Mousius commented on a change in pull request #31: URL: https://github.com/apache/tvm-rfcs/pull/31#discussion_r714036291 ## File path: rfcs/0031-devices-api.md ## @@ -0,0 +1,363 @@ +- Feature Name: C Device API +- Start Date: 02-08-2021 +- RFC PR: [apache/tvm-rfcs#31](https://g

[GitHub] [tvm-rfcs] gromero commented on a change in pull request #33: [RFC][Project API] Extend metadata in ProjectOption

2021-09-22 Thread GitBox
gromero commented on a change in pull request #33: URL: https://github.com/apache/tvm-rfcs/pull/33#discussion_r714028366 ## File path: rfcs/0020-project_api_extend_metadata.md ## @@ -0,0 +1,252 @@ +- Feature Name: extend_metadata_in_projectoption +- Start Date: 2021-09-09 +- RF

[GitHub] [tvm-rfcs] Mousius commented on pull request #30: Command Line Configuration Files

2021-09-22 Thread GitBox
Mousius commented on pull request #30: URL: https://github.com/apache/tvm-rfcs/pull/30#issuecomment-924997826 Hi @areusch, thanks for your feedback! > I would welcome --config option to tvmc. I'm wondering if there are possibilities of providing PCB-level configs this way--hence my q

[GitHub] [tvm-rfcs] Mousius commented on a change in pull request #30: Command Line Configuration Files

2021-09-22 Thread GitBox
Mousius commented on a change in pull request #30: URL: https://github.com/apache/tvm-rfcs/pull/30#discussion_r714015416 ## File path: rfcs/0030-tvmc-comand-line-configuration-files.md ## @@ -0,0 +1,119 @@ +- Feature Name: Command Line Configuration Files +- Start Date: 2021-08

[GitHub] [tvm-rfcs] Mousius commented on a change in pull request #30: Command Line Configuration Files

2021-09-22 Thread GitBox
Mousius commented on a change in pull request #30: URL: https://github.com/apache/tvm-rfcs/pull/30#discussion_r714015215 ## File path: rfcs/0030-tvmc-comand-line-configuration-files.md ## @@ -0,0 +1,119 @@ +- Feature Name: Command Line Configuration Files +- Start Date: 2021-08

[GitHub] [tvm-rfcs] Mousius commented on a change in pull request #30: Command Line Configuration Files

2021-09-22 Thread GitBox
Mousius commented on a change in pull request #30: URL: https://github.com/apache/tvm-rfcs/pull/30#discussion_r714014999 ## File path: rfcs/0030-tvmc-comand-line-configuration-files.md ## @@ -0,0 +1,119 @@ +- Feature Name: Command Line Configuration Files +- Start Date: 2021-08

[GitHub] [tvm-rfcs] Mousius commented on a change in pull request #30: Command Line Configuration Files

2021-09-22 Thread GitBox
Mousius commented on a change in pull request #30: URL: https://github.com/apache/tvm-rfcs/pull/30#discussion_r714014716 ## File path: rfcs/0030-tvmc-comand-line-configuration-files.md ## @@ -0,0 +1,119 @@ +- Feature Name: Command Line Configuration Files +- Start Date: 2021-08

[GitHub] [tvm] stoa commented on a change in pull request #7742: Contributing the STM32 port

2021-09-22 Thread GitBox
stoa commented on a change in pull request #7742: URL: https://github.com/apache/tvm/pull/7742#discussion_r713992580 ## File path: python/tvm/contrib/stm32/emitter.py ## @@ -0,0 +1,1618 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor lice

[GitHub] [tvm] stoa commented on a change in pull request #7742: Contributing the STM32 port

2021-09-22 Thread GitBox
stoa commented on a change in pull request #7742: URL: https://github.com/apache/tvm/pull/7742#discussion_r713992109 ## File path: python/tvm/micro/contrib/stm32/emitter.py ## @@ -0,0 +1,1643 @@ +# Licensed to the Apache Software Foundation (ASF) under one Review comment:

[GitHub] [tvm] stoa commented on a change in pull request #7742: Contributing the STM32 port

2021-09-22 Thread GitBox
stoa commented on a change in pull request #7742: URL: https://github.com/apache/tvm/pull/7742#discussion_r713991503 ## File path: src/runtime/crt/contrib/stm32/runtime.c ## @@ -0,0 +1,91 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contribu

[GitHub] [tvm] stoa commented on a change in pull request #7742: Contributing the STM32 port

2021-09-22 Thread GitBox
stoa commented on a change in pull request #7742: URL: https://github.com/apache/tvm/pull/7742#discussion_r713990676 ## File path: tests/crt/contrib/stm32/src/main.c ## @@ -0,0 +1,461 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor

[GitHub] [tvm] sunshinemyson commented on a change in pull request #9046: Support verisilicon's NPU with BYOC framework

2021-09-22 Thread GitBox
sunshinemyson commented on a change in pull request #9046: URL: https://github.com/apache/tvm/pull/9046#discussion_r713974334 ## File path: tests/python/contrib/test_vsi_npu/test_operations.py ## @@ -0,0 +1,1673 @@ +# Licensed to the Apache Software Foundation (ASF) under one +

[GitHub] [tvm] sunshinemyson commented on a change in pull request #9046: Support verisilicon's NPU with BYOC framework

2021-09-22 Thread GitBox
sunshinemyson commented on a change in pull request #9046: URL: https://github.com/apache/tvm/pull/9046#discussion_r713972588 ## File path: src/relay/backend/contrib/vsi_npu/codegen_vsi_npu.h ## @@ -0,0 +1,151 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under on

[GitHub] [tvm] sunshinemyson commented on a change in pull request #9046: Support verisilicon's NPU with BYOC framework

2021-09-22 Thread GitBox
sunshinemyson commented on a change in pull request #9046: URL: https://github.com/apache/tvm/pull/9046#discussion_r713973055 ## File path: src/relay/backend/contrib/vsi_npu/codegen.cc ## @@ -0,0 +1,425 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * o

[GitHub] [tvm] sunshinemyson commented on a change in pull request #9046: Support verisilicon's NPU with BYOC framework

2021-09-22 Thread GitBox
sunshinemyson commented on a change in pull request #9046: URL: https://github.com/apache/tvm/pull/9046#discussion_r713971208 ## File path: src/relay/backend/contrib/vsi_npu/codegen.cc ## @@ -0,0 +1,425 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * o

  1   2   >