[GitHub] [tvm] blackkker commented on pull request #12028: [WIP][Pylint] Making frontend tests pylint compliant

2022-07-26 Thread GitBox
blackkker commented on PR #12028: URL: https://github.com/apache/tvm/pull/12028#issuecomment-1196289756 @areusch basically completed, there are still a few questions that need to be confirmed with you. -- This is an automated message from the Apache Git Service. To respond to the

[GitHub] [tvm] AndrewZhaoLuo closed pull request #11712: [Docker][Pylint] Use regexes for good names

2022-07-26 Thread GitBox
AndrewZhaoLuo closed pull request #11712: [Docker][Pylint] Use regexes for good names URL: https://github.com/apache/tvm/pull/11712 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [tvm] AndrewZhaoLuo commented on pull request #11712: [Docker][Pylint] Use regexes for good names

2022-07-26 Thread GitBox
AndrewZhaoLuo commented on PR #11712: URL: https://github.com/apache/tvm/pull/11712#issuecomment-1196281584 @quic-sanirudh I haven't found time to get to this. I think your plan of closing the loophole is a good one. However, it is another major refactor -- This is an automated message

[GitHub] [tvm] AndrewZhaoLuo commented on pull request #12145: [TFLite] Fix _test_tflite2_quantized_depthwise_convolution is unused

2022-07-26 Thread GitBox
AndrewZhaoLuo commented on PR #12145: URL: https://github.com/apache/tvm/pull/12145#issuecomment-1196281676 I will take a look tomorrow -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [tvm] echuraev commented on a diff in pull request #12173: [OpenCL] Fix profiling hang for OpenCL device

2022-07-26 Thread GitBox
echuraev commented on code in PR #12173: URL: https://github.com/apache/tvm/pull/12173#discussion_r930617226 ## tests/cpp-runtime/opencl/opencl_timer_test.cc: ## @@ -0,0 +1,60 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license

[GitHub] [tvm] sunjiweiswift commented on a diff in pull request #11599: [Bugfix][Runtime] Fix sched_setaffinity in Android

2022-07-26 Thread GitBox
sunjiweiswift commented on code in PR #11599: URL: https://github.com/apache/tvm/pull/11599#discussion_r930612103 ## src/runtime/threading_backend.cc: ## @@ -321,12 +350,25 @@ class ThreadGroup::Impl { } } +#ifndef __hexagon__ + pid_t Tid() { +#if defined(_WIN32) +

[tvm] branch last-successful updated (ea6ea42757 -> 421f9d756a)

2022-07-26 Thread github-bot
This is an automated email from the ASF dual-hosted git repository. github-bot pushed a change to branch last-successful in repository https://gitbox.apache.org/repos/asf/tvm.git from ea6ea42757 TVM Vertical Integration with PyTorch (#11911) add eada707a70 [Fix] Fix some errors in

[GitHub] [tvm] ganler opened a new pull request, #12197: [UX] highlight tvm script

2022-07-26 Thread GitBox
ganler opened a new pull request, #12197: URL: https://github.com/apache/tvm/pull/12197 See https://github.com/tlc-pack/relax/pull/185 cc: @YuchenJin @junrushao1994 @Hzfengsy -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [tvm] sunjiweiswift commented on a diff in pull request #11599: [Bugfix][Runtime] Fix sched_setaffinity in Android

2022-07-26 Thread GitBox
sunjiweiswift commented on code in PR #11599: URL: https://github.com/apache/tvm/pull/11599#discussion_r930591164 ## src/runtime/threading_backend.cc: ## @@ -321,12 +350,25 @@ class ThreadGroup::Impl { } } +#ifndef __hexagon__ + pid_t Tid() { +#if defined(_WIN32) +

[GitHub] [tvm] wrongtest-intellif commented on pull request #12196: Use std::move to avoid warnings on clang-13

2022-07-26 Thread GitBox
wrongtest-intellif commented on PR #12196: URL: https://github.com/apache/tvm/pull/12196#issuecomment-1196197309 Thank you~ It is happy for macos users :) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [tvm] masahi merged pull request #12192: [skip ci][ci] Skip broken android_rpc failures

2022-07-26 Thread GitBox
masahi merged PR #12192: URL: https://github.com/apache/tvm/pull/12192 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[tvm] branch main updated: [ci] Skip broken android_rpc failures (#12192)

2022-07-26 Thread masahi
This is an automated email from the ASF dual-hosted git repository. masahi pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/tvm.git The following commit(s) were added to refs/heads/main by this push: new 421f9d756a [ci] Skip broken android_rpc failures

[GitHub] [tvm] shingjan commented on a diff in pull request #12141: [Meta Schedule][XGBoost] Update the custom callback function of xgboost in meta schedule

2022-07-26 Thread GitBox
shingjan commented on code in PR #12141: URL: https://github.com/apache/tvm/pull/12141#discussion_r930543004 ## python/tvm/meta_schedule/cost_model/xgb_model.py: ## @@ -763,3 +768,162 @@ def callback(env: "xgb.core.CallbackEnv"): raise

[GitHub] [tvm] shingjan commented on a diff in pull request #12141: [Meta Schedule][XGBoost] Update the custom callback function of xgboost in meta schedule

2022-07-26 Thread GitBox
shingjan commented on code in PR #12141: URL: https://github.com/apache/tvm/pull/12141#discussion_r930542012 ## python/tvm/meta_schedule/cost_model/xgb_model.py: ## @@ -763,3 +768,162 @@ def callback(env: "xgb.core.CallbackEnv"): raise

[GitHub] [tvm] cconvey commented on pull request #12195: [hexagon][testing] filesystem-friendly test IDs

2022-07-26 Thread GitBox
cconvey commented on PR #12195: URL: https://github.com/apache/tvm/pull/12195#issuecomment-1196165877 @tvm-bot rerun -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [tvm] masahi commented on a diff in pull request #12171: [TIR] Asynchronous stage in software pipeline

2022-07-26 Thread GitBox
masahi commented on code in PR #12171: URL: https://github.com/apache/tvm/pull/12171#discussion_r930523406 ## src/tir/transforms/inject_software_pipeline.cc: ## @@ -494,6 +512,267 @@ class PipelineRewriter : public StmtExprMutator { return Buffer(new_buffer); } + //

[GitHub] [tvm] masahi commented on a diff in pull request #12171: [TIR] Asynchronous stage in software pipeline

2022-07-26 Thread GitBox
masahi commented on code in PR #12171: URL: https://github.com/apache/tvm/pull/12171#discussion_r930522785 ## src/tir/transforms/inject_software_pipeline.cc: ## @@ -530,18 +620,269 @@ class PipelineRewriter : public StmtExprMutator { Block new_block =

[GitHub] [tvm] github-actions[bot] commented on pull request #12190: Update to 0.10.0

2022-07-26 Thread GitBox
github-actions[bot] commented on PR #12190: URL: https://github.com/apache/tvm/pull/12190#issuecomment-1196133919 Built docs for commit 1d5474230d3ec1cc3d248cb3949f44deb274636b can be found [here](https://pr-docs.tlcpack.ai/PR-12190/2/docs/index.html). -- This is an automated

[GitHub] [tvm] jwfromm commented on pull request #12124: [Relay][Op] Trilu operator implementation

2022-07-26 Thread GitBox
jwfromm commented on PR #12124: URL: https://github.com/apache/tvm/pull/12124#issuecomment-1196125814 I added pytorch testing and integration. Thanks for the recommendation @shingjan. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [tvm] jwfromm commented on a diff in pull request #12124: [Relay][Op] Trilu operator implementation

2022-07-26 Thread GitBox
jwfromm commented on code in PR #12124: URL: https://github.com/apache/tvm/pull/12124#discussion_r930506616 ## python/tvm/relay/op/transform.py: ## @@ -1889,3 +1889,46 @@ def stft( window = _make.ones([n_fft], "int32") return _make.stft(data, n_fft, hop_length,

[tvm] branch nightly-docker-update updated (4a74d37ef7 -> 865607305d)

2022-07-26 Thread github-bot
This is an automated email from the ASF dual-hosted git repository. github-bot pushed a change to branch nightly-docker-update in repository https://gitbox.apache.org/repos/asf/tvm.git discard 4a74d37ef7 [ci][docker] Nightly Docker image update add ca2ec5429b [CI][docker] Add comment

[GitHub] [tvm] shingjan commented on a diff in pull request #12124: [Relay][Op] Trilu operator implementation

2022-07-26 Thread GitBox
shingjan commented on code in PR #12124: URL: https://github.com/apache/tvm/pull/12124#discussion_r930499403 ## python/tvm/relay/op/transform.py: ## @@ -1889,3 +1889,46 @@ def stft( window = _make.ones([n_fft], "int32") return _make.stft(data, n_fft, hop_length,

[GitHub] [tvm] jwfromm commented on a diff in pull request #12124: [Relay][Op] Trilu operator implementation

2022-07-26 Thread GitBox
jwfromm commented on code in PR #12124: URL: https://github.com/apache/tvm/pull/12124#discussion_r930491682 ## tests/python/frontend/onnx/test_forward.py: ## @@ -5241,23 +5241,7 @@ def verify_eyelike(indata, dynamic=False): "test_training_dropout_mask",

[GitHub] [tvm] jwfromm commented on a diff in pull request #12124: [Relay][Op] Trilu operator implementation

2022-07-26 Thread GitBox
jwfromm commented on code in PR #12124: URL: https://github.com/apache/tvm/pull/12124#discussion_r930491682 ## tests/python/frontend/onnx/test_forward.py: ## @@ -5241,23 +5241,7 @@ def verify_eyelike(indata, dynamic=False): "test_training_dropout_mask",

[GitHub] [tvm] jwfromm commented on a diff in pull request #12124: [Relay][Op] Trilu operator implementation

2022-07-26 Thread GitBox
jwfromm commented on code in PR #12124: URL: https://github.com/apache/tvm/pull/12124#discussion_r930487887 ## tests/python/frontend/onnx/test_forward.py: ## @@ -5241,23 +5241,7 @@ def verify_eyelike(indata, dynamic=False): "test_training_dropout_mask",

[GitHub] [tvm] vinx13 opened a new pull request, #12196: Use std::move to avoid warnings on clang-13

2022-07-26 Thread GitBox
vinx13 opened a new pull request, #12196: URL: https://github.com/apache/tvm/pull/12196 Returning an instance of a subclass of the return type disable copy elision, `std::move` is needed in this case. -- This is an automated message from the Apache Git Service. To respond to the message,

[tvm] branch skip_android_rpc updated (9ab27d35d4 -> 9c45394ca3)

2022-07-26 Thread driazati
This is an automated email from the ASF dual-hosted git repository. driazati pushed a change to branch skip_android_rpc in repository https://gitbox.apache.org/repos/asf/tvm.git discard 9ab27d35d4 [ci] Skip broken android_rpc failures add 9c45394ca3 [ci] Skip broken android_rpc failures

[GitHub] [tvm] cconvey commented on pull request #12193: [util] add `tvm.support.dump_for_debug` function

2022-07-26 Thread GitBox
cconvey commented on PR #12193: URL: https://github.com/apache/tvm/pull/12193#issuecomment-1196041454 @areusch : This seems like the kind of thing you'd have thoughts on :) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[GitHub] [tvm] github-actions[bot] commented on pull request #12188: [docs] Update tlcpack-sphinx-addon

2022-07-26 Thread GitBox
github-actions[bot] commented on PR #12188: URL: https://github.com/apache/tvm/pull/12188#issuecomment-1196033210 Built docs for commit 3ae82db33c2d5b186f1a3548bcd22d1f36fc4552 can be found [here](https://pr-docs.tlcpack.ai/PR-12188/1/docs/index.html). -- This is an automated

[GitHub] [tvm] cconvey commented on issue #12191: [ci] Build android_rpc fails in CI

2022-07-26 Thread GitBox
cconvey commented on issue #12191: URL: https://github.com/apache/tvm/issues/12191#issuecomment-1196029860 Thanks for reporting this @driazati ! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [tvm] cconvey commented on pull request #12195: [hexagon][testing] filesystem-friendly test IDs

2022-07-26 Thread GitBox
cconvey commented on PR #12195: URL: https://github.com/apache/tvm/pull/12195#issuecomment-1196026638 CC: @mehrdadh -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [tvm] cconvey opened a new pull request, #12195: [hexagon][testing] filesystem-friendly test IDs

2022-07-26 Thread GitBox
cconvey opened a new pull request, #12195: URL: https://github.com/apache/tvm/pull/12195 - Change the formula used to compute pytest test-ID strings. The previous formula included '(' and ')' characters, which can cause the filename to require escaping / quoting on the Bash

[GitHub] [tvm] cconvey commented on pull request #12194: [runtime][hexagon] improved file-copy logic

2022-07-26 Thread GitBox
cconvey commented on PR #12194: URL: https://github.com/apache/tvm/pull/12194#issuecomment-1196023022 CC: @kparzysz-quic @csullivan -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [tvm] cconvey opened a new pull request, #12194: [runtime][hexagon] improved file-copy logic

2022-07-26 Thread GitBox
cconvey opened a new pull request, #12194: URL: https://github.com/apache/tvm/pull/12194 - Add `tvm::runtime::CopyFile` function. - Change `HexagonModuleNode::SaveToFile` to use new function instead of a shell `cp` invocation. This fixes a problem where the `cp`-based

[GitHub] [tvm] github-actions[bot] commented on pull request #12192: [ci] Skip broken android_rpc failures

2022-07-26 Thread GitBox
github-actions[bot] commented on PR #12192: URL: https://github.com/apache/tvm/pull/12192#issuecomment-1196022432 Built docs for commit 9ab27d35d4e56e37fea928e73fe989af985fa40a can be found [here](https://pr-docs.tlcpack.ai/PR-12192/2/docs/index.html). -- This is an automated

[GitHub] [tvm] cconvey commented on pull request #12193: [util] add `tvm.support.dump_for_debug` function

2022-07-26 Thread GitBox
cconvey commented on PR #12193: URL: https://github.com/apache/tvm/pull/12193#issuecomment-1196019808 I find this function helpful for my own development work. I'm not positive that `tvm/support.py` is the best home for it, but it would be nice to have it around. -- This is an

[GitHub] [tvm] cconvey opened a new pull request, #12193: [util] add `tvm.support.dump_for_debug` function

2022-07-26 Thread GitBox
cconvey opened a new pull request, #12193: URL: https://github.com/apache/tvm/pull/12193 - add a utility function to help with debugging / investigation The function is particularly geared to help programmers examine changes to TVM modules and functions as they progress through

[tvm] branch skip_android_rpc updated (815455566e -> 9ab27d35d4)

2022-07-26 Thread driazati
This is an automated email from the ASF dual-hosted git repository. driazati pushed a change to branch skip_android_rpc in repository https://gitbox.apache.org/repos/asf/tvm.git omit 815455566e [ci] Skip broken android_rpc failures add 9ab27d35d4 [ci] Skip broken android_rpc failures

[tvm] branch skip_android_rpc created (now 815455566e)

2022-07-26 Thread driazati
This is an automated email from the ASF dual-hosted git repository. driazati pushed a change to branch skip_android_rpc in repository https://gitbox.apache.org/repos/asf/tvm.git at 815455566e [ci] Skip broken android_rpc failures No new revisions were added by this update.

[GitHub] [tvm] driazati opened a new pull request, #12192: [ci] Skip broken android_rpc failures

2022-07-26 Thread GitBox
driazati opened a new pull request, #12192: URL: https://github.com/apache/tvm/pull/12192 See #12191 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe,

[GitHub] [tvm] driazati opened a new issue, #12191: [ci] Build android_rpc fails in CI

2022-07-26 Thread GitBox
driazati opened a new issue, #12191: URL: https://github.com/apache/tvm/issues/12191 This has been failing intermittently but with increasing frequency lately: https://github.com/apache/tvm/runs/7519810828?check_suite_focus=true cc @argrento -- This is an automated message

[GitHub] [tvm] gromero commented on a diff in pull request #12182: [microTVM][tutorial] AOT host-driven tutorial with TFLite model

2022-07-26 Thread GitBox
gromero commented on code in PR #12182: URL: https://github.com/apache/tvm/pull/12182#discussion_r930436112 ## gallery/how_to/work_with_microtvm/micro_aot.py: ## @@ -125,7 +125,7 @@ # # Now that we have the compiled model as an IRModule, we need to create a firmware project

[GitHub] [tvm] driazati opened a new pull request, #12190: Update to 0.10.0

2022-07-26 Thread GitBox
driazati opened a new pull request, #12190: URL: https://github.com/apache/tvm/pull/12190 This updates the version numbers after the v0.9.0 release and adds a version selector option for the v0.9.0 docs. -- This is an automated message from the Apache Git Service. To respond to the

[GitHub] [tvm] mehrdadh commented on a diff in pull request #12182: [microTVM][tutorial] AOT host-driven tutorial with TFLite model

2022-07-26 Thread GitBox
mehrdadh commented on code in PR #12182: URL: https://github.com/apache/tvm/pull/12182#discussion_r930431666 ## gallery/how_to/work_with_microtvm/micro_aot.py: ## @@ -125,7 +125,7 @@ # # Now that we have the compiled model as an IRModule, we need to create a firmware project

[GitHub] [tvm] gromero commented on a diff in pull request #12182: [microTVM][tutorial] AOT host-driven tutorial with TFLite model

2022-07-26 Thread GitBox
gromero commented on code in PR #12182: URL: https://github.com/apache/tvm/pull/12182#discussion_r930403762 ## gallery/how_to/work_with_microtvm/micro_aot.py: ## @@ -125,7 +125,7 @@ # # Now that we have the compiled model as an IRModule, we need to create a firmware project

[GitHub] [tvm] mehrdadh commented on pull request #12182: [microTVM][tutorial] AOT host-driven tutorial with TFLite model

2022-07-26 Thread GitBox
mehrdadh commented on PR #12182: URL: https://github.com/apache/tvm/pull/12182#issuecomment-1195938488 @gromero thanks for the second review. I addressed comments -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

[GitHub] [tvm] mehrdadh commented on a diff in pull request #12182: [microTVM][tutorial] AOT host-driven tutorial with TFLite model

2022-07-26 Thread GitBox
mehrdadh commented on code in PR #12182: URL: https://github.com/apache/tvm/pull/12182#discussion_r930375549 ## gallery/how_to/work_with_microtvm/micro_aot.py: ## @@ -110,11 +121,11 @@ ## # Create a

[GitHub] [tvm] guberti opened a new pull request, #12189: [microTVM] Fix timeout of -1 breaking Arduino transport

2022-07-26 Thread GitBox
guberti opened a new pull request, #12189: URL: https://github.com/apache/tvm/pull/12189 Fixes a small bug causing `test_arduino_workflow.py` to fail. Also updates a comment in `boards.json` to reflect a GitHub issue that has since been fininshed. -- This is an automated message from

[GitHub] [tvm] tqchen commented on issue #11707: [Bug][TVMC] Map is not supported by RPC

2022-07-26 Thread GitBox
tqchen commented on issue #11707: URL: https://github.com/apache/tvm/issues/11707#issuecomment-1195891572 This is the intended behavior of RPC for now to restrict the object that we can support (so we can support minimum cases like uTVM). Would be a good starting pt to document the related

[GitHub] [tvm] zxybazh commented on issue #12135: [Bug] Metaschedule nonexistent error message

2022-07-26 Thread GitBox
zxybazh commented on issue #12135: URL: https://github.com/apache/tvm/issues/12135#issuecomment-1195889152 Corrected TIR would not cause the problem, please defined the write buffer for root block as follows: ``` @tvm.script.ir_module class Module: @T.prim_func def

[GitHub] [tvm] tqchen commented on issue #8473: [RFC][Tracking Issue] Meta Schedule (AutoTIR)

2022-07-26 Thread GitBox
tqchen commented on issue #8473: URL: https://github.com/apache/tvm/issues/8473#issuecomment-1195888767 Would be good to get a status update @junrushao1994 . I would suggest we move followup non-infra part to separate trackings to keep things tracable. -- This is an automated message

[GitHub] [tvm] tqchen commented on issue #9183: [Tracking Issue] C Device API implementation

2022-07-26 Thread GitBox
tqchen commented on issue #9183: URL: https://github.com/apache/tvm/issues/9183#issuecomment-1195888170 We should perhaps close this tracking issue? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [tvm] zxybazh commented on a diff in pull request #12184: [MetaSchedule] Remove Root Block From Collector

2022-07-26 Thread GitBox
zxybazh commented on code in PR #12184: URL: https://github.com/apache/tvm/pull/12184#discussion_r930334204 ## src/meta_schedule/space_generator/post_order_apply.cc: ## @@ -55,8 +55,10 @@ class BlockCollector : public tir::StmtVisitor {

[GitHub] [tvm] zxybazh closed pull request #12184: [MetaSchedule] Remove Root Block From Collector

2022-07-26 Thread GitBox
zxybazh closed pull request #12184: [MetaSchedule] Remove Root Block From Collector URL: https://github.com/apache/tvm/pull/12184 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [tvm] zxybazh commented on pull request #12184: [MetaSchedule] Remove Root Block From Collector

2022-07-26 Thread GitBox
zxybazh commented on PR #12184: URL: https://github.com/apache/tvm/pull/12184#issuecomment-1195887993 After some local discussion with Junru I found the problem lies in the tir script. As long as we define the write buffer for the root block (should be no write block), it would not cause

[GitHub] [tvm] gromero commented on a diff in pull request #12182: [microTVM][tutorial] AOT host-driven tutorial with TFLite model

2022-07-26 Thread GitBox
gromero commented on code in PR #12182: URL: https://github.com/apache/tvm/pull/12182#discussion_r930304436 ## gallery/how_to/work_with_microtvm/micro_aot.py: ## @@ -24,8 +24,10 @@ `Alan MacDonald `_ This tutorial is showcasing microTVM

[GitHub] [tvm] zxybazh commented on a diff in pull request #12141: [Meta Schedule][XGBoost] Update the custom callback function of xgboost in meta schedule

2022-07-26 Thread GitBox
zxybazh commented on code in PR #12141: URL: https://github.com/apache/tvm/pull/12141#discussion_r930315114 ## python/tvm/meta_schedule/cost_model/xgb_model.py: ## @@ -763,3 +768,162 @@ def callback(env: "xgb.core.CallbackEnv"): raise

[GitHub] [tvm] driazati opened a new pull request, #12188: [docs] Update tlcpack-sphinx-addon

2022-07-26 Thread GitBox
driazati opened a new pull request, #12188: URL: https://github.com/apache/tvm/pull/12188 This includes https://github.com/tlc-pack/tlcpack-sphinx-addon/commit/545450acaf0ee4e2932d8c5d9ab6e321d0bc86c8 which fixes the sphinx-gallery cards and closes #12156 -- This is an automated message

[GitHub] [tvm] areusch closed issue #12156: [Docs] Clicking on chapters in User Tutorial doesn't do anything

2022-07-26 Thread GitBox
areusch closed issue #12156: [Docs] Clicking on chapters in User Tutorial doesn't do anything URL: https://github.com/apache/tvm/issues/12156 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [tvm] Sunny-Island commented on a diff in pull request #12141: [Meta Schedule][XGBoost] Update the custom callback function of xgboost in meta schedule

2022-07-26 Thread GitBox
Sunny-Island commented on code in PR #12141: URL: https://github.com/apache/tvm/pull/12141#discussion_r930296373 ## python/tvm/meta_schedule/cost_model/xgb_model.py: ## @@ -763,3 +768,162 @@ def callback(env: "xgb.core.CallbackEnv"): raise

[GitHub] [tvm] shingjan commented on a diff in pull request #12144: [Auto Scheduler] Upgrade autoscheduler xgboost callback

2022-07-26 Thread GitBox
shingjan commented on code in PR #12144: URL: https://github.com/apache/tvm/pull/12144#discussion_r930273242 ## python/tvm/auto_scheduler/cost_model/xgb_model.py: ## @@ -539,125 +539,128 @@ def feval(preds, labels): return feval -def custom_callback( -

[GitHub] [tvm] driazati commented on issue #12156: [Docs] Clicking on chapters in User Tutorial doesn't do anything

2022-07-26 Thread GitBox
driazati commented on issue #12156: URL: https://github.com/apache/tvm/issues/12156#issuecomment-1195812894 Thanks for reporting! Once https://github.com/tlc-pack/tlcpack-sphinx-addon/pull/8 is merged (that should fix this issue), we can update the version of `tlcpack-sphinx-addon` we use

[GitHub] [tvm] driazati closed issue #12156: [Docs] Clicking on chapters in User Tutorial doesn't do anything

2022-07-26 Thread GitBox
driazati closed issue #12156: [Docs] Clicking on chapters in User Tutorial doesn't do anything URL: https://github.com/apache/tvm/issues/12156 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [tvm] mehrdadh commented on a diff in pull request #12182: [microTVM][tutorial] AOT host-driven tutorial with TFLite model

2022-07-26 Thread GitBox
mehrdadh commented on code in PR #12182: URL: https://github.com/apache/tvm/pull/12182#discussion_r930240740 ## gallery/how_to/work_with_microtvm/micro_aot.py: ## @@ -0,0 +1,162 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license

[GitHub] [tvm] mkatanbaf commented on a diff in pull request #12125: Zephyr fvp support

2022-07-26 Thread GitBox
mkatanbaf commented on code in PR #12125: URL: https://github.com/apache/tvm/pull/12125#discussion_r930227788 ## apps/microtvm/zephyr/template_project/src/host_driven/main.c: ## @@ -218,11 +303,42 @@ void uart_irq_cb(const struct device* dev, void* user_data) { } }

[GitHub] [tvm] mikepapadim commented on issue #12109: [ci] CPU integration tests are bottleneck-ing CI

2022-07-26 Thread GitBox
mikepapadim commented on issue #12109: URL: https://github.com/apache/tvm/issues/12109#issuecomment-1195740286 I am having a look into this. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [tvm] TejashShah commented on pull request #11878: [Adreno] Add markup pass of relay tensors for static texture planning

2022-07-26 Thread GitBox
TejashShah commented on PR #11878: URL: https://github.com/apache/tvm/pull/11878#issuecomment-1195739065 @masahi @csullivan @junrushao1994, please take out sometime to review this code and offer some feedback to @elvin-n. Thanks. -- This is an automated message from the Apache Git

[GitHub] [tvm] driazati commented on a diff in pull request #12178: Build and test TVM under minimal configuration

2022-07-26 Thread GitBox
driazati commented on code in PR #12178: URL: https://github.com/apache/tvm/pull/12178#discussion_r930197046 ## ci/jenkins/Test.groovy.j2: ## @@ -199,6 +234,9 @@ stage('Test') { {{ method_name }}() }, {% endfor %} + 'unittest: CPU MINIMAL': { Review Comment: I

[GitHub] [tvm] tkonolige commented on a diff in pull request #12138: [FIX,TIR] Handle LetStmt in EstimateTIRFLops

2022-07-26 Thread GitBox
tkonolige commented on code in PR #12138: URL: https://github.com/apache/tvm/pull/12138#discussion_r930195958 ## tests/python/unittest/test_tir_analysis_estimate_tir_flops.py: ## @@ -48,5 +50,16 @@ def test_te_workload(workload, flops): assert float(flops) ==

[GitHub] [tvm] gigiblender commented on a diff in pull request #12178: Build and test TVM under minimal configuration

2022-07-26 Thread GitBox
gigiblender commented on code in PR #12178: URL: https://github.com/apache/tvm/pull/12178#discussion_r930113155 ## ci/jenkins/Test.groovy.j2: ## @@ -199,6 +234,9 @@ stage('Test') { {{ method_name }}() }, {% endfor %} + 'unittest: CPU MINIMAL': { Review Comment:

[GitHub] [tvm] NicolaLancellotti commented on pull request #11519: [TFLite] Support quantized GREATER op in TFLite frontend

2022-07-26 Thread GitBox
NicolaLancellotti commented on PR #11519: URL: https://github.com/apache/tvm/pull/11519#issuecomment-1195634974 With tflite 2.9.1 `test_elemwise[_test_greater]` does not fail any more. We should wait for #12130 and #12131 to be merged. -- This is an automated message from the Apache Git

[GitHub] [tvm] mbrookhart commented on a diff in pull request #12124: [Relay][Op] Trilu operator implementation

2022-07-26 Thread GitBox
mbrookhart commented on code in PR #12124: URL: https://github.com/apache/tvm/pull/12124#discussion_r930088467 ## tests/python/frontend/onnx/test_forward.py: ## @@ -5241,23 +5241,7 @@ def verify_eyelike(indata, dynamic=False): "test_training_dropout_mask",

[GitHub] [tvm] areusch commented on a diff in pull request #12182: [microTVM][tutorial] AOT host-driven tutorial with TFLite model

2022-07-26 Thread GitBox
areusch commented on code in PR #12182: URL: https://github.com/apache/tvm/pull/12182#discussion_r930059752 ## gallery/how_to/work_with_microtvm/micro_aot.py: ## @@ -0,0 +1,168 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license

[GitHub] [tvm] gigiblender commented on a diff in pull request #12178: Build and test TVM under minimal configuration

2022-07-26 Thread GitBox
gigiblender commented on code in PR #12178: URL: https://github.com/apache/tvm/pull/12178#discussion_r930059275 ## ci/jenkins/Test.groovy.j2: ## @@ -199,6 +234,9 @@ stage('Test') { {{ method_name }}() }, {% endfor %} + 'unittest: CPU MINIMAL': { Review Comment:

[GitHub] [tvm] MichaelJKlaiber commented on a diff in pull request #12087: [UMA] UMA v1.0

2022-07-26 Thread GitBox
MichaelJKlaiber commented on code in PR #12087: URL: https://github.com/apache/tvm/pull/12087#discussion_r930056748 ## tests/scripts/task_python_uma.sh: ## @@ -0,0 +1,24 @@ +#!/usr/bin/env bash +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor

[GitHub] [tvm] MichaelJKlaiber commented on a diff in pull request #12087: [UMA] UMA v1.0

2022-07-26 Thread GitBox
MichaelJKlaiber commented on code in PR #12087: URL: https://github.com/apache/tvm/pull/12087#discussion_r930047570 ## python/tvm/relay/backend/contrib/uma/_template/backend.py: ## @@ -0,0 +1,53 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more

[GitHub] [tvm] MichaelJKlaiber commented on a diff in pull request #12087: [UMA] UMA v1.0

2022-07-26 Thread GitBox
MichaelJKlaiber commented on code in PR #12087: URL: https://github.com/apache/tvm/pull/12087#discussion_r930044501 ## python/tvm/relay/backend/contrib/uma/_template/run.py: ## @@ -0,0 +1,88 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor

[GitHub] [tvm] MichaelJKlaiber commented on a diff in pull request #12087: [UMA] UMA v1.0

2022-07-26 Thread GitBox
MichaelJKlaiber commented on code in PR #12087: URL: https://github.com/apache/tvm/pull/12087#discussion_r930041551 ## python/tvm/relay/backend/contrib/uma/uma_cli.py: ## @@ -0,0 +1,92 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor

[GitHub] [tvm] MichaelJKlaiber commented on a diff in pull request #12087: [UMA] UMA v1.0

2022-07-26 Thread GitBox
MichaelJKlaiber commented on code in PR #12087: URL: https://github.com/apache/tvm/pull/12087#discussion_r930040959 ## src/relay/backend/contrib/uma/tir_to_runtime.cc: ## @@ -0,0 +1,104 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more

[GitHub] [tvm] MichaelJKlaiber commented on a diff in pull request #12087: [UMA] UMA v1.0

2022-07-26 Thread GitBox
MichaelJKlaiber commented on code in PR #12087: URL: https://github.com/apache/tvm/pull/12087#discussion_r930030731 ## src/relay/backend/contrib/uma/relay_to_tir.cc: ## @@ -0,0 +1,174 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor

[GitHub] [tvm] MichaelJKlaiber commented on a diff in pull request #12087: [UMA] UMA v1.0

2022-07-26 Thread GitBox
MichaelJKlaiber commented on code in PR #12087: URL: https://github.com/apache/tvm/pull/12087#discussion_r930028351 ## src/relay/backend/contrib/uma/relay_to_tir.cc: ## @@ -0,0 +1,174 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor

[GitHub] [tvm] MichaelJKlaiber commented on a diff in pull request #12087: [UMA] UMA v1.0

2022-07-26 Thread GitBox
MichaelJKlaiber commented on code in PR #12087: URL: https://github.com/apache/tvm/pull/12087#discussion_r930025468 ## tests/python/contrib/test_uma/test_partition.py: ## @@ -0,0 +1,71 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor

[GitHub] [tvm] MichaelJKlaiber commented on a diff in pull request #12087: [UMA] UMA v1.0

2022-07-26 Thread GitBox
MichaelJKlaiber commented on code in PR #12087: URL: https://github.com/apache/tvm/pull/12087#discussion_r930022435 ## tests/python/contrib/test_uma/test_partition.py: ## @@ -0,0 +1,71 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor

[GitHub] [tvm] MichaelJKlaiber commented on a diff in pull request #12087: [UMA] UMA v1.0

2022-07-26 Thread GitBox
MichaelJKlaiber commented on code in PR #12087: URL: https://github.com/apache/tvm/pull/12087#discussion_r930020506 ## python/tvm/relay/backend/contrib/uma/api/codegen.py: ## @@ -0,0 +1,53 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor

[GitHub] [tvm] MichaelJKlaiber commented on a diff in pull request #12087: [UMA] UMA v1.0

2022-07-26 Thread GitBox
MichaelJKlaiber commented on code in PR #12087: URL: https://github.com/apache/tvm/pull/12087#discussion_r930017268 ## python/tvm/relay/backend/contrib/uma/_template/run.py: ## @@ -0,0 +1,88 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor

[GitHub] [tvm] MichaelJKlaiber commented on a diff in pull request #12087: [UMA] UMA v1.0

2022-07-26 Thread GitBox
MichaelJKlaiber commented on code in PR #12087: URL: https://github.com/apache/tvm/pull/12087#discussion_r930008614 ## python/tvm/relay/backend/contrib/uma/_template/passes.py: ## @@ -0,0 +1,137 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more

[GitHub] [tvm] MichaelJKlaiber commented on a diff in pull request #12087: [UMA] UMA v1.0

2022-07-26 Thread GitBox
MichaelJKlaiber commented on code in PR #12087: URL: https://github.com/apache/tvm/pull/12087#discussion_r930006872 ## python/tvm/relay/backend/contrib/uma/_template/passes.py: ## @@ -0,0 +1,137 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more

[GitHub] [tvm] MichaelJKlaiber commented on a diff in pull request #12087: [UMA] UMA v1.0

2022-07-26 Thread GitBox
MichaelJKlaiber commented on code in PR #12087: URL: https://github.com/apache/tvm/pull/12087#discussion_r93397 ## python/tvm/relay/backend/contrib/uma/_template/passes.py: ## @@ -0,0 +1,137 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more

[GitHub] [tvm] MichaelJKlaiber commented on a diff in pull request #12087: [UMA] UMA v1.0

2022-07-26 Thread GitBox
MichaelJKlaiber commented on code in PR #12087: URL: https://github.com/apache/tvm/pull/12087#discussion_r929993795 ## python/tvm/relay/backend/contrib/uma/_template/conv2dnchw.cc: ## @@ -0,0 +1,76 @@ +/* +# Licensed to the Apache Software Foundation (ASF) under one +# or more

[GitHub] [tvm] gigiblender commented on pull request #11938: [ci][docker] Use RFC image tags only

2022-07-26 Thread GitBox
gigiblender commented on PR #11938: URL: https://github.com/apache/tvm/pull/11938#issuecomment-1195513761 Thanks @driazati! LGTM! @areusch -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [tvm] MichaelJKlaiber commented on a diff in pull request #12087: [UMA] UMA v1.0

2022-07-26 Thread GitBox
MichaelJKlaiber commented on code in PR #12087: URL: https://github.com/apache/tvm/pull/12087#discussion_r929982909 ## python/tvm/relay/backend/contrib/uma/_template/conv2dnchw.cc: ## @@ -0,0 +1,76 @@ +/* +# Licensed to the Apache Software Foundation (ASF) under one +# or more

[GitHub] [tvm] MichaelJKlaiber commented on a diff in pull request #12087: [UMA] UMA v1.0

2022-07-26 Thread GitBox
MichaelJKlaiber commented on code in PR #12087: URL: https://github.com/apache/tvm/pull/12087#discussion_r929982499 ## python/tvm/relay/backend/contrib/uma/_template/backend.py: ## @@ -0,0 +1,53 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more

[GitHub] [tvm] elvin-n commented on a diff in pull request #11878: [Adreno] Add markup pass of relay tensors for static texture planning

2022-07-26 Thread GitBox
elvin-n commented on code in PR #11878: URL: https://github.com/apache/tvm/pull/11878#discussion_r929977746 ## tests/python/relay/test_conv2d_nchw_texture.py: ## @@ -435,3 +435,641 @@ def test_conv2d_vgg16_winograd_4d(): graph = build_run_compare(mod, params1, {"data":

[tvm] 02/03: This is PR #12130.

2022-07-26 Thread leandron
This is an automated email from the ASF dual-hosted git repository. leandron pushed a commit to branch ci-docker-staging in repository https://gitbox.apache.org/repos/asf/tvm.git commit 2bcf79b059cb124f2e035a9ba06386d975bd9925 Author: Leandro Nunes AuthorDate: Fri Jul 22 16:41:03 2022 +0100

[tvm] 03/03: Update Jenkins ci_arm, ci_cpu, ci_gpu, ci_qemu to use 20220725-085822-8ae520b1b

2022-07-26 Thread leandron
This is an automated email from the ASF dual-hosted git repository. leandron pushed a commit to branch ci-docker-staging in repository https://gitbox.apache.org/repos/asf/tvm.git commit 112c37eda35ed32f0c8aaf02e7e458a0e3d3935a Author: Leandro Nunes AuthorDate: Tue Jul 26 14:37:02 2022 +0100

[tvm] 01/03: [TFLite][CI] Update TensorFlow dependency to 2.9.1

2022-07-26 Thread leandron
This is an automated email from the ASF dual-hosted git repository. leandron pushed a commit to branch ci-docker-staging in repository https://gitbox.apache.org/repos/asf/tvm.git commit bd4c900925f6a29ac95fd1e17bf6c07903e43230 Author: Leandro Nunes AuthorDate: Mon May 23 11:55:08 2022 +0100

[tvm] branch ci-docker-staging updated (8ae520b1be -> 112c37eda3)

2022-07-26 Thread leandron
This is an automated email from the ASF dual-hosted git repository. leandron pushed a change to branch ci-docker-staging in repository https://gitbox.apache.org/repos/asf/tvm.git discard 8ae520b1be This is PR #12130. discard 15cf56e7df [TFLite][CI] Update TensorFlow dependency to 2.9.1

[GitHub] [tvm] MichaelJKlaiber commented on a diff in pull request #12087: [UMA] UMA v1.0

2022-07-26 Thread GitBox
MichaelJKlaiber commented on code in PR #12087: URL: https://github.com/apache/tvm/pull/12087#discussion_r929975111 ## python/tvm/relay/backend/contrib/uma/api/utils.py: ## @@ -0,0 +1,52 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor

[GitHub] [tvm] kparzysz-quic opened a new pull request, #12187: [JIT] Force finalization of JITed code, expose sf/hf runtime functions

2022-07-26 Thread GitBox
kparzysz-quic opened a new pull request, #12187: URL: https://github.com/apache/tvm/pull/12187 Code that handles fp16 and fp32 may end up calling builtins that do the conversions between these types. LLVM emits calls to `__truncsfhf2`, and `__extendhfsf2`, which are not present in TVM or

[GitHub] [tvm] MichaelJKlaiber commented on a diff in pull request #12087: [UMA] UMA v1.0

2022-07-26 Thread GitBox
MichaelJKlaiber commented on code in PR #12087: URL: https://github.com/apache/tvm/pull/12087#discussion_r929962126 ## python/tvm/relay/backend/contrib/uma/api/codegen.py: ## @@ -0,0 +1,53 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor

  1   2   >