[GitHub] [tvm] junrushao1994 commented on pull request #12462: [TVMScript] Printer entry point

2022-08-18 Thread GitBox
junrushao1994 commented on PR #12462: URL: https://github.com/apache/tvm/pull/12462#issuecomment-1220249905 Otherwise the PR looks nice to me! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [tvm] junrushao1994 commented on a diff in pull request #12462: [TVMScript] Printer entry point

2022-08-18 Thread GitBox
junrushao1994 commented on code in PR #12462: URL: https://github.com/apache/tvm/pull/12462#discussion_r949799093 ## include/tvm/script/printer.h: ## @@ -0,0 +1,54 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements.

[GitHub] [tvm] junrushao1994 commented on a diff in pull request #12462: [TVMScript] Printer entry point

2022-08-18 Thread GitBox
junrushao1994 commented on code in PR #12462: URL: https://github.com/apache/tvm/pull/12462#discussion_r949798902 ## include/tvm/script/printer.h: ## @@ -0,0 +1,54 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements.

[tvm-rfcs] branch main updated: Add link to the tracking issue of TVMScript Metaprogramming (#90)

2022-08-18 Thread junrushao
This is an automated email from the ASF dual-hosted git repository. junrushao pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/tvm-rfcs.git The following commit(s) were added to refs/heads/main by this push: new f6f0247 Add link to the tracking issue of

[GitHub] [tvm-rfcs] junrushao1994 merged pull request #90: Add link to the tracking issue of TVMScript Metaprogramming

2022-08-18 Thread GitBox
junrushao1994 merged PR #90: URL: https://github.com/apache/tvm-rfcs/pull/90 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [tvm-rfcs] junrushao1994 commented on pull request #90: Add link to the tracking issue of TVMScript Metaprogramming

2022-08-18 Thread GitBox
junrushao1994 commented on PR #90: URL: https://github.com/apache/tvm-rfcs/pull/90#issuecomment-1220248037 Thanks for updating the RFC! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [tvm] junrushao1994 opened a new pull request, #12496: [TVMScript] Reorganize the folder structure

2022-08-18 Thread GitBox
junrushao1994 opened a new pull request, #12496: URL: https://github.com/apache/tvm/pull/12496 This PR introduces some minor restructuring of the `python/tvm/script` folder structure to make it more convenient for future upstreaming. CC: @Hzfengsy @cyx-6 -- This is an automated

[GitHub] [tvm-rfcs] YuchenJin commented on a diff in pull request #89: [RFC] Relax Upstreaming

2022-08-18 Thread GitBox
YuchenJin commented on code in PR #89: URL: https://github.com/apache/tvm-rfcs/pull/89#discussion_r949758752 ## rfcs/0089-relax-upstreaming.md: ## @@ -0,0 +1,701 @@ +- Feature Name: Relax Upstreaming +- Start Date: 2022-08-17 +- RFC PR: 

[GitHub] [tvm-rfcs] YuchenJin commented on a diff in pull request #89: [RFC] Relax Upstreaming

2022-08-18 Thread GitBox
YuchenJin commented on code in PR #89: URL: https://github.com/apache/tvm-rfcs/pull/89#discussion_r949758210 ## rfcs/0089-relax-upstreaming.md: ## @@ -0,0 +1,701 @@ +- Feature Name: Relax Upstreaming +- Start Date: 2022-08-17 +- RFC PR: 

[tvm] branch last-successful updated (d1e6f3949c -> 72b0f5ee34)

2022-08-18 Thread github-bot
This is an automated email from the ASF dual-hosted git repository. github-bot pushed a change to branch last-successful in repository https://gitbox.apache.org/repos/asf/tvm.git from d1e6f3949c [CMSIS-NN] Re-use CPU Target Parser (#12320) add 6def53aeaa [Target] Only append default

[GitHub] [tvm-rfcs] YuchenJin commented on pull request #89: [RFC] Relax Upstreaming

2022-08-18 Thread GitBox
YuchenJin commented on PR #89: URL: https://github.com/apache/tvm-rfcs/pull/89#issuecomment-1220178200 Hi @leandron, thanks for your feedback! :) We share a common goal of minimizing disruption while incrementally improving TVM. One of the main questions is how to bring in the

[GitHub] [tvm] adstraw commented on a diff in pull request #12411: [Hexagon] Asynchronous DMA support

2022-08-18 Thread GitBox
adstraw commented on code in PR #12411: URL: https://github.com/apache/tvm/pull/12411#discussion_r949709289 ## src/runtime/hexagon/hexagon_user_dma.h: ## @@ -0,0 +1,90 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license

[GitHub] [tvm] adstraw commented on a diff in pull request #12411: [Hexagon] Asynchronous DMA support

2022-08-18 Thread GitBox
adstraw commented on code in PR #12411: URL: https://github.com/apache/tvm/pull/12411#discussion_r949709014 ## src/runtime/hexagon/hexagon_user_dma_instructions.h: ## @@ -24,8 +24,6 @@ namespace tvm { namespace runtime { namespace hexagon { -#if __HEXAGON_ARCH__ >= 68

[GitHub] [tvm] adstraw commented on a diff in pull request #12411: [Hexagon] Asynchronous DMA support

2022-08-18 Thread GitBox
adstraw commented on code in PR #12411: URL: https://github.com/apache/tvm/pull/12411#discussion_r949031227 ## src/runtime/hexagon/hexagon_user_dma.cc: ## @@ -90,32 +78,80 @@ int hexagon_user_dma_1d_sync_helper(void* dst, void* src, uint32_t length) {

[tvm] branch last-successful updated (efd7c45462 -> d1e6f3949c)

2022-08-18 Thread github-bot
This is an automated email from the ASF dual-hosted git repository. github-bot pushed a change to branch last-successful in repository https://gitbox.apache.org/repos/asf/tvm.git from efd7c45462 [TIR] [bfloat16] add bfloat16 promotion for CallNode (#12370) add d1e6f3949c [CMSIS-NN]

[GitHub] [tvm] adstraw commented on a diff in pull request #12411: [Hexagon] Asynchronous DMA support

2022-08-18 Thread GitBox
adstraw commented on code in PR #12411: URL: https://github.com/apache/tvm/pull/12411#discussion_r949707780 ## tests/cpp-runtime/hexagon/hexagon_user_dma_tests.cc: ## @@ -0,0 +1,141 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor

[GitHub] [tvm] mehrdadh commented on pull request #12483: [micro] Fix pytest fixture

2022-08-18 Thread GitBox
mehrdadh commented on PR #12483: URL: https://github.com/apache/tvm/pull/12483#issuecomment-1220098594 @tvm-bot rerun -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[tvm] branch nightly-docker-update updated (73379864b1 -> 72e7438a74)

2022-08-18 Thread github-bot
This is an automated email from the ASF dual-hosted git repository. github-bot pushed a change to branch nightly-docker-update in repository https://gitbox.apache.org/repos/asf/tvm.git discard 73379864b1 [ci][docker] Nightly Docker image update add 4231ebb715 [TVMScript] TracedObject

[GitHub] [tvm-rfcs] gromero commented on a diff in pull request #88: [RFC] Add Commit Message Guideline

2022-08-18 Thread GitBox
gromero commented on code in PR #88: URL: https://github.com/apache/tvm-rfcs/pull/88#discussion_r949688496 ## rfcs/0088-commit-message-guideline.md: ## @@ -0,0 +1,181 @@ +- Feature Name: Commit Message Guideline +- Start Date: 2022-08-12 +- RFC PR:

[GitHub] [tvm-rfcs] areusch commented on pull request #88: [RFC] Add Commit Message Guideline

2022-08-18 Thread GitBox
areusch commented on PR #88: URL: https://github.com/apache/tvm-rfcs/pull/88#issuecomment-1220078234 @junrushao1994 i would love for tvm-bot to enforce this as much as possible. some items are going to be more challenging than others. the thing i think we'd really like is for tvm-bot to

[GitHub] [tvm] masahi commented on pull request #12416: [Target] Remove deprecated parameters from target

2022-08-18 Thread GitBox
masahi commented on PR #12416: URL: https://github.com/apache/tvm/pull/12416#issuecomment-1220071237 @areusch Since most common use cases do not need `link-params`, I hesitate to break API and impose `executor` argument to all users of meta schedule task extraction. Instead, I'm leaning

[GitHub] [tvm] kparzysz-quic commented on a diff in pull request #12440: [LLVM] Add "cl-opt" attribute to target_kind "llvm"

2022-08-18 Thread GitBox
kparzysz-quic commented on code in PR #12440: URL: https://github.com/apache/tvm/pull/12440#discussion_r949674103 ## src/target/llvm/llvm_instance.cc: ## @@ -153,6 +176,21 @@ LLVMTarget::LLVMTarget(LLVMInstance& instance, const Target& target) } } + if (const

[GitHub] [tvm] kparzysz-quic commented on a diff in pull request #12440: [LLVM] Add "cl-opt" attribute to target_kind "llvm"

2022-08-18 Thread GitBox
kparzysz-quic commented on code in PR #12440: URL: https://github.com/apache/tvm/pull/12440#discussion_r949673763 ## src/target/llvm/llvm_instance.cc: ## @@ -340,9 +373,327 @@ std::string LLVMTarget::str() const { } } + if (size_t num = llvm_options_.size(); num > 0)

[tvm] branch main updated: [ci][tvmbot] Search more users when checking usernames (#12491)

2022-08-18 Thread kparzysz
This is an automated email from the ASF dual-hosted git repository. kparzysz pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/tvm.git The following commit(s) were added to refs/heads/main by this push: new 72b0f5ee34 [ci][tvmbot] Search more users when

[GitHub] [tvm] kparzysz-quic merged pull request #12491: [ci][tvmbot] Search more users when checking usernames

2022-08-18 Thread GitBox
kparzysz-quic merged PR #12491: URL: https://github.com/apache/tvm/pull/12491 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[tvm] branch main updated: [Target] Only append default keys if target doesn't have any yet (#12474)

2022-08-18 Thread kparzysz
This is an automated email from the ASF dual-hosted git repository. kparzysz pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/tvm.git The following commit(s) were added to refs/heads/main by this push: new 6def53aeaa [Target] Only append default keys if

[GitHub] [tvm] kparzysz-quic merged pull request #12474: [Target] Only append default keys if target doesn't have any yet

2022-08-18 Thread GitBox
kparzysz-quic merged PR #12474: URL: https://github.com/apache/tvm/pull/12474 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [tvm] AndrewZhaoLuo commented on pull request #12352: [TIR] Add pass to check for out of bounds memory access

2022-08-18 Thread GitBox
AndrewZhaoLuo commented on PR #12352: URL: https://github.com/apache/tvm/pull/12352#issuecomment-1220064039 I'll take a look over the weekend -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [tvm-rfcs] gromero commented on a diff in pull request #88: [RFC] Add Commit Message Guideline

2022-08-18 Thread GitBox
gromero commented on code in PR #88: URL: https://github.com/apache/tvm-rfcs/pull/88#discussion_r949670019 ## rfcs/0088-commit-message-guideline.md: ## @@ -0,0 +1,187 @@ +- Feature Name: Commit Message Guideline +- Start Date: 2022-08-12 +- RFC PR:

[GitHub] [tvm-rfcs] gromero commented on a diff in pull request #88: [RFC] Add Commit Message Guideline

2022-08-18 Thread GitBox
gromero commented on code in PR #88: URL: https://github.com/apache/tvm-rfcs/pull/88#discussion_r949670019 ## rfcs/0088-commit-message-guideline.md: ## @@ -0,0 +1,187 @@ +- Feature Name: Commit Message Guideline +- Start Date: 2022-08-12 +- RFC PR:

[GitHub] [tvm] areusch commented on pull request #12483: [micro] Fix pytest fixture

2022-08-18 Thread GitBox
areusch commented on PR #12483: URL: https://github.com/apache/tvm/pull/12483#issuecomment-1220061396 @mehrdadh could you elaborate on the problem in the PR title/body? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

[GitHub] [tvm] areusch commented on a diff in pull request #12440: [LLVM] Add "cl-opt" attribute to target_kind "llvm"

2022-08-18 Thread GitBox
areusch commented on code in PR #12440: URL: https://github.com/apache/tvm/pull/12440#discussion_r949647671 ## src/target/llvm/llvm_instance.cc: ## @@ -153,6 +176,21 @@ LLVMTarget::LLVMTarget(LLVMInstance& instance, const Target& target) } } + if (const Optional>& v

[GitHub] [tvm] mkatanbaf opened a new pull request, #12495: [microTVM] add the option to open a saved project for debugging

2022-08-18 Thread GitBox
mkatanbaf opened a new pull request, #12495: URL: https://github.com/apache/tvm/pull/12495 This PR adds the option to save a generated micro project at a custom path, and to open a saved project and start communicating with it (instead of generating a new one) for debugging. -- This

[GitHub] [tvm] kparzysz-quic commented on a diff in pull request #12204: [Hexagon] Add Hand written HVX conv2d

2022-08-18 Thread GitBox
kparzysz-quic commented on code in PR #12204: URL: https://github.com/apache/tvm/pull/12204#discussion_r949654199 ## src/runtime/hexagon/ops/conv2d_hvx.cc: ## @@ -0,0 +1,473 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license

[GitHub] [tvm] kparzysz-quic commented on a diff in pull request #12204: [Hexagon] Add Hand written HVX conv2d

2022-08-18 Thread GitBox
kparzysz-quic commented on code in PR #12204: URL: https://github.com/apache/tvm/pull/12204#discussion_r949653345 ## include/tvm/runtime/hexagon/ops/conv2d.h: ## @@ -0,0 +1,133 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license

[GitHub] [tvm] kparzysz-quic commented on a diff in pull request #12204: [Hexagon] Add Hand written HVX conv2d

2022-08-18 Thread GitBox
kparzysz-quic commented on code in PR #12204: URL: https://github.com/apache/tvm/pull/12204#discussion_r949649604 ## include/tvm/runtime/hexagon/ops/conv2d.h: ## @@ -0,0 +1,133 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license

[GitHub] [tvm] kparzysz-quic commented on a diff in pull request #12204: [Hexagon] Add Hand written HVX conv2d

2022-08-18 Thread GitBox
kparzysz-quic commented on code in PR #12204: URL: https://github.com/apache/tvm/pull/12204#discussion_r949649604 ## include/tvm/runtime/hexagon/ops/conv2d.h: ## @@ -0,0 +1,133 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license

[GitHub] [tvm] areusch commented on pull request #12125: [microTVM] Zephyr: Add support for FVP

2022-08-18 Thread GitBox
areusch commented on PR #12125: URL: https://github.com/apache/tvm/pull/12125#issuecomment-1220026288 @gromero i think we should try it, and CI Monitoring rotation will catch any flakes a lot faster. -- This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [tvm] areusch commented on pull request #12456: [CI] Set USE_CMSISNN and USE_ETHOSU off in task_config_build_cpu.sh

2022-08-18 Thread GitBox
areusch commented on PR #12456: URL: https://github.com/apache/tvm/pull/12456#issuecomment-1220025860 thanks @ekalda ! looks like we are still running one of those tests in CPU somehow, maybe need to make sure that one got moved to arm and then remove it from CPU. -- This is an

[tvm] branch main updated (efd7c45462 -> d1e6f3949c)

2022-08-18 Thread areusch
This is an automated email from the ASF dual-hosted git repository. areusch pushed a change to branch main in repository https://gitbox.apache.org/repos/asf/tvm.git from efd7c45462 [TIR] [bfloat16] add bfloat16 promotion for CallNode (#12370) add d1e6f3949c [CMSIS-NN] Re-use CPU

[GitHub] [tvm] areusch commented on a diff in pull request #12320: [CMSIS-NN] Re-use CPU Target Parser

2022-08-18 Thread GitBox
areusch commented on code in PR #12320: URL: https://github.com/apache/tvm/pull/12320#discussion_r949641262 ## src/relay/backend/contrib/cmsisnn/target.cc: ## @@ -31,10 +34,11 @@ tvm::transform::Pass RelayToTIR(); runtime::Module TIRToRuntime(IRModule mod, Target target);

[GitHub] [tvm] areusch merged pull request #12320: [CMSIS-NN] Re-use CPU Target Parser

2022-08-18 Thread GitBox
areusch merged PR #12320: URL: https://github.com/apache/tvm/pull/12320 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [tvm] areusch commented on a diff in pull request #12448: Add Arm DSP implentation of Depthwise Conv2D

2022-08-18 Thread GitBox
areusch commented on code in PR #12448: URL: https://github.com/apache/tvm/pull/12448#discussion_r949635686 ## python/tvm/topi/arm_cpu/mprofile/dsp/depthwise_conv2d.py: ## @@ -0,0 +1,381 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor

[GitHub] [tvm] cconvey commented on a diff in pull request #12340: [TOPI][Hexagon] Implement quantized avgpool

2022-08-18 Thread GitBox
cconvey commented on code in PR #12340: URL: https://github.com/apache/tvm/pull/12340#discussion_r949637472 ## python/tvm/topi/hexagon/qnn/avg_pool2d.py: ## @@ -0,0 +1,205 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license

[GitHub] [tvm] MichaelJKlaiber commented on pull request #12447: Fix for Issue #12410:Issue/uma tflite

2022-08-18 Thread GitBox
MichaelJKlaiber commented on PR #12447: URL: https://github.com/apache/tvm/pull/12447#issuecomment-1220008336 @areusch, you are referring to the question from https://github.com/apache/tvm/issues/12410, right? " Seems the bug is in the lowering step from relay_prim_func to

[GitHub] [tvm-rfcs] areusch commented on pull request #87: Amend RFC0070 with DeclBuffer TVMScript syntax updates

2022-08-18 Thread GitBox
areusch commented on PR #87: URL: https://github.com/apache/tvm-rfcs/pull/87#issuecomment-1220007525 lgtm! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe,

[GitHub] [tvm] areusch commented on pull request #12437: [CRT runtime] Fix memset of memory pool in PageMemoryManagerCreate

2022-08-18 Thread GitBox
areusch commented on PR #12437: URL: https://github.com/apache/tvm/pull/12437#issuecomment-1220006726 thanks @hugy718 ! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [tvm-rfcs] slyubomirsky commented on a diff in pull request #89: [RFC] Relax Upstreaming

2022-08-18 Thread GitBox
slyubomirsky commented on code in PR #89: URL: https://github.com/apache/tvm-rfcs/pull/89#discussion_r949618073 ## rfcs/0089-relax-upstreaming.md: ## @@ -0,0 +1,701 @@ +- Feature Name: Relax Upstreaming +- Start Date: 2022-08-17 +- RFC PR: 

[GitHub] [tvm-rfcs] slyubomirsky commented on a diff in pull request #89: [RFC] Relax Upstreaming

2022-08-18 Thread GitBox
slyubomirsky commented on code in PR #89: URL: https://github.com/apache/tvm-rfcs/pull/89#discussion_r949630757 ## rfcs/0089-relax-upstreaming.md: ## @@ -0,0 +1,701 @@ +- Feature Name: Relax Upstreaming +- Start Date: 2022-08-17 +- RFC PR: 

[GitHub] [tvm-rfcs] slyubomirsky commented on a diff in pull request #89: [RFC] Relax Upstreaming

2022-08-18 Thread GitBox
slyubomirsky commented on code in PR #89: URL: https://github.com/apache/tvm-rfcs/pull/89#discussion_r949630757 ## rfcs/0089-relax-upstreaming.md: ## @@ -0,0 +1,701 @@ +- Feature Name: Relax Upstreaming +- Start Date: 2022-08-17 +- RFC PR: 

[GitHub] [tvm-rfcs] tkonolige commented on a diff in pull request #89: [RFC] Relax Upstreaming

2022-08-18 Thread GitBox
tkonolige commented on code in PR #89: URL: https://github.com/apache/tvm-rfcs/pull/89#discussion_r949627983 ## rfcs/0089-relax-upstreaming.md: ## @@ -0,0 +1,701 @@ +- Feature Name: Relax Upstreaming +- Start Date: 2022-08-17 +- RFC PR: 

[GitHub] [tvm-rfcs] slyubomirsky commented on a diff in pull request #89: [RFC] Relax Upstreaming

2022-08-18 Thread GitBox
slyubomirsky commented on code in PR #89: URL: https://github.com/apache/tvm-rfcs/pull/89#discussion_r949611408 ## rfcs/0089-relax-upstreaming.md: ## @@ -0,0 +1,701 @@ +- Feature Name: Relax Upstreaming +- Start Date: 2022-08-17 +- RFC PR: 

[GitHub] [tvm] cconvey commented on a diff in pull request #12340: [TOPI][Hexagon] Implement quantized avgpool

2022-08-18 Thread GitBox
cconvey commented on code in PR #12340: URL: https://github.com/apache/tvm/pull/12340#discussion_r948135363 ## python/tvm/topi/hexagon/utils.py: ## @@ -150,4 +157,126 @@ def get_layout_transform_fn(layout): return nc_2048_2d if layout == "nhwc-8h8w32c-2d":

[GitHub] [tvm] cconvey commented on a diff in pull request #12204: [Hexagon] Add Hand written HVX conv2d

2022-08-18 Thread GitBox
cconvey commented on code in PR #12204: URL: https://github.com/apache/tvm/pull/12204#discussion_r949624162 ## include/tvm/runtime/hexagon/ops/conv2d.h: ## @@ -0,0 +1,133 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license

[GitHub] [tvm] cconvey commented on a diff in pull request #12204: [Hexagon] Add Hand written HVX conv2d

2022-08-18 Thread GitBox
cconvey commented on code in PR #12204: URL: https://github.com/apache/tvm/pull/12204#discussion_r949623025 ## src/runtime/hexagon/ops/conv2d.h: ## @@ -0,0 +1,144 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements.

[GitHub] [tvm] trahman-quic commented on pull request #12494: [TOPI][Hexagon] Test case to reproduce resize2d bug with cubic

2022-08-18 Thread GitBox
trahman-quic commented on PR #12494: URL: https://github.com/apache/tvm/pull/12494#issuecomment-1219989282 Ticket link: https://octoml.atlassian.net/servicedesk/customer/portal/6/OHD-540?created=true -- This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [tvm] cconvey commented on a diff in pull request #12204: [Hexagon] Add Hand written HVX conv2d

2022-08-18 Thread GitBox
cconvey commented on code in PR #12204: URL: https://github.com/apache/tvm/pull/12204#discussion_r949620130 ## src/runtime/hexagon/ops/conv2d_hvx.cc: ## @@ -0,0 +1,473 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license

[GitHub] [tvm-rfcs] slyubomirsky commented on a diff in pull request #89: [RFC] Relax Upstreaming

2022-08-18 Thread GitBox
slyubomirsky commented on code in PR #89: URL: https://github.com/apache/tvm-rfcs/pull/89#discussion_r949618073 ## rfcs/0089-relax-upstreaming.md: ## @@ -0,0 +1,701 @@ +- Feature Name: Relax Upstreaming +- Start Date: 2022-08-17 +- RFC PR: 

[GitHub] [tvm] cconvey commented on a diff in pull request #12204: [Hexagon] Add Hand written HVX conv2d

2022-08-18 Thread GitBox
cconvey commented on code in PR #12204: URL: https://github.com/apache/tvm/pull/12204#discussion_r949617801 ## include/tvm/runtime/hexagon/ops/conv2d.h: ## @@ -0,0 +1,133 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license

[GitHub] [tvm-rfcs] slyubomirsky commented on a diff in pull request #89: [RFC] Relax Upstreaming

2022-08-18 Thread GitBox
slyubomirsky commented on code in PR #89: URL: https://github.com/apache/tvm-rfcs/pull/89#discussion_r949615712 ## rfcs/0089-relax-upstreaming.md: ## @@ -0,0 +1,701 @@ +- Feature Name: Relax Upstreaming +- Start Date: 2022-08-17 +- RFC PR: 

[GitHub] [tvm] trahman-quic opened a new pull request, #12494: [TOPI][Hexagon] Test case to reproduce resize2d bug with cubic

2022-08-18 Thread GitBox
trahman-quic opened a new pull request, #12494: URL: https://github.com/apache/tvm/pull/12494 Thanks for contributing to TVM! Please refer to guideline https://tvm.apache.org/docs/contribute/ for useful information and tips. After the pull request is submitted, please request code

[GitHub] [tvm] cconvey commented on a diff in pull request #12204: [Hexagon] Add Hand written HVX conv2d

2022-08-18 Thread GitBox
cconvey commented on code in PR #12204: URL: https://github.com/apache/tvm/pull/12204#discussion_r949613464 ## src/runtime/hexagon/ops/conv2d_hvx.cc: ## @@ -0,0 +1,473 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license

[GitHub] [tvm-rfcs] slyubomirsky commented on a diff in pull request #89: [RFC] Relax Upstreaming

2022-08-18 Thread GitBox
slyubomirsky commented on code in PR #89: URL: https://github.com/apache/tvm-rfcs/pull/89#discussion_r949611408 ## rfcs/0089-relax-upstreaming.md: ## @@ -0,0 +1,701 @@ +- Feature Name: Relax Upstreaming +- Start Date: 2022-08-17 +- RFC PR: 

[GitHub] [tvm-rfcs] slyubomirsky commented on a diff in pull request #89: [RFC] Relax Upstreaming

2022-08-18 Thread GitBox
slyubomirsky commented on code in PR #89: URL: https://github.com/apache/tvm-rfcs/pull/89#discussion_r949608390 ## rfcs/0089-relax-upstreaming.md: ## @@ -0,0 +1,701 @@ +- Feature Name: Relax Upstreaming +- Start Date: 2022-08-17 +- RFC PR: 

[GitHub] [tvm] cconvey commented on a diff in pull request #12204: [Hexagon] Add Hand written HVX conv2d

2022-08-18 Thread GitBox
cconvey commented on code in PR #12204: URL: https://github.com/apache/tvm/pull/12204#discussion_r949329234 ## src/runtime/hexagon/ops/conv2d_hvx.cc: ## @@ -0,0 +1,473 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license

[GitHub] [tvm] areusch commented on a diff in pull request #12389: [ci] Check for timestamps in Jenkinsfile changes

2022-08-18 Thread GitBox
areusch commented on code in PR #12389: URL: https://github.com/apache/tvm/pull/12389#discussion_r949597085 ## ci/jenkins/generate.py: ## @@ -72,12 +75,49 @@ } -def lines_without_generated_tag(content): +def lines_without_generated_tag(content: str) -> List[str]:

[GitHub] [tvm] areusch commented on pull request #12447: Fix for Issue #12410:Issue/uma tflite

2022-08-18 Thread GitBox
areusch commented on PR #12447: URL: https://github.com/apache/tvm/pull/12447#issuecomment-1219955270 @mbaret wondering if you know the answer to this one (see attached PR)? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[tvm] branch last-successful updated (da7675c546 -> efd7c45462)

2022-08-18 Thread github-bot
This is an automated email from the ASF dual-hosted git repository. github-bot pushed a change to branch last-successful in repository https://gitbox.apache.org/repos/asf/tvm.git from da7675c546 Fix memset of memory pool in PageMemoryManagerCreate (#12437) add a96bda446c Add RISC-V

[GitHub] [tvm] trahman-quic commented on pull request #12406: [TOPI][Hexagon] Implement quantized elementwise

2022-08-18 Thread GitBox
trahman-quic commented on PR #12406: URL: https://github.com/apache/tvm/pull/12406#issuecomment-1219892853 Hi @mehrdadh, could you please take a look at the CI test's error in this PR? Any idea what's causing this error or how I can fix this? It doesn't seem to be an error caused by my PR

[GitHub] [tvm] EclecticGriffin opened a new pull request, #12493: [TIR] Intrinsic declaration extensions

2022-08-18 Thread GitBox
EclecticGriffin opened a new pull request, #12493: URL: https://github.com/apache/tvm/pull/12493 Adds several decorators and classes for declaring tensor intrinsics is a (hopefully) more ergonomic way. The `AcceleratorInterface` and `IntrinsicDeclaration` classes act as handles to

[GitHub] [tvm] yelite opened a new pull request, #12492: [TVMScript] TIR Printer: Var and Type

2022-08-18 Thread GitBox
yelite opened a new pull request, #12492: URL: https://github.com/apache/tvm/pull/12492 This PR: - Adds printing function for Var and Type in TIR - Update the traced_object_functor to require type parameter on `set_dispatch` for better code readability. - Add the TracedObject

[GitHub] [tvm] github-actions[bot] commented on pull request #12491: [ci][tvmbot] Search more users when checking usernames

2022-08-18 Thread GitBox
github-actions[bot] commented on PR #12491: URL: https://github.com/apache/tvm/pull/12491#issuecomment-1219833228 Built docs for commit cffec97a1480b2f9617267aacff3590d6a548cc6 can be found [here](https://pr-docs.tlcpack.ai/PR-12491/1/docs/index.html). -- This is an automated

[GitHub] [tvm] driazati commented on pull request #12361: [ci][tvmbot] Trigger GitHub Actions after merging

2022-08-18 Thread GitBox
driazati commented on PR #12361: URL: https://github.com/apache/tvm/pull/12361#issuecomment-1219828254 > possible to unit test this one? curious about bypassing the subsequent auth checks here. it should have been an OR instead of an AND for the checks hence the break but i’ll add

[GitHub] [tvm] adstraw commented on a diff in pull request #12411: [Hexagon] Asynchronous DMA support

2022-08-18 Thread GitBox
adstraw commented on code in PR #12411: URL: https://github.com/apache/tvm/pull/12411#discussion_r949489424 ## src/runtime/hexagon/hexagon_user_dma.h: ## @@ -0,0 +1,90 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license

[GitHub] [tvm] adstraw commented on a diff in pull request #12411: [Hexagon] Asynchronous DMA support

2022-08-18 Thread GitBox
adstraw commented on code in PR #12411: URL: https://github.com/apache/tvm/pull/12411#discussion_r949484536 ## src/runtime/hexagon/hexagon_user_dma_instructions.h: ## @@ -24,8 +24,6 @@ namespace tvm { namespace runtime { namespace hexagon { -#if __HEXAGON_ARCH__ >= 68

[GitHub] [tvm] adstraw commented on a diff in pull request #12411: [Hexagon] Asynchronous DMA support

2022-08-18 Thread GitBox
adstraw commented on code in PR #12411: URL: https://github.com/apache/tvm/pull/12411#discussion_r949483132 ## src/runtime/hexagon/hexagon_user_dma.h: ## @@ -0,0 +1,90 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license

[GitHub] [tvm-rfcs] junrushao1994 commented on a diff in pull request #88: [RFC] Add Commit Message Guideline

2022-08-18 Thread GitBox
junrushao1994 commented on code in PR #88: URL: https://github.com/apache/tvm-rfcs/pull/88#discussion_r949468894 ## rfcs/0088-commit-message-guideline.md: ## @@ -0,0 +1,187 @@ +- Feature Name: Commit Message Guideline +- Start Date: 2022-08-12 +- RFC PR:

[GitHub] [tvm-rfcs] junrushao1994 commented on a diff in pull request #88: [RFC] Add Commit Message Guideline

2022-08-18 Thread GitBox
junrushao1994 commented on code in PR #88: URL: https://github.com/apache/tvm-rfcs/pull/88#discussion_r949466177 ## rfcs/0088-commit-message-guideline.md: ## @@ -0,0 +1,187 @@ +- Feature Name: Commit Message Guideline +- Start Date: 2022-08-12 +- RFC PR:

[GitHub] [tvm-rfcs] junrushao1994 commented on a diff in pull request #88: [RFC] Add Commit Message Guideline

2022-08-18 Thread GitBox
junrushao1994 commented on code in PR #88: URL: https://github.com/apache/tvm-rfcs/pull/88#discussion_r949461034 ## rfcs/0088-commit-message-guideline.md: ## @@ -0,0 +1,187 @@ +- Feature Name: Commit Message Guideline +- Start Date: 2022-08-12 +- RFC PR:

[tvm] branch main updated: [TIR] [bfloat16] add bfloat16 promotion for CallNode (#12370)

2022-08-18 Thread wuwei
This is an automated email from the ASF dual-hosted git repository. wuwei pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/tvm.git The following commit(s) were added to refs/heads/main by this push: new efd7c45462 [TIR] [bfloat16] add bfloat16 promotion for

[GitHub] [tvm] vinx13 merged pull request #12370: [TIR] [bfloat16] add bfloat16 promotion for CallNode

2022-08-18 Thread GitBox
vinx13 merged PR #12370: URL: https://github.com/apache/tvm/pull/12370 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [tvm] kparzysz-quic merged pull request #12397: [HEXAGON] Auto-vectorization (fp16) for v68

2022-08-18 Thread GitBox
kparzysz-quic merged PR #12397: URL: https://github.com/apache/tvm/pull/12397 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[tvm] branch main updated: [HEXAGON] Auto-vectorization (fp16) for v68 (#12397)

2022-08-18 Thread kparzysz
This is an automated email from the ASF dual-hosted git repository. kparzysz pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/tvm.git The following commit(s) were added to refs/heads/main by this push: new 88928a40f1 [HEXAGON] Auto-vectorization (fp16) for

[GitHub] [tvm] kparzysz-quic commented on a diff in pull request #12204: [Hexagon] Add Hand written HVX conv2d

2022-08-18 Thread GitBox
kparzysz-quic commented on code in PR #12204: URL: https://github.com/apache/tvm/pull/12204#discussion_r949419338 ## src/runtime/hexagon/ops/conv2d.h: ## @@ -0,0 +1,144 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license

[GitHub] [tvm] areusch commented on pull request #12416: [Target] Remove deprecated parameters from target

2022-08-18 Thread GitBox
areusch commented on PR #12416: URL: https://github.com/apache/tvm/pull/12416#issuecomment-1219752845 @masahi I see...I think perhaps we might need to arrange to thread the Executor through. at the moment the way we model memory in the compiler doesn't guarantee that Constant will wind up

[GitHub] [tvm] kparzysz-quic commented on a diff in pull request #12204: [Hexagon] Add Hand written HVX conv2d

2022-08-18 Thread GitBox
kparzysz-quic commented on code in PR #12204: URL: https://github.com/apache/tvm/pull/12204#discussion_r949410521 ## src/runtime/hexagon/ops/conv2d.h: ## @@ -0,0 +1,144 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license

[GitHub] [tvm] kparzysz-quic commented on a diff in pull request #12204: [Hexagon] Add Hand written HVX conv2d

2022-08-18 Thread GitBox
kparzysz-quic commented on code in PR #12204: URL: https://github.com/apache/tvm/pull/12204#discussion_r949407183 ## src/runtime/hexagon/ops/conv2d_hvx.cc: ## @@ -0,0 +1,473 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license

[GitHub] [tvm] kparzysz-quic commented on a diff in pull request #12204: [Hexagon] Add Hand written HVX conv2d

2022-08-18 Thread GitBox
kparzysz-quic commented on code in PR #12204: URL: https://github.com/apache/tvm/pull/12204#discussion_r949404879 ## src/runtime/hexagon/ops/conv2d_hvx.cc: ## @@ -0,0 +1,473 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license

[tvm] branch last-successful updated (250b68e202 -> da7675c546)

2022-08-18 Thread github-bot
This is an automated email from the ASF dual-hosted git repository. github-bot pushed a change to branch last-successful in repository https://gitbox.apache.org/repos/asf/tvm.git from 250b68e202 [TVMScript] IRBuilder, IRBuilderFrame base class (#12482) add da7675c546 Fix memset of

[GitHub] [tvm] kparzysz-quic commented on a diff in pull request #12204: [Hexagon] Add Hand written HVX conv2d

2022-08-18 Thread GitBox
kparzysz-quic commented on code in PR #12204: URL: https://github.com/apache/tvm/pull/12204#discussion_r949401536 ## include/tvm/runtime/hexagon/ops/conv2d.h: ## @@ -0,0 +1,133 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license

[GitHub] [tvm] kparzysz-quic commented on a diff in pull request #12204: [Hexagon] Add Hand written HVX conv2d

2022-08-18 Thread GitBox
kparzysz-quic commented on code in PR #12204: URL: https://github.com/apache/tvm/pull/12204#discussion_r949400871 ## include/tvm/runtime/hexagon/ops/conv2d.h: ## @@ -0,0 +1,133 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license

[GitHub] [tvm] kparzysz-quic commented on a diff in pull request #12204: [Hexagon] Add Hand written HVX conv2d

2022-08-18 Thread GitBox
kparzysz-quic commented on code in PR #12204: URL: https://github.com/apache/tvm/pull/12204#discussion_r949399707 ## include/tvm/runtime/hexagon/ops/conv2d.h: ## @@ -0,0 +1,133 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license

[GitHub] [tvm] kparzysz-quic commented on a diff in pull request #12204: [Hexagon] Add Hand written HVX conv2d

2022-08-18 Thread GitBox
kparzysz-quic commented on code in PR #12204: URL: https://github.com/apache/tvm/pull/12204#discussion_r949397877 ## include/tvm/runtime/hexagon/ops/conv2d.h: ## @@ -0,0 +1,133 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license

[GitHub] [tvm] Yulv-git commented on pull request #11503: [Fix] Fix some typos in src/.

2022-08-18 Thread GitBox
Yulv-git commented on PR #11503: URL: https://github.com/apache/tvm/pull/11503#issuecomment-1219731839 > looks like we have permission to update your fork branch, I can handle shepherding this through CI in that case Thanks for your help. -- This is an automated message from the

[GitHub] [tvm] cconvey commented on a diff in pull request #12204: [Hexagon] Add Hand written HVX conv2d

2022-08-18 Thread GitBox
cconvey commented on code in PR #12204: URL: https://github.com/apache/tvm/pull/12204#discussion_r949267658 ## include/tvm/runtime/hexagon/ops/conv2d.h: ## @@ -0,0 +1,133 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license

[GitHub] [tvm] cconvey commented on a diff in pull request #12204: [Hexagon] Add Hand written HVX conv2d

2022-08-18 Thread GitBox
cconvey commented on code in PR #12204: URL: https://github.com/apache/tvm/pull/12204#discussion_r949267658 ## include/tvm/runtime/hexagon/ops/conv2d.h: ## @@ -0,0 +1,133 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license

[GitHub] [tvm] driazati commented on pull request #12200: [TOPI]fix scatterND large shape problem

2022-08-18 Thread GitBox
driazati commented on PR #12200: URL: https://github.com/apache/tvm/pull/12200#issuecomment-1219711251 > @driazati Could you take a look at what happened here with the bot? We couldn't get it to rerun the CI. #12491 should fix it -- This is an automated message from the Apache Git

[GitHub] [tvm] cconvey commented on a diff in pull request #12204: [Hexagon] Add Hand written HVX conv2d

2022-08-18 Thread GitBox
cconvey commented on code in PR #12204: URL: https://github.com/apache/tvm/pull/12204#discussion_r949341528 ## src/runtime/hexagon/ops/conv2d_hvx.cc: ## @@ -0,0 +1,473 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license

[GitHub] [tvm] driazati commented on pull request #11503: [Fix] Fix some typos in src/.

2022-08-18 Thread GitBox
driazati commented on PR #11503: URL: https://github.com/apache/tvm/pull/11503#issuecomment-1219710094 looks like we have permission to update your fork branch, I can handle shepherding this through CI in that case -- This is an automated message from the Apache Git Service. To respond

[GitHub] [tvm] driazati opened a new pull request, #12491: [ci][tvmbot] Search more users when checking usernames

2022-08-18 Thread GitBox
driazati opened a new pull request, #12491: URL: https://github.com/apache/tvm/pull/12491 To figure out a user's association with the repo this code before searched the associations in the repo filtered by the relevant username. GitHub doesn't return the exact match only though, so we

  1   2   >