[GitHub] [tvm] echuraev commented on a diff in pull request #13349: [TIR][Hexagon] Add vtcm memory capacity verification for Hexagon target

2022-11-15 Thread GitBox
echuraev commented on code in PR #13349: URL: https://github.com/apache/tvm/pull/13349#discussion_r1023577713 ## python/tvm/rpc/tracker.py: ## @@ -348,7 +348,7 @@ def close(self, conn): if "key" in conn._info: for value in conn.put_values:

[GitHub] [tvm] chunit-quic commented on pull request #13402: [Relay][Frontend] Span filling common API

2022-11-15 Thread GitBox
chunit-quic commented on PR #13402: URL: https://github.com/apache/tvm/pull/13402#issuecomment-1316473284 Hi community, This is the very first PR of the RFC, TVM Explorer Infrastructure. We spend a while to extract the code blocks, and verify them after rebasing. Feel free to give

[GitHub] [tvm] driazati commented on a diff in pull request #13335: [ci] Split out C++ unittests

2022-11-15 Thread GitBox
driazati commented on code in PR #13335: URL: https://github.com/apache/tvm/pull/13335#discussion_r1023571421 ## tests/scripts/task_cpp_unittest.sh: ## @@ -28,38 +28,15 @@ else BUILD_DIR=build fi -# Python is required by apps/bundle_deploy -source

[GitHub] [tvm] driazati commented on a diff in pull request #13335: [ci] Split out C++ unittests

2022-11-15 Thread GitBox
driazati commented on code in PR #13335: URL: https://github.com/apache/tvm/pull/13335#discussion_r1023570932 ## tests/scripts/task_microtvm_cpp_tests.sh: ## @@ -0,0 +1,44 @@ +#!/usr/bin/env bash Review Comment: ah forgot to add calls to these in the relevant jobs after

[GitHub] [tvm] tvm-bot commented on pull request #13402: [Relay][Frontend] Span filling common API

2022-11-15 Thread GitBox
tvm-bot commented on PR #13402: URL: https://github.com/apache/tvm/pull/13402#issuecomment-1316470418 Thanks for contributing to TVM! Please refer to the contributing guidelines https://tvm.apache.org/docs/contribute/ for useful information and tips. Please request code reviews

[GitHub] [tvm] chunit-quic opened a new pull request, #13402: [Relay][Frontend] Span filling common API

2022-11-15 Thread GitBox
chunit-quic opened a new pull request, #13402: URL: https://github.com/apache/tvm/pull/13402 - Expose and add span attribute of Expr-derived types from C++ to Python - Add common API of span filling - Add test cases of span filling - Add function to control whether to fill span via

[GitHub] [tvm] Alexey-Yazev commented on a diff in pull request #13369: [usmp] Hill Climb greedy layout size check relaxed

2022-11-15 Thread GitBox
Alexey-Yazev commented on code in PR #13369: URL: https://github.com/apache/tvm/pull/13369#discussion_r1023569114 ## tests/python/contrib/test_ethosu/test_networks.py: ## @@ -142,18 +141,8 @@ def test_networks_with_usmp_and_cascader_wo_striping(accel_type, model_url, work

[GitHub] [tvm] driazati commented on pull request #13398: [CI] Update minor git options

2022-11-15 Thread GitBox
driazati commented on PR #13398: URL: https://github.com/apache/tvm/pull/13398#issuecomment-1316467139 I'm good with merging this PR but just curious about `--filter=tree:0`, it seems like from that article that `--depth=1` is still best here since it avoids downloading the whole history

[tvm] branch main updated (6401d0ef62 -> 0d9b1850af)

2022-11-15 Thread driazati
This is an automated email from the ASF dual-hosted git repository. driazati pushed a change to branch main in repository https://gitbox.apache.org/repos/asf/tvm.git from 6401d0ef62 [TIR] Fix extern_primfunc buffer order bug (#13347) add 0d9b1850af [ci] fix GPU other build (#13366)

[GitHub] [tvm] driazati merged pull request #13366: [ci] fix GPU other build

2022-11-15 Thread GitBox
driazati merged PR #13366: URL: https://github.com/apache/tvm/pull/13366 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [tvm] tvm-bot commented on pull request #13401: [TOPI] Specify names for pooling ops

2022-11-15 Thread GitBox
tvm-bot commented on PR #13401: URL: https://github.com/apache/tvm/pull/13401#issuecomment-1316455262 Thanks for contributing to TVM! Please refer to the contributing guidelines https://tvm.apache.org/docs/contribute/ for useful information and tips. Please request code reviews

[GitHub] [tvm] abhikran-quic opened a new pull request, #13401: [TOPI] Specify names for pooling ops

2022-11-15 Thread GitBox
abhikran-quic opened a new pull request, #13401: URL: https://github.com/apache/tvm/pull/13401 - Explicit names are useful while fetching the compute during scheduling of pooling ops. - Specify `meta_schedule` attributes. -- This is an automated message from the Apache Git Service. To

[GitHub] [tvm] echuraev commented on a diff in pull request #13393: [Adreno] Add documentation for Adreno deployment

2022-11-15 Thread GitBox
echuraev commented on code in PR #13393: URL: https://github.com/apache/tvm/pull/13393#discussion_r1023537991 ## docs/how_to/deploy/adreno.rst: ## @@ -0,0 +1,314 @@ +Deploy to Adreno GPU +=== + +**Authors**: Daniil Barinov, Egor Churaev,

[GitHub] [tvm] zxybazh commented on a diff in pull request #13399: [MetaSchedule] Fix segfault in gradient based scheduler

2022-11-15 Thread GitBox
zxybazh commented on code in PR #13399: URL: https://github.com/apache/tvm/pull/13399#discussion_r1023535988 ## tests/python/unittest/test_meta_schedule_task_scheduler.py: ## @@ -352,10 +353,85 @@ def test_meta_schedule_task_scheduler_multiple_gradient_based(): )

[GitHub] [tvm] tvm-bot commented on pull request #13400: [OpenCL][CI] Enable OpenCL cpp tests in CI

2022-11-15 Thread GitBox
tvm-bot commented on PR #13400: URL: https://github.com/apache/tvm/pull/13400#issuecomment-1316411680 Thanks for contributing to TVM! Please refer to the contributing guidelines https://tvm.apache.org/docs/contribute/ for useful information and tips. Please request code reviews

[GitHub] [tvm] echuraev opened a new pull request, #13400: [OpenCL][CI] Enable OpenCL cpp tests in CI

2022-11-15 Thread GitBox
echuraev opened a new pull request, #13400: URL: https://github.com/apache/tvm/pull/13400 Enable OpenCL cpp tests in CI -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [tvm] abhikran-quic commented on a diff in pull request #13388: [Hexagon] Use VTCM while scheduling conv2d op

2022-11-15 Thread GitBox
abhikran-quic commented on code in PR #13388: URL: https://github.com/apache/tvm/pull/13388#discussion_r1023512424 ## tests/python/contrib/test_hexagon/metaschedule_e2e/test_resnet50_int8.py: ## @@ -248,8 +248,9 @@ def index_map_nchw32c_nchw8h8w32c(n_batch, channel, height,

[GitHub] [tvm] abhikran-quic commented on pull request #13388: [Hexagon] Use VTCM while scheduling conv2d op

2022-11-15 Thread GitBox
abhikran-quic commented on PR #13388: URL: https://github.com/apache/tvm/pull/13388#issuecomment-1316362164 > > to reduce tuning time > > This test doesn't really tune anything, but does this change bring such non-trivial reduction? Yes. I saw the test execution time to come

[GitHub] [tvm] tvm-bot commented on pull request #13399: [MetaSchedule] Fix segfault in gradient based scheduler

2022-11-15 Thread GitBox
tvm-bot commented on PR #13399: URL: https://github.com/apache/tvm/pull/13399#issuecomment-1316347917 Thanks for contributing to TVM! Please refer to the contributing guidelines https://tvm.apache.org/docs/contribute/ for useful information and tips. Please request code reviews

[GitHub] [tvm] yelite opened a new pull request, #13399: [MetaSchedule] Fix segfault in gradient based scheduler

2022-11-15 Thread GitBox
yelite opened a new pull request, #13399: URL: https://github.com/apache/tvm/pull/13399 Gradient based scheduler would segfault if no candidates can be returned by the search strategy for some workload. It's expected that the scheduler continues to tune other workloads that have

[tvm] branch main updated: [TIR] Fix extern_primfunc buffer order bug (#13347)

2022-11-15 Thread junrushao
This is an automated email from the ASF dual-hosted git repository. junrushao pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/tvm.git The following commit(s) were added to refs/heads/main by this push: new 6401d0ef62 [TIR] Fix extern_primfunc buffer order

[GitHub] [tvm] junrushao closed issue #13330: [Bug] DomainTouchedAccessMap does not preserve buffer order

2022-11-15 Thread GitBox
junrushao closed issue #13330: [Bug] DomainTouchedAccessMap does not preserve buffer order URL: https://github.com/apache/tvm/issues/13330 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [tvm] junrushao merged pull request #13347: [TIR] Fix extern_primfunc buffer order bug

2022-11-15 Thread GitBox
junrushao merged PR #13347: URL: https://github.com/apache/tvm/pull/13347 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [tvm] junrushao commented on pull request #13347: [TIR] Fix extern_primfunc buffer order bug

2022-11-15 Thread GitBox
junrushao commented on PR #13347: URL: https://github.com/apache/tvm/pull/13347#issuecomment-1316296008 Thanks @guberti for confirming :-) Merging it in -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [tvm] guberti commented on pull request #13347: [TIR] Fix extern_primfunc buffer order bug

2022-11-15 Thread GitBox
guberti commented on PR #13347: URL: https://github.com/apache/tvm/pull/13347#issuecomment-1316291634 @junrushao I've confirmed the TVMScript issue (#13360) is fixed, can we merge this? -- This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [tvm] guberti commented on issue #13360: [Bug] TVMScript does not parse correctly with Python 3.8

2022-11-15 Thread GitBox
guberti commented on issue #13360: URL: https://github.com/apache/tvm/issues/13360#issuecomment-1316290986 @junrushao just tested it, the issue is fixed on the latest HEAD. Your testing script and the unit test `tests/python/unittest/test_tir_te_extern_primfunc.py` both work. Thanks! --

[GitHub] [tvm] guberti closed issue #13360: [Bug] TVMScript does not parse correctly with Python 3.8

2022-11-15 Thread GitBox
guberti closed issue #13360: [Bug] TVMScript does not parse correctly with Python 3.8 URL: https://github.com/apache/tvm/issues/13360 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[tvm] branch main updated (edc1bfd105 -> a042a93cd9)

2022-11-15 Thread junrushao
This is an automated email from the ASF dual-hosted git repository. junrushao pushed a change to branch main in repository https://gitbox.apache.org/repos/asf/tvm.git from edc1bfd105 Add support for cast double to fp16 (#13395) add a042a93cd9 [TIR] Add test to cover specific case of

[GitHub] [tvm] junrushao merged pull request #13373: [TIR] Add test to cover specific case of reducer match buffer checking

2022-11-15 Thread GitBox
junrushao merged PR #13373: URL: https://github.com/apache/tvm/pull/13373 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[tvm] branch main updated (e030b146d9 -> edc1bfd105)

2022-11-15 Thread junrushao
This is an automated email from the ASF dual-hosted git repository. junrushao pushed a change to branch main in repository https://gitbox.apache.org/repos/asf/tvm.git from e030b146d9 [TECompiler] Replace static constant index with NameSupply (#13397) add edc1bfd105 Add support for

[GitHub] [tvm] junrushao merged pull request #13395: Add support for cast double to fp16

2022-11-15 Thread GitBox
junrushao merged PR #13395: URL: https://github.com/apache/tvm/pull/13395 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[tvm] branch main updated (49c5d2f173 -> e030b146d9)

2022-11-15 Thread junrushao
This is an automated email from the ASF dual-hosted git repository. junrushao pushed a change to branch main in repository https://gitbox.apache.org/repos/asf/tvm.git from 49c5d2f173 [Hexagon] Change single dma alloc buffers to be vtcm (#13374) add e030b146d9 [TECompiler] Replace

[GitHub] [tvm] junrushao merged pull request #13397: [TECompiler] Replace static constant index with NameSupply

2022-11-15 Thread GitBox
junrushao merged PR #13397: URL: https://github.com/apache/tvm/pull/13397 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[tvm] branch main updated (86a5ceec27 -> 49c5d2f173)

2022-11-15 Thread junrushao
This is an automated email from the ASF dual-hosted git repository. junrushao pushed a change to branch main in repository https://gitbox.apache.org/repos/asf/tvm.git from 86a5ceec27 [TVMScript] Use tir::Evaluate if expression is in statement context (#13396) add 49c5d2f173 [Hexagon]

[GitHub] [tvm] junrushao merged pull request #13374: [Hexagon] Change single dma alloc buffers to be vtcm

2022-11-15 Thread GitBox
junrushao merged PR #13374: URL: https://github.com/apache/tvm/pull/13374 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [tvm] tvm-bot commented on pull request #13398: [CI] Update minor git options

2022-11-15 Thread GitBox
tvm-bot commented on PR #13398: URL: https://github.com/apache/tvm/pull/13398#issuecomment-1316257381 Thanks for contributing to TVM! Please refer to the contributing guidelines https://tvm.apache.org/docs/contribute/ for useful information and tips. Please request code reviews

[GitHub] [tvm] mshr-h opened a new pull request, #13398: [CI] Update minor git options

2022-11-15 Thread GitBox
mshr-h opened a new pull request, #13398: URL: https://github.com/apache/tvm/pull/13398 The changes are listed below. - avoid git checkout after git clone - use --filter=tree:0 instead of --depth 1 because [it' preferred for

[GitHub] [tvm] mehrdadh commented on a diff in pull request #13335: [ci] Split out C++ unittests

2022-11-15 Thread GitBox
mehrdadh commented on code in PR #13335: URL: https://github.com/apache/tvm/pull/13335#discussion_r1023422856 ## tests/scripts/task_cpp_unittest.sh: ## @@ -28,38 +28,15 @@ else BUILD_DIR=build fi -# Python is required by apps/bundle_deploy -source

[GitHub] [tvm] alter-xp commented on a diff in pull request #13366: [ci] fix GPU other build

2022-11-15 Thread GitBox
alter-xp commented on code in PR #13366: URL: https://github.com/apache/tvm/pull/13366#discussion_r1023419852 ## ci/jenkins/Build.groovy.j2: ## @@ -21,7 +21,7 @@ def fsim_test(image) { def cmake_build(image, path, make_flag) { sh ( -script: "${docker_run} --env

[GitHub] [tvm] mehrdadh commented on a diff in pull request #13335: [ci] Split out C++ unittests

2022-11-15 Thread GitBox
mehrdadh commented on code in PR #13335: URL: https://github.com/apache/tvm/pull/13335#discussion_r1023418780 ## tests/scripts/task_microtvm_cpp_tests.sh: ## @@ -0,0 +1,44 @@ +#!/usr/bin/env bash Review Comment: is this used anywhere? -- This is an automated message

[GitHub] [tvm] driazati commented on a diff in pull request #13366: [ci] fix GPU other build

2022-11-15 Thread GitBox
driazati commented on code in PR #13366: URL: https://github.com/apache/tvm/pull/13366#discussion_r1023417800 ## ci/jenkins/Build.groovy.j2: ## @@ -21,7 +21,7 @@ def fsim_test(image) { def cmake_build(image, path, make_flag) { sh ( -script: "${docker_run} --env

[GitHub] [tvm] driazati commented on a diff in pull request #13335: [ci] Split out C++ unittests

2022-11-15 Thread GitBox
driazati commented on code in PR #13335: URL: https://github.com/apache/tvm/pull/13335#discussion_r1023416998 ## ci/jenkins/Test.groovy.j2: ## @@ -14,11 +21,19 @@ test_method_names=test_method_names, ) %} {% if shard_index == 1 %} - {{ m.download_artifacts(tag='gpu2',

[tvm] branch main updated: [TVMScript] Use tir::Evaluate if expression is in statement context (#13396)

2022-11-15 Thread syfeng
This is an automated email from the ASF dual-hosted git repository. syfeng pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/tvm.git The following commit(s) were added to refs/heads/main by this push: new 86a5ceec27 [TVMScript] Use tir::Evaluate if expression

[GitHub] [tvm] Hzfengsy merged pull request #13396: [TVMScript] Use tir::Evaluate if expression is in statement context

2022-11-15 Thread GitBox
Hzfengsy merged PR #13396: URL: https://github.com/apache/tvm/pull/13396 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [tvm] masahi opened a new pull request, #13397: [TECompiler] Replace static constant index with NameSupply

2022-11-15 Thread GitBox
masahi opened a new pull request, #13397: URL: https://github.com/apache/tvm/pull/13397 The `static` qualifier on the constant index causes a problem, when `TECompiler` is invoked on the same module multiple times. Since the names of constants become different in each call to `TECompiler`,

[GitHub] [tvm] tvm-bot commented on pull request #13397: [TECompiler] Replace static constant index with NameSupply

2022-11-15 Thread GitBox
tvm-bot commented on PR #13397: URL: https://github.com/apache/tvm/pull/13397#issuecomment-1316102530 Thanks for contributing to TVM! Please refer to the contributing guidelines https://tvm.apache.org/docs/contribute/ for useful information and tips. Please request code reviews

[GitHub] [tvm] Icemist commented on issue #10317: Auto-cc subscription tracker

2022-11-15 Thread GitBox
Icemist commented on issue #10317: URL: https://github.com/apache/tvm/issues/10317#issuecomment-1316070153 hexagon @Icemist -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[tvm] branch nightly-docker-update updated (4ce2e82ea1 -> 4806d9088e)

2022-11-15 Thread github-bot
This is an automated email from the ASF dual-hosted git repository. github-bot pushed a change to branch nightly-docker-update in repository https://gitbox.apache.org/repos/asf/tvm.git omit 4ce2e82ea1 [ci][docker] Nightly Docker image update add 3aa16f72dd [Codegen] Fix CUDA codegen

[tvm] branch main updated: [OpenCL] Introduce OpenCL wrapper to TVM (#13362)

2022-11-15 Thread masahi
This is an automated email from the ASF dual-hosted git repository. masahi pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/tvm.git The following commit(s) were added to refs/heads/main by this push: new 2bb3382c89 [OpenCL] Introduce OpenCL wrapper to TVM

[GitHub] [tvm] masahi merged pull request #13362: [OpenCL] Introduce OpenCL wrapper to TVM

2022-11-15 Thread GitBox
masahi merged PR #13362: URL: https://github.com/apache/tvm/pull/13362 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [tvm] junrushao commented on pull request #13396: [TVMScript] Use tir::Evaluate if expression is in statement context

2022-11-15 Thread GitBox
junrushao commented on PR #13396: URL: https://github.com/apache/tvm/pull/13396#issuecomment-1315970348 Thanks for the great update! This helps a lot with the usability of TVMScript :-) Let's get it in ASAP! -- This is an automated message from the Apache Git Service. To respond to the

[GitHub] [tvm] junrushao commented on a diff in pull request #13396: [TVMScript] Use tir::Evaluate if expression is in statement context

2022-11-15 Thread GitBox
junrushao commented on code in PR #13396: URL: https://github.com/apache/tvm/pull/13396#discussion_r1023332191 ## python/tvm/script/parser/tir/parser.py: ## @@ -411,6 +412,10 @@ def visit_expr_stmt(self: Parser, node: doc.Expr) -> None: if isinstance(res, Frame):

[tvm] branch main updated: [TOPI][Hexagon] Implement quantized adaptive_avg_pool1d for hexagon (#13282)

2022-11-15 Thread mehrdadh
This is an automated email from the ASF dual-hosted git repository. mehrdadh pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/tvm.git The following commit(s) were added to refs/heads/main by this push: new 4f4b4edafd [TOPI][Hexagon] Implement quantized

[GitHub] [tvm] mehrdadh merged pull request #13282: [TOPI][Hexagon] Implement quantized adaptive_avg_pool1d for hexagon

2022-11-15 Thread GitBox
mehrdadh merged PR #13282: URL: https://github.com/apache/tvm/pull/13282 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [tvm] junrushao commented on a diff in pull request #13396: [TVMScript] Use tir::Evaluate if expression is in statement context

2022-11-15 Thread GitBox
junrushao commented on code in PR #13396: URL: https://github.com/apache/tvm/pull/13396#discussion_r1023328978 ## tests/python/unittest/test_tvmscript_roundtrip.py: ## @@ -3458,6 +3458,15 @@ def func() -> None: return func +def implicit_evaluate(): +@T.prim_func +

[GitHub] [tvm] trahman-quic commented on pull request #13282: [TOPI][Hexagon] Implement quantized adaptive_avg_pool1d for hexagon

2022-11-15 Thread GitBox
trahman-quic commented on PR #13282: URL: https://github.com/apache/tvm/pull/13282#issuecomment-1315963048 Hi @mehrdadh thank you for suggesting the fix for import. All tests have passed now. If it looks good to you, we can merge it. -- This is an automated message from the Apache Git

[GitHub] [tvm] nverke commented on pull request #13374: [Hexagon] Change single dma alloc buffers to be vtcm

2022-11-15 Thread GitBox
nverke commented on PR #13374: URL: https://github.com/apache/tvm/pull/13374#issuecomment-1315940024 Oh I see. Sorry, I thought it was just a mistake did not realize that the test is broken now. Going to remove that schedule as it is not needed. Thanks for the investigation! -- This is

[GitHub] [tvm] Lunderberg commented on pull request #13396: [TVMScript] Use tir::Evaluate if expression is in statement context

2022-11-15 Thread GitBox
Lunderberg commented on PR #13396: URL: https://github.com/apache/tvm/pull/13396#issuecomment-1315920808 > LGTM! I was thinking about the same thing but holding back a bit because I dont want to change TIR too often, but it is definitely a positive change and I really love it Thank

[GitHub] [tvm] Lunderberg commented on a diff in pull request #13396: [TVMScript] Use tir::Evaluate if expression is in statement context

2022-11-15 Thread GitBox
Lunderberg commented on code in PR #13396: URL: https://github.com/apache/tvm/pull/13396#discussion_r1023299110 ## src/printer/tvmscript_printer.cc: ## @@ -1275,16 +1275,11 @@ Doc TVMScriptPrinter::VisitStmt_(const SeqStmtNode* op) { } Doc

[GitHub] [tvm] Lunderberg commented on a diff in pull request #13396: [TVMScript] Use tir::Evaluate if expression is in statement context

2022-11-15 Thread GitBox
Lunderberg commented on code in PR #13396: URL: https://github.com/apache/tvm/pull/13396#discussion_r1023297485 ## tests/python/unittest/test_tvmscript_roundtrip.py: ## @@ -3458,6 +3458,15 @@ def func() -> None: return func +def implicit_evaluate(): +@T.prim_func +

[GitHub] [tvm] Lunderberg commented on a diff in pull request #13396: [TVMScript] Use tir::Evaluate if expression is in statement context

2022-11-15 Thread GitBox
Lunderberg commented on code in PR #13396: URL: https://github.com/apache/tvm/pull/13396#discussion_r1023296204 ## python/tvm/script/parser/tir/parser.py: ## @@ -411,6 +412,10 @@ def visit_expr_stmt(self: Parser, node: doc.Expr) -> None: if isinstance(res, Frame):

[GitHub] [tvm] michalpiszczek commented on a diff in pull request #12496: [TVMScript] Reorganize the folder structure

2022-11-15 Thread GitBox
michalpiszczek commented on code in PR #12496: URL: https://github.com/apache/tvm/pull/12496#discussion_r1023292517 ## python/tvm/script/__init__.py: ## @@ -14,8 +14,5 @@ # KIND, either express or implied. See the License for the # specific language governing permissions and

[GitHub] [tvm] nverke commented on pull request #13352: [Hexagon] Add test to show scheduling of resnet50 with async dma pipe…

2022-11-15 Thread GitBox
nverke commented on PR #13352: URL: https://github.com/apache/tvm/pull/13352#issuecomment-1315901484 The changes to TIR broke the tensorization with this so those issues need to be fixed. For the time being rebased on top of another commit and made updates that were requested. -- This

[GitHub] [tvm] nverke commented on a diff in pull request #13352: [Hexagon] Add test to show scheduling of resnet50 with async dma pipe…

2022-11-15 Thread GitBox
nverke commented on code in PR #13352: URL: https://github.com/apache/tvm/pull/13352#discussion_r1023286600 ## tests/python/contrib/test_hexagon/metaschedule_e2e/test_resnet50_int8.py: ## @@ -372,6 +596,11 @@ def test_packed_8x8x32_resnet50(hexagon_launcher):

[GitHub] [tvm] nverke commented on a diff in pull request #13352: [Hexagon] Add test to show scheduling of resnet50 with async dma pipe…

2022-11-15 Thread GitBox
nverke commented on code in PR #13352: URL: https://github.com/apache/tvm/pull/13352#discussion_r1023285390 ## tests/python/contrib/test_hexagon/metaschedule_e2e/test_resnet50_int8.py: ## @@ -359,11 +371,223 @@ def test_packed_8x8x32_resnet50(hexagon_launcher):

[GitHub] [tvm] nverke commented on a diff in pull request #13352: [Hexagon] Add test to show scheduling of resnet50 with async dma pipe…

2022-11-15 Thread GitBox
nverke commented on code in PR #13352: URL: https://github.com/apache/tvm/pull/13352#discussion_r1023284963 ## tests/python/contrib/test_hexagon/metaschedule_e2e/test_resnet50_int8.py: ## @@ -208,7 +215,7 @@ def schedule_fn(sch, conv2d_block: Optional[BlockRV] = None) -> bool:

[GitHub] [tvm] nverke commented on a diff in pull request #13352: [Hexagon] Add test to show scheduling of resnet50 with async dma pipe…

2022-11-15 Thread GitBox
nverke commented on code in PR #13352: URL: https://github.com/apache/tvm/pull/13352#discussion_r1023284499 ## python/tvm/contrib/hexagon/meta_schedule.py: ## @@ -121,14 +129,23 @@ def _worker_func(hexagon_launcher, evaluator_config, alloc_repeat, artifact_path return

[GitHub] [tvm] masahi closed issue #13390: [Bug] when Debugging TVM,how to VLOGging just with only one file ?

2022-11-15 Thread GitBox
masahi closed issue #13390: [Bug] when Debugging TVM,how to VLOGging just with only one file ? URL: https://github.com/apache/tvm/issues/13390 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [tvm] masahi commented on issue #13390: [Bug] when Debugging TVM,how to VLOGging just with only one file ?

2022-11-15 Thread GitBox
masahi commented on issue #13390: URL: https://github.com/apache/tvm/issues/13390#issuecomment-1315886025 Github issue is not the place to ask general questions. Please use the discussion forum. -- This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [tvm] junrushao commented on a diff in pull request #13396: [TVMScript] Use tir::Evaluate if expression is in statement context

2022-11-15 Thread GitBox
junrushao commented on code in PR #13396: URL: https://github.com/apache/tvm/pull/13396#discussion_r1023260390 ## src/printer/tvmscript_printer.cc: ## @@ -1275,16 +1275,11 @@ Doc TVMScriptPrinter::VisitStmt_(const SeqStmtNode* op) { } Doc TVMScriptPrinter::VisitStmt_(const

[GitHub] [tvm] junrushao commented on a diff in pull request #13396: [TVMScript] Use tir::Evaluate if expression is in statement context

2022-11-15 Thread GitBox
junrushao commented on code in PR #13396: URL: https://github.com/apache/tvm/pull/13396#discussion_r1023258542 ## python/tvm/script/parser/tir/parser.py: ## @@ -411,6 +412,10 @@ def visit_expr_stmt(self: Parser, node: doc.Expr) -> None: if isinstance(res, Frame):

[GitHub] [tvm] driazati commented on a diff in pull request #13300: [ci] Split Jenkinsfile into platform-specific jobs

2022-11-15 Thread GitBox
driazati commented on code in PR #13300: URL: https://github.com/apache/tvm/pull/13300#discussion_r1023251090 ## ci/jenkins/generated/docker_jenkinsfile.groovy: ## @@ -0,0 +1,928 @@ +#!groovy +// -*- mode: groovy -*- + +// Licensed to the Apache Software Foundation (ASF) under

[GitHub] [tvm] junrushao commented on pull request #13347: [TIR] Fix extern_primfunc buffer order bug

2022-11-15 Thread GitBox
junrushao commented on PR #13347: URL: https://github.com/apache/tvm/pull/13347#issuecomment-1315853968 I'm happy to merge it in once it's confirmed that the TVMScript issue has been fixed. -- This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [tvm] junrushao commented on issue #13360: [Bug] TVMScript does not parse correctly with Python 3.8

2022-11-15 Thread GitBox
junrushao commented on issue #13360: URL: https://github.com/apache/tvm/issues/13360#issuecomment-1315853244 Hey @guberti, this issue should be fixed in the latest HEAD. Testing script: ```python from tvm.script import tir as T @T.prim_func def func_1( A:

[GitHub] [tvm] Lunderberg commented on pull request #13396: [TVMScript] Use tir::Evaluate if expression is in statement context

2022-11-15 Thread GitBox
Lunderberg commented on PR #13396: URL: https://github.com/apache/tvm/pull/13396#issuecomment-1315851513 This PR is in response to CI failures found in https://github.com/apache/tvm/pull/13130, when writing TVMScript that used the `T.assume()` builtin without wrapping in `T.evaluate()`. I

[GitHub] [tvm] tvm-bot commented on pull request #13396: [TVMScript] Use tir::Evaluate if expression is in statement context

2022-11-15 Thread GitBox
tvm-bot commented on PR #13396: URL: https://github.com/apache/tvm/pull/13396#issuecomment-1315846775 Thanks for contributing to TVM! Please refer to the contributing guidelines https://tvm.apache.org/docs/contribute/ for useful information and tips. Please request code reviews

[GitHub] [tvm] Lunderberg opened a new pull request, #13396: [TVMScript] Use tir::Evaluate if expression is in statement context

2022-11-15 Thread GitBox
Lunderberg opened a new pull request, #13396: URL: https://github.com/apache/tvm/pull/13396 For the previous version of the parser, this was special-cased for some intrinsic operators. After the new TVMScript was enabled in https://github.com/apache/tvm/pull/12496, any `PrimExpr` that

[GitHub] [tvm] tvm-bot commented on pull request #13396: [TVMScript] Use tir::Evaluate if expression is in statement context

2022-11-15 Thread GitBox
tvm-bot commented on PR #13396: URL: https://github.com/apache/tvm/pull/13396#issuecomment-1315846779 Thanks for contributing to TVM! Please refer to the contributing guidelines https://tvm.apache.org/docs/contribute/ for useful information and tips. Please request code reviews

[GitHub] [tvm] Lunderberg commented on pull request #13130: [TIR][Arith] Implement basic data-flow analysis

2022-11-15 Thread GitBox
Lunderberg commented on PR #13130: URL: https://github.com/apache/tvm/pull/13130#issuecomment-1315840361 Current CI failures are due to `T.assume(expr)` no longer being parsed by TVMScript on main. It looks like this is related to https://github.com/apache/tvm/pull/12496. After that PR,

[tvm] branch main updated: [docs] Add some more release process docs (#13351)

2022-11-15 Thread junrushao
This is an automated email from the ASF dual-hosted git repository. junrushao pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/tvm.git The following commit(s) were added to refs/heads/main by this push: new 557f1a9ded [docs] Add some more release process

[GitHub] [tvm] junrushao merged pull request #13351: [docs] Add some more release process docs

2022-11-15 Thread GitBox
junrushao merged PR #13351: URL: https://github.com/apache/tvm/pull/13351 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[tvm] branch main updated: [tvm4j] Fix tvm4j build on MacOS (#13370)

2022-11-15 Thread junrushao
This is an automated email from the ASF dual-hosted git repository. junrushao pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/tvm.git The following commit(s) were added to refs/heads/main by this push: new aa0c0db71b [tvm4j] Fix tvm4j build on MacOS

[GitHub] [tvm] junrushao merged pull request #13370: [tvm4j] Fix tvm4j build on MacOS

2022-11-15 Thread GitBox
junrushao merged PR #13370: URL: https://github.com/apache/tvm/pull/13370 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[tvm] branch main updated: [Hexagon] Use VTCM while scheduling conv2d op (#13388)

2022-11-15 Thread junrushao
This is an automated email from the ASF dual-hosted git repository. junrushao pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/tvm.git The following commit(s) were added to refs/heads/main by this push: new bac450a645 [Hexagon] Use VTCM while scheduling

[GitHub] [tvm] junrushao merged pull request #13388: [Hexagon] Use VTCM while scheduling conv2d op

2022-11-15 Thread GitBox
junrushao merged PR #13388: URL: https://github.com/apache/tvm/pull/13388 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [tvm] junrushao commented on pull request #13327: [TIR] Unify index data type when creating prim func

2022-11-15 Thread GitBox
junrushao commented on PR #13327: URL: https://github.com/apache/tvm/pull/13327#issuecomment-1315831212 Happy to review and let's fix the CI :-) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [tvm] junrushao merged pull request #13385: [TOPI] Add padding for dense/batch matmul for x86 vnni

2022-11-15 Thread GitBox
junrushao merged PR #13385: URL: https://github.com/apache/tvm/pull/13385 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [tvm] junrushao commented on pull request #13385: [TOPI] Add padding for dense/batch matmul for x86 vnni

2022-11-15 Thread GitBox
junrushao commented on PR #13385: URL: https://github.com/apache/tvm/pull/13385#issuecomment-1315830731 Neat. Thanks for the contribution! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[tvm] branch main updated: [TOPI] Add padding for dense/batch matmul for x86 vnni (#13385)

2022-11-15 Thread junrushao
This is an automated email from the ASF dual-hosted git repository. junrushao pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/tvm.git The following commit(s) were added to refs/heads/main by this push: new 42f9a766ff [TOPI] Add padding for dense/batch

[tvm] branch main updated: [MetaSchedule] Support schedules with cache read in RewriteLayout (#13384)

2022-11-15 Thread junrushao
This is an automated email from the ASF dual-hosted git repository. junrushao pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/tvm.git The following commit(s) were added to refs/heads/main by this push: new 8c30bda738 [MetaSchedule] Support schedules with

[GitHub] [tvm] driazati commented on pull request #13276: [ci][tvmbot] Fix spelling error, metionable -> mentionable

2022-11-15 Thread GitBox
driazati commented on PR #13276: URL: https://github.com/apache/tvm/pull/13276#issuecomment-1315824931 Hey @bkmgit, we recently merged a PR #13276 that makes it so you can iterate and test on this PR without needing a committer in the loop, can you rebase this PR to fix the conflicts then

[GitHub] [tvm] junrushao merged pull request #13384: [MetaSchedule] Support schedules with cache read in RewriteLayout

2022-11-15 Thread GitBox
junrushao merged PR #13384: URL: https://github.com/apache/tvm/pull/13384 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [tvm] junrushao commented on a diff in pull request #13384: [MetaSchedule] Support schedules with cache read in RewriteLayout

2022-11-15 Thread GitBox
junrushao commented on code in PR #13384: URL: https://github.com/apache/tvm/pull/13384#discussion_r1023226878 ## src/te/operation/create_primfunc.cc: ## @@ -110,13 +110,20 @@ class LayoutFreePlaceholdersNormalizer : public StmtMutator { Block block =

[GitHub] [tvm] driazati closed pull request #12941: [ci] Split the ci/scripts directory into ci/scripts/github and ci/scripts/jenkins

2022-11-15 Thread GitBox
driazati closed pull request #12941: [ci] Split the ci/scripts directory into ci/scripts/github and ci/scripts/jenkins URL: https://github.com/apache/tvm/pull/12941 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [tvm] driazati closed pull request #13276: [ci][tvmbot] Fix spelling error, metionable -> mentionable

2022-11-15 Thread GitBox
driazati closed pull request #13276: [ci][tvmbot] Fix spelling error, metionable -> mentionable URL: https://github.com/apache/tvm/pull/13276 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [tvm] driazati commented on a diff in pull request #13300: [ci] Split Jenkinsfile into platform-specific jobs

2022-11-15 Thread GitBox
driazati commented on code in PR #13300: URL: https://github.com/apache/tvm/pull/13300#discussion_r1023223953 ## ci/jenkins/generated/arm_jenkinsfile.groovy: ## @@ -0,0 +1,1042 @@ +#!groovy +// -*- mode: groovy -*- + +// Licensed to the Apache Software Foundation (ASF) under

[GitHub] [tvm] tmoreau89 commented on pull request #13392: [AOT][FIX] Handle device contexts properly in CreateFunctionMetadata

2022-11-15 Thread GitBox
tmoreau89 commented on PR #13392: URL: https://github.com/apache/tvm/pull/13392#issuecomment-1315820742 Thanks @mbaret @Mousius the PR has been merged -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[tvm] branch main updated (24790d1d56 -> 72c60ad78a)

2022-11-15 Thread moreau
This is an automated email from the ASF dual-hosted git repository. moreau pushed a change to branch main in repository https://gitbox.apache.org/repos/asf/tvm.git from 24790d1d56 [RUNTIME][ALIGNMENT] Configurable kAllocAlignment if needed (#13307) add 72c60ad78a [AOT][FIX] Handle

[GitHub] [tvm] driazati commented on a diff in pull request #13300: [ci] Split Jenkinsfile into platform-specific jobs

2022-11-15 Thread GitBox
driazati commented on code in PR #13300: URL: https://github.com/apache/tvm/pull/13300#discussion_r1023223237 ## ci/jenkins/generate.py: ## @@ -173,17 +147,30 @@ def change_type(lines: List[str]) -> Change: diff = "".join(diff) +return ChangeData(diff=diff,

[GitHub] [tvm] tmoreau89 merged pull request #13392: [AOT][FIX] Handle device contexts properly in CreateFunctionMetadata

2022-11-15 Thread GitBox
tmoreau89 merged PR #13392: URL: https://github.com/apache/tvm/pull/13392 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

  1   2   3   >