[GitHub] [tvm] junrushao merged pull request #15827: [Unity][Disco] Use default stream in disco

2023-09-26 Thread via GitHub
junrushao merged PR #15827: URL: https://github.com/apache/tvm/pull/15827 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@tvm.apache

[tvm] branch unity updated (beef1f7c75 -> d06a658b10)

2023-09-26 Thread junrushao
This is an automated email from the ASF dual-hosted git repository. junrushao pushed a change to branch unity in repository https://gitbox.apache.org/repos/asf/tvm.git from beef1f7c75 [TE] Support using tir::Var as CreatePrimFunc args (#15817) add d06a658b10 [Unity][Disco] Use default s

[GitHub] [tvm] masahi opened a new pull request, #15831: [Unity][BYOC] Support offloading multi-query attention by Flash Attention

2023-09-26 Thread via GitHub
masahi opened a new pull request, #15831: URL: https://github.com/apache/tvm/pull/15831 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[tvm] branch nightly updated (cde83e1088 -> d5fab9e4fb)

2023-09-26 Thread github-bot
This is an automated email from the ASF dual-hosted git repository. github-bot pushed a change to branch nightly in repository https://gitbox.apache.org/repos/asf/tvm.git from cde83e1088 [TVMC] enable dumping imported modules too (#15779) add dfd525bda5 Revert "[TensorIR][Visitor] Visit

[GitHub] [tvm] github-actions[bot] commented on pull request #15823: [Unity] Add Relax multi-device e2e cases

2023-09-26 Thread via GitHub
github-actions[bot] commented on PR #15823: URL: https://github.com/apache/tvm/pull/15823#issuecomment-1736621514 Failed to re-run CI in https://github.com/apache/tvm/actions/runs/6321093415 ``` Traceback (most recent call last): File "ci/scripts/github/github_tvmbot.py

[GitHub] [tvm] yongwww commented on pull request #15823: [Unity] Add Relax multi-device e2e cases

2023-09-26 Thread via GitHub
yongwww commented on PR #15823: URL: https://github.com/apache/tvm/pull/15823#issuecomment-1736621315 @tvm-bot rerun -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To uns

[GitHub] [tvm] yongwww commented on pull request #15817: [TE] Support using tir::Var as CreatePrimFunc args

2023-09-26 Thread via GitHub
yongwww commented on PR #15817: URL: https://github.com/apache/tvm/pull/15817#issuecomment-1736618293 thanks for the change, looks good to me! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [tvm] LeshengJin opened a new pull request, #15828: Remove create_relax_prim_func

2023-09-26 Thread via GitHub
LeshengJin opened a new pull request, #15828: URL: https://github.com/apache/tvm/pull/15828 A followup pr of #15817 cc: @junrushao -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the spe

[GitHub] [tvm] junrushao commented on pull request #15826: [Disco] Loading-time sharding support

2023-09-26 Thread via GitHub
junrushao commented on PR #15826: URL: https://github.com/apache/tvm/pull/15826#issuecomment-1736533921 CC: @jinhongyii -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[tvm] branch unity updated: [TE] Support using tir::Var as CreatePrimFunc args (#15817)

2023-09-26 Thread junrushao
This is an automated email from the ASF dual-hosted git repository. junrushao pushed a commit to branch unity in repository https://gitbox.apache.org/repos/asf/tvm.git The following commit(s) were added to refs/heads/unity by this push: new beef1f7c75 [TE] Support using tir::Var as CreatePr

[GitHub] [tvm] junrushao merged pull request #15817: [TE] Support using tir::Var as CreatePrimFunc args

2023-09-26 Thread via GitHub
junrushao merged PR #15817: URL: https://github.com/apache/tvm/pull/15817 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@tvm.apache

[GitHub] [tvm] Archermmt commented on pull request #15813: [Unity][MSC][pre M1.2] Reconstruct codegen

2023-09-26 Thread via GitHub
Archermmt commented on PR #15813: URL: https://github.com/apache/tvm/pull/15813#issuecomment-1736428746 Thanks! Now I understand -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific c

[tvm] branch unity updated: [Unity] Extend RemoveAllUnused to support relax::Expr (#15807)

2023-09-26 Thread csullivan
This is an automated email from the ASF dual-hosted git repository. csullivan pushed a commit to branch unity in repository https://gitbox.apache.org/repos/asf/tvm.git The following commit(s) were added to refs/heads/unity by this push: new dfc77eb129 [Unity] Extend RemoveAllUnused to suppo

[GitHub] [tvm] csullivan merged pull request #15807: [Unity] Extend RemoveAllUnused to support relax::Expr

2023-09-26 Thread via GitHub
csullivan merged PR #15807: URL: https://github.com/apache/tvm/pull/15807 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@tvm.apache

[GitHub] [tvm] csullivan commented on a diff in pull request #15810: [Unity] Implement relax.transform.KillAfterLastUse

2023-09-26 Thread via GitHub
csullivan commented on code in PR #15810: URL: https://github.com/apache/tvm/pull/15810#discussion_r1337861771 ## src/relax/transform/kill_after_last_use.cc: ## @@ -0,0 +1,289 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license a

[GitHub] [tvm] jinhongyii commented on pull request #15827: [Unity][Disco] Use default stream in disco

2023-09-26 Thread via GitHub
jinhongyii commented on PR #15827: URL: https://github.com/apache/tvm/pull/15827#issuecomment-1736381738 cc: @junrushao @tqchen -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comme

[GitHub] [tvm] jinhongyii opened a new pull request, #15827: [Unity][Disco] Use default stream in disco

2023-09-26 Thread via GitHub
jinhongyii opened a new pull request, #15827: URL: https://github.com/apache/tvm/pull/15827 running on default stream and synchronizing with it is significantly faster on amd gpu than running on other stream and synchronizing that stream, so we switch to using default stream in init_ccl -

[GitHub] [tvm] slyubomirsky commented on pull request #15825: [Unity] Dtype check in legalization of R.matmul

2023-09-26 Thread via GitHub
slyubomirsky commented on PR #15825: URL: https://github.com/apache/tvm/pull/15825#issuecomment-1736341597 Are you certain that `Void` is treated as false in that check? There's no test case included. -- This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [tvm] csullivan commented on a diff in pull request #15809: [Unity] Implement LowerAllocTensor to remove R.builtin.alloc_tensor

2023-09-26 Thread via GitHub
csullivan commented on code in PR #15809: URL: https://github.com/apache/tvm/pull/15809#discussion_r1337806792 ## python/tvm/relax/vm_build.py: ## @@ -310,6 +310,7 @@ def foo(x: Tensor((3, 4), "float32"), y: Tensor((3, 4), "float32")): passes.append(relax.transform.RemoveP

[GitHub] [tvm] LeshengJin opened a new pull request, #15826: [Disco] Advanced sharding support

2023-09-26 Thread via GitHub
LeshengJin opened a new pull request, #15826: URL: https://github.com/apache/tvm/pull/15826 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-m

[GitHub] [tvm] junrushao commented on pull request #15817: [TE] Support using tir::Var as CreatePrimFunc args

2023-09-26 Thread via GitHub
junrushao commented on PR #15817: URL: https://github.com/apache/tvm/pull/15817#issuecomment-1736324878 The motivation behind is to unify [`CreatePrimFunc`](https://github.com/apache/tvm/blob/b7471f8315ac50ed42da33db733dfbe3a94eff06/src/te/operation/create_primfunc.cc#L646) and [`CreateRel

[tvm] branch unity updated: [Unity][TVMScript] Produce var = R.ExternFunc("") statements (#15703)

2023-09-26 Thread junrushao
This is an automated email from the ASF dual-hosted git repository. junrushao pushed a commit to branch unity in repository https://gitbox.apache.org/repos/asf/tvm.git The following commit(s) were added to refs/heads/unity by this push: new 732ae53653 [Unity][TVMScript] Produce var = R.Exte

[GitHub] [tvm] junrushao merged pull request #15703: [Unity][TVMScript] Produce var = R.ExternFunc("") statements

2023-09-26 Thread via GitHub
junrushao merged PR #15703: URL: https://github.com/apache/tvm/pull/15703 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@tvm.apache

[GitHub] [tvm] Lunderberg opened a new pull request, #15825: [Unity] Dtype check in legalization of R.matmul

2023-09-26 Thread via GitHub
Lunderberg opened a new pull request, #15825: URL: https://github.com/apache/tvm/pull/15825 Prior to this commit, if `R.matmul` has arguments with an unknown datatype, it would produce an error from within the `R.call_te` implementation of `BlockBuilder.call_te`, stating `TVMError: cannot m

[GitHub] [tvm] Lunderberg opened a new pull request, #15824: [TVMScript] Preserve traceback across TVMScript parsing

2023-09-26 Thread via GitHub
Lunderberg opened a new pull request, #15824: URL: https://github.com/apache/tvm/pull/15824 Prior to this commit, exceptions raised during the parsing of TVMScript would be caught and replaced with a new exception. While this does allow the TVMScript location of the error to be included in

[tvm] branch unity updated: [Unity] Delegate DataflowVar visitor to Var by default (#15688)

2023-09-26 Thread lunderberg
This is an automated email from the ASF dual-hosted git repository. lunderberg pushed a commit to branch unity in repository https://gitbox.apache.org/repos/asf/tvm.git The following commit(s) were added to refs/heads/unity by this push: new 6ea16b98e7 [Unity] Delegate DataflowVar visitor t

[GitHub] [tvm] Lunderberg merged pull request #15688: [Unity] Delegate DataflowVar visitor to Var by default

2023-09-26 Thread via GitHub
Lunderberg merged PR #15688: URL: https://github.com/apache/tvm/pull/15688 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@tvm.apach

[tvm] branch main updated: [TVMScript] Use environment variable TVM_BLACK_FORMAT for .show() (#15762)

2023-09-26 Thread lunderberg
This is an automated email from the ASF dual-hosted git repository. lunderberg pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/tvm.git The following commit(s) were added to refs/heads/main by this push: new d5fab9e4fb [TVMScript] Use environment variable TVM

[GitHub] [tvm] Lunderberg merged pull request #15762: [TVMScript] Use environment variable TVM_BLACK_FORMAT for .show()

2023-09-26 Thread via GitHub
Lunderberg merged PR #15762: URL: https://github.com/apache/tvm/pull/15762 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@tvm.apach

[GitHub] [tvm] Lunderberg commented on pull request #15756: [Draft][Unittest][Metal] Add minimal metal functionality test to CI

2023-09-26 Thread via GitHub
Lunderberg commented on PR #15756: URL: https://github.com/apache/tvm/pull/15756#issuecomment-1736104207 And ready for review! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment

[GitHub] [tvm] Lunderberg commented on issue #15233: [Unity][MSC][Tracking Issue] Introduction to Multi-System Compiler

2023-09-26 Thread via GitHub
Lunderberg commented on issue #15233: URL: https://github.com/apache/tvm/issues/15233#issuecomment-1736066884 I'm somewhat concerned about the `relay -> python codegen -> relax` code path used in `tvm.contrib.msc.framework.torch.frontend.translate.from_torch` when `via_relax=False`. This i

[GitHub] [tvm] Lunderberg commented on pull request #15783: [Unity] Use PrimValue as offset in R.tril and R.triu

2023-09-26 Thread via GitHub
Lunderberg commented on PR #15783: URL: https://github.com/apache/tvm/pull/15783#issuecomment-1736030766 @Archermmt Can you take a look at the MSC-specific unit tests? I've parametrized the tests and marked the failing cases (`via_relax=False`) with `pytest.mark.xfail`, but it would be goo

[GitHub] [tvm] tlopex closed pull request #15821: [TFLite][Frontend] Support quantized ELU

2023-09-26 Thread via GitHub
tlopex closed pull request #15821: [TFLite][Frontend] Support quantized ELU URL: https://github.com/apache/tvm/pull/15821 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To uns

[GitHub] [tvm] yongwww commented on issue #15101: [Unity] [Tracking Issue] Heterogeneous execution for Relax

2023-09-26 Thread via GitHub
yongwww commented on issue #15101: URL: https://github.com/apache/tvm/issues/15101#issuecomment-1736018176 The e2e multi-device test cases were added in https://github.com/apache/tvm/pull/15823. Will close this issue once it lands -- This is an automated message from the Apache Git Servic

[GitHub] [tvm] yongwww opened a new pull request, #15823: [Unity] Add Relax multi-device e2e cases

2023-09-26 Thread via GitHub
yongwww opened a new pull request, #15823: URL: https://github.com/apache/tvm/pull/15823 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail

[GitHub] [tvm] vinx13 closed pull request #15794: [IR] Use CoW in StmtFunctor to prevent mutating buffer

2023-09-26 Thread via GitHub
vinx13 closed pull request #15794: [IR] Use CoW in StmtFunctor to prevent mutating buffer URL: https://github.com/apache/tvm/pull/15794 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific c

[GitHub] [tvm] vinx13 commented on pull request #15794: [IR] Use CoW in StmtFunctor to prevent mutating buffer

2023-09-26 Thread via GitHub
vinx13 commented on PR #15794: URL: https://github.com/apache/tvm/pull/15794#issuecomment-1735923862 superseded by #15816 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. T

[GitHub] [tvm-rfcs] tqchen commented on pull request #89: [RFC] Relax Upstreaming

2023-09-26 Thread via GitHub
tqchen commented on PR #89: URL: https://github.com/apache/tvm-rfcs/pull/89#issuecomment-1735749718 Thanks @FrozenGene for bring this up! To bring broader awareness, we posted a new strategy proposal here https://discuss.tvm.apache.org/t/discuss-tvm-core-strategy-for-emerging-needs/15751 t

[GitHub] [tvm] tlopex closed pull request #15821: [TFLite][Frontend] Support quantized ELU

2023-09-26 Thread via GitHub
tlopex closed pull request #15821: [TFLite][Frontend] Support quantized ELU URL: https://github.com/apache/tvm/pull/15821 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To uns

[GitHub] [tvm] tlopex opened a new pull request, #15821: [TFLite][Frontend] Support quantized ELU

2023-09-26 Thread via GitHub
tlopex opened a new pull request, #15821: URL: https://github.com/apache/tvm/pull/15821 Support ELU quantization operation as part of #15148 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the s

[GitHub] [tvm] Lunderberg commented on pull request #15813: [Unity][MSC][pre M1.2] Reconstruct codegen

2023-09-26 Thread via GitHub
Lunderberg commented on PR #15813: URL: https://github.com/apache/tvm/pull/15813#issuecomment-1735693748 (Made https://github.com/apache/tvm/pull/15820, which updates the warning to an info.) -- This is an automated message from the Apache Git Service. To respond to the message, please lo

[GitHub] [tvm] Lunderberg commented on pull request #15816: Revert "[TensorIR][Visitor] Visit buffer members in `match_buffer`'s in block visitor functions (#15153)

2023-09-26 Thread via GitHub
Lunderberg commented on PR #15816: URL: https://github.com/apache/tvm/pull/15816#issuecomment-1735692136 As a potential third option, I think that we could have the buffers be visited at their point of definition. That is, any `DeclBuffer` statement would have the buffer internals visited

[GitHub] [tvm] Lunderberg commented on a diff in pull request #15806: [UNITY][Pass] Remove redundant reshape

2023-09-26 Thread via GitHub
Lunderberg commented on code in PR #15806: URL: https://github.com/apache/tvm/pull/15806#discussion_r1337320164 ## python/tvm/relax/transform/remove_redundant_reshape.py: ## @@ -0,0 +1,83 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor lic

[GitHub] [tvm] Lunderberg opened a new pull request, #15820: [Unity][Analysis] Change warning to info for non-affine transform

2023-09-26 Thread via GitHub
Lunderberg opened a new pull request, #15820: URL: https://github.com/apache/tvm/pull/15820 A `PrimFunc` may contain transformations that are not affine, or that are not recognizable as being affine. Prior to this commit, this produced a `LOG(WARNING)` stating that this was an error in the

[GitHub] [tvm] Lunderberg commented on pull request #15813: [Unity][MSC][pre M1.2] Reconstruct codegen

2023-09-26 Thread via GitHub
Lunderberg commented on PR #15813: URL: https://github.com/apache/tvm/pull/15813#issuecomment-1735629528 I had a couple of MSC-related CI failures, but they were mainly related to expected IRModule definitions needing to be updated for changed behavior. If I run the `tests/python/relax/te

[GitHub] [tvm] MasterJH5574 commented on pull request #15817: [TE] Support using tir::Var as CreatePrimFunc args

2023-09-26 Thread via GitHub
MasterJH5574 commented on PR #15817: URL: https://github.com/apache/tvm/pull/15817#issuecomment-1735568257 Looks like the PR is mainly about TE and TIR, so I’m wondering if there is any blocker for this PR to be sent to main branch? -- This is an automated message from the Apache Git Serv

[tvm] branch fix-oneflow-install created (now 571b85216e)

2023-09-26 Thread lukhut
This is an automated email from the ASF dual-hosted git repository. lukhut pushed a change to branch fix-oneflow-install in repository https://gitbox.apache.org/repos/asf/tvm.git at 571b85216e [Docker] Install oneflow from PyPi No new revisions were added by this update.

[GitHub] [tvm] lhutton1 opened a new pull request, #15819: [Docker] Install oneflow from PyPi

2023-09-26 Thread via GitHub
lhutton1 opened a new pull request, #15819: URL: https://github.com/apache/tvm/pull/15819 Installing oneflow from the current link (https://release.oneflow.info) seems to be broken as reported in #15754, which is impacting other unrelated changes in CI. This commit attempts to fix the insta

[tvm] branch main updated: Revert "[TensorIR][Visitor] Visit buffer members in `match_buffer`'s in block visitor functions (#15153) (#15816)

2023-09-26 Thread tqchen
This is an automated email from the ASF dual-hosted git repository. tqchen pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/tvm.git The following commit(s) were added to refs/heads/main by this push: new dfd525bda5 Revert "[TensorIR][Visitor] Visit buffer mem

[GitHub] [tvm] tqchen merged pull request #15816: Revert "[TensorIR][Visitor] Visit buffer members in `match_buffer`'s in block visitor functions (#15153)

2023-09-26 Thread via GitHub
tqchen merged PR #15816: URL: https://github.com/apache/tvm/pull/15816 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@tvm.apache.or

[GitHub] [tvm] sjain58 commented on a diff in pull request #15806: [UNITY][Pass] Remove redundant reshape

2023-09-26 Thread via GitHub
sjain58 commented on code in PR #15806: URL: https://github.com/apache/tvm/pull/15806#discussion_r1336885976 ## tests/python/relax/test_remove_redundant_reshape.py: ## @@ -0,0 +1,68 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license a

[GitHub] [tvm] sjain58 commented on a diff in pull request #15806: [UNITY][Pass] Remove redundant reshape

2023-09-26 Thread via GitHub
sjain58 commented on code in PR #15806: URL: https://github.com/apache/tvm/pull/15806#discussion_r1336885976 ## tests/python/relax/test_remove_redundant_reshape.py: ## @@ -0,0 +1,68 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license a

[GitHub] [tvm] sjain58 commented on a diff in pull request #15806: [UNITY][Pass] Remove redundant reshape

2023-09-26 Thread via GitHub
sjain58 commented on code in PR #15806: URL: https://github.com/apache/tvm/pull/15806#discussion_r1336881777 ## python/tvm/relax/transform/remove_redundant_reshape.py: ## @@ -0,0 +1,73 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor licens

[GitHub] [tvm] sjain58 commented on a diff in pull request #15806: [UNITY][Pass] Remove redundant reshape

2023-09-26 Thread via GitHub
sjain58 commented on code in PR #15806: URL: https://github.com/apache/tvm/pull/15806#discussion_r1336871892 ## python/tvm/relax/transform/remove_redundant_reshape.py: ## @@ -0,0 +1,73 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor licens

[GitHub] [tvm] sjain58 commented on a diff in pull request #15806: [UNITY][Pass] Remove redundant reshape

2023-09-26 Thread via GitHub
sjain58 commented on code in PR #15806: URL: https://github.com/apache/tvm/pull/15806#discussion_r1336869336 ## python/tvm/relax/transform/remove_redundant_reshape.py: ## @@ -0,0 +1,73 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor licens

[GitHub] [tvm] cbalint13 commented on pull request #15761: [Target] LLVM helper functions for any target info

2023-09-26 Thread via GitHub
cbalint13 commented on PR #15761: URL: https://github.com/apache/tvm/pull/15761#issuecomment-1735025580 @kparzysz-quic Added the fuctions as ```LLVMTargetInfo``` public members, now looks to be it's ideal place. Updated the first comment here with the example & usage of the exporte

[GitHub] [tvm] masahi commented on a diff in pull request #15679: [Unity] Support Padding Reversal in Alter-Op pass

2023-09-26 Thread via GitHub
masahi commented on code in PR #15679: URL: https://github.com/apache/tvm/pull/15679#discussion_r1336715785 ## python/tvm/relax/transform/legalize_ops/manipulate.py: ## @@ -182,7 +182,15 @@ def te_layout_transform(data, name): ) index_map: tvm.tir.IndexMap = call