[tvm] branch nightly updated (e754bc2325 -> e89b39e55b)

2023-10-05 Thread github-bot
This is an automated email from the ASF dual-hosted git repository. github-bot pushed a change to branch nightly in repository https://gitbox.apache.org/repos/asf/tvm.git from e754bc2325 [Relay][Bugfix] Fix conv transpose with default strides in ONNX frontend (#15868) add 958c27123a [F

Re: [PR] [Unity] Propagate extra symbolic vars through LiftTransformParams [tvm]

2023-10-05 Thread via GitHub
vinx13 commented on code in PR #15699: URL: https://github.com/apache/tvm/pull/15699#discussion_r1348147295 ## src/relax/transform/lift_transform_params.cc: ## @@ -43,26 +43,92 @@ struct LiftTransformParamsInfoPlan { lifted_bindings; // the bindings of the original funct

Re: [I] [Bug] How to use `kDLCUDAManaged` [tvm]

2023-10-05 Thread via GitHub
tqchen commented on issue #15874: URL: https://github.com/apache/tvm/issues/15874#issuecomment-1749784280 Looks like indeed we didn't have proper `kDLCUDAManaged ` . I think it can be added in similar ways as https://github.com/apache/tvm/blob/main/src/runtime/cuda/cuda_device_api.cc#L256

Re: [PR] [Unity] Propagate extra symbolic vars through LiftTransformParams [tvm]

2023-10-05 Thread via GitHub
Lunderberg commented on code in PR #15699: URL: https://github.com/apache/tvm/pull/15699#discussion_r1348094509 ## src/relax/transform/lift_transform_params.cc: ## @@ -43,26 +43,92 @@ struct LiftTransformParamsInfoPlan { lifted_bindings; // the bindings of the original f

Re: [I] [Bug] [Unity] Fail to print out call trace under relax::Normalizer [tvm]

2023-10-05 Thread via GitHub
Lunderberg commented on issue #15880: URL: https://github.com/apache/tvm/issues/15880#issuecomment-1749783656 Ah, looks like the string isn't collecting the full stack track, only the python object. This becomes a problem if the error is caught in a context where the string is printed. -

Re: [I] [Bug] [Unity] Fail to print out call trace under relax::Normalizer [tvm]

2023-10-05 Thread via GitHub
Lunderberg commented on issue #15880: URL: https://github.com/apache/tvm/issues/15880#issuecomment-1749783066 Thank you, and I'll take a look at it later this week. When catching in python, it resolved some out-of-order issues, but I hadn't checked if it also caused others. -- This is a

Re: [PR] [Unity] Propagate extra symbolic vars through LiftTransformParams [tvm]

2023-10-05 Thread via GitHub
vinx13 commented on code in PR #15699: URL: https://github.com/apache/tvm/pull/15699#discussion_r1348071553 ## src/relax/transform/lift_transform_params.cc: ## @@ -43,26 +43,92 @@ struct LiftTransformParamsInfoPlan { lifted_bindings; // the bindings of the original funct

Re: [PR] [Arith] Fix detect non-divisible iteration form like (x % 255) // 16 [tvm]

2023-10-05 Thread via GitHub
vinx13 commented on PR #15665: URL: https://github.com/apache/tvm/pull/15665#issuecomment-1749743038 The simplification @Lunderberg mentioned should work. Actually we can get the extent from the source `IterMark` of the split. Say we want to compute `floordiv(lhs, rhs)` where `lhs == flo

Re: [I] [Bug] [Unity] Fail to print out call trace under relax::Normalizer [tvm]

2023-10-05 Thread via GitHub
tqchen commented on issue #15880: URL: https://github.com/apache/tvm/issues/15880#issuecomment-1749697570 seems is related to https://github.com/apache/tvm/pull/15596 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

Re: [PR] [FFI] Propagate Python errors across FFI boundaries [tvm]

2023-10-05 Thread via GitHub
tqchen commented on PR #15596: URL: https://github.com/apache/tvm/pull/15596#issuecomment-1749697384 This PR seems to cause an issue here https://github.com/apache/tvm/issues/15880 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to Gi

Re: [I] [Bug] [Unity] Fail to print out call trace under relax::Normalizer [tvm]

2023-10-05 Thread via GitHub
tqchen commented on issue #15880: URL: https://github.com/apache/tvm/issues/15880#issuecomment-1749695727 cc @Lunderberg -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[I] [Bug] [Unity] Fail to print out call trace under relax::Normalizer [tvm]

2023-10-05 Thread via GitHub
jinhongyii opened a new issue, #15880: URL: https://github.com/apache/tvm/issues/15880 ### Expected behavior printing out call trace when encountering `ICHECK` failure ### Actual behavior ``` python/tvm/relax/block_builder.py:645: in normalize return _ffi_api.Bl

Re: [PR] [Unity] Use PrimValue as offset in R.tril and R.triu [tvm]

2023-10-05 Thread via GitHub
vinx13 merged PR #15783: URL: https://github.com/apache/tvm/pull/15783 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@tvm.apache.or

[tvm] branch unity updated: [Unity] Use PrimValue as offset in R.tril and R.triu (#15783)

2023-10-05 Thread wuwei
This is an automated email from the ASF dual-hosted git repository. wuwei pushed a commit to branch unity in repository https://gitbox.apache.org/repos/asf/tvm.git The following commit(s) were added to refs/heads/unity by this push: new 8a2ca3405b [Unity] Use PrimValue as offset in R.tril a

Re: [PR] [Unity][Op] Introduce `call_inplace_packed` as a counterpart to `call_tir_inplace` [tvm]

2023-10-05 Thread via GitHub
slyubomirsky commented on PR #15878: URL: https://github.com/apache/tvm/pull/15878#issuecomment-1749521997 Glad to know that this op sounds like it will address that problem. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

Re: [PR] [Unity][Op] Introduce `call_inplace_packed` as a counterpart to `call_tir_inplace` [tvm]

2023-10-05 Thread via GitHub
masahi commented on PR #15878: URL: https://github.com/apache/tvm/pull/15878#issuecomment-1749492432 I mean, the KV cache update operation is disguised as a pure operation in the model. So it does build and run, that's no problem. But semantically it is not quite right and I also need to re

Re: [PR] [Unity][Op] Introduce `call_inplace_packed` as a counterpart to `call_tir_inplace` [tvm]

2023-10-05 Thread via GitHub
slyubomirsky commented on PR #15878: URL: https://github.com/apache/tvm/pull/15878#issuecomment-1749472076 Good to know. I'm glad it gets caught, though I'm curious how LLaMa is able to build and run despite also having packed calls in it. -- This is an automated message from the Apache G

Re: [PR] [Unity][Op] Introduce `call_inplace_packed` as a counterpart to `call_tir_inplace` [tvm]

2023-10-05 Thread via GitHub
masahi commented on PR #15878: URL: https://github.com/apache/tvm/pull/15878#issuecomment-1749464086 No, assuming that such check occurs automatically during `relax.build()`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

Re: [PR] [Unity][Op] Introduce `call_inplace_packed` as a counterpart to `call_tir_inplace` [tvm]

2023-10-05 Thread via GitHub
slyubomirsky commented on PR #15878: URL: https://github.com/apache/tvm/pull/15878#issuecomment-1749456251 Were you getting a well-formed error? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to th

[tvm] branch dependabot/pip/apps/microtvm/ethosu/pillow-10.0.1 updated (d8f2c63d54 -> e623ba5adf)

2023-10-05 Thread github-bot
This is an automated email from the ASF dual-hosted git repository. github-bot pushed a change to branch dependabot/pip/apps/microtvm/ethosu/pillow-10.0.1 in repository https://gitbox.apache.org/repos/asf/tvm.git discard d8f2c63d54 Bump pillow from 9.3.0 to 10.0.1 in /apps/microtvm/ethosu

[tvm] branch dependabot/pip/apps/microtvm/cmsisnn/pillow-10.0.1 updated (a734fac5aa -> 62a873f876)

2023-10-05 Thread github-bot
This is an automated email from the ASF dual-hosted git repository. github-bot pushed a change to branch dependabot/pip/apps/microtvm/cmsisnn/pillow-10.0.1 in repository https://gitbox.apache.org/repos/asf/tvm.git discard a734fac5aa Bump pillow from 9.3.0 to 10.0.1 in /apps/microtvm/cmsisnn

[tvm] branch dependabot/pip/apps/microtvm/pillow-10.0.1 deleted (was 1f4d2ebd75)

2023-10-05 Thread lukhut
This is an automated email from the ASF dual-hosted git repository. lukhut pushed a change to branch dependabot/pip/apps/microtvm/pillow-10.0.1 in repository https://gitbox.apache.org/repos/asf/tvm.git was 1f4d2ebd75 Bump pillow from 9.2.0 to 10.0.1 in /apps/microtvm The revisions that wer

[tvm] branch main updated (958c27123a -> e89b39e55b)

2023-10-05 Thread lukhut
This is an automated email from the ASF dual-hosted git repository. lukhut pushed a change to branch main in repository https://gitbox.apache.org/repos/asf/tvm.git from 958c27123a [Fix] Remove duplicated words from comments, NFC (#15873) add e89b39e55b Bump pillow from 9.2.0 to 10.0.1 i

Re: [PR] Bump pillow from 9.2.0 to 10.0.1 in /apps/microtvm [tvm]

2023-10-05 Thread via GitHub
lhutton1 merged PR #15865: URL: https://github.com/apache/tvm/pull/15865 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@tvm.apache.

Re: [PR] [Arith] Fix detect non-divisible iteration form like (x % 255) // 16 [tvm]

2023-10-05 Thread via GitHub
junrushao commented on PR #15665: URL: https://github.com/apache/tvm/pull/15665#issuecomment-1749310256 This seems to cause a break in MLC LLM q3f16_1, which is a pretty commonly used format. @vinx13 mind sharing what a proper fix should look like? -- This is an automated message from the

[tvm] branch dependabot/pip/apps/microtvm/pillow-10.0.1 updated (08428055f8 -> 1f4d2ebd75)

2023-10-05 Thread github-bot
This is an automated email from the ASF dual-hosted git repository. github-bot pushed a change to branch dependabot/pip/apps/microtvm/pillow-10.0.1 in repository https://gitbox.apache.org/repos/asf/tvm.git omit 08428055f8 Bump pillow from 9.2.0 to 10.0.1 in /apps/microtvm add 7a1f7d0b5a

[tvm] 01/01: Bump pillow from 9.2.0 to 10.0.1 in /apps/microtvm

2023-10-05 Thread github-bot
This is an automated email from the ASF dual-hosted git repository. github-bot pushed a commit to branch dependabot/pip/apps/microtvm/pillow-10.0.1 in repository https://gitbox.apache.org/repos/asf/tvm.git commit 1f4d2ebd75303a725a2843c2836d4193cd15a741 Author: dependabot[bot] <49699333+dependabo

[tvm] branch dependabot/pip/apps/microtvm/cmsisnn/pillow-10.0.1 updated (390ca580d0 -> a734fac5aa)

2023-10-05 Thread github-bot
This is an automated email from the ASF dual-hosted git repository. github-bot pushed a change to branch dependabot/pip/apps/microtvm/cmsisnn/pillow-10.0.1 in repository https://gitbox.apache.org/repos/asf/tvm.git omit 390ca580d0 Bump pillow from 9.3.0 to 10.0.1 in /apps/microtvm/cmsisnn

[tvm] 01/01: Bump pillow from 9.3.0 to 10.0.1 in /apps/microtvm/cmsisnn

2023-10-05 Thread github-bot
This is an automated email from the ASF dual-hosted git repository. github-bot pushed a commit to branch dependabot/pip/apps/microtvm/cmsisnn/pillow-10.0.1 in repository https://gitbox.apache.org/repos/asf/tvm.git commit a734fac5aa938f6d54088e1b7c38192a1a660cb9 Author: dependabot[bot] <49699333+

[tvm] branch dependabot/pip/apps/microtvm/pillow-10.0.1 created (now 08428055f8)

2023-10-05 Thread lukhut
This is an automated email from the ASF dual-hosted git repository. lukhut pushed a change to branch dependabot/pip/apps/microtvm/pillow-10.0.1 in repository https://gitbox.apache.org/repos/asf/tvm.git at 08428055f8 Bump pillow from 9.2.0 to 10.0.1 in /apps/microtvm No new revisions were

[tvm] branch dependabot/pip/apps/microtvm/ethosu/pillow-10.0.1 updated (fbd06896f9 -> d8f2c63d54)

2023-10-05 Thread github-bot
This is an automated email from the ASF dual-hosted git repository. github-bot pushed a change to branch dependabot/pip/apps/microtvm/ethosu/pillow-10.0.1 in repository https://gitbox.apache.org/repos/asf/tvm.git omit fbd06896f9 Bump pillow from 9.3.0 to 10.0.1 in /apps/microtvm/ethosu

[tvm] 01/01: Bump pillow from 9.3.0 to 10.0.1 in /apps/microtvm/ethosu

2023-10-05 Thread github-bot
This is an automated email from the ASF dual-hosted git repository. github-bot pushed a commit to branch dependabot/pip/apps/microtvm/ethosu/pillow-10.0.1 in repository https://gitbox.apache.org/repos/asf/tvm.git commit d8f2c63d54be8b3114890d4d36ebc6544f232338 Author: dependabot[bot] <49699333+d

[tvm] branch dependabot/pip/apps/microtvm/cmsisnn/pillow-10.0.1 created (now 390ca580d0)

2023-10-05 Thread lukhut
This is an automated email from the ASF dual-hosted git repository. lukhut pushed a change to branch dependabot/pip/apps/microtvm/cmsisnn/pillow-10.0.1 in repository https://gitbox.apache.org/repos/asf/tvm.git at 390ca580d0 Bump pillow from 9.3.0 to 10.0.1 in /apps/microtvm/cmsisnn No ne

[tvm] branch dependabot/pip/apps/microtvm/ethosu/pillow-10.0.1 created (now fbd06896f9)

2023-10-05 Thread lukhut
This is an automated email from the ASF dual-hosted git repository. lukhut pushed a change to branch dependabot/pip/apps/microtvm/ethosu/pillow-10.0.1 in repository https://gitbox.apache.org/repos/asf/tvm.git at fbd06896f9 Bump pillow from 9.3.0 to 10.0.1 in /apps/microtvm/ethosu No new

Re: [PR] Bump pillow from 9.3.0 to 10.0.1 in /apps/microtvm/ethosu [tvm]

2023-10-05 Thread via GitHub
lhutton1 commented on PR #15867: URL: https://github.com/apache/tvm/pull/15867#issuecomment-1749100249 ah I see, no worries! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

Re: [PR] Bump pillow from 9.3.0 to 10.0.1 in /apps/microtvm/ethosu [tvm]

2023-10-05 Thread via GitHub
junrushao commented on PR #15867: URL: https://github.com/apache/tvm/pull/15867#issuecomment-1748990910 Sorry I didn’t notice the PR is closed - was cleaning up redundant branches. @lhutton1 please feel free to submit a new PR and im happy to get it in -- This is an automated message from

Re: [I] [Torch] A list of missing op conversion in need of help [tvm]

2023-10-05 Thread via GitHub
nkhlS141 commented on issue #5133: URL: https://github.com/apache/tvm/issues/5133#issuecomment-1748957091 {aten::pad, } missing -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific commen

Re: [PR] [Unity] Include LegalizeOps in the default relax.build lowering flow [tvm]

2023-10-05 Thread via GitHub
Lunderberg commented on PR #15864: URL: https://github.com/apache/tvm/pull/15864#issuecomment-1748949037 Philosophically, I like the distinction @quic-sanirudh is drawing between the minimal `relax.build` and the more expansive options in `relax.pipeline`. I'd see `relax.build` as a tool w

Re: [PR] [Unity] Include LegalizeOps in the default relax.build lowering flow [tvm]

2023-10-05 Thread via GitHub
Lunderberg commented on PR #15864: URL: https://github.com/apache/tvm/pull/15864#issuecomment-1748927570 @junrushao Absolutely agreed, there's a wide variety of hand-selected transformations that optimized models require, many of which must be performed after `LegalizeOps`. That is essent

Re: [PR] [CI] Update ci-gpu image [tvm]

2023-10-05 Thread via GitHub
lhutton1 commented on PR #15836: URL: https://github.com/apache/tvm/pull/15836#issuecomment-1748904838 Hit a ``` fatal: unable to access 'https://github.com/apache/tvm.git/': Failed to connect to github.com port 443: Connection timed out ``` on the cortexm build, retriggering... -

[I] [Bug] Critical Compilation Warning in Generated Model for CMSIS Target in uTVM [tvm]

2023-10-05 Thread via GitHub
mehmetalici opened a new issue, #15879: URL: https://github.com/apache/tvm/issues/15879 I am facing a critical compilation warning when I try to compile a model generated for CMSIS target in uTVM. Below is the generated code snippet that results in warning by the compiler: ```c

Re: [PR] [Unity] Include LegalizeOps in the default relax.build lowering flow [tvm]

2023-10-05 Thread via GitHub
quic-sanirudh commented on PR #15864: URL: https://github.com/apache/tvm/pull/15864#issuecomment-1748440464 > I'm not super sure if it's desirable. Usually after operator lowering, we will apply a series of transformations to reach the end state of the desirable TIR, which we could abstract

Re: [PR] Bump pillow from 9.3.0 to 10.0.1 in /apps/microtvm/ethosu [tvm]

2023-10-05 Thread via GitHub
lhutton1 commented on PR #15867: URL: https://github.com/apache/tvm/pull/15867#issuecomment-1748406577 Hi @junrushao, any reason to close the version upgrade? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL abo

Re: [PR] [Unity][Op] Introduce `call_inplace_packed` as a counterpart to `call_tir_inplace` [tvm]

2023-10-05 Thread via GitHub
masahi commented on PR #15878: URL: https://github.com/apache/tvm/pull/15878#issuecomment-1748329331 > it might be desirable to have a way to have packed calls inside dataflow blocks Very strong +1 for this need. This week I integrated a KV cache update kernel, and faced a problem of