[GitHub] [incubator-tvm] anijain2305 commented on pull request #6430: [ConvertLayout] Use a packed function to decide layout based on operator attributes

2020-09-10 Thread GitBox
anijain2305 commented on pull request #6430: URL: https://github.com/apache/incubator-tvm/pull/6430#issuecomment-690618685 @tqchen Do you have any suggestions here? This is an automated message from the Apache Git Service. To

[GitHub] [incubator-tvm] anijain2305 commented on pull request #6430: [ConvertLayout] Use a packed function to decide layout based on operator attributes

2020-09-10 Thread GitBox
anijain2305 commented on pull request #6430: URL: https://github.com/apache/incubator-tvm/pull/6430#issuecomment-690600943 Yes, that makes sense. Thanks for explaining! Yes, if we want to go through something like `TempOpAttr`, we need that functionality in C++. Is your curren

[GitHub] [incubator-tvm] anijain2305 commented on pull request #6430: [ConvertLayout] Use a packed function to decide layout based on operator attributes

2020-09-10 Thread GitBox
anijain2305 commented on pull request #6430: URL: https://github.com/apache/incubator-tvm/pull/6430#issuecomment-690504454 I think calling ConvertLayout in C++ should be ok. The thing that I don't fully understand is why do we need to set the `FTVMConvertOpLayout` in C++? Is there a way to

[GitHub] [incubator-tvm] anijain2305 commented on pull request #6430: [ConvertLayout] Use a packed function to decide layout based on operator attributes

2020-09-09 Thread GitBox
anijain2305 commented on pull request #6430: URL: https://github.com/apache/incubator-tvm/pull/6430#issuecomment-689703548 Hi @lhutton1 Thanks for the PR! I am trying to understand the need for this PR. We can always overwrite the existing convert_op_layout for each operator. So, I