comaniac commented on a change in pull request #6437: URL: https://github.com/apache/incubator-tvm/pull/6437#discussion_r486506436
########## File path: tests/lint/git-black.sh ########## @@ -0,0 +1,76 @@ +#!/bin/bash +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. +set -e +set -u +set -o pipefail + +if [[ "$1" == "-i" ]]; then + INPLACE_FORMAT=1 + shift 1 +else + INPLACE_FORMAT=0 +fi + +if [[ "$#" -lt 1 ]]; then + echo "Usage: tests/lint/git-black.sh [-i] <commit>" + echo "" + echo "Run black-format on files that changed since <commit>" Review comment: ```suggestion echo "Run black-format on Python files that changed since <commit>" ``` ########## File path: tests/lint/git-black.sh ########## @@ -0,0 +1,76 @@ +#!/bin/bash +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. +set -e +set -u +set -o pipefail + +if [[ "$1" == "-i" ]]; then + INPLACE_FORMAT=1 + shift 1 +else + INPLACE_FORMAT=0 +fi + +if [[ "$#" -lt 1 ]]; then + echo "Usage: tests/lint/git-black.sh [-i] <commit>" + echo "" + echo "Run black-format on files that changed since <commit>" + echo "Examples:" + echo "- Compare last one commit: tests/lint/git-black.sh HEAD~1" + echo "- Compare against upstream/master: tests/lint/git-black.sh upstream/master" + echo "You can also add -i option to do inplace format" + exit 1 +fi + +cleanup() +{ + rm -rf /tmp/$$.black-format.txt +} +trap cleanup 0 + + +if [ -x "$(command -v black)" ]; then + BLACK=black +else + echo "Cannot find black" + exit 1 +fi + +# Print out specific version +${BLACK} --version + +FILES=$(git diff --name-only HEAD $1 -- "*.py" "*.pyi" | tr '\n' ' ') +echo $FILES + +if [[ ${INPLACE_FORMAT} -eq 1 ]]; then + echo "Running black in place on your working tree." $1 + CMD="black --check $FILES" + echo $CMD + eval $CMD + exit 0 +fi + +echo "Running git-black against" $1 Review comment: ```suggestion echo "Running git-black on Python files against" $1 ``` ########## File path: pyproject.toml ########## @@ -0,0 +1,29 @@ +[tool.black] +line-length = 88 Review comment: So we are using 88 as the TVM standard column length for Python codes? I know this is the default and the suggested value in black so just want to double confirm. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
