[GitHub] [incubator-tvm] jroesch commented on pull request #5830: Rust Refactor Stage 4: Rewrite Rust graph runtime to use new APIs

2020-06-22 Thread GitBox
jroesch commented on pull request #5830: URL: https://github.com/apache/incubator-tvm/pull/5830#issuecomment-647834984 @binarybana and @robo-corg many of the things you guys identified existed in the previous graph runtime, it would be my preference to land this port which just makes it

[GitHub] [incubator-tvm] jroesch commented on pull request #5830: Rust Refactor Stage 4: Rewrite Rust graph runtime to use new APIs

2020-06-22 Thread GitBox
jroesch commented on pull request #5830: URL: https://github.com/apache/incubator-tvm/pull/5830#issuecomment-647833753 > @jroesch Can we enable derive_default for bindgen? Otherwise, test_wasm32 fails with tvm-sys because of the generated padding field. > > The following change

[GitHub] [incubator-tvm] jroesch commented on pull request #5830: Rust Refactor Stage 4: Rewrite Rust graph runtime to use new APIs

2020-06-18 Thread GitBox
jroesch commented on pull request #5830: URL: https://github.com/apache/incubator-tvm/pull/5830#issuecomment-646242260 @robo-corg @tqchen this is like a straight copy of the old `runtime` crate with slight modifications to use the new `tvm-sys`. After this patch lands I can send a final