[GitHub] [incubator-tvm] junrushao1994 commented on a change in pull request #5718: [Object][FFI] Introduce runtime::String::CanConvertFrom

2020-06-03 Thread GitBox
junrushao1994 commented on a change in pull request #5718: URL: https://github.com/apache/incubator-tvm/pull/5718#discussion_r434366562 ## File path: src/ir/attrs.cc ## @@ -37,7 +37,7 @@ void DictAttrsNode::InitByPackedArgs(const runtime::TVMArgs& args, bool allow_un

[GitHub] [incubator-tvm] junrushao1994 commented on a change in pull request #5718: [Object][FFI] Introduce runtime::String::CanConvertFrom

2020-06-02 Thread GitBox
junrushao1994 commented on a change in pull request #5718: URL: https://github.com/apache/incubator-tvm/pull/5718#discussion_r434308571 ## File path: src/ir/attrs.cc ## @@ -37,7 +37,7 @@ void DictAttrsNode::InitByPackedArgs(const runtime::TVMArgs& args, bool allow_un

[GitHub] [incubator-tvm] junrushao1994 commented on a change in pull request #5718: [Object][FFI] Introduce runtime::String::CanConvertFrom

2020-06-02 Thread GitBox
junrushao1994 commented on a change in pull request #5718: URL: https://github.com/apache/incubator-tvm/pull/5718#discussion_r434302862 ## File path: src/ir/attrs.cc ## @@ -37,7 +37,7 @@ void DictAttrsNode::InitByPackedArgs(const runtime::TVMArgs& args, bool allow_un

[GitHub] [incubator-tvm] junrushao1994 commented on a change in pull request #5718: [Object][FFI] Introduce runtime::String::CanConvertFrom

2020-06-02 Thread GitBox
junrushao1994 commented on a change in pull request #5718: URL: https://github.com/apache/incubator-tvm/pull/5718#discussion_r434289143 ## File path: include/tvm/runtime/container.h ## @@ -1301,6 +1301,10 @@ class String : public ObjectRef { */ operator std::string()