[GitHub] [incubator-tvm] junrushao1994 commented on a change in pull request #5740: [Object] Introduce POD-C Compliant tvm::Map

junrushao1994 commented on a change in pull request #5740: URL: https://github.com/apache/incubator-tvm/pull/5740#discussion_r442577192 ## File path: include/tvm/node/container.h ## @@ -43,51 +44,1200 @@ using runtime::Downcast; using runtime::IterAdapter; using

[GitHub] [incubator-tvm] junrushao1994 commented on a change in pull request #5740: [Object] Introduce POD-C Compliant tvm::Map

junrushao1994 commented on a change in pull request #5740: URL: https://github.com/apache/incubator-tvm/pull/5740#discussion_r442576289 ## File path: tests/cpp/container_test.cc ## @@ -324,6 +324,29 @@ TEST(Map, Iterator) { CHECK(map2[a].as()->value == 2); } +TEST(Map,

[GitHub] [incubator-tvm] junrushao1994 commented on a change in pull request #5740: [Object] Introduce POD-C Compliant tvm::Map

junrushao1994 commented on a change in pull request #5740: URL: https://github.com/apache/incubator-tvm/pull/5740#discussion_r442576113 ## File path: tests/cpp/container_test.cc ## @@ -310,7 +310,7 @@ TEST(Map, Mutate) { CHECK(it != dict.end() && (*it).second.same_as(x));

[GitHub] [incubator-tvm] junrushao1994 commented on a change in pull request #5740: [Object] Introduce POD-C Compliant tvm::Map

junrushao1994 commented on a change in pull request #5740: URL: https://github.com/apache/incubator-tvm/pull/5740#discussion_r442509398 ## File path: include/tvm/node/container.h ## @@ -43,51 +44,1188 @@ using runtime::Downcast; using runtime::IterAdapter; using

[GitHub] [incubator-tvm] junrushao1994 commented on a change in pull request #5740: [Object] Introduce POD-C Compliant tvm::Map

junrushao1994 commented on a change in pull request #5740: URL: https://github.com/apache/incubator-tvm/pull/5740#discussion_r442488594 ## File path: include/tvm/node/container.h ## @@ -43,51 +44,1188 @@ using runtime::Downcast; using runtime::IterAdapter; using

[GitHub] [incubator-tvm] junrushao1994 commented on a change in pull request #5740: [Object] Introduce POD-C Compliant tvm::Map

junrushao1994 commented on a change in pull request #5740: URL: https://github.com/apache/incubator-tvm/pull/5740#discussion_r440670880 ## File path: include/tvm/node/container.h ## @@ -43,51 +44,1188 @@ using runtime::Downcast; using runtime::IterAdapter; using

[GitHub] [incubator-tvm] junrushao1994 commented on a change in pull request #5740: [Object] Introduce POD-C Compliant tvm::Map

junrushao1994 commented on a change in pull request #5740: URL: https://github.com/apache/incubator-tvm/pull/5740#discussion_r44095 ## File path: include/tvm/node/container.h ## @@ -43,51 +44,1188 @@ using runtime::Downcast; using runtime::IterAdapter; using

[GitHub] [incubator-tvm] junrushao1994 commented on a change in pull request #5740: [Object] Introduce POD-C Compliant tvm::Map

junrushao1994 commented on a change in pull request #5740: URL: https://github.com/apache/incubator-tvm/pull/5740#discussion_r440340863 ## File path: include/tvm/node/container.h ## @@ -43,51 +44,1188 @@ using runtime::Downcast; using runtime::IterAdapter; using

[GitHub] [incubator-tvm] junrushao1994 commented on a change in pull request #5740: [Object] Introduce POD-C Compliant tvm::Map

junrushao1994 commented on a change in pull request #5740: URL: https://github.com/apache/incubator-tvm/pull/5740#discussion_r440659939 ## File path: include/tvm/node/container.h ## @@ -43,51 +44,1188 @@ using runtime::Downcast; using runtime::IterAdapter; using

[GitHub] [incubator-tvm] junrushao1994 commented on a change in pull request #5740: [Object] Introduce POD-C Compliant tvm::Map

junrushao1994 commented on a change in pull request #5740: URL: https://github.com/apache/incubator-tvm/pull/5740#discussion_r440651195 ## File path: include/tvm/node/container.h ## @@ -43,51 +44,1188 @@ using runtime::Downcast; using runtime::IterAdapter; using

[GitHub] [incubator-tvm] junrushao1994 commented on a change in pull request #5740: [Object] Introduce POD-C Compliant tvm::Map

junrushao1994 commented on a change in pull request #5740: URL: https://github.com/apache/incubator-tvm/pull/5740#discussion_r440648093 ## File path: include/tvm/node/container.h ## @@ -43,51 +44,1188 @@ using runtime::Downcast; using runtime::IterAdapter; using

[GitHub] [incubator-tvm] junrushao1994 commented on a change in pull request #5740: [Object] Introduce POD-C Compliant tvm::Map

junrushao1994 commented on a change in pull request #5740: URL: https://github.com/apache/incubator-tvm/pull/5740#discussion_r440615351 ## File path: include/tvm/node/container.h ## @@ -43,51 +44,1188 @@ using runtime::Downcast; using runtime::IterAdapter; using

[GitHub] [incubator-tvm] junrushao1994 commented on a change in pull request #5740: [Object] Introduce POD-C Compliant tvm::Map

junrushao1994 commented on a change in pull request #5740: URL: https://github.com/apache/incubator-tvm/pull/5740#discussion_r440341151 ## File path: include/tvm/node/container.h ## @@ -43,51 +44,1188 @@ using runtime::Downcast; using runtime::IterAdapter; using

[GitHub] [incubator-tvm] junrushao1994 commented on a change in pull request #5740: [Object] Introduce POD-C Compliant tvm::Map

junrushao1994 commented on a change in pull request #5740: URL: https://github.com/apache/incubator-tvm/pull/5740#discussion_r440340863 ## File path: include/tvm/node/container.h ## @@ -43,51 +44,1188 @@ using runtime::Downcast; using runtime::IterAdapter; using