[GitHub] [incubator-tvm] junrushao1994 commented on a change in pull request #5838: [Target] Introduce Target Id Registry

2020-06-19 Thread GitBox
junrushao1994 commented on a change in pull request #5838: URL: https://github.com/apache/incubator-tvm/pull/5838#discussion_r443085597 ## File path: src/target/target_id.cc ## @@ -91,38 +91,74 @@ void VerifyTypeInfo(const ObjectRef& obj, const TargetIdNode::ValueTypeInfo&

[GitHub] [incubator-tvm] junrushao1994 commented on a change in pull request #5838: [Target] Introduce Target Id Registry

2020-06-19 Thread GitBox
junrushao1994 commented on a change in pull request #5838: URL: https://github.com/apache/incubator-tvm/pull/5838#discussion_r443011655 ## File path: tests/cpp/target_test.cc ## @@ -0,0 +1,40 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more

[GitHub] [incubator-tvm] junrushao1994 commented on a change in pull request #5838: [Target] Introduce Target Id Registry

2020-06-19 Thread GitBox
junrushao1994 commented on a change in pull request #5838: URL: https://github.com/apache/incubator-tvm/pull/5838#discussion_r442980201 ## File path: include/tvm/target/target_id.h ## @@ -0,0 +1,298 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or

[GitHub] [incubator-tvm] junrushao1994 commented on a change in pull request #5838: [Target] Introduce Target Id Registry

2020-06-19 Thread GitBox
junrushao1994 commented on a change in pull request #5838: URL: https://github.com/apache/incubator-tvm/pull/5838#discussion_r442972847 ## File path: include/tvm/target/target_id.h ## @@ -0,0 +1,298 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or

[GitHub] [incubator-tvm] junrushao1994 commented on a change in pull request #5838: [Target] Introduce Target Id Registry

2020-06-19 Thread GitBox
junrushao1994 commented on a change in pull request #5838: URL: https://github.com/apache/incubator-tvm/pull/5838#discussion_r442969162 ## File path: include/tvm/target/target_id.h ## @@ -0,0 +1,298 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or

[GitHub] [incubator-tvm] junrushao1994 commented on a change in pull request #5838: [Target] Introduce Target Id Registry

2020-06-19 Thread GitBox
junrushao1994 commented on a change in pull request #5838: URL: https://github.com/apache/incubator-tvm/pull/5838#discussion_r442968000 ## File path: include/tvm/target/target_id.h ## @@ -0,0 +1,298 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or

[GitHub] [incubator-tvm] junrushao1994 commented on a change in pull request #5838: [Target] Introduce Target Id Registry

2020-06-19 Thread GitBox
junrushao1994 commented on a change in pull request #5838: URL: https://github.com/apache/incubator-tvm/pull/5838#discussion_r442957099 ## File path: include/tvm/target/target_id.h ## @@ -0,0 +1,298 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or

[GitHub] [incubator-tvm] junrushao1994 commented on a change in pull request #5838: [Target] Introduce Target Id Registry

2020-06-19 Thread GitBox
junrushao1994 commented on a change in pull request #5838: URL: https://github.com/apache/incubator-tvm/pull/5838#discussion_r442953431 ## File path: include/tvm/target/target_id.h ## @@ -0,0 +1,298 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or

[GitHub] [incubator-tvm] junrushao1994 commented on a change in pull request #5838: [Target] Introduce Target Id Registry

2020-06-18 Thread GitBox
junrushao1994 commented on a change in pull request #5838: URL: https://github.com/apache/incubator-tvm/pull/5838#discussion_r442558981 ## File path: include/tvm/target/target_id.h ## @@ -0,0 +1,228 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or

[GitHub] [incubator-tvm] junrushao1994 commented on a change in pull request #5838: [Target] Introduce Target Id Registry

2020-06-18 Thread GitBox
junrushao1994 commented on a change in pull request #5838: URL: https://github.com/apache/incubator-tvm/pull/5838#discussion_r442552581 ## File path: include/tvm/target/target_id.h ## @@ -0,0 +1,228 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or