[GitHub] [incubator-tvm] junrushao1994 commented on pull request #5730: [REFACTOR] Separate ArgTypeCode from DLDataTypeCode

2020-06-06 Thread GitBox
junrushao1994 commented on pull request #5730: URL: https://github.com/apache/incubator-tvm/pull/5730#issuecomment-640100020 #5742 This is an automated message from the Apache Git Service. To respond to the message, please lo

[GitHub] [incubator-tvm] junrushao1994 commented on pull request #5730: [REFACTOR] Separate ArgTypeCode from DLDataTypeCode

2020-06-05 Thread GitBox
junrushao1994 commented on pull request #5730: URL: https://github.com/apache/incubator-tvm/pull/5730#issuecomment-639605616 Sure On Fri, Jun 5, 2020 at 08:33 Tianqi Chen wrote: > @junrushao1994 we can also send a PR > to add the comment a

[GitHub] [incubator-tvm] junrushao1994 commented on pull request #5730: [REFACTOR] Separate ArgTypeCode from DLDataTypeCode

2020-06-05 Thread GitBox
junrushao1994 commented on pull request #5730: URL: https://github.com/apache/incubator-tvm/pull/5730#issuecomment-639564805 I seelooks like this might affect downstream projects too because kDLInt are not encouraged any more ---

[GitHub] [incubator-tvm] junrushao1994 commented on pull request #5730: [REFACTOR] Separate ArgTypeCode from DLDataTypeCode

2020-06-04 Thread GitBox
junrushao1994 commented on pull request #5730: URL: https://github.com/apache/incubator-tvm/pull/5730#issuecomment-639018766 Will take a look tonight! Thank you! This is an automated message from the Apache Git Service. To re