kevinthesun edited a comment on pull request #6449:
URL: https://github.com/apache/incubator-tvm/pull/6449#issuecomment-693093647
@masahi Yeah. Those ops look like coming from scripted model. I believe for
pt 1.6 if we trace the model there are 2 or 3 ops missing.
kevinthesun edited a comment on pull request #6449:
URL: https://github.com/apache/incubator-tvm/pull/6449#issuecomment-693007551
@t-vi For now IMO it doesn't bring obvious benefit of adding an extra common
api to just wrap ```try ... except``` for ```_infer_value```, considering the
lack
kevinthesun edited a comment on pull request #6449:
URL: https://github.com/apache/incubator-tvm/pull/6449#issuecomment-693007551
@t-vi For now IMO it doesn't bring obvious benefit of adding an extra common
api to just wrap ```try ... except``` for ```_infer_value```, considering the
lack
kevinthesun edited a comment on pull request #6449:
URL: https://github.com/apache/incubator-tvm/pull/6449#issuecomment-693007551
@t-vi For now IMO it doesn't bring obvious benefit of adding an extra common
api to just wrap ```try ... except``` for ```_infer_value```, considering the
lack
kevinthesun edited a comment on pull request #6449:
URL: https://github.com/apache/incubator-tvm/pull/6449#issuecomment-692975419
Original pt frontend just handles limited cases, mostly static
shape/attributes. It is fine we just keep input as it is for static models. For
more dynamic mode
kevinthesun edited a comment on pull request #6449:
URL: https://github.com/apache/incubator-tvm/pull/6449#issuecomment-692975419
Original pt frontend just handles limited cases, mostly static
shape/attributes. It is fine we just keep input as it is. For more dynamic
models, we need to do
kevinthesun edited a comment on pull request #6449:
URL: https://github.com/apache/incubator-tvm/pull/6449#issuecomment-692917238
> @zhiics @kevinthesun @masahi
> Thank you, @kevinthesun for your summary and all the work in the
investigation and your PR.
>
> I think using `if isin
kevinthesun edited a comment on pull request #6449:
URL: https://github.com/apache/incubator-tvm/pull/6449#issuecomment-692392769
> Is moving to fully dynamic frontend like being done for onnx #6351 help
removing infer_value usage?
While we try to make relay expression as static as p
kevinthesun edited a comment on pull request #6449:
URL: https://github.com/apache/incubator-tvm/pull/6449#issuecomment-692285615
> But we should still know when it is appropriate to run the inference,
should we not?
> I must admit I'm still troubled by the idea that we don't know before
kevinthesun edited a comment on pull request #6449:
URL: https://github.com/apache/incubator-tvm/pull/6449#issuecomment-692285615
> But we should still know when it is appropriate to run the inference,
should we not?
> I must admit I'm still troubled by the idea that we don't know before
kevinthesun edited a comment on pull request #6449:
URL: https://github.com/apache/incubator-tvm/pull/6449#issuecomment-692285615
> But we should still know when it is appropriate to run the inference,
should we not?
> I must admit I'm still troubled by the idea that we don't know before
kevinthesun edited a comment on pull request #6449:
URL: https://github.com/apache/incubator-tvm/pull/6449#issuecomment-692285615
> But we should still know when it is appropriate to run the inference,
should we not?
> I must admit I'm still troubled by the idea that we don't know before
kevinthesun edited a comment on pull request #6449:
URL: https://github.com/apache/incubator-tvm/pull/6449#issuecomment-692285615
> But we should still know when it is appropriate to run the inference,
should we not?
> I must admit I'm still troubled by the idea that we don't know before
kevinthesun edited a comment on pull request #6449:
URL: https://github.com/apache/incubator-tvm/pull/6449#issuecomment-692260607
@masahi The problem of creating a try_infer_value API is that it doesn't
simplify the codes since we need to do various handling in except block for
different o
14 matches
Mail list logo
