[GitHub] [incubator-tvm] leandron edited a comment on pull request #6302: [tvmc] command line driver 'compile' (part 2/4)

2020-09-16 Thread GitBox
leandron edited a comment on pull request #6302: URL: https://github.com/apache/incubator-tvm/pull/6302#issuecomment-693475975 I recently rebased with the latest changes and un-skipped the test fixed by #6442 @tqchen @comaniac @junrushao1994 would you mind having another look into

[GitHub] [incubator-tvm] leandron edited a comment on pull request #6302: [tvmc] command line driver 'compile' (part 2/4)

2020-09-12 Thread GitBox
leandron edited a comment on pull request #6302: URL: https://github.com/apache/incubator-tvm/pull/6302#issuecomment-691009229 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [incubator-tvm] leandron edited a comment on pull request #6302: [tvmc] command line driver 'compile' (part 2/4)

2020-09-12 Thread GitBox
leandron edited a comment on pull request #6302: URL: https://github.com/apache/incubator-tvm/pull/6302#issuecomment-691009229 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [incubator-tvm] leandron edited a comment on pull request #6302: [tvmc] command line driver 'compile' (part 2/4)

2020-09-12 Thread GitBox
leandron edited a comment on pull request #6302: URL: https://github.com/apache/incubator-tvm/pull/6302#issuecomment-691009229 Thanks @comaniac - I submitted a new version incorporating pretty much all the feedback (apart from the `Target` one, details in the comment). One test is st

[GitHub] [incubator-tvm] leandron edited a comment on pull request #6302: [tvmc] command line driver 'compile' (part 2/4)

2020-09-11 Thread GitBox
leandron edited a comment on pull request #6302: URL: https://github.com/apache/incubator-tvm/pull/6302#issuecomment-691009229 Thanks @comaniac - I submitted a new version incorporating pretty much all the feedback (apart from the `Target` one, details in the comment). One test is st

[GitHub] [incubator-tvm] leandron edited a comment on pull request #6302: [tvmc] command line driver 'compile' (part 2/4)

2020-09-10 Thread GitBox
leandron edited a comment on pull request #6302: URL: https://github.com/apache/incubator-tvm/pull/6302#issuecomment-690379907 There was an issue we discovered with `ConvertLayout` when running the new tests introduced here, once #6442 is merged, all the tests should pass. @comaniac