maheshambule commented on pull request #5528:
URL: https://github.com/apache/incubator-tvm/pull/5528#issuecomment-646202822
@anijain2305, it would be great to hear your feedback/review on this
proposed refactoring.
@u99127 Do you want to add further comments/suggestions here.
maheshambule commented on pull request #5528:
URL: https://github.com/apache/incubator-tvm/pull/5528#issuecomment-624809315
Thanks for the response.
> Few more points to consider:
Let me clarify, the points which I mentioned are not for in or against both
the approaches
maheshambule commented on pull request #5528:
URL: https://github.com/apache/incubator-tvm/pull/5528#issuecomment-624726976
I thought of adding all the op attributes in table/map but decorator seemed
to be more pythonic.
Few more points to consider:
1. Sometimes equality checks
maheshambule commented on pull request #5528:
URL: https://github.com/apache/incubator-tvm/pull/5528#issuecomment-624668670
> Have you seen #5519 ?
>
> Ramana
Just now. I replied there.
This is an automated
maheshambule commented on pull request #5528:
URL: https://github.com/apache/incubator-tvm/pull/5528#issuecomment-624659434
@FrozenGene, @anijain2305, @siju-samuel, @u99127, @mbaret Could you please
review and let me know your thoughts?
