[GitHub] [incubator-tvm] mbrookhart edited a comment on pull request #5689: [PatternLang] Add ConstantPattern

2020-05-28 Thread GitBox
mbrookhart edited a comment on pull request #5689: URL: https://github.com/apache/incubator-tvm/pull/5689#issuecomment-635646234 :point_up: I'll let you guys discuss the appropriate behavior, there's seems to be some complication to this. In the mean time, this was my initial assump

[GitHub] [incubator-tvm] mbrookhart edited a comment on pull request #5689: [PatternLang] Add ConstantPattern

2020-05-28 Thread GitBox
mbrookhart edited a comment on pull request #5689: URL: https://github.com/apache/incubator-tvm/pull/5689#issuecomment-635637682 @mbaret Originally the partition pass embedded constants in the function body, but @comaniac filed #5662, and I responded with #5663, so it currently will lift t