soiferj commented on issue #4939: [Relay][Pass] Sort MergeComposite generated
function params alphabetically
URL: https://github.com/apache/incubator-tvm/pull/4939#issuecomment-591170273
@comaniac @zhiics that's a great idea. I'll keep these fixes locally for
now. Thanks a lot for helping!
soiferj commented on issue #4939: [Relay][Pass] Sort MergeComposite generated
function params alphabetically
URL: https://github.com/apache/incubator-tvm/pull/4939#issuecomment-591064120
I definitely agree that we'll want that eventually. However, improved
pattern matching won't change the
soiferj commented on issue #4939: [Relay][Pass] Sort MergeComposite generated
function params alphabetically
URL: https://github.com/apache/incubator-tvm/pull/4939#issuecomment-591040506
Thanks, @zhiics. This fix is not intended to solve the ordering of pattern
matching, but rather to solv
soiferj commented on issue #4939: [Relay][Pass] Sort MergeComposite generated
function params alphabetically
URL: https://github.com/apache/incubator-tvm/pull/4939#issuecomment-591014458
Got it, I see what you're saying. I'm still not convinced that we want to
generalize sorting free vars
soiferj commented on issue #4939: [Relay][Pass] Sort MergeComposite generated
function params alphabetically
URL: https://github.com/apache/incubator-tvm/pull/4939#issuecomment-591008923
Sorry, I don't quite understand - where do you think the change should be
made? The main issue here is
