[GitHub] [incubator-tvm] tkonolige commented on a change in pull request #6656: [Rust][Diagnostics] Add initial boilerplate for Rust diagnostic interface.

tkonolige commented on a change in pull request #6656: URL: https://github.com/apache/incubator-tvm/pull/6656#discussion_r512321071 ## File path: cmake/modules/LLVM.cmake ## @@ -16,7 +16,12 @@ # under the License. # LLVM rules -add_definitions(-DDMLC_USE_FOPEN64=0) +# Due

[GitHub] [incubator-tvm] tkonolige commented on a change in pull request #6656: [Rust][Diagnostics] Add initial boilerplate for Rust diagnostic interface.

tkonolige commented on a change in pull request #6656: URL: https://github.com/apache/incubator-tvm/pull/6656#discussion_r512085469 ## File path: cmake/modules/RustExt.cmake ## @@ -0,0 +1,43 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more

[GitHub] [incubator-tvm] tkonolige commented on a change in pull request #6656: [Rust][Diagnostics] Add initial boilerplate for Rust diagnostic interface.

tkonolige commented on a change in pull request #6656: URL: https://github.com/apache/incubator-tvm/pull/6656#discussion_r512085151 ## File path: cmake/modules/LLVM.cmake ## @@ -16,7 +16,12 @@ # under the License. # LLVM rules -add_definitions(-DDMLC_USE_FOPEN64=0) +# Due

[GitHub] [incubator-tvm] tkonolige commented on a change in pull request #6656: [Rust][Diagnostics] Add initial boilerplate for Rust diagnostic interface.

tkonolige commented on a change in pull request #6656: URL: https://github.com/apache/incubator-tvm/pull/6656#discussion_r506766614 ## File path: cmake/modules/RustExt.cmake ## @@ -0,0 +1,26 @@ +if(USE_RUST_EXT AND NOT USE_RUST_EXT EQUAL OFF) Review comment: I think

[GitHub] [incubator-tvm] tkonolige commented on a change in pull request #6656: [Rust][Diagnostics] Add initial boilerplate for Rust diagnostic interface.

tkonolige commented on a change in pull request #6656: URL: https://github.com/apache/incubator-tvm/pull/6656#discussion_r506766711 ## File path: cmake/modules/RustExt.cmake ## @@ -0,0 +1,26 @@ +if(USE_RUST_EXT AND NOT USE_RUST_EXT EQUAL OFF) Review comment:

[GitHub] [incubator-tvm] tkonolige commented on a change in pull request #6656: [Rust][Diagnostics] Add initial boilerplate for Rust diagnostic interface.

tkonolige commented on a change in pull request #6656: URL: https://github.com/apache/incubator-tvm/pull/6656#discussion_r506766711 ## File path: cmake/modules/RustExt.cmake ## @@ -0,0 +1,26 @@ +if(USE_RUST_EXT AND NOT USE_RUST_EXT EQUAL OFF) Review comment: _if()

[GitHub] [incubator-tvm] tkonolige commented on a change in pull request #6656: [Rust][Diagnostics] Add initial boilerplate for Rust diagnostic interface.

tkonolige commented on a change in pull request #6656: URL: https://github.com/apache/incubator-tvm/pull/6656#discussion_r506762570 ## File path: rust/tvm/src/ir/diagnostics/codespan.rs ## @@ -0,0 +1,183 @@ +use std::collections::HashMap; Review comment: This file

[GitHub] [incubator-tvm] tkonolige commented on a change in pull request #6656: [Rust][Diagnostics] Add initial boilerplate for Rust diagnostic interface.

tkonolige commented on a change in pull request #6656: URL: https://github.com/apache/incubator-tvm/pull/6656#discussion_r506761995 ## File path: rust/compiler-ext/src/lib.rs ## @@ -0,0 +1,43 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more