[GitHub] [incubator-tvm] tmoreau89 commented on issue #4986: [VTA][Chisel, de10nano] Chisel fixes and de10nano support

tmoreau89 commented on issue #4986: [VTA][Chisel,de10nano] Chisel fixes and de10nano support URL: https://github.com/apache/incubator-tvm/pull/4986#issuecomment-596658449 Thanks @pasqoc @liangfu @vegaluisjose for the work and the reviews; the PR has been merged!

[GitHub] [incubator-tvm] tmoreau89 commented on issue #4986: [VTA][Chisel, de10nano] Chisel fixes and de10nano support

tmoreau89 commented on issue #4986: [VTA][Chisel,de10nano] Chisel fixes and de10nano support URL: https://github.com/apache/incubator-tvm/pull/4986#issuecomment-596126498 Thanks against for pushing this PR through @pasqoc this work is hugely appreciated by the TVM community!

[GitHub] [incubator-tvm] tmoreau89 commented on issue #4986: [VTA][Chisel, de10nano] Chisel fixes and de10nano support

tmoreau89 commented on issue #4986: [VTA][Chisel,de10nano] Chisel fixes and de10nano support URL: https://github.com/apache/incubator-tvm/pull/4986#issuecomment-596126449 @liangfu I just merged @liangfu 's scala linter fix: https://github.com/apache/incubator-tvm/pull/4998 If

[GitHub] [incubator-tvm] tmoreau89 commented on issue #4986: [VTA][Chisel, de10nano] Chisel fixes and de10nano support

tmoreau89 commented on issue #4986: [VTA][Chisel,de10nano] Chisel fixes and de10nano support URL: https://github.com/apache/incubator-tvm/pull/4986#issuecomment-595995212 > I have put the linter back in, BTW, so the new linter should not gate this PR. ack

[GitHub] [incubator-tvm] tmoreau89 commented on issue #4986: [VTA][Chisel, de10nano] Chisel fixes and de10nano support

tmoreau89 commented on issue #4986: [VTA][Chisel,de10nano] Chisel fixes and de10nano support URL: https://github.com/apache/incubator-tvm/pull/4986#issuecomment-595993915 Once this PR lands, I'll add e2e unit testing in TSIM on a variant of the ResNet-18 tutorial

[GitHub] [incubator-tvm] tmoreau89 commented on issue #4986: [VTA][Chisel, de10nano] Chisel fixes and de10nano support

tmoreau89 commented on issue #4986: [VTA][Chisel,de10nano] Chisel fixes and de10nano support URL: https://github.com/apache/incubator-tvm/pull/4986#issuecomment-595992450 Nice, thanks! So we'll wait for @liangfu 's linter PR to merge, land that so we can re-enable the linter in your PR.

[GitHub] [incubator-tvm] tmoreau89 commented on issue #4986: [VTA][Chisel, de10nano] Chisel fixes and de10nano support

tmoreau89 commented on issue #4986: [VTA][Chisel,de10nano] Chisel fixes and de10nano support URL: https://github.com/apache/incubator-tvm/pull/4986#issuecomment-595991256 It's possible that some failed experiments left the pynq in a stale state. The CMA drivers that perform pinned page

[GitHub] [incubator-tvm] tmoreau89 commented on issue #4986: [VTA][Chisel, de10nano] Chisel fixes and de10nano support

tmoreau89 commented on issue #4986: [VTA][Chisel,de10nano] Chisel fixes and de10nano support URL: https://github.com/apache/incubator-tvm/pull/4986#issuecomment-595986283 Does the default HLS generated bitstream produce the right results then? It could very well be a broader issue with

[GitHub] [incubator-tvm] tmoreau89 commented on issue #4986: [VTA][Chisel, de10nano] Chisel fixes and de10nano support

tmoreau89 commented on issue #4986: [VTA][Chisel,de10nano] Chisel fixes and de10nano support URL: https://github.com/apache/incubator-tvm/pull/4986#issuecomment-595984335 @pasqoc I haven't run the full test recently, but I can do it on my end. Are you using a bitstream generated from

[GitHub] [incubator-tvm] tmoreau89 commented on issue #4986: [VTA][Chisel, de10nano] Chisel fixes and de10nano support

tmoreau89 commented on issue #4986: [VTA][Chisel,de10nano] Chisel fixes and de10nano support URL: https://github.com/apache/incubator-tvm/pull/4986#issuecomment-595970177 That's a fair assessment, let's go with m.run() as default with a comment about timer causing failures on the Chisel

[GitHub] [incubator-tvm] tmoreau89 commented on issue #4986: [VTA][Chisel, de10nano] Chisel fixes and de10nano support

tmoreau89 commented on issue #4986: [VTA][Chisel,de10nano] Chisel fixes and de10nano support URL: https://github.com/apache/incubator-tvm/pull/4986#issuecomment-595967041 I see, if this affects the behavior of the de10nano runs then it's probably a bug on the hardware side (things are not

[GitHub] [incubator-tvm] tmoreau89 commented on issue #4986: [VTA][Chisel, de10nano] Chisel fixes and de10nano support

tmoreau89 commented on issue #4986: [VTA][Chisel,de10nano] Chisel fixes and de10nano support URL: https://github.com/apache/incubator-tvm/pull/4986#issuecomment-595916237 @pasqoc I suggest that we change the script in the CI to not use the timer and just invoke `m.run()` for simulation

[GitHub] [incubator-tvm] tmoreau89 commented on issue #4986: [VTA][Chisel, de10nano] Chisel fixes and de10nano support

tmoreau89 commented on issue #4986: [VTA][Chisel,de10nano] Chisel fixes and de10nano support URL: https://github.com/apache/incubator-tvm/pull/4986#issuecomment-595593538 Agree with @vegaluisjose on the separate PR; if you submit it, we'll work to merge it quickly so you can rebase

[GitHub] [incubator-tvm] tmoreau89 commented on issue #4986: [VTA][Chisel, de10nano] Chisel fixes and de10nano support

tmoreau89 commented on issue #4986: [VTA][Chisel,de10nano] Chisel fixes and de10nano support URL: https://github.com/apache/incubator-tvm/pull/4986#issuecomment-595474164 It looks like at the moment the cpp lint test is failing:

[GitHub] [incubator-tvm] tmoreau89 commented on issue #4986: [VTA][Chisel, de10nano] Chisel fixes and de10nano support

tmoreau89 commented on issue #4986: [VTA][Chisel,de10nano] Chisel fixes and de10nano support URL: https://github.com/apache/incubator-tvm/pull/4986#issuecomment-594973729 @vegaluisjose @liangfu this makes me realize that we may want to run CI testing for different FPGA parameterizations

[GitHub] [incubator-tvm] tmoreau89 commented on issue #4986: [VTA][Chisel, de10nano] Chisel fixes and de10nano support

tmoreau89 commented on issue #4986: [VTA][Chisel,de10nano] Chisel fixes and de10nano support URL: https://github.com/apache/incubator-tvm/pull/4986#issuecomment-594917196 Thank you @pasqoc for this awesome PR, and extensive fixes to the Chisel codebase. @liangfu , @vegaluisjose and I will

[GitHub] [incubator-tvm] tmoreau89 commented on issue #4986: [VTA][Chisel, de10nano] Chisel fixes and de10nano support

tmoreau89 commented on issue #4986: [VTA][Chisel,de10nano] Chisel fixes and de10nano support URL: https://github.com/apache/incubator-tvm/pull/4986#issuecomment-594916203 @vegaluisjose can you also review this PR? This is an