[GitHub] [incubator-tvm] tqchen commented on a change in pull request #5838: [Target] Introduce Target Id Registry

2020-06-19 Thread GitBox
tqchen commented on a change in pull request #5838: URL: https://github.com/apache/incubator-tvm/pull/5838#discussion_r443085746 ## File path: src/target/target_id.cc ## @@ -91,38 +91,74 @@ void VerifyTypeInfo(const ObjectRef& obj, const TargetIdNode::ValueTypeInfo& inf }

[GitHub] [incubator-tvm] tqchen commented on a change in pull request #5838: [Target] Introduce Target Id Registry

2020-06-19 Thread GitBox
tqchen commented on a change in pull request #5838: URL: https://github.com/apache/incubator-tvm/pull/5838#discussion_r443085301 ## File path: src/target/target_id.cc ## @@ -91,38 +91,74 @@ void VerifyTypeInfo(const ObjectRef& obj, const TargetIdNode::ValueTypeInfo& inf }

[GitHub] [incubator-tvm] tqchen commented on a change in pull request #5838: [Target] Introduce Target Id Registry

2020-06-19 Thread GitBox
tqchen commented on a change in pull request #5838: URL: https://github.com/apache/incubator-tvm/pull/5838#discussion_r443085167 ## File path: src/target/target_id.cc ## @@ -91,38 +91,74 @@ void VerifyTypeInfo(const ObjectRef& obj, const TargetIdNode::ValueTypeInfo& inf }

[GitHub] [incubator-tvm] tqchen commented on a change in pull request #5838: [Target] Introduce Target Id Registry

2020-06-19 Thread GitBox
tqchen commented on a change in pull request #5838: URL: https://github.com/apache/incubator-tvm/pull/5838#discussion_r443085167 ## File path: src/target/target_id.cc ## @@ -91,38 +91,74 @@ void VerifyTypeInfo(const ObjectRef& obj, const TargetIdNode::ValueTypeInfo& inf }

[GitHub] [incubator-tvm] tqchen commented on a change in pull request #5838: [Target] Introduce Target Id Registry

2020-06-19 Thread GitBox
tqchen commented on a change in pull request #5838: URL: https://github.com/apache/incubator-tvm/pull/5838#discussion_r443061397 ## File path: src/target/target_id.cc ## @@ -0,0 +1,128 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more

[GitHub] [incubator-tvm] tqchen commented on a change in pull request #5838: [Target] Introduce Target Id Registry

2020-06-18 Thread GitBox
tqchen commented on a change in pull request #5838: URL: https://github.com/apache/incubator-tvm/pull/5838#discussion_r442558792 ## File path: include/tvm/target/target_id.h ## @@ -0,0 +1,228 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more

[GitHub] [incubator-tvm] tqchen commented on a change in pull request #5838: [Target] Introduce Target Id Registry

2020-06-18 Thread GitBox
tqchen commented on a change in pull request #5838: URL: https://github.com/apache/incubator-tvm/pull/5838#discussion_r442552150 ## File path: include/tvm/target/target_id.h ## @@ -0,0 +1,228 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more

[GitHub] [incubator-tvm] tqchen commented on a change in pull request #5838: [Target] Introduce Target Id Registry

2020-06-18 Thread GitBox
tqchen commented on a change in pull request #5838: URL: https://github.com/apache/incubator-tvm/pull/5838#discussion_r442552006 ## File path: include/tvm/target/target_id.h ## @@ -0,0 +1,228 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more