tqchen commented on issue #4628: [Object] Add String container
URL: https://github.com/apache/incubator-tvm/pull/4628#issuecomment-596871935
ping @wweic :)
This is an automated message from the Apache Git Service.
To respond
tqchen commented on issue #4628: [Object] Add String container
URL: https://github.com/apache/incubator-tvm/pull/4628#issuecomment-593235220
@FrozenGene @icemelon9 please help to take another look. The standard lib is
the core part of the system so we need extra caution in terms of
tqchen commented on issue #4628: [Object] Add String container
URL: https://github.com/apache/incubator-tvm/pull/4628#issuecomment-590978688
please look into the compilation error.
This is an automated message from the Apache
tqchen commented on issue #4628: [Object] Add String container
URL: https://github.com/apache/incubator-tvm/pull/4628#issuecomment-590977222
Interesting, i think it is fine given that we will fallback to the
std::string impl. The standard only requires it to available in C++17, so they
tqchen commented on issue #4628: [Object] Add String container
URL: https://github.com/apache/incubator-tvm/pull/4628#issuecomment-588394175
ping @wweic
This is an automated message from the Apache Git Service.
To respond to
tqchen commented on issue #4628: [Object] Add String container
URL: https://github.com/apache/incubator-tvm/pull/4628#issuecomment-584734563
@wweic please update as per comments :)
This is an automated message from the Apache
tqchen commented on issue #4628: [Object] Add String container
URL: https://github.com/apache/incubator-tvm/pull/4628#issuecomment-583871162
@FrozenGene In general I agree that we should avoid std::experimental.
In this particular case, i think the usage is fair, because it is
tqchen commented on issue #4628: [Object] Add String container
URL: https://github.com/apache/incubator-tvm/pull/4628#issuecomment-583765522
@wweic here is an code snippet that we can reuse for hash. We should
consider migrate to require c++14, which will give us string view support
tqchen commented on issue #4628: [Object] Add String container
URL: https://github.com/apache/incubator-tvm/pull/4628#issuecomment-580904651
gentle ping
This is an automated message from the Apache Git Service.
To respond to
tqchen commented on issue #4628: [Object] Add String container
URL: https://github.com/apache/incubator-tvm/pull/4628#issuecomment-573450243
we can do it in a followup PR but as a reminder, we need python side wrapper
for String and perhaps we need to make some special treatment to make
10 matches
Mail list logo
