tqchen commented on pull request #5601:
URL: https://github.com/apache/incubator-tvm/pull/5601#issuecomment-646674793
Thanks @Menooker for being patient and keep improving the PR to maintain a
high quality standard! Thanks @ZhennanQin @junrushao1994 @liangfu for helpful
reviews!
tqchen commented on pull request #5601:
URL: https://github.com/apache/incubator-tvm/pull/5601#issuecomment-646355311
@junrushao1994 @ZhennanQin please followup and
https://tvm.apache.org/docs/contribute/code_review.html#approve-and-request-changes-explicitly
tqchen commented on pull request #5601:
URL: https://github.com/apache/incubator-tvm/pull/5601#issuecomment-645017563
@vinx13 @ZihengJiang @liangfu it would be great if you cam take another look
and
tqchen commented on pull request #5601:
URL: https://github.com/apache/incubator-tvm/pull/5601#issuecomment-643337519
@junrushao1994 can you also take a quick look at this PR. thank you!
This is an automated message from the
tqchen commented on pull request #5601:
URL: https://github.com/apache/incubator-tvm/pull/5601#issuecomment-641553734
@vinx13 @ZihengJiang @liangfu it would be great if you cam take another
look. Thanks @Menooker for keep improving the PR
tqchen commented on pull request #5601:
URL: https://github.com/apache/incubator-tvm/pull/5601#issuecomment-639143314
https://github.com/apache/incubator-tvm/pull/5730 splits the two type codes,
we only need to add BFLoat16 to the DataTypeCode. cc @Menooker
tqchen commented on pull request #5601:
URL: https://github.com/apache/incubator-tvm/pull/5601#issuecomment-638583235
See the data type code defined here
https://github.com/apache/incubator-tvm/blob/master/include/tvm/runtime/data_type.h#L48
tqchen commented on pull request #5601:
URL: https://github.com/apache/incubator-tvm/pull/5601#issuecomment-638582535
I want to clarify the case of the TypeCode. Given that we are not trying to
making a consistent type code for arguments beyond kOpaqueHandle.
So in this case, we
